aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
...
* detect non-finite ptsGravatar Mike Reed2018-03-15
| | | | | | | | Bug: oss-fuzz:6638 Change-Id: I72dab6783099facbe8d658ec1bc4b175a383e174 Reviewed-on: https://skia-review.googlesource.com/114565 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Disable CCPR path rendering in DDL modeGravatar Robert Phillips2018-03-15
| | | | | | | Change-Id: Ib16a7b037eff6cd0528177646c2eced467763a06 Reviewed-on: https://skia-review.googlesource.com/114560 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* drawTextRSXform should not apply matrix to shaderGravatar Mike Reed2018-03-15
| | | | | | | | | | | drawTextRSXform should draw the same as drawTextOnPath (as regards shaders) Bug: b/69904791 Change-Id: I393dd8fd7a5bdc6a018b1ca33592b208c7141868 Reviewed-on: https://skia-review.googlesource.com/114468 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* GrGLES: unify MakeNativeInterface_{android,egl}Gravatar Hal Canary2018-03-15
| | | | | | | | BUG=skia:3508 Change-Id: Ibc98ea3e579cb545635c28d345cae24f57d0c2a3 Reviewed-on: https://skia-review.googlesource.com/114471 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* fix pathops fuzzers and debuggingGravatar Cary Clark2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | En route to fixing fuzzer bugs, I discovered that most debugging in pathops was broken. Pathops has extensive runtime functions that trace links and connections between data structures that are invaluable to debugging. The only practical way to use these functions is to call them from the debugger in immediate mode. Some time, some where, the MSVS Immediate Window ceased to be able to call functions that are members of structs or classes, and functions that take templated parameters. I can find no mention of this on the web, so I assume that something about our setup is triggering this, but I've had no luck finding the culprit. In the meantime, I've added global functions wrapped in a namespace to sneak calls to these functions without MSVS being any the wiser. While this works, it is likely to bitrot by tomorrow or next Tuesday so I will continue to try to find and fix the root cause. This also fixes the fuzzer bugs; generally one-line edits that change asserts to fails. All pathops tests succeed with this. To run all tests, do: ./out/debug/pathops_unittest -V -x ./out/release/pathops_unittest -V -x TBR=caryclark@google.com Bug: skia: Change-Id: I956ae3d8df6d25e155e62bd6dede64519c7fbdb1 Reviewed-on: https://skia-review.googlesource.com/114321 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* SkAutoGlyphCache change some sites to Find*.Gravatar Herb Derby2018-03-15
| | | | | | | Change-Id: Iec3a0c60106017394fcdd981052713b6e42fa595 Reviewed-on: https://skia-review.googlesource.com/114506 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Make CreateBackendFormatFromTexture shared codeGravatar Robert Phillips2018-03-15
| | | | | | | | | TBR=bsalomon@google.com Change-Id: I19e6e6c8dc32ba584738545d443de092e4987a5a Reviewed-on: https://skia-review.googlesource.com/114374 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix initialLayout update in Vk createTestingOnlyImageGravatar Greg Daniel2018-03-15
| | | | | | | | Bug: skia: Change-Id: I5d4321e68c065e3775266994c65a4abf18360731 Reviewed-on: https://skia-review.googlesource.com/114497 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Check GL_EXT_texture_format_BGRA8888 before GL_APPLE_texture_format_BGRA8888Gravatar Alexis Hetu2018-03-15
| | | | | | | | | | | | | | | | When both GL_EXT_texture_format_BGRA8888 and GL_APPLE_texture_format_BGRA8888 extensions are present, the presence of GL_APPLE_texture_format_BGRA8888 was preventing GL_EXT_texture_format_BGRA8888 from allowing BGRA8888 to be used as a render target. By checking for GL_EXT_texture_format_BGRA8888 first, this solves the issue. The issue was encountered trying to run vr_pixeltests on top of SwiftShader on the bots with a version of SwiftShader exposing both extension strings. Change-Id: I446ec502a4703d24c24339708dcbbe9c334a7533 Reviewed-on: https://skia-review.googlesource.com/114495 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Alexis Hetu <sugoi@google.com>
* protect PathMeasure against input paths with NaNsGravatar Cary Clark2018-03-15
| | | | | | | | | | | found by fuzzer R=kjlubick@google.com Bug: skia: Change-Id: Ifde8706a7ca6fad785a1b0b50f3df3fb099c0e36 Reviewed-on: https://skia-review.googlesource.com/114477 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* Remove SK_RASTER_RECORDER_IMPLEMENTATIONGravatar Robert Phillips2018-03-15
| | | | | | | | | TBR=bsalomon@google.com Change-Id: I9608ce5ce2b9d38c5e356d8428a8ff05df6ccda7 Reviewed-on: https://skia-review.googlesource.com/114490 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Revert "ccpr: Unblacklist vulkan"Gravatar Greg Daniel2018-03-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 30ce2a3620ffe428762de08be50f3a62462524a2. Reason for revert: Crashing drivers on intel and powerVR. Possible SPIR-V error Original change's description: > ccpr: Unblacklist vulkan > > All issues have been resolved. > > Bug: skia: > Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7 > Reviewed-on: https://skia-review.googlesource.com/113060 > Commit-Queue: Chris Dalton <csmartdalton@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,csmartdalton@google.com Change-Id: Ibb9ea75cc0fbe2db0ff11a8b22bac8f47242f775 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114540 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Make sure we set correct GrPixelConfig in promise imagesGravatar Greg Daniel2018-03-15
| | | | | | | | | | Land just the Promise image fixes from, https://skia-review.googlesource.com/c/skia/+/114261 Bug: skia: Change-Id: I917cf2c1f5c6e51f9d7f1d3ec4526db551e89d84 Reviewed-on: https://skia-review.googlesource.com/114472 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* ccpr: Unblacklist vulkanGravatar Chris Dalton2018-03-15
| | | | | | | | | | All issues have been resolved. Bug: skia: Change-Id: Id63d63ad081725885cb0225b410b0d3972abd8f7 Reviewed-on: https://skia-review.googlesource.com/113060 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* GrGLES: clean up android_get_gl_procGravatar Hal Canary2018-03-14
| | | | | | | Change-Id: Ia65b582d17c80e27574042c02363ec75bafcb0db Reviewed-on: https://skia-review.googlesource.com/114440 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add SkColorType getter on SkImage.Gravatar Greg Daniel2018-03-14
| | | | | | | | | | Bug: skia: Change-Id: I131fb5f7faf3f54e0eb6d31b800d224e6d4963ce Reviewed-on: https://skia-review.googlesource.com/114464 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Reland "Add back missing unique key checks when creating CachedBitmap/Image ↵Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proxies" This reverts commit 4f57eb8002a0488cfbf08717b25af93fae37a39a. Reason for revert: Doesn't look to be cause of chrome roll failures Original change's description: > Revert "Add back missing unique key checks when creating CachedBitmap/Image Proxies" > > This reverts commit b78dd5d01eb16ae3cb9104ce8c0fa7e861431259. > > Reason for revert: possibly breaking chrome roll > > Original change's description: > > Add back missing unique key checks when creating CachedBitmap/Image Proxies > > > > Its possible that this could fix perf regression in Chrome. > > > > Bug: 811452 > > Change-Id: I2d4f7827092b361469586580f0c7c843ab2d5cec > > Reviewed-on: https://skia-review.googlesource.com/114280 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > Change-Id: I71646befd07bf28442ac3b9225c021cd141bf398 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 811452 > Reviewed-on: https://skia-review.googlesource.com/114422 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I957d66123bce150387a1ce6a80bcfc06c82d5fa1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811452 Reviewed-on: https://skia-review.googlesource.com/114426 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add glyph cache warming - prototypeGravatar Herb Derby2018-03-14
| | | | | | | | | | | | | | | | | A system for prewarming the cache using a single "RPC" This improve performance by ~5X. This is a checkin of rough code so I can use small changes clean it up. BUG=skia:7515 Change-Id: Id0192b4f533c257b0a7eea0170b1e25c336d6432 Reviewed-on: https://skia-review.googlesource.com/105440 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* fixed SkSL SPIR-V vector comparisonsGravatar Ethan Nicholas2018-03-14
| | | | | | | | Bug: skia: Change-Id: I57788fe427f62e20c6e073fd96279910febef22e Reviewed-on: https://skia-review.googlesource.com/114367 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Add accessor and less for raw glyph ID and WSGravatar Herb Derby2018-03-14
| | | | | | | | | | Accessor is for debugging and Android. Less is for ordered containers. Change-Id: Ic4b7e0e9e32506f8594db961c274f93c5b5d1cee Reviewed-on: https://skia-review.googlesource.com/114369 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add incompleteShortIntPrecision to SkSL StandaloneShaderCapsGravatar Chris Dalton2018-03-14
| | | | | | | | | | TBR=ethannicholas@google.com Bug: skia: Change-Id: If3b86e414d74072dd3e38a5507bbcbcecc3946f6 Reviewed-on: https://skia-review.googlesource.com/114378 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "Improve handling of GrPixelConfig in GrBackendTex/RT ctors"Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7d2b16ad13fd3262c776ae75ae35da4ad69df690. Reason for revert: Maybe breaking chrome? Original change's description: > Improve handling of GrPixelConfig in GrBackendTex/RT ctors > > Make sure that no client facing code was relying on what we set as the > default value for fConfig by making in kUnkown. > > Bug: skia: > Change-Id: Ie52ff08ba8deeacc16fe06eb0dd0c7292b2edf91 > Reviewed-on: https://skia-review.googlesource.com/114261 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I91e190d72407f9c4bee93a031a557f740bb49b66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114423 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* hide SkBlurMaskFilter and SkBlurQualityGravatar Mike Reed2018-03-14
| | | | | | | | | | SK_SUPPORT_LEGACY_BLURMASKFILTER Bug: skia: Change-Id: Ic3e27e08e6e3cd2ffc1cd13b044e197bebc96236 Reviewed-on: https://skia-review.googlesource.com/113940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Experiment: relax 4 byte alignment for glyph imagesGravatar Herb Derby2018-03-14
| | | | | | | | | | | | | This experiment remove the need for rowbytes to be 4 byte aligned in width. This causes waste in data transfer between the Renderer and GPU process. BUG=skia:7515 Change-Id: Iad0383ee0adbacaa791bf4251325867e82fdbea1 Reviewed-on: https://skia-review.googlesource.com/114371 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Revert "Add back missing unique key checks when creating CachedBitmap/Image ↵Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proxies" This reverts commit b78dd5d01eb16ae3cb9104ce8c0fa7e861431259. Reason for revert: possibly breaking chrome roll Original change's description: > Add back missing unique key checks when creating CachedBitmap/Image Proxies > > Its possible that this could fix perf regression in Chrome. > > Bug: 811452 > Change-Id: I2d4f7827092b361469586580f0c7c843ab2d5cec > Reviewed-on: https://skia-review.googlesource.com/114280 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I71646befd07bf28442ac3b9225c021cd141bf398 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811452 Reviewed-on: https://skia-review.googlesource.com/114422 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* ccpr: Add an attenuation parameter to triangle cornersGravatar Chris Dalton2018-03-14
| | | | | | | | | | | | | Adds an attenuation parameter to corners that corrects the over-coverage from linear interpolation. Adds a GM for shared corners that ensures we're doing this right. Bug: skia: Change-Id: Iff8bd40554f9fda2e7e03faa3c9fbefe65f27568 Reviewed-on: https://skia-review.googlesource.com/114272 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add a shader cap for incomplete short int precisionGravatar Chris Dalton2018-03-14
| | | | | | | | | Bug: skia: Change-Id: Iac36eb763e687f6ecc3acbd4afced66f95596be2 Reviewed-on: https://skia-review.googlesource.com/109003 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Provide promise images when rendering SKPs w/ DDLGravatar Robert Phillips2018-03-14
| | | | | | | Change-Id: I8014693eefb3c7811a1fc0354ee8441c90c97328 Reviewed-on: https://skia-review.googlesource.com/113213 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Ensure that GrGpu state tracking is initialized before making a backend ↵Gravatar Brian Salomon2018-03-14
| | | | | | | | | RT/Tex in tests Change-Id: Ie5692d97678705306f514d5911bf331f784e7a40 Reviewed-on: https://skia-review.googlesource.com/114288 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* add explicit API to know if the writebuffer is using its external storageGravatar Mike Reed2018-03-14
| | | | | | | | | | To help with https://skia-review.googlesource.com/c/skia/+/114262 Bug: skia: Change-Id: I83fcccdec0dbaef28d0e557ea6fb9bd0ed59ed44 Reviewed-on: https://skia-review.googlesource.com/114284 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Improve handling of GrPixelConfig in GrBackendTex/RT ctorsGravatar Greg Daniel2018-03-14
| | | | | | | | | | | | Make sure that no client facing code was relying on what we set as the default value for fConfig by making in kUnkown. Bug: skia: Change-Id: Ie52ff08ba8deeacc16fe06eb0dd0c7292b2edf91 Reviewed-on: https://skia-review.googlesource.com/114261 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add back missing unique key checks when creating CachedBitmap/Image ProxiesGravatar Greg Daniel2018-03-14
| | | | | | | | | | | Its possible that this could fix perf regression in Chrome. Bug: 811452 Change-Id: I2d4f7827092b361469586580f0c7c843ab2d5cec Reviewed-on: https://skia-review.googlesource.com/114280 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* exact divide by 255 with NEONGravatar Mike Klein2018-03-14
| | | | | | | Change-Id: Ib121eb0d5af1f22f48f517fe909112a77d92032e Reviewed-on: https://skia-review.googlesource.com/113666 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Cleanup size calculations in SkGlyphGravatar Herb Derby2018-03-14
| | | | | | | | | BUG=skia:7515 Change-Id: Ie9d255a93ecff86ce018f8510332bdb280ec575e Reviewed-on: https://skia-review.googlesource.com/113863 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Compile with GCC 7.2.0.Gravatar Ben Wagner2018-03-13
| | | | | | | | | | | | | | This suppresses the noexcept-type warning, since Skia doesn't have a stable ABI in any event. GCC now warns on more printf style formats, so we have to hide our bad test formats a little better. GCC now also warns on implicit enum to bool conversions, which did catch two issues. Change-Id: Ib81769c421757186506873f0fe298ecd0106ae87 Reviewed-on: https://skia-review.googlesource.com/114263 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Harden initial LinearGradient4f tilingGravatar Florin Malita2018-03-13
| | | | | | | | | | | | | | | | | | Even with verified/finite inputs, fx can sometimes collapse to infinity. When that happens, attempting to apply repeat/mirror tiling produces NaN results and things go south. Catch these degenerate cases and tile to 0 (for lack of a better idea). Note: leaving fx == +/- inf in clamp mode should be safe. BUG=oss-fuzz:6622 Change-Id: I65711020057856b47045f67a52d906336ad1f173 Reviewed-on: https://skia-review.googlesource.com/114090 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* consolidate SaveLayerFlag internal referencesGravatar Cary Clark2018-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a third define in SkCanvasPriv to complement SkCanvas::kDontClipToLayer_PrivateSaveLayerFlag and SkCanvas::kDontClipToLayer_Legacy_SaveLayerFlag. SkCanvas::kDontClipToLayer_PrivateSaveLayerFlag exists only to define SkCanvas::kDontClipToLayer_Legacy_SaveLayerFlag and SkCanvasPriv::kDontClipToLayer_SaveLayerFlag. SkCanvas::kDontClipToLayer_Legacy_SaveLayerFlag is used only by Android framework. SkCanvasPriv::kDontClipToLayer_SaveLayerFlag is used internally. Note that changes to CanvasStateTest.cpp inside SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG aren't testable by existing skiabots; it requires building an Android framework aware version of dm. CanvasStateTest.cpp may have bit-rotted. R=reed@google.com,scroggo@google.com Bug: skia:6454,skia:7690 Change-Id: I74f2a54636fae89a5a88a7e13f1baba49d3e2115 Reviewed-on: https://skia-review.googlesource.com/112401 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Include correct trace.h.Gravatar Ben Wagner2018-03-13
| | | | | | | | | | | | | SkTraceEventCommon.h currently includes <utils/Trace.h>, but doesn't actually use anything directly from it. In addition, Skia doesn't directly depend on libutils, but instead on libcutils. As a result, replace the <utils/Trace.h> include with <cutils/trace.h> which is what actually provides all the needed macros and declarations. Change-Id: Ic6a7283c71fc94058f735b1b3e541fec3a7db760 Reviewed-on: https://skia-review.googlesource.com/114099 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix possible overflows in hair line path renderer vertex countsGravatar Brian Salomon2018-03-13
| | | | | | | | Bug: chromium:820913 Change-Id: I77f9b40cf6173369a4a1b943d71734c305893e09 Reviewed-on: https://skia-review.googlesource.com/114140 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fixed some shader cache issuesGravatar Ethan Nicholas2018-03-13
| | | | | | | | | | | | We now check GL_NUM_SHADER_BINARY_FORMATS to ensure that it is greater than zero, and handle errors that occur when we try to install a cached shader by falling back to using GLSL. Bug: skia: Change-Id: I1ac46243e9c561d15e1b4190b68afbf514fc8079 Reviewed-on: https://skia-review.googlesource.com/113820 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Remove calls to computeOutputColor- Type and SpaceGravatar Leon Scroggins III2018-03-13
| | | | | | | | | | | | | | Bug: b/70846442 Test: I5110881203c000474116a94a48f2afc9a9b62001 These methods were already called by the client. The client may have further overridden the SkColorType (and therefore the SkColorSpace), so respect their final decision on both. Change-Id: Iddcf618e474784b0a000fd516250c44285dacc6b Reviewed-on: https://skia-review.googlesource.com/114062 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
* Add testing-only backend render target support to GrVkGpu.Gravatar Brian Salomon2018-03-13
| | | | | | | | | | | | | Update unit tests to use backend render targets on non-GL contexts Add named DM configs for rendering to Vulkan backend render targets and textures. Make src data ptr param to createTestingOnlyBackendTexture be const. Change-Id: I17f5375ed9bb08422006698956469d3151c4954c Reviewed-on: https://skia-review.googlesource.com/113276 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* avoid divide by zeroGravatar Cary Clark2018-03-13
| | | | | | | | | | R=kjlubick@google.com Bug: skia:7623 Change-Id: Ia9fb31201a39a4540d94f97e8d2f06eb290ab6e5 Reviewed-on: https://skia-review.googlesource.com/114082 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* protect SkPathMeasure against NaNGravatar Cary Clark2018-03-13
| | | | | | | | | | R=kjlubick@google.com Bug: skia:7714 Change-Id: I4d260061605404cc7f1b4ee5dd20578cf63c8b2d Reviewed-on: https://skia-review.googlesource.com/114060 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Revert "Reland "Add SkColorSpaceXform_skcms""Gravatar Brian Osman2018-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 57337d90a56f458451a01944efcdc205473bc0bb. Reason for revert: More investigation needed... Original change's description: > Reland "Add SkColorSpaceXform_skcms" > > This reverts commit 8103ecae7b535f011f89b03545fe768801027b6b. > > Reason for revert: Investigated the 565 diffs, they appear to be *more* correct. > > Original change's description: > > Revert "Add SkColorSpaceXform_skcms" > > > > This reverts commit 67f62b1a61016ad07b44ae5a0bbf79d97adc9ba9. > > > > Reason for revert: I want to investigate the image/colorimage gold diffs. May be correct, but some of them are pretty large. > > > > Original change's description: > > > Add SkColorSpaceXform_skcms > > > > > > Currently only enabled in Skia dev builds. Passes all unit > > > tests. Has some GM differences, but nothing major. > > > > > > Bug: skia: > > > Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910 > > > Reviewed-on: https://skia-review.googlesource.com/112520 > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > Reviewed-by: Mike Klein <mtklein@google.com> > > > > TBR=mtklein@google.com,brianosman@google.com,reed@google.com > > > > Change-Id: Ib4d7174f5c2700d6f742f488e740e5a6c87ac7a8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/113880 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Commit-Queue: Brian Osman <brianosman@google.com> > > TBR=mtklein@google.com,brianosman@google.com,reed@google.com > > Change-Id: I6501ff55349a6aeed62bb64afc47f789e8cc3460 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/114040 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=mtklein@google.com,brianosman@google.com,reed@google.com Change-Id: Ic9ee46032762a8b5fc96314c460ce01708673472 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114100 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "Add SkColorSpaceXform_skcms"Gravatar Brian Osman2018-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8103ecae7b535f011f89b03545fe768801027b6b. Reason for revert: Investigated the 565 diffs, they appear to be *more* correct. Original change's description: > Revert "Add SkColorSpaceXform_skcms" > > This reverts commit 67f62b1a61016ad07b44ae5a0bbf79d97adc9ba9. > > Reason for revert: I want to investigate the image/colorimage gold diffs. May be correct, but some of them are pretty large. > > Original change's description: > > Add SkColorSpaceXform_skcms > > > > Currently only enabled in Skia dev builds. Passes all unit > > tests. Has some GM differences, but nothing major. > > > > Bug: skia: > > Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910 > > Reviewed-on: https://skia-review.googlesource.com/112520 > > Commit-Queue: Brian Osman <brianosman@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,brianosman@google.com,reed@google.com > > Change-Id: Ib4d7174f5c2700d6f742f488e740e5a6c87ac7a8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/113880 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=mtklein@google.com,brianosman@google.com,reed@google.com Change-Id: I6501ff55349a6aeed62bb64afc47f789e8cc3460 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114040 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* fix a couple pathops fuzzersGravatar Cary Clark2018-03-13
| | | | | | | | | | | | | | This fixes these: src/pathops/SkOpCoincidence.cpp -- 1 crash-causing fuzzes src/pathops/SkOpSpan.h -- 1 crash-causing fuzzes R=kjlubick@google.com Bug: skia: Change-Id: I2b0dbd74757a32e522901753e2e17114a1a9f79b Reviewed-on: https://skia-review.googlesource.com/113751 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Revert "Add SkColorSpaceXform_skcms"Gravatar Brian Osman2018-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 67f62b1a61016ad07b44ae5a0bbf79d97adc9ba9. Reason for revert: I want to investigate the image/colorimage gold diffs. May be correct, but some of them are pretty large. Original change's description: > Add SkColorSpaceXform_skcms > > Currently only enabled in Skia dev builds. Passes all unit > tests. Has some GM differences, but nothing major. > > Bug: skia: > Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910 > Reviewed-on: https://skia-review.googlesource.com/112520 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,brianosman@google.com,reed@google.com Change-Id: Ib4d7174f5c2700d6f742f488e740e5a6c87ac7a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/113880 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add SkColorSpaceXform_skcmsGravatar Brian Osman2018-03-12
| | | | | | | | | | | Currently only enabled in Skia dev builds. Passes all unit tests. Has some GM differences, but nothing major. Bug: skia: Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910 Reviewed-on: https://skia-review.googlesource.com/112520 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Move ComputeAxisAlignmentForHText to Rec.Gravatar Herb Derby2018-03-12
| | | | | | | | | BUG=skia:7515 Change-Id: I81d7950e508e0893f3591cc07596c10e8aaa636a Reviewed-on: https://skia-review.googlesource.com/113749 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 00:03:28 +0000