aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Add functions for inspecting SkShader.Gravatar commit-bot@chromium.org2014-05-13
| | | | | | | | | | | | | | | | | | | Add a function to inspect an SkShader to determine if it is an SkComposeShader. Add a virtual function for determining if an SkShader is a custom shader, which returns a custom set of information. The implementation is in Android, and this function is only defined if SK_BUILD_FOR_ANDROID_FRAMEWORK. BUG=b/10650594 R=reed@google.com, scroggo@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/282733005 git-svn-id: http://skia.googlecode.com/svn/trunk@14716 2bbb7eff-a529-9590-31e7-b0007b416f81
* Always inline Filter_32_*_neon functionsGravatar commit-bot@chromium.org2014-05-13
| | | | | | | | | | | | | | | | | | | The functions are rather performance critical and already marked 'inline'. However, Chrome for Android will not have these functions inlined due to it being compiled with -Os and a small -finline-limit. This avoids one call in the filtering functions. Does not increase the library size. BUG=chromium:363073 R=mtklein@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/280403005 git-svn-id: http://skia.googlecode.com/svn/trunk@14709 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add check for bad dash interval in dash effect picture readGravatar commit-bot@chromium.org2014-05-13
| | | | | | | | | | | BUG=skia:2542 R=caryclark@google.com, reed@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/275053004 git-svn-id: http://skia.googlecode.com/svn/trunk@14708 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-05-13
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@14705 2bbb7eff-a529-9590-31e7-b0007b416f81
* re-land hide get/setLocalMatrixGravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | This reverts commit b1d702a43b07934f5b001b1b09db2c57ede909a1. TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/279903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14702 2bbb7eff-a529-9590-31e7-b0007b416f81
* apply localmatrix in pre-order, to match other shadersGravatar reed@google.com2014-05-12
| | | | | | | | BUG=skia: Review URL: https://codereview.chromium.org/280293002 git-svn-id: http://skia.googlecode.com/svn/trunk@14699 2bbb7eff-a529-9590-31e7-b0007b416f81
* Clean up global gSkSuppressFontCachePurgeSpew.Gravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | | | | No one is using it except to flick it to true to shut up the spew, but the spew is already guarded by #ifdef SPEW_PURGE_STATUS. Let's leave it to SPEW_PURGE_STATUS. Noticed this specificially when TSAN complained about FontScalerBench modifying it in a thread-unsafe way. BUG=skia:1792 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/264333008 git-svn-id: http://skia.googlecode.com/svn/trunk@14697 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make gMask_00FF00FF a constantGravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | | | | | | | | | This is to optimize SkAlphaMulQ() in PIC mode. With the visibility=default symbol the constant is not known at compile time (and is not a constant), but instead is fetched through a double indirection through GOT. The function is quite hot on one of the chromium benchmarks: rasterize_and_record_micro.key_silk_cases. This change replaces the symbol with a compile-time constant. As a bonus the variable is not exported from the dynamic library, i. e. a cleaner library interface. See specific performance improvements on Android here: http://goo.gl/iMuTDt R=skyostil@chromium.org, tomhudson@chromium.org, mtklein@google.com, reed@google.com, tomhudson@google.com Author: pasko@chromium.org Review URL: https://codereview.chromium.org/270473003 git-svn-id: http://skia.googlecode.com/svn/trunk@14696 2bbb7eff-a529-9590-31e7-b0007b416f81
* Improved x86 SSE build and run-time checks.Gravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | | | | | | Replaces the current build/run-time checks for SSE level in opts_check_x86.cpp with a simpler and more future-proof version. Also adds SSE versions 4.1 and 4.2 to the config file. Author: henrik.smiding@intel.com Signed-off-by: Henrik Smiding <henrik.smiding@intel.com> Committed: http://code.google.com/p/skia/source/detail?r=14644 R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com Author: henrik.smiding@intel.com Review URL: https://codereview.chromium.org/272503006 git-svn-id: http://skia.googlecode.com/svn/trunk@14693 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove unused Kernel33MaskFilterGravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | R=robertphillips@google.com TBR=robertphilips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/280233002 git-svn-id: http://skia.googlecode.com/svn/trunk@14691 2bbb7eff-a529-9590-31e7-b0007b416f81
* add localmatrix param to asNewEffectGravatar reed@google.com2014-05-09
| | | | | | | | BUG=skia: Review URL: https://codereview.chromium.org/278983002 git-svn-id: http://skia.googlecode.com/svn/trunk@14688 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factor GrTexture into public GrTexture and private GrTextureImpl.Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | Committed: http://code.google.com/p/skia/source/detail?r=14680 R=jvanverth@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14687 2bbb7eff-a529-9590-31e7-b0007b416f81
* add localmatrix parameter to shader's asNewEffectGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com, dominikg@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/278963002 git-svn-id: http://skia.googlecode.com/svn/trunk@14686 2bbb7eff-a529-9590-31e7-b0007b416f81
* Un-swap underline position and thickness calcualtions in DirectWrite.Gravatar bungeman@google.com2014-05-09
| | | | | | | The change at r13635 got these backwards. git-svn-id: http://skia.googlecode.com/svn/trunk@14683 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Factor GrTexture into public GrTexture and private GrTextureImpl. ↵Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/275903002/) Reason for revert: Breaks chrome build. Original issue's description: > Factor GrTexture into public GrTexture and private GrTextureImpl. > > Committed: http://code.google.com/p/skia/source/detail?r=14680 R=jvanverth@google.com, robertphillips@google.com TBR=jvanverth@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: bsalomon@google.com Review URL: https://codereview.chromium.org/278073002 git-svn-id: http://skia.googlecode.com/svn/trunk@14681 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factor GrTexture into public GrTexture and private GrTextureImpl.Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | R=jvanverth@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14680 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of hide get/setLocalMatrix (https://codereview.chromium.org/279563002/)Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | | Reason for revert: broke gms Original issue's description: > hide get/setLocalMatrix > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14675 R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org TBR=dominikg@chromium.org, fmalita@chromium.org, fmalita@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/278903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14677 2bbb7eff-a529-9590-31e7-b0007b416f81
* hide get/setLocalMatrixGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | BUG=skia: R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/279563002 git-svn-id: http://skia.googlecode.com/svn/trunk@14675 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add timing to dump_record.Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prints microsecond timing for each command in the left-hand column: optimized flat/http___mobile_news_sandbox_google_com_news_pt0_scroll_layer_7.skp 4.0 1 Save 2075.0 2 DrawRect 104.0 3 BoundedDrawPosTextH 135.4 4 DrawRect 9.4 5 DrawRect 5.6 6 DrawRect 8.2 7 DrawRect 6.8 8 DrawRect ... (I'm sure Rietveld will just mangle the crap out of that. It's helpfully right-aligned.) To do this, I made Draw from SkRecordDraw Skia-public as SkRecords::Draw, and time it command-by-command. BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/272723007 git-svn-id: http://skia.googlecode.com/svn/trunk@14672 2bbb7eff-a529-9590-31e7-b0007b416f81
* QuadTree: don't leak deferred inserts past clear()Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | BUG=skia: R=djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/277713003 git-svn-id: http://skia.googlecode.com/svn/trunk@14670 2bbb7eff-a529-9590-31e7-b0007b416f81
* cleanup GrContext resource cache apiGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275563005 git-svn-id: http://skia.googlecode.com/svn/trunk@14669 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix typo in SkFontHost_win.cpp in comment.Gravatar bungeman@google.com2014-05-09
| | | | | | | We want the 'size', not the 'side'. git-svn-id: http://skia.googlecode.com/svn/trunk@14667 2bbb7eff-a529-9590-31e7-b0007b416f81
* Disable filtering in draw Bitmap operation when pixels are alignedGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | The check is now performed in the callers of internalDrawBitmap() to avoid retrieve the texture with wrong filter mode when the pixels were aligned. This bug was spotted in Chrome for Android: Chrome for Androids's Canvas drawImage loses fidelity in canvases larger than 64k pixels. BUG=chromium:231916 R=bsalomon@google.com, robertphillips@google.com Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Author: siglesias@igalia.com Review URL: https://codereview.chromium.org/264303008 git-svn-id: http://skia.googlecode.com/svn/trunk@14665 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix rendering artifacts in pull-saveLayers-forward modeGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | | | This CL fixes 2 bugs in the pre-rendering of saveLayers: 1) The drawBitmapRect call wasn't occurring in device space so could sometimes be double transformed 2) The BBH op skipping in SkPicturePlayback could sometimes mess up the SkPictureStateTree's state It also reduces the number of layers that are pre-rendered when a BBH is not in use. Committed: http://code.google.com/p/skia/source/detail?r=14650 R=bsalomon@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/267293007 git-svn-id: http://skia.googlecode.com/svn/trunk@14659 2bbb7eff-a529-9590-31e7-b0007b416f81
* return null if subshader failsGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/279573002 git-svn-id: http://skia.googlecode.com/svn/trunk@14656 2bbb7eff-a529-9590-31e7-b0007b416f81
* Split Star into Star (stores nothing) and List (stores matches).Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | | Just noticed that the cull noop pattern (PushCull, Star<NoOp>, PopCull) would trigger the Star that stores matches. We certainly don't need those matches here, so instead of magically determining which Star you need, we'll make you tell us which one you want. No one but List's unit test needs List. I'll leave it for now, but we might find it's not useful. BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com, bungeman@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/275623002 git-svn-id: http://skia.googlecode.com/svn/trunk@14655 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert r14650 (Fix rendering artifacts in pull-saveLayers-forward mode - ↵Gravatar robertphillips@google.com2014-05-08
| | | | | | https://codereview.chromium.org/267293007) due to unit test failures git-svn-id: http://skia.googlecode.com/svn/trunk@14654 2bbb7eff-a529-9590-31e7-b0007b416f81
* Noop away PushCull/PopCull pairs with nothing between them.Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/277613002 git-svn-id: http://skia.googlecode.com/svn/trunk@14653 2bbb7eff-a529-9590-31e7-b0007b416f81
* store map ptr in GrGeometryBuffer base classGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/272503009 git-svn-id: http://skia.googlecode.com/svn/trunk@14652 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix rendering artifacts in pull-saveLayers-forward modeGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | This CL fixes 2 bugs in the pre-rendering of saveLayers: 1) The drawBitmapRect call wasn't occurring in device space so could sometimes be double transformed 2) The BBH op skipping in SkPicturePlayback could sometimes mess up the SkPictureStateTree's state It also reduces the number of layers that are pre-rendered when a BBH is not in use. R=bsalomon@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/267293007 git-svn-id: http://skia.googlecode.com/svn/trunk@14650 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of extract some common code from PictureRenderer ↵Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/273703006/) Reason for revert: breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue. Original issue's description: > extract some common code from PictureRenderer > > Committed: http://code.google.com/p/skia/source/detail?r=14638 R=borenet@google.com, epoger@google.com TBR=borenet@google.com, epoger@google.com NOTREECHECKS=true NOTRY=true Author: djsollen@google.com Review URL: https://codereview.chromium.org/274463004 git-svn-id: http://skia.googlecode.com/svn/trunk@14649 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Improved x86 SSE build and run-time checks. ↵Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/272503006/) Reason for revert: Windows builders breaking. :( Original issue's description: > Improved x86 SSE build and run-time checks. > > Replaces the current build/run-time checks for SSE level in > opts_check_x86.cpp with a simpler and more future-proof version. > Also adds SSE versions 4.1 and 4.2 to the config file. > > Author: henrik.smiding@intel.com > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com> > > Committed: http://code.google.com/p/skia/source/detail?r=14644 R=reed@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, henrik.smiding@intel.com TBR=djsollen@google.com, henrik.smiding@intel.com, joakim.landberg@intel.com, reed@google.com, tomhudson@google.com NOTREECHECKS=true NOTRY=true Author: mtklein@google.com Review URL: https://codereview.chromium.org/277593004 git-svn-id: http://skia.googlecode.com/svn/trunk@14646 2bbb7eff-a529-9590-31e7-b0007b416f81
* Improved x86 SSE build and run-time checks.Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | Replaces the current build/run-time checks for SSE level in opts_check_x86.cpp with a simpler and more future-proof version. Also adds SSE versions 4.1 and 4.2 to the config file. Author: henrik.smiding@intel.com Signed-off-by: Henrik Smiding <henrik.smiding@intel.com> R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com Author: henrik.smiding@intel.com Review URL: https://codereview.chromium.org/272503006 git-svn-id: http://skia.googlecode.com/svn/trunk@14644 2bbb7eff-a529-9590-31e7-b0007b416f81
* extract some common code from PictureRendererGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/273703006 git-svn-id: http://skia.googlecode.com/svn/trunk@14638 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-05-08
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@14636 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move paints to the front of draw structs.Gravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | | | The order of arguments in these structs is arbitrary, so we might as well arrange them to optimize something. Putting the paints at the front means the logic to find the paint is a lot more concise: it's usually just ptr+0, or *(ptr+0) when the SkPaint is optional. This considerably reduces the size of the jump table in IsDraw::operator(). BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/272673002 git-svn-id: http://skia.googlecode.com/svn/trunk@14634 2bbb7eff-a529-9590-31e7-b0007b416f81
* add localmatrix-shaderGravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | BUG=skia: R=scroggo@google.com, dominikg@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/272593002 git-svn-id: http://skia.googlecode.com/svn/trunk@14633 2bbb7eff-a529-9590-31e7-b0007b416f81
* First pass at pre-rendering saveLayers for GPUGravatar robertphillips@google.com2014-05-07
| | | | | | | | https://codereview.chromium.org/261663003/ git-svn-id: http://skia.googlecode.com/svn/trunk@14632 2bbb7eff-a529-9590-31e7-b0007b416f81
* Convert all SkRecordPattern matchers into SkRecord mutators.Gravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | | | | | | | - Allow any return type from SkRecord mutators and visitors; - update existing calls to mutate and visit; - convert match to operator() in SkRecordPattern; - tidy up a few inelegant bits of old code in tests. The net result is that the generated code is much clearer. All the mutate() calls inline as you'd hope, and you can now actually follow along with the disassembly. BUG=skia:2378 R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/273643007 git-svn-id: http://skia.googlecode.com/svn/trunk@14631 2bbb7eff-a529-9590-31e7-b0007b416f81
* Some small cleanups for image filter code.Gravatar senorblanco@chromium.org2014-05-07
| | | | | | | | | | | Use the 2-param flavour of mapVector instead of the 3-param, where possible. Add an SkMatrixImageFilter test case to the tiling unit test. R=junov@chromium.org Review URL: https://codereview.chromium.org/277543002 git-svn-id: http://skia.googlecode.com/svn/trunk@14630 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rename from "(un)lock" to "(un)map" for geometry buffers.Gravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | This better reflects OpenGL terminology and is less overloaded ("lock" is used w.r.t. the resource cache). R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275493004 git-svn-id: http://skia.googlecode.com/svn/trunk@14628 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix for SkDisplacementMap::onFilterBounds().Gravatar senorblanco@chromium.org2014-05-07
| | | | | | | | | | | | | Two problems: we were not applying the CTM to the scale parameter when modifying clip bounds, and the recursion for onFilterBounds() must be done in the reverse order. BUG=370914 R=junov@chromium.org Review URL: https://codereview.chromium.org/272643003 git-svn-id: http://skia.googlecode.com/svn/trunk@14627 2bbb7eff-a529-9590-31e7-b0007b416f81
* Statically initialize those zero-size singletons.Gravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | | | | | This way GCC/Clang don't generate the magic static code to call the pointless T::T() once in a threadsafe way. = {} is plenty initialized. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14623 R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/270353003 git-svn-id: http://skia.googlecode.com/svn/trunk@14626 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Statically initialize those zero-size singletons. ↵Gravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/270353003/) Reason for revert: breaks windows bots Original issue's description: > Statically initialize those zero-size singletons. > > This way GCC/Clang don't generate the magic static code to call the > pointless T::T() once in a threadsafe way. = {} is plenty initialized. > > BUG=skia:2378 > > Committed: http://code.google.com/p/skia/source/detail?r=14623 R=bungeman@google.com, mtklein@chromium.org TBR=bungeman@google.com, mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2378 Author: mtklein@google.com Review URL: https://codereview.chromium.org/270363005 git-svn-id: http://skia.googlecode.com/svn/trunk@14625 2bbb7eff-a529-9590-31e7-b0007b416f81
* Statically initialize those zero-size singletons.Gravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | | This way GCC/Clang don't generate the magic static code to call the pointless T::T() once in a threadsafe way. = {} is plenty initialized. BUG=skia:2378 R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/270353003 git-svn-id: http://skia.googlecode.com/svn/trunk@14623 2bbb7eff-a529-9590-31e7-b0007b416f81
* Partially restore small-T optimization for very small (empty) T.Gravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | | This is particularly helpful for SkRecord::replace<NoOp>, which now doesn't go off and allocate a pointless byte. BUG=skia:2378 R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/269543025 git-svn-id: http://skia.googlecode.com/svn/trunk@14622 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix Dash Effect readback calc for fPhase from old skpsGravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | BUG=skia: R=reed@google.com, bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/270223003 git-svn-id: http://skia.googlecode.com/svn/trunk@14620 2bbb7eff-a529-9590-31e7-b0007b416f81
* save-draw*-restore -> noop-draw*-noopGravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | | | | save-drawA-drawB-drawC-restore always means drawA-drawB-drawC, no matter what flags we use for save(). This one triggers all over the silk SKPs and in several of the bot SKPs, typically as save-drawBitmap-restore. BUG=skia:2378 R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/267793006 git-svn-id: http://skia.googlecode.com/svn/trunk@14618 2bbb7eff-a529-9590-31e7-b0007b416f81
* if SK_DEBUG -> ifdef SK_DEBUGGravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | | | Should unbreak Chrome canary bots. BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/272623002 git-svn-id: http://skia.googlecode.com/svn/trunk@14616 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix warningGravatar commit-bot@chromium.org2014-05-07
| | | | | | | | | | | BUG=skia:2526 R=caryclark@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/270253006 git-svn-id: http://skia.googlecode.com/svn/trunk@14615 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-14 21:41:30 +0000