aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Small pathops cleanup.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | | | | | | Newer clang compiler produces the diagnostic ../../tests/PathOpsDebug.cpp:1349:44: error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-unsigned-enum-zero-compare] if (!firstOp && c->operand() && op >= 0) { The check seems to be defending against bad values of SkPathOp, but this now seems unnecessary. This also adds 'rdiff' to kPathOpStr for future debugging. Change-Id: I08e5ba77c56e519ce4d9ae89491f7ccd5eb7f944 Reviewed-on: https://skia-review.googlesource.com/57104 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Remove trailing whitespace.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | Also adds a presubmit to prevent adding trailing whitespace to source code in the future. Change-Id: I41a4df81487f6f00aa19b188f0cac6a3377efde6 Reviewed-on: https://skia-review.googlesource.com/57380 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Remove carriage returns.Gravatar Ben Wagner2017-10-09
| | | | | | | | | Also add a presubmit so they don't get added to source code. Change-Id: I6a85c6a934b1068a63646a0dcc0d3a08baa96ced Reviewed-on: https://skia-review.googlesource.com/57110 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Revert "Revert "Disable GL buffer mapping on TSAN/Mac.""Gravatar Brian Salomon2017-10-09
| | | | | | | | | | This reverts commit 4e7cdd5a0052aa76bed6f80ec325be19e09e6ab1. Bug: skia:7058 Change-Id: I3b92c35835cf7a8c04e9218194bf293b790413e0 Reviewed-on: https://skia-review.googlesource.com/57222 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Reduce the frequency of the text atlas compaction.Gravatar Derek Sollenberger2017-10-09
| | | | | | | Change-Id: I2e3e9add5f9a9074243d220fa37e610e6ad086c8 Reviewed-on: https://skia-review.googlesource.com/57111 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* fix use of uninitialized flag in SkCodecGravatar Ivan Afanasyev2017-10-09
| | | | | | | | | | | | | SkCodec class has the fStartedIncrementalDecode field, which is not initialized on construction, but may be used in incrementalDecode method being uninitialized. Bug: skia: Change-Id: I378412a375100ad2df4aa38f2dd5682867e0e34b Reviewed-on: https://skia-review.googlesource.com/53160 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Revert "Enable coverage counting path rendering except on Android framework"Gravatar Chris Dalton2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 196efbf71cdd9a64b807e5e869cd45da5a66ac36. Reason for revert: 1k SKPs GPU bot fails, perf regressions to look into. Original change's description: > Enable coverage counting path rendering except on Android framework > > Android framework will come after collecting a bit more data. > > Bug: skia: > Change-Id: I6f4738e457f09c976b8bf282153ca75160a1d91c > Reviewed-on: https://skia-review.googlesource.com/55563 > Commit-Queue: Chris Dalton <csmartdalton@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,csmartdalton@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I3f1a7022414ccec80541772d9912065fa4efd74e Reviewed-on: https://skia-review.googlesource.com/57300 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* use unsigned to allow for using all 32bits for approx distanceGravatar Mike Reed2017-10-09
| | | | | | | | | Bug:757146 Change-Id: If783f1b36fc70c443d0808947275acf003a872ee Reviewed-on: https://skia-review.googlesource.com/57109 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* fix include guardGravatar Mike Reed2017-10-09
| | | | | | | | Bug: skia:7136 Change-Id: I4bc7bb932b24deb1e8fc2938ce641ac6677458e0 Reviewed-on: https://skia-review.googlesource.com/57107 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Disable deferred proxies a different way in ChromeGravatar Robert Phillips2017-10-09
| | | | | | | | | | This keeps crbug.com/769760 working but also fixes the new bug (crbug.com/769898) Bug: 769898 Change-Id: I53c00e2bca602fa9c33e5a50a98274c1ce8b2534 Reviewed-on: https://skia-review.googlesource.com/57282 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Fix a couple float-cast-overflow in SkScan*."Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3cd0bef0fd9d062bbcc313c329b4f31925e8ded7. Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143 Original change's description: > Fix a couple float-cast-overflow in SkScan*. > > Bug: skia:5060 > Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 > Reviewed-on: https://skia-review.googlesource.com/47422 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=benjaminwagner@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:7143 Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae Reviewed-on: https://skia-review.googlesource.com/57240 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "change computeByteSize to return max_size_t on overflow""Gravatar Mike Reed2017-10-09
| | | | | | | | | | | This reverts commit 384f0a7d6626026f21313e85e51890d747171ee8. Bug: skia: Change-Id: I392ef5c1a5172181caf81ae270befeba6e778241 Reviewed-on: https://skia-review.googlesource.com/57084 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Fix new compiler warnings in GLInstancedRendering.cppGravatar Chris Dalton2017-10-09
| | | | | | | | Bug: skia:7109 Change-Id: I6d42991d4aba611819260411aaebd508ff242d09 Reviewed-on: https://skia-review.googlesource.com/56921 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* initClassID no longer auto-allocates idsGravatar Ethan Nicholas2017-10-09
| | | | | | | | | | | | | Auto-allocated IDs mean that the IDs depend upon the order in which classes happen to get initialized and are therefore not consistent from run to run. This change paves the way for a persistent shader cache by fixing the IDs in an enum. Bug: skia: Change-Id: I3e923c6c54f41b3b3eb616458abee83e0909c09f Reviewed-on: https://skia-review.googlesource.com/56401 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Disable GL buffer mapping on TSAN/Mac."Gravatar Brian Salomon2017-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c203e65265ccf0dcf426eafa4fae97b2b99cba7d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable GL buffer mapping on TSAN/Mac. > > Also reverts 65e706379657d64371012c2e95ccf1354d741145 which disabled buffer mapping in GrResourceProvider::createPatternedIndexBuffer. > > Bug: skia:7058 > Change-Id: I6816abe53251e1cd8e92eae41b8cdbe45218a341 > Reviewed-on: https://skia-review.googlesource.com/50100 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=mtklein@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Icf0cf40ba4d6e7081971eee2eea0a41033790df7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7058 Reviewed-on: https://skia-review.googlesource.com/57220 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* add helper to check for overflowGravatar Mike Reed2017-10-09
| | | | | | | | | | pre-CL to aid in changing the convention for when we overflow Bug: skia: Change-Id: I1e34a18fefb80187787a1c0c8ed7ee3516744d24 Reviewed-on: https://skia-review.googlesource.com/57103 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Disable GL buffer mapping on TSAN/Mac.Gravatar Brian Salomon2017-10-09
| | | | | | | | | | Also reverts 65e706379657d64371012c2e95ccf1354d741145 which disabled buffer mapping in GrResourceProvider::createPatternedIndexBuffer. Bug: skia:7058 Change-Id: I6816abe53251e1cd8e92eae41b8cdbe45218a341 Reviewed-on: https://skia-review.googlesource.com/50100 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove SkTypeface::Style use in API.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | | | All known callers of SkTypeface::MakeDefault call it with kNormal and the only users specifying kNormal explicitly are in Skia, so remove the parameter. There appear to be no users of SkTypeface::MakeFromTypeface, so remove it. The current alternative is SkFontMgr::matchFaceStyle which can do a better job anyway. Change-Id: I89d94c77f9593407b0a319786848a8b823fcbae4 Reviewed-on: https://skia-review.googlesource.com/56762 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* CCPR: Blacklist Intel driver except on MacGravatar Chris Dalton2017-10-08
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia: Change-Id: I93306a285c5bd1d71a69c4c8a12b7fc583a52e12 Reviewed-on: https://skia-review.googlesource.com/57160 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* CCPR: Block older Intel/Mesa setupsGravatar Chris Dalton2017-10-07
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia:7134 Change-Id: I71af6c8ca75804f7ac6d187ecdc1467cad686494 Reviewed-on: https://skia-review.googlesource.com/56941 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix a couple float-cast-overflow in SkScan*.Gravatar Ben Wagner2017-10-07
| | | | | | | | Bug: skia:5060 Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4 Reviewed-on: https://skia-review.googlesource.com/47422 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Enable coverage counting path rendering except on Android frameworkGravatar Chris Dalton2017-10-07
| | | | | | | | | | Android framework will come after collecting a bit more data. Bug: skia: Change-Id: I6f4738e457f09c976b8bf282153ca75160a1d91c Reviewed-on: https://skia-review.googlesource.com/55563 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* CCPR: Add workaround for PowerVR crashGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: Icd00f81fda5366813f9c959fdc91b0415894cbfc Reviewed-on: https://skia-review.googlesource.com/55360 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* CCPR: Blacklist intel 4xxx and 6xxxGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: I590725027a6ed66a5612631686f41d62aeeb09fd Reviewed-on: https://skia-review.googlesource.com/56803 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "change computeByteSize to return max_size_t on overflow"Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 24295462722fd5a298d108a80b0aacbb0964da53. Reason for revert: broke running dm on google3 Original change's description: > change computeByteSize to return max_size_t on overflow > > Bug: skia:7132 > Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf > Reviewed-on: https://skia-review.googlesource.com/56620 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=bungeman@google.com,herb@google.com,reed@google.com Change-Id: I5f58ec37241d2fae3ebdb7a3d6b41f9fd6d3c2ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7132 Reviewed-on: https://skia-review.googlesource.com/56880 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add option to create a deferred render target context with mipsGravatar Greg Daniel2017-10-06
| | | | | | | | | | | | | | We need this since we have texture generators that draw the base level but nothing more. Thus we want them to be able to directly draw into a pre allocated mipped target instead of doing a copy later. TBR: bsalomon@google.com Bug: skia: Change-Id: I1dfae0da7153b21b30fdfa51a7061fc255739a1e Reviewed-on: https://skia-review.googlesource.com/54100 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add GS Invocations caps to SkSL StandaloneShaderCapsGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: I58f0caf97048e62a11cf8732acc79e3c2fbc683b Reviewed-on: https://skia-review.googlesource.com/56801 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* change computeByteSize to return max_size_t on overflowGravatar Mike Reed2017-10-06
| | | | | | | | Bug: skia:7132 Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf Reviewed-on: https://skia-review.googlesource.com/56620 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add a cap for geometry shader invocationsGravatar Chris Dalton2017-10-06
| | | | | | | | | Bug: skia:7116 Change-Id: I3cc2ce7b2e5123c9adfd9781b2a5a8553747dfa5 Reviewed-on: https://skia-review.googlesource.com/56000 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix window origin on mac viewsGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: I25e4e791760bd1d95a2bfac1a1b5d18d9caa78e8 Reviewed-on: https://skia-review.googlesource.com/56581 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Generate warning settings for Android frameworkGravatar Leon Scroggins III2017-10-06
| | | | | | | | | | | | | | | | | | Bug: b/66996870 Android wants to build with warnings as errors. Keep the external/skia warnings in sync with other Skia builds by pulling them from the json generated by GN. Fix a couple small errors that show up in the framework build. Uploaded in response to AOSP's https://android-review.googlesource.com/#/c/platform/external/skia/+/498211/ Change-Id: I4d791d43a9b00f9d6b79ecf16839716f241cba99 Reviewed-on: https://skia-review.googlesource.com/55703 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Don't execute onFlush op lists until after GPU data is uploadedGravatar Chris Dalton2017-10-06
| | | | | | | | Bug: skia: Change-Id: Ide85e802fd6e6a19412457dbaded3545b962c240 Reviewed-on: https://skia-review.googlesource.com/55562 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* CCPR: Don't forget resource provider in Pipeline InitArgsGravatar Chris Dalton2017-10-06
| | | | | | | | | | | | Ideally this would use an initializer list to guarantee we never forget another value in the future, but the default member values don't allow it. Bug: skia: Change-Id: I21e5b33bb99c4e0d42a7988b444d08266320bf37 Reviewed-on: https://skia-review.googlesource.com/56262 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* When mip mapping, do YUV mip generation on CPU then upload to GPU.Gravatar Greg Daniel2017-10-05
| | | | | | | | Bug: skia: Change-Id: I930508b38e828652dfbb7c3f9d934d206cf1d72a Reviewed-on: https://skia-review.googlesource.com/56060 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* experiments to speed up drawing 32bit images into 565Gravatar Mike Reed2017-10-05
| | | | | | | | | | | | New (legacy style) blitters only coded for shaders (and very restricted blendmodes) Bug: skia: See https://buganizer.corp.google.com/issues/64884885 Change-Id: Ie2546093bfe1e670a825dfd9542d252d53732c40 Reviewed-on: https://skia-review.googlesource.com/54103 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Fewer atomic ops in debug with SkBufferHead.Gravatar Ben Wagner2017-10-05
| | | | | | | | | | | | | | In debug builds an assert would do an atomic load to assert the reference count was greater than zero, then a fetch_add would access the value again to do the reference counting. Instead just assert in debug on the value produced by the reference counting. This both improves debug performance and (more importantly) makes the debug asserts correct instead of mearly opprotunistic. Change-Id: Ic4ce788930d2564b5f86ab0e09fcd66006c8b73d Reviewed-on: https://skia-review.googlesource.com/55880 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* clamp to [0,1] in all gradient tilersGravatar Mike Klein2017-10-05
| | | | | | | | | | | | | | | | | Today gradient mirror and repeat don't explicitly clamp. They work fine for normal float values, but blow up with inputs like infinity and NaN, and those aren't hard to construct with a combination of a funky matrix and some squaring for xy -> radius. So explicitly clamp in each of the three matrix tilers. This should fix the fuzz at the associated bug. Bug: skia:7093 Change-Id: Idd44e3c7a1ed95e2b1ace8eb953b62eddeb4e00e Reviewed-on: https://skia-review.googlesource.com/55702 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Clean up SkString reference counting a bit.Gravatar Ben Wagner2017-10-05
| | | | | | | | | | | This reverts commit 01f8e41c1368bfd60d3f011cb5aa9cc478799e63, and then works around whatever issues were seen on Ubuntu 14 by continuing the clean up. Change-Id: I3523b12c83e4efef01a8142c00cde4e3e12189fa Reviewed-on: https://skia-review.googlesource.com/55761 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Use draws instead of clears on Macs w/ Intel Iris Pro GPUsGravatar Robert Phillips2017-10-05
| | | | | | | | Bug: 768134 Change-Id: Iebebb617208c0d8415bebef495c6ff02b17efd65 Reviewed-on: https://skia-review.googlesource.com/55800 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* abort if glyph metrics fall outside safe rectGravatar Mike Klein2017-10-05
| | | | | | | | | | | | Caught this while debugging a fuzz from Kevin. Haven't seen this on Windows, but seems like it's got roughly the same possible issue. Change-Id: I5e1c7328890492b3f3295af27757e456e26f9cbf Reviewed-on: https://skia-review.googlesource.com/55760 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* reformat hard-to-read preprocessor in SkJumper.cppGravatar Mike Klein2017-10-05
| | | | | | | Change-Id: I9a140e342e7b12b1cbb09503ca8fc03016717784 Reviewed-on: https://skia-review.googlesource.com/55701 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* converted GrConfigConversionEffect to SkSLGravatar Ethan Nicholas2017-10-05
| | | | | | | | Bug: skia: Change-Id: If17cf0fc8b857d22f33a462a39a02bcddd15deda Reviewed-on: https://skia-review.googlesource.com/55741 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* aggressively refactor pipeline building in SkColorSpaceXformGravatar Mike Klein2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | This rewrites things into 5 distinct phases: 1) load src 2) linearize src 3) gamut transform 4) apply dst transfer function and premul 5) store dst In the existing code, steps 1+2 were really intertwined, and we had all sorts of arbitrary restrictions on input formats and output formats. I've removed most of those. This is guarded by SK_COLOR_SPACE_XFORM_LEGACY_PIPELINE for Blink layout tests. (The 35 diffs all look fine.) Bug: skia:7114 Change-Id: Ib5f15d1ac3240a6ef202ba30acef660152beee82 Reviewed-on: https://skia-review.googlesource.com/55320 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Update SkBufferHead fRefCnt to std::atomic.Gravatar Ben Wagner2017-10-05
| | | | | | | | | This fixes the noisiest bit of a debug tsan build. Change-Id: I5df8cb3003c73640c04bd73e0aad1aefd87f833e Reviewed-on: https://skia-review.googlesource.com/55480 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Always use draws instead of clears for ANGLE D3D11Gravatar Robert Phillips2017-10-05
| | | | | | | | | | | | | | | | At least for my repro case on a Z620 with an nVidia Quadro K620 and recent drivers, this eliminates the noise artifacts. It appears that full target clears are broken in ANGLE D3D11. Note I was never able to repro the bug in the D3D9 or openGL configs. The bug reproed for both the ES2 and ES3 ANGLE D3D11 configs though. Bug: 768134 Change-Id: I68e5fa0dc5e84b31d1d01a1e4b86132ab12a2e09 Reviewed-on: https://skia-review.googlesource.com/55381 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Clean up SkString reference counting a bit."Gravatar Robert Phillips2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a910c847e9d04e183e9e610902cbd363c8488196. Reason for revert: Compilation failure on Ubuntu14 bots ../../../../../work/skia/src/core/SkString.cpp:200:55: error: could not convert ‘{0, {0}, 0}’ from ‘<brace-enclosed initializer list>’ to ‘const SkString::Rec’ const SkString::Rec SkString::gEmptyRec = { 0, {0}, 0 }; Original change's description: > Clean up SkString reference counting a bit. > > BUG=skia:7107 > > Change-Id: I47072bf31b902c79dbb850179ff6d35940de3e63 > Reviewed-on: https://skia-review.googlesource.com/54720 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Ben Wagner <bungeman@google.com> TBR=mtklein@google.com,bungeman@google.com,reed@google.com Change-Id: I6ec327511e8e1c1fd7e4c1bd5839c0547d4ab609 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7107 Reviewed-on: https://skia-review.googlesource.com/55640 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Don't execute onFlush op lists until after GPU data is uploaded"Gravatar Mike Klein2017-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 374a4e49e47a2f1f793a4673f285984953a73308. Reason for revert: lots of failures across the board. Here's one: ../../../src/gpu/GrDrawingManager.cpp:203: fatal error: "assert(onFlushOpList->unique())" Original change's description: > Don't execute onFlush op lists until after GPU data is uploaded > > Bug: skia: > Change-Id: I2ea15f67466761ebd24b9d4a8eb51cd2d452be3c > Reviewed-on: https://skia-review.googlesource.com/54942 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=robertphillips@google.com,csmartdalton@google.com Change-Id: I3f9de3708dd925c93aefc1e6fe8a48833de9171b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/55600 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* refactor SkColorSpaceXform a bitGravatar Mike Klein2017-10-04
| | | | | | | | | | | | | | | | | I was having trouble reading my way through this code, so I decided it needed a little weedwhacking. The main thrust here is: - remove completely pointless ColorSpaceMatch templating - remove absurdly paranoid public/protected/private/friend relationships This is still about twice as overdesigned as I'd like... Change-Id: I275ddbe028ebb09ed383ed7bfaba394975eea27a Reviewed-on: https://skia-review.googlesource.com/55260 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Don't execute onFlush op lists until after GPU data is uploadedGravatar Chris Dalton2017-10-04
| | | | | | | | Bug: skia: Change-Id: I2ea15f67466761ebd24b9d4a8eb51cd2d452be3c Reviewed-on: https://skia-review.googlesource.com/54942 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Clean up SkString reference counting a bit.Gravatar Ben Wagner2017-10-04
| | | | | | | | | BUG=skia:7107 Change-Id: I47072bf31b902c79dbb850179ff6d35940de3e63 Reviewed-on: https://skia-review.googlesource.com/54720 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-07 23:15:41 +0000