aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* More non-invertible shader local matrix guardsGravatar Florin Malita2017-02-10
| | | | | | | Change-Id: Ida9a300420ff1d883e617cdaadb80e88c99ad226 Reviewed-on: https://skia-review.googlesource.com/8333 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Generate sse2/sse4.1 splices, use them.Gravatar Mike Klein2017-02-10
| | | | | | | | | | | | | | While we're at it, tidy up build_stages.py a bit. Redirecting stdout seems a lot easier than print >>f all over the place. TODO: non-VEX-encoded before_loop() and after_loop() CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win2k8-MSVC-GCE-CPU-AVX2-x86_64-Debug Change-Id: I3f38e55f081670dd598c6050435466d9f394e5be Reviewed-on: https://skia-review.googlesource.com/8230 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* 'gasp' to control symmetric rendering on Windows.Gravatar Ben Wagner2017-02-10
| | | | | | | | | | | | | | | | Currently Skia tries hard to use symmetric rendering with DirectWrite as often as possible. However, particularly on Windows 7 with CJK fonts, thin horizontal strokes can be rendered without sufficient contrast because the font was relying on the 6x1 oversampling for what is effecitvely drop-out control. This change will only allow symmetric rendering if the font allows it in the 'gasp' table. BUG=chromium:645055 Change-Id: I45a9d5e4a0b49bb969c44fb20dc92528dfe9c48d Reviewed-on: https://skia-review.googlesource.com/8268 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Use new fragment processor optimization queries.Gravatar Brian Salomon2017-02-10
| | | | | | | | | | | This doesn't yet delete the old virtuals. It still uses the color and component flags model for the pipeline input and blended output but I'm planning to change those as well. Change-Id: I64e2ec0fe9ed9fae3aabf1ca8c9bc0582fc7565a Reviewed-on: https://skia-review.googlesource.com/7760 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* IWYUGravatar Mike Reed2017-02-10
| | | | | | | | | BUG=skia: Change-Id: Ib6b4d52841dbe3fa69a86ddb6b97d6a5d0f004ee Reviewed-on: https://skia-review.googlesource.com/8231 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove declaration of non-existent constructorGravatar Brian Osman2017-02-10
| | | | | | | | | BUG=skia: Change-Id: If60588d5b6e960f2fb89cc24296cea7606fa189a Reviewed-on: https://skia-review.googlesource.com/8324 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Remove SkTextureCompressor.Gravatar Herb Derby2017-02-10
| | | | | | | | | | | | | | | | | | | This is the ultimate state of what it looks like to remove SkTextureCompressor. This end result will result from the following steps. 1) Remove Skia dep on ktx (done) 2) Move format over to ktx (done) 3) Remove all SkTexture compressor code CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: I3ad7a6abbea006a3034d95662c652d6db90b86ef Reviewed-on: https://skia-review.googlesource.com/8272 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Add support for RG float texturesGravatar csmartdalton2017-02-10
| | | | | | | | | | | | | | Adds kRG_float_GrPixelConfig. Also removes default labels from switches on GrPixelConfig, in order to help guide future enumerals to handle them properly. BUG=skia: Change-Id: Ie80b9413b4002b666df3ef1a7a8ea4c9c29ce43b Reviewed-on: https://skia-review.googlesource.com/8226 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fixed3232 overflow in LinearGradientContext::shadeSpan()Gravatar Florin Malita2017-02-10
| | | | | | | | | Speculative fix for TAP ubsan failures. Change-Id: Id3a78adbfab04ba3404a23059cbd8c162d812c2e Reviewed-on: https://skia-review.googlesource.com/8315 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Change the Sprite portion of SkBlitter use SkArenaAlloc.Gravatar Herb Derby2017-02-10
| | | | | | | | | | | | The semantics of createT and make are the same with respect to dtors, so it just a simple replacement of calls. TBR=reed@google.com Change-Id: Ib7d071d214edb44ea5c5466ce81252e9374b6eb7 Reviewed-on: https://skia-review.googlesource.com/8301 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Fix GrRenderTargetContext::drawArc's abandoned Context handlingGravatar Robert Phillips2017-02-10
| | | | | | | | | This was causing a crash in --preAbandonGpuContext mode Change-Id: Ifbd8eea05402d4db2f06c48f31aa53bce09d0c07 Reviewed-on: https://skia-review.googlesource.com/8310 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Roll minimum picture version up to 44."Gravatar Robert Phillips2017-02-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e037d12625b1dbb7952ae8a6553d6830e8b3ebbf. Reason for revert: Checking to see if this broke the Chrome DEPS roll Original change's description: > Roll minimum picture version up to 44. > > This is the version produced by Chrome M54. M56 is stable now. > > I am most interested in deleting SkBitmapSourceDeserializer, > because it awkwardly calls from core into effects (SkImageSource). > > Change-Id: I58b8b990017ba43372ab3333a4ef8312e75abc61 > Reviewed-on: https://skia-review.googlesource.com/8286 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I9202591c7945c9421f335e544bf12461e38acdc6 Reviewed-on: https://skia-review.googlesource.com/8305 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Add a -Mini build bot to build the smallest Skia possible.Gravatar Mike Klein2017-02-10
| | | | | | | | | | | This bot wants everything possible to turn off turned off. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Ubuntu-Clang-x86_64-Release-Mini Change-Id: Ida7ee2406f8fecda9bd408cd9880a3838590a81b Reviewed-on: https://skia-review.googlesource.com/8280 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make header files self-sufficientGravatar Hal Canary2017-02-10
| | | | | | | Change-Id: Ice7d761b1023da77e50e5d6aa597964f7d9aa1d8 Reviewed-on: https://skia-review.googlesource.com/8302 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Fix CopyPixels() bugGravatar Matt Sarett2017-02-10
| | | | | | | | | | BUG=skia: Change-Id: I102fa9f4b16caa1c00602af1a89a0a0372e047b2 Reviewed-on: https://skia-review.googlesource.com/8303 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Replace kCTFontXXXOrientation with kCTFontOrientationXXX.Gravatar bungeman2017-02-09
| | | | | | | | | | | | | | | | | English has a quite complex order of adjectives, and adjectives come before the noun. However, this order often clashes with the desire for clear hierarchy in naming. In the kingdom of nouns the nouns come first. A great eye at Apple noticed a lack of dicipline in the naming of the orientation constants and ranamed them to conform, deprecating the original names. To avoid warnings which become errors, Skia must now use the new names for these constants. BUG=chromium:408571 Change-Id: I5ccce4a3353157e1e8780c3a169099cec76b7637 Reviewed-on: https://skia-review.googlesource.com/8300 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Roll minimum picture version up to 44.Gravatar Mike Klein2017-02-09
| | | | | | | | | | | | This is the version produced by Chrome M54. M56 is stable now. I am most interested in deleting SkBitmapSourceDeserializer, because it awkwardly calls from core into effects (SkImageSource). Change-Id: I58b8b990017ba43372ab3333a4ef8312e75abc61 Reviewed-on: https://skia-review.googlesource.com/8286 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix int64 overflow in SkClampRange::init()Gravatar Florin Malita2017-02-09
| | | | | | | | | BUG=skia:5915,skia:6219 Change-Id: Ic849bf9dc90e623fc1d6269cd245a2e3eca05d1d Reviewed-on: https://skia-review.googlesource.com/8290 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Refactor pixel conversion: premul and unpremulGravatar Matt Sarett2017-02-09
| | | | | | | | | | | Just going for simpler and more code sharing. BUG=skia: Change-Id: I84c20cd4dbb6950f7b4d0bc659c4b3b5a2af201c Reviewed-on: https://skia-review.googlesource.com/8287 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Properly create CTFontDescriptor from SkFontStyle.Gravatar bungeman2017-02-09
| | | | | | | | | | | There has been a long standing TODO about adding weight, width, and slant properly to created CTFontDescriptors. Now that the correct mappings are known, add these values to the descriptors. Change-Id: I37c3b892c2eb9dc3bb63399d14b535737c4fafb3 Reviewed-on: https://skia-review.googlesource.com/8273 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Move C effects into effects.Gravatar Mike Klein2017-02-09
| | | | | | | Change-Id: If5fb69781425260004a9782f8e92ea3d981bb0ed Reviewed-on: https://skia-review.googlesource.com/8283 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove inner/outer threshold restriction on SkAlphaThresholdFilter.Gravatar Brian Salomon2017-02-09
| | | | | | | | Chrome pixel tests are relying on this being a valid configuration. Change-Id: Ib67e3168b72c15d014fae50faff4eb34fcc50a0d Reviewed-on: https://skia-review.googlesource.com/8284 Reviewed-by: Robert Phillips <robertphillips@google.com>
* [4fGradient] Relax interval checks for SkGradientShaderBase alsoGravatar Florin Malita2017-02-09
| | | | | | | | | | | | Similar to https://skia-review.googlesource.com/8270, treat intervals as closed at both extremities in the 4f gradient fallback impl also. BUG=skia:6212 Change-Id: I7f164868202ae6a0f76cbcdbcbf8e62db12a1bd4 Reviewed-on: https://skia-review.googlesource.com/8277 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* re-land of skslc type constructor cleanupsGravatar Ethan Nicholas2017-02-09
| | | | | | | | | BUG=skia: Change-Id: I953be07e2389dd4a9e7dcce0ddfd7505b309bda1 Reviewed-on: https://skia-review.googlesource.com/8265 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Temporarily don't mark alpha threshold fp as modulatingGravatar Brian Salomon2017-02-09
| | | | | | Change-Id: I4b2b4f69f1d68cb55ca65d046355a5ea2dc34e36 Reviewed-on: https://skia-review.googlesource.com/8279 Reviewed-by: Brian Salomon <bsalomon@google.com>
* Pixel conversion refactors: use raster pipeline for 565 and grayGravatar Matt Sarett2017-02-09
| | | | | | | | | | | | | | | I'm trying not to do too much in one CL. But, in general, I hope to drop (non-performance important/optimized) special cases and use the pipeline. BUG=skia: CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: I724d3982f1467f6232371360b860484f13b1ede8 Reviewed-on: https://skia-review.googlesource.com/8271 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Make src/effects explicitly optional.Gravatar Mike Klein2017-02-09
| | | | | | | | | | | | | | This adds a GN argument to disable src/effects, which can cut about 1M off libskia. It's not the first place you'd go to trim code size, but after turning off easy big things like Ganesh, it starts looking big. I tested that fiddle builds and links. It uses Skia but not effects. Most of our test apps use effects and can't build in this new mode. Change-Id: I9b5d6e9289a87bc08eedf6d202d0eabe754da41a Reviewed-on: https://skia-review.googlesource.com/8263 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* added support for sk_ClipDistanceGravatar Ethan Nicholas2017-02-09
| | | | | | | Change-Id: I9ea202679211b98cf98165c8609f24f9b4e14b66 Reviewed-on: https://skia-review.googlesource.com/8247 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Re-enable processor optimization test with some fixes.Gravatar Brian Salomon2017-02-09
| | | | | | | | | Enables on GL (for now) Change-Id: I5f5a38632963dd705f8434e8627eb33446e8f027 Reviewed-on: https://skia-review.googlesource.com/7721 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* [4fGradient] Relax interval checksGravatar Florin Malita2017-02-09
| | | | | | | | | | | | | | | | | | | We're currently considering intervals open at one extremity, in order to ensure that a given value is always contained in a single interval. This creates problems with synthetic clamp intervals [1, +inf), for t == +inf (no interval can contain it). Treat intervals as closed at both extremities instead. This introduces some ambiguitiy for overlapping values (contained in both adjacent intervals), but solves the more serious problem above. BUG=skia:6213 Change-Id: I33064f762fa9c2b914615e27977115d6654b12f4 Reviewed-on: https://skia-review.googlesource.com/8270 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Remove last use of ktx.hGravatar Herb Derby2017-02-09
| | | | | | | | | | | If this breaks something in Google3, revert it. Change-Id: Id719a87b6ca95c41d06f44f05ee1fdd430d4e0a2 Reviewed-on: https://skia-review.googlesource.com/8262 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Don't batch circles and circular rrects beyond index limitGravatar Jim Van Verth2017-02-09
| | | | | | | | | | BUG=skia:6158, chromium:690144, chromium:688582, chromium:684112 Change-Id: I7a6d1fb73cbe6cb4328848acd153ff2505b5fea2 Reviewed-on: https://skia-review.googlesource.com/8256 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Revert "skslc type constructor cleanups"Gravatar Ethan Nicholas2017-02-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6f223283661c1ddc4a5334d2464804c6b6ba3ffa. Reason for revert: bot breakage Original change's description: > skslc type constructor cleanups > > BUG=skia: > > Change-Id: I87108b5e107419d99c996ef032eda512a68451ab > Reviewed-on: https://skia-review.googlesource.com/8117 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> > TBR=egdaniel@google.com,ethannicholas@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: I1c9a8c4c62c7dd0f724f22000507112641d25e3b Reviewed-on: https://skia-review.googlesource.com/8259 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Include correct header in SkFontMgr_custom_empty_factory.cpp.Gravatar Ben Wagner2017-02-09
| | | | | The SkFontMgr_New_Custom_Empty function used to be declared in SkFontMgr_custom.h, but is now declared in SkFontMgr_empty.h.
* Revert "added support for sk_ClipDistance"Gravatar Ethan Nicholas2017-02-09
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8b8c76506a9a3b07246e6c2770e35dfc413da97a. Reason for revert: breaks Vulkan Original change's description: > added support for sk_ClipDistance > > Change-Id: I14fd921cace23ab37a1e5e9d5da94d92d3688680 > Reviewed-on: https://skia-review.googlesource.com/8225 > Reviewed-by: Chris Dalton <csmartdalton@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > TBR=csmartdalton@google.com,ethannicholas@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I84d6bc75738eb9a8e090aa60e6421f2437a027b2 Reviewed-on: https://skia-review.googlesource.com/8246 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Split custom font managers.Gravatar Ben Wagner2017-02-09
| | | | | | | | | | | | Some users would like to use the empty font manager, but the directory gont manager brings in extra dependencies to work which would otherwise be unneeded. Allow these users to build just the bits of code they actually need. Change-Id: Ib029ef2682883509bad5a2aa39f1ef55631f4d8a Reviewed-on: https://skia-review.googlesource.com/8200 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* skslc type constructor cleanupsGravatar Ethan Nicholas2017-02-09
| | | | | | | | | | BUG=skia: Change-Id: I87108b5e107419d99c996ef032eda512a68451ab Reviewed-on: https://skia-review.googlesource.com/8117 Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* added support for sk_ClipDistanceGravatar Ethan Nicholas2017-02-09
| | | | | | | Change-Id: I14fd921cace23ab37a1e5e9d5da94d92d3688680 Reviewed-on: https://skia-review.googlesource.com/8225 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* [4fLinearGradient] Avoid NaNs for degenerate perspectivesGravatar Florin Malita2017-02-09
| | | | | | | | | BUG=skia:6211 Change-Id: I92148497b29860b3844fe35c2985070a197e4085 Reviewed-on: https://skia-review.googlesource.com/8229 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Add integer vectors to GrSLTypeGravatar csmartdalton2017-02-08
| | | | | | | | | BUG=skia: Change-Id: I4a4a50e214f2240d83f6f0b02cf43e695c067933 Reviewed-on: https://skia-review.googlesource.com/8122 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add a basic constructor to GrPipelineGravatar csmartdalton2017-02-08
| | | | | | | | | | | | Adds a simple constructor for when we just need to set up basic internal rendering. BUG=skia: Change-Id: Ib046c62e9a759aa7d0a3345e16ccf6e6af9342ea Reviewed-on: https://skia-review.googlesource.com/8121 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* SkRasterPipelineBlitter doesn't need an SkArenaAlloc.Gravatar Mike Klein2017-02-08
| | | | | | | Change-Id: Ie4f8bb1c05dee4639a075c100abbc5262e521fc4 Reviewed-on: https://skia-review.googlesource.com/8128 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* [4fGradient] Fix degenerate vertical gradient assertGravatar Florin Malita2017-02-08
| | | | | | | | | | | | | | | | | | For vertical gradients, we rely on LinearIntervalProcessor to yield a fAdvX == +inf, thanks to division by dx (== +/-0). But certain degenerate values may cause the numerator to also collapse to 0, resulting in fAdvX == NaN. Instead or relying on float semantics, pin fAdvX to +inf explicitly for vertical gradients. BUG=skia:5912 Change-Id: Ia8007b99802a6b1e0b22f5618a0ca8959b0cfbb2 Reviewed-on: https://skia-review.googlesource.com/8223 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Remove use of SkSmallAllocator from all Loopers.Gravatar Herb Derby2017-02-08
| | | | | | | | | R=reed@google.com Change-Id: I22b140ee8e12900de13bc623adb30b5fca3051f9 Reviewed-on: https://skia-review.googlesource.com/7658 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Herb Derby <herb@google.com>
* SkSplicer: begin on sse2/sse4.1 supportGravatar Mike Klein2017-02-08
| | | | | | | | | | | | | | | | This lets us target older machines with SkSplicer. SSE2 and SSE4.1 are the sweet spots if we're going to pick two more. Nothing too interesting here except maybe the f16<->f32 code. I rearranged a little to keep things consistent across platforms. Next CL will get this into _generated.h and use it when appropriate. Change-Id: Ibbdc61ea7a45d22b4f4058b01f75161ea74a7726 Reviewed-on: https://skia-review.googlesource.com/8193 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Simplify SkCpu.cpp preprocessor guards.Gravatar Mike Klein2017-02-08
| | | | | | | | | | | | | | | | | | | | | | | We have a couple ways to detect CPU features on ARM: - on ARMv8, getauxval(AT_HWCAP) - on ARMv7, getauxval(AT_HWCAP) and cpu-features.h This guards each of these methods with preprocessor guards to match exactly when we can use them. Today they're sort of a mix of that and higher level expectations about particular build and operating systems. I'm looking into doing this directly by reading CPU registers, much like we do for x86 further up the file. None of this is super important right now, so as long as we don't decide that we have these features when we don't, things will be fine. It's no big deal for now if we fail to detect them. Change-Id: I3b7768483086d0f3f4f6516b754c3ea5ec2d03e5 Reviewed-on: https://skia-review.googlesource.com/8182 Reviewed-by: Chinmay Garde <chinmaygarde@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove exec bit from source files.Gravatar Ben Wagner2017-02-08
| | | | | | | | | | | | Ran: find src include \( -name '*.cpp' -o -name '*.h' \) -executable -exec chmod -x {} \; BUG=skia: Change-Id: I04a4adbfcea9fd9860ab83d43734dc5158d3a884 Reviewed-on: https://skia-review.googlesource.com/8220 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* add virtuals in prep for device-clippingGravatar Mike Reed2017-02-08
| | | | | | | | | | | | | | Build flag available for backends to begin testing their impl. Need to formalize save/restore, and how to forward these to device but not on picture canvases. BUG=skia:6214 Change-Id: Ic5c0afba3e8c84fcf124567e63fe2f5880b623e7 Reviewed-on: https://skia-review.googlesource.com/8183 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add a blend-wrong mode to SkRasterPipelineBlitter.Gravatar Mike Klein2017-02-08
| | | | | | | | | | | This keeps correct linear blending as the only option exericsed, but it should be easy to see how to turn on blend-wrong mode. Change-Id: I7d87ef8ed00e8990107bd36b826f8d229d930400 Reviewed-on: https://skia-review.googlesource.com/8125 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Revert "Disallow readPixels() conversions from untagged srcs to ↵Gravatar Matt Sarett2017-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tagged dsts"" This reverts commit 8461506c8b025522eb89cd754c63fb5dbf0cb7f1. Reason for revert: Fixed some Chrome code, let's try this again. Original change's description: > Revert "Disallow readPixels() conversions from untagged srcs to tagged dsts" > > This reverts commit ccfd1083a7b9d546735ddd1037f3240635cce72d. > > Reason for revert: Roll is failing. > > Original change's description: > > Disallow readPixels() conversions from untagged srcs to tagged dsts > > > > This might break the roll into Chrome. But let's see how. > > > > BUG=skia:6021 > > > > Change-Id: I2698b5d6fe72d01bed0dc64703b592a03d441a80 > > Reviewed-on: https://skia-review.googlesource.com/7127 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Matt Sarett <msarett@google.com> > > > > TBR=msarett@google.com,brianosman@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:6021 > > Change-Id: I4b62178fd7c23f43cf69ca69fc14526ecd503956 > Reviewed-on: https://skia-review.googlesource.com/7205 > Commit-Queue: Matt Sarett <msarett@google.com> > Reviewed-by: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,brianosman@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia:6021 Change-Id: I3f3f33fe6b84fbd5c537b60ed5c8b9201d529a6a Reviewed-on: https://skia-review.googlesource.com/8156 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>