aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Switch fragment coordinate to 'highp' to fix various broken GMs.Gravatar ethannicholas2015-12-14
| | | | | | BUG=skia:4693 Review URL: https://codereview.chromium.org/1523793002
* Unify some SkNx codeGravatar mtklein2015-12-14
| | | | | | | | | | | | | | | - one base case and one N=1 case instead of two each (or three with doubles) - use SkNx_cast instead of FromBytes/toBytes - 4-at-a-time Sk4f::ToBytes becomes a special standalone Sk4f_ToBytes If I did everything right, this'll be perf- and pixel- neutral. https://gold.skia.org/search2?issue=1526523003&unt=true&query=source_type%3Dgm&master=false BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1526523003
* Revert of SkTime updates (patchset #2 id:20001 of ↵Gravatar mtklein2015-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1521293002/ ) Reason for revert: linux Canary builder has no std::steady_clock. Weird... Original issue's description: > SkTime updates > > 1) Use steady_clock instead of high_resolution_clock. If we don't have a > guarantee of monotonicity, it's pretty much useless for timing things. > > 2) Implement Mac/iOS with <chrono> too. This was waiting on C++11 library support. > > Both high_resolution_clock and steady_clock are (still) busted on MSVC 2013, > so no change there. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6a20871e5aeaa7e61f3348694bf436af16f824b9 TBR=herb@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1529603002
* SkBitmap moveGravatar halcanary2015-12-14
| | | | | | | | Running `Release/dm --gpu 0`, the number of times we call SkBitmap::operator=(const SkBitmap&) (which refs the pixelref) is reduced from ~214929 to ~214626. Review URL: https://codereview.chromium.org/1514503004
* path ops: check for deleted endsGravatar caryclark2015-12-14
| | | | | | | TBR=fmalita@chromium.org BUG=569540 Review URL: https://codereview.chromium.org/1524803002
* SkTime updatesGravatar mtklein2015-12-14
| | | | | | | | | | | | | | 1) Use steady_clock instead of high_resolution_clock. If we don't have a guarantee of monotonicity, it's pretty much useless for timing things. 2) Implement Mac/iOS with <chrono> too. This was waiting on C++11 library support. Both high_resolution_clock and steady_clock are (still) busted on MSVC 2013, so no change there. BUG=skia: Review URL: https://codereview.chromium.org/1521293002
* If a point is on a path edge, it's in the path, at least for all cases where ↵Gravatar caryclark2015-12-14
| | | | | | | | | | | the path edge is not canceled with another edge through coincidence. Add test cases for edges and conics, and make sure it all works. R=reed@google.com BUG=skia:4669,4265 Review URL: https://codereview.chromium.org/1517883002
* Revert of Add config options to run different GPU APIs to dm and nanobench ↵Gravatar reed2015-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #12 id:220001 of https://codereview.chromium.org/1490113005/ ) Reason for revert: speculative revert to see if it unblocks the DEPS roll https://codereview.chromium.org/1529443002 Original issue's description: > Add config options to run different GPU APIs to dm and nanobench > > Add extended config specification form that can be used to run different > gpu backend with different APIs. > > The configs can be specified with the form: > gpu(api=string,dit=bool,nvpr=bool,samples=int) > > This replaces and removes the --gpuAPI flag. > > All existing configs should still work. > > Adds following documentation: > > out/Debug/dm --help config > > Flags: > --config: type: string default: 565 8888 gpu nonrendering > Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4 > nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg > xps or use extended form 'backend(option=value,...)'. > > Extended form: 'backend(option=value,...)' > > Possible backends and options: > > gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend > api type: string default: native. > Select graphics API to use with gpu backend. > Options: > native Use platform default OpenGL or OpenGL ES backend. > gl Use OpenGL. > gles Use OpenGL ES. > debug Use debug OpenGL. > null Use null OpenGL. > dit type: bool default: false. > Use device independent text. > nvpr type: bool default: false. > Use NV_path_rendering OpenGL and OpenGL ES extension. > samples type: int default: 0. > Use multisampling with N samples. > > Predefined configs: > > gpu = gpu() > msaa4 = gpu(samples=4) > msaa16 = gpu(samples=16) > nvprmsaa4 = gpu(nvpr=true,samples=4) > nvprmsaa16 = gpu(nvpr=true,samples=16) > gpudft = gpu(dit=true) > gpudebug = gpu(api=debug) > gpunull = gpu(api=null) > debug = gpu(api=debug) > nullgpu = gpu(api=null) > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/e13ca329fca4c28cf4e078561f591ab27b743d23 TBR=bsalomon@google.com,scroggo@google.com,joshualitt@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Review URL: https://codereview.chromium.org/1528473002
* Add config options to run different GPU APIs to dm and nanobenchGravatar kkinnunen2015-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add extended config specification form that can be used to run different gpu backend with different APIs. The configs can be specified with the form: gpu(api=string,dit=bool,nvpr=bool,samples=int) This replaces and removes the --gpuAPI flag. All existing configs should still work. Adds following documentation: out/Debug/dm --help config Flags: --config: type: string default: 565 8888 gpu nonrendering Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4 nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg xps or use extended form 'backend(option=value,...)'. Extended form: 'backend(option=value,...)' Possible backends and options: gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend api type: string default: native. Select graphics API to use with gpu backend. Options: native Use platform default OpenGL or OpenGL ES backend. gl Use OpenGL. gles Use OpenGL ES. debug Use debug OpenGL. null Use null OpenGL. dit type: bool default: false. Use device independent text. nvpr type: bool default: false. Use NV_path_rendering OpenGL and OpenGL ES extension. samples type: int default: 0. Use multisampling with N samples. Predefined configs: gpu = gpu() msaa4 = gpu(samples=4) msaa16 = gpu(samples=16) nvprmsaa4 = gpu(nvpr=true,samples=4) nvprmsaa16 = gpu(nvpr=true,samples=16) gpudft = gpu(dit=true) gpudebug = gpu(api=debug) gpunull = gpu(api=null) debug = gpu(api=debug) nullgpu = gpu(api=null) BUG=skia:2992 Review URL: https://codereview.chromium.org/1490113005
* Try to fix intermittent GrAutoLocaleSetter crashes on WindowsGravatar kkinnunen2015-12-13
| | | | | | | | | | | | Try to fix intermittent GrAutoLocaleSetter crashes on Windows. The string returned by setlocale() is only valid up to next setlocale(), so it can not be fed to setlocale(). Also, libraries such as ANGLE might call setlocale when inside a callstack containing GrAutoLocaleSetter. This would render the old locale pointer invalid. Review URL: https://codereview.chromium.org/1514083002
* In SkPixmap.cpp, change SkAlphaMul to SkMulDiv255.Gravatar benjaminwagner2015-12-11
| | | | | | | | | | Add a test that we get the same color back after calling SkBitmap::eraseColor, modulo rounding. Also update some incorrect docs. BUG=skia:4297 Review URL: https://codereview.chromium.org/1521673002
* archive skpx... currently dead codeGravatar mtklein2015-12-11
| | | | | | | BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1521623003
* A change to cleanup some organization around df textGravatar joshualitt2015-12-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1519083002
* Change computeOutputColorType() to mimic old behaviorGravatar msarett2015-12-11
| | | | | | | | | | | | | | | This will prevent behavior changes in BitmapFactory when switching from SkImageDecoder to SkAndroidCodec. We will only choose kGray8 if it is explicitly requested (and also supported). Additionally, we will always decode GIFS and WBMPS to kIndex8. BUG=skia: Review URL: https://codereview.chromium.org/1519843002
* Fix a crash in SkParsePath::FromSVGStringGravatar scroggo2015-12-11
| | | | | | BUG=skia:3491 Review URL: https://codereview.chromium.org/1515193002
* Make BitmapRegionDecoder succeed on invalid requestsGravatar msarett2015-12-11
| | | | | | | | | | If the client requests a color type or alpha type that is not supported, we should decode to the default/appropriate color and alpha types to match existing behavior in Android. BUG=skia: Review URL: https://codereview.chromium.org/1513023002
* Move all text stuff to its own folderGravatar joshualitt2015-12-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1521453002
* make internaldrawBmpText part of GrTextUtilsGravatar joshualitt2015-12-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1518883002
* Add check for highp support in Conic effectGravatar robertphillips2015-12-11
| | | | | | | | | | | | | | | | | | | | | This CL may not really be necessary since it seems that the Android Ones we have fall back to mediump when highp isn't supported. FYI, for bits-of-precision/precision we have: Low Med High Precision-Used A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad N5 (Adreno 330) 10 10 23 High - conic looks bad!!! N6 (Adreno 420) 10 10 23 High - conic looks good N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!! N9 (K1) 23 23 23 High - looks good N10 (Mail-604) 10 10 23 High - looks good I suspect derivative computation is broken on the Adreno 300s. BUG=555779,skia:4668 TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1513573009
* Initialize glGen* call id args to zeroGravatar kkinnunen2015-12-11
| | | | | | | | | | | | Initialize glGenTexture, glGenBuffer call id buffer items to zero before calls. Otherwise it's not easy to check if the call succeeded or not. Assert the rule in debug gl context. Make TesselatingPathRendererTests use debug gl context. It exercises some of the GenBuffers call sites. Review URL: https://codereview.chromium.org/1514033002
* Fix UB function problems for AA merger.Gravatar herb2015-12-10
| | | | | | BUG=skia:4634 Review URL: https://codereview.chromium.org/1518863002
* Change SkTaskGroup to use std::function. Ripple all the changes.Gravatar herb2015-12-10
| | | | | | BUG=skia:4634 Review URL: https://codereview.chromium.org/1519573003
* Use size_t for strlen() return valueGravatar scroggo2015-12-10
| | | | | | BUG=skia:2810 Review URL: https://codereview.chromium.org/1518843002
* try adding flag to allow lcd text even in a layerGravatar reed2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1513513002
* Address precision issue in circle blur effectGravatar robertphillips2015-12-10
| | | | | | BUG=560651 Review URL: https://codereview.chromium.org/1504333003
* Create GrTextUtilsGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1514933002
* Add reallyHasAlpha() to SkAndroidCodecGravatar msarett2015-12-10
| | | | | | | | | This also modified the default implementation of onReallyHasAlpha() in SkCodec. BUG=skia: Review URL: https://codereview.chromium.org/1518743002
* default SkPixelSerializerGravatar halcanary2015-12-10
| | | | | | | | | | | | | | | Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function. Add SkImageEncoder::CreatePixelSerializer() to return a PixelSerializer that calls into SkImageEncoder::EncodeData. SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer. Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce Review URL: https://codereview.chromium.org/1507123002
* Move flush logic into GrAtlasTextBlobGravatar joshualitt2015-12-10
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1518763002
* Switch SkAutoMalloc to SkAutoTMalloc to avoid castGravatar scroggo2015-12-10
| | | | | | | | | | | | Make SkAutoTMalloc's interface look more like SkAutoMalloc: - add free(), which does what you expect - make reset() return a pointer fPtr No public API changes (SkAutoTMalloc is in include/private) BUG=skia:2148 Review URL: https://codereview.chromium.org/1516833003
* Move DistanceAdjustTable to its own fileGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1512823004
* Add Apple renderer strings to PowerVR detectionGravatar jvanverth2015-12-10
| | | | | | BUG=skia:4148 Review URL: https://codereview.chromium.org/1512903005
* SkDocument::setDCTEncoder() for old versions of webkitGravatar halcanary2015-12-10
| | | | Review URL: https://codereview.chromium.org/1505763003
* Move appending of large glyphs into GrAtlasTextBlobGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1517563002
* Silence another PNG print statementGravatar scroggo2015-12-10
| | | | | | | It can still be turned on by using setting c_suppressPNGImageDecoderWarnings to true. Review URL: https://codereview.chromium.org/1512293003
* Move 'mustRegenerate' function into GrAtlasTextBlobGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1515543003
* another null src, memcpy -> sk_careful_memcpyGravatar mtklein2015-12-10
| | | | | | | | https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3798/steps/dm/logs/stdio BUG=skia: Review URL: https://codereview.chromium.org/1510903005
* Remove uniform color for GrDistanceFieldGeoProcGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1512533003
* Make NVPR a GL context option instead of a GL contextGravatar kkinnunen2015-12-10
| | | | | | | | | | | | | | | | | Make NVPR a GL context option instead of a GL context. This may enable NVPR to be run with command buffer interface. No functionality change in DM or nanobench. NVPR can only be run with normal GL APIs. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/eeebdb538d476c1bfc8b63a946094ca1b505ecd1 Committed: https://skia.googlesource.com/skia/+/64492c43c3faee7ab0f69b1c84e0267616f85e52 Review URL: https://codereview.chromium.org/1448883002
* Use a pseudo-extension CHROMIUM_framebuffer_mixed_samplesGravatar kkinnunen2015-12-10
| | | | | | | | | | | Use the pseudo-extension CHROMIUM_framebuffer_mixed_samples when run with Chromium command buffer. The extension exposes NV_framebuffer_mixed_samples subset that Skia needs in order to use NV_path_rendering with mixed samples. BUG=506765 Review URL: https://codereview.chromium.org/1507373004
* Populate NVPR functions when run with command bufferGravatar kkinnunen2015-12-09
| | | | | | | | | | Populate the NV_path_rendering functions provided by CHROMIUM_path_rendering when the tools are being run with command buffer API. BUG=skia:2992 Review URL: https://codereview.chromium.org/1510163003
* Do elliptical clips in normalized space on devices with a "real" mediumpGravatar bsalomon2015-12-09
| | | | | | BUG=chromium:477684 Review URL: https://codereview.chromium.org/1517573002
* Make "alpha only" be a property of GrTextureProducerGravatar bsalomon2015-12-09
| | | | Review URL: https://codereview.chromium.org/1507973005
* Use BRGA as internal format on later iOSGravatar jvanverth2015-12-09
| | | | | | BUG=skia:2733 Review URL: https://codereview.chromium.org/1504333007
* add support for capped hairlinesGravatar caryclark2015-12-09
| | | | | | | | | Extend the ends of hairline and haircurve segments when the paint is set to square or round, and the line or curve is at the start or end of a contour. R=reed@google.com BUG=skia:4599 Review URL: https://codereview.chromium.org/1491843006
* Silence libjpeg warnings in SkImageDecoderGravatar scroggo2015-12-09
| | | | | | | | | | | | We just did the same for libpng (see crrev.com/1512043002), so we might as well do this here. SkImageDecoder is deprecated, and SkCodec already has a way to turn off its messages. BUG=skia:1649 Review URL: https://codereview.chromium.org/1505953007
* Another undefined shift caught by -fsanitize=shift.Gravatar mtklein2015-12-09
| | | | | | | | | | left was -16 I didn't see any warning about fTop, but seems simplest to fix that too. BUG=skia: Review URL: https://codereview.chromium.org/1505993007
* Another memcpy -> sk_careful_memcpyGravatar mtklein2015-12-09
| | | | | | | | | | | https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3787/steps/dm/logs/stdio dst is null. TBR=herb@google.com BUG=skia: Review URL: https://codereview.chromium.org/1507113007
* Fix compile error with GOOGLE3 define.Gravatar benjaminwagner2015-12-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1509023004
* Rewrite drawBitmap/ImageNine on top of GrTextureProducerGravatar bsalomon2015-12-09
| | | | Review URL: https://codereview.chromium.org/1504723004