aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/utils
Commit message (Collapse)AuthorAge
* remove unused SkFixed and SkFract functionsGravatar reed@google.com2013-12-19
| | | | | | | | | BUG= R=caryclark@google.com Review URL: https://codereview.chromium.org/113873008 git-svn-id: http://skia.googlecode.com/svn/trunk@12767 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add cast to fix Win* compile complaint/failureGravatar commit-bot@chromium.org2013-12-19
| | | | | | | | | | | R=tomhudson@google.com, reed@google.com TBR=tomhudson@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/100313005 git-svn-id: http://skia.googlecode.com/svn/trunk@12764 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add cast to fix Win* compile complaint/failureGravatar robertphillips@google.com2013-12-18
| | | | | | | | https://codereview.chromium.org/100313005/ git-svn-id: http://skia.googlecode.com/svn/trunk@12750 2bbb7eff-a529-9590-31e7-b0007b416f81
* Expose more SkPaint fields in Lua API.Gravatar commit-bot@chromium.org2013-12-18
| | | | | | | | | | | | Adds getters (but not setters) for most SkPaint fields. R=reed@google.com, robertphillips@google.com, tomhudson@google.com Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/105143009 git-svn-id: http://skia.googlecode.com/svn/trunk@12746 2bbb7eff-a529-9590-31e7-b0007b416f81
* replace SkScalarMulRound(a,b) with SkScalarRountToInt(a*b)Gravatar reed@google.com2013-12-18
| | | | | | | | | BUG= R=sugoi@google.com Review URL: https://codereview.chromium.org/111393010 git-svn-id: http://skia.googlecode.com/svn/trunk@12740 2bbb7eff-a529-9590-31e7-b0007b416f81
* deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. ↵Gravatar reed@google.com2013-12-17
| | | | | | | | | | | #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/111353003 git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floatsGravatar reed@google.com2013-12-17
| | | | | | | | | | | | | To keep the CL (slightly) managable, this does not make any changes to existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this time around. BUG= R=bsalomon@google.com, caryclark@google.com Review URL: https://codereview.chromium.org/117053002 git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81
* Prevent crash in Lua bindings.Gravatar commit-bot@chromium.org2013-12-17
| | | | | | | | | | | | | | SkPaint::getTypeface() can return NULL; paint:getTypeface() would attempt to refcount that value before storing it on the Lua stack and crash. This is a minimal workaround that fixes the crash. R=reed@google.com, tomhudson@google.com, robertphillips@google.com Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/109793010 git-svn-id: http://skia.googlecode.com/svn/trunk@12706 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement SkAshmemDiscardableMemoryGravatar halcanary@google.com2013-12-10
| | | | | | | | | | | | | | | | | | | | | | | | | | - Implement ashmem-backed SkDiscardableMemory subclass: This class in only accesible via the SkDiscardableMemory::Create() function, which replaces the mock implementation in SkDiscardableMemory_none.cpp - Added SkDiscardableMemory_ashmem.cpp to the Android port of Skia Removed SkDiscardableMemory_none.cpp from the Android port. - Added DiscardableMemoryTest. Still needs work. - SkDiscardablePixelRef Bugfix: onLockPixels() now calls SkDELETE on the SkDiscardableMemory pointer when it fails to unlock. - Improved documentation inside ashmem.h BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/83563002 git-svn-id: http://skia.googlecode.com/svn/trunk@12608 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix compilation with SK_ENABLE_INST_COUNT=1Gravatar commit-bot@chromium.org2013-12-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add INHERITED declarations to class declarations that prevent compilation with the flag. Remove SK_DEFINE_INST_COUNT from all class implementations. Instead, use function-local static variables in the reference count helper classes to create the global instances to store the needed info. The accessor functions are defined inline in the helper classes, so definitions are not needed. The initialization point of the variables should be as well defined as previously. Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT instead. This avoids possible future compilation errors further. For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member function to all classes that use SK_DECLARE_INST_COUNT and SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes contain public INHERITED typedef. This member function seems to be compiled away. This shouĺd ensure that part of the compilation errors are caught earlier. Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses. R=robertphillips@google.com, richardlin@chromium.org, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/98703002 git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix incremental visibility filter handling.Gravatar commit-bot@chromium.org2013-12-04
| | | | | | | | | | | | | | | When drawing incrementally, SkDebugCanvas can end up applying the visibility overlay multiple times (resulting in a fade-to-white effect). The CL also includes a minor/unrelated SkDebugCanvas cleanup. R=robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/103083004 git-svn-id: http://skia.googlecode.com/svn/trunk@12478 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use lowercase windows.h in includes to fix Windows cross compilation using ↵Gravatar bungeman@google.com2013-12-03
| | | | | | | | | | | | mingw. While it doesn't matter on Windows, mingw on case-sensitive OSes uses all lower case filenames for platform include files. I found the problem in SkCondVar.h from Mozilla checkout of skia sources, but the patch contains a fix for the whole skia tree. R=bungeman@google.com Review URL: https://codereview.chromium.org/99173003 git-svn-id: http://skia.googlecode.com/svn/trunk@12461 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix 'i-i' to 'i-1' in SkCanvasStack.Gravatar bungeman@google.com2013-12-02
| | | | | | | | | | Pointed out in http://www.viva64.com/en/b/0225/ . R=djsollen@google.com Review URL: https://codereview.chromium.org/99753002 git-svn-id: http://skia.googlecode.com/svn/trunk@12439 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r12427Gravatar rmistry@google.com2013-12-02
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12428 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-02
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12427 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "remove kA1_Config, as it is no longer supported""Gravatar commit-bot@chromium.org2013-11-26
| | | | | | | | | | | | | This reverts commit 36d712f2d4c5c79719280ad95523e6aaa88b068e. BUG= R=rmistry@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/86483002 git-svn-id: http://skia.googlecode.com/svn/trunk@12392 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "remove kA1_Config, as it is no longer supported"Gravatar reed@google.com2013-11-25
| | | | | | This reverts commit 2d72d8b242eac6e9d30228f5b0a407236491c369. git-svn-id: http://skia.googlecode.com/svn/trunk@12387 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove SkFloatToScalar macroGravatar commit-bot@chromium.org2013-11-25
| | | | | | | | | | | BUG= R=reed@google.com, djsollen@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/85463005 git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove kA1_Config, as it is no longer supportedGravatar reed@google.com2013-11-25
| | | | | | | | | BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/83093005 git-svn-id: http://skia.googlecode.com/svn/trunk@12384 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-11-22
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12358 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SkScalar conversion warning.Gravatar fmalita@google.com2013-11-21
| | | | | | | | TBR=scroggo@google.com Review URL: https://codereview.chromium.org/81293002 git-svn-id: http://skia.googlecode.com/svn/trunk@12348 2bbb7eff-a529-9590-31e7-b0007b416f81
* Show basic SkPicture details in debugger.Gravatar commit-bot@chromium.org2013-11-21
| | | | | | | | | | R=robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/80223003 git-svn-id: http://skia.googlecode.com/svn/trunk@12345 2bbb7eff-a529-9590-31e7-b0007b416f81
* More Windows 64b compilation warning fixesGravatar robertphillips@google.com2013-11-21
| | | | | | | | https://codereview.chromium.org/47513017/ git-svn-id: http://skia.googlecode.com/svn/trunk@12337 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SkMatrix44::invert(...) for identity matrices and a NULL parameterGravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | | | | | | | Currently, to check if an SkMatrix44 is singular, we call ::invert(NULL) and check the result. Usually this does no more work than is necessary. One case where we do far too much work is if |this| is an identity matrix. In this case, we do not early out and compute a (partial) determinant (we don't do the full shebang because there are no perspective components). BUG=None R=ajuma@chromium.org, reed@google.com Author: vollick@chromium.org Review URL: https://codereview.chromium.org/79333002 git-svn-id: http://skia.googlecode.com/svn/trunk@12327 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r12315 (More Windows 64b compilation warning fixes) due to ↵Gravatar robertphillips@google.com2013-11-20
| | | | | | compilation failures git-svn-id: http://skia.googlecode.com/svn/trunk@12316 2bbb7eff-a529-9590-31e7-b0007b416f81
* More Windows 64b compilation warning fixesGravatar robertphillips@google.com2013-11-20
| | | | | | | | https://codereview.chromium.org/47513017/ git-svn-id: http://skia.googlecode.com/svn/trunk@12315 2bbb7eff-a529-9590-31e7-b0007b416f81
* Guard against most unintentionally ephemeral SkAutoFoo instantiations.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | | | | | | | | | | I think I applied the trick everywhere possible. Limitations: - can't be used with templated classes - all constructors and destructors must be defined inline A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I deleted them. This change caught the same bugs Cary found in SkPath, plus one more in SampleApp. BUG= R=reed@google.com, caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/72603005 git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add missing functions to SkNWayCanvasGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | R=reed@google.com BUG=none Author: enne@chromium.org Review URL: https://codereview.chromium.org/65513003 git-svn-id: http://skia.googlecode.com/svn/trunk@12295 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "switch GatherPixelRefs to use SkBaseDevice instead of ↵Gravatar reed@google.com2013-11-13
| | | | | | | | | | | | SkBitmapDevice"" This reverts commit ff0152ec5e2a0faf38ae1a317c5d77df08139104. BUG= Review URL: https://codereview.chromium.org/68203018 git-svn-id: http://skia.googlecode.com/svn/trunk@12271 2bbb7eff-a529-9590-31e7-b0007b416f81
* drawPosTextOnPath is now deprecated, removing all overrides and implsGravatar reed@google.com2013-11-13
| | | | | | | | | BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/61743017 git-svn-id: http://skia.googlecode.com/svn/trunk@12270 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice"Gravatar reed@google.com2013-11-12
| | | | | | | | | | This reverts commit 72958c374bdb9457419beeba7de1387da3293882. BUG= Review URL: https://codereview.chromium.org/58933007 git-svn-id: http://skia.googlecode.com/svn/trunk@12260 2bbb7eff-a529-9590-31e7-b0007b416f81
* switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDeviceGravatar reed@google.com2013-11-12
| | | | | | | | | BUG= R=robertphillips@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/70473003 git-svn-id: http://skia.googlecode.com/svn/trunk@12259 2bbb7eff-a529-9590-31e7-b0007b416f81
* Hide implementation details: SkFrontBufferedStreamGravatar scroggo@google.com2013-11-12
| | | | | | | | R=reed@google.com Review URL: https://codereview.chromium.org/25581002 git-svn-id: http://skia.googlecode.com/svn/trunk@12256 2bbb7eff-a529-9590-31e7-b0007b416f81
* pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we ↵Gravatar commit-bot@chromium.org2013-11-12
| | | | | | | | | | | | compile pdfviewer, even if it is not used) R=scroggo@google.com, jvanverth@google.com Author: edisonn@google.com Review URL: https://codereview.chromium.org/68533003 git-svn-id: http://skia.googlecode.com/svn/trunk@12249 2bbb7eff-a529-9590-31e7-b0007b416f81
* Override drawRRect in fake SkBitmapDevices.Gravatar scroggo@google.com2013-11-12
| | | | | | | | | | | | | | Recent changes to SkBitmapDevice modified ::drawRRect() to take an optimized drawing case. Some subclasses of SkBitmapDevice were depending on the old behavior of calling ::drawPath(). Since they do not draw, attempting to take the drawing path can cause problems. For these subclasses, call drawPath() in the subclass. R=reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/70443002 git-svn-id: http://skia.googlecode.com/svn/trunk@12247 2bbb7eff-a529-9590-31e7-b0007b416f81
* Initial draft code to run pdfviewer withg gmsGravatar commit-bot@chromium.org2013-11-11
| | | | | | | | | | | | draft cl to run pdfviewer with gms modified: gm/gmmain.cpp modified: gyp/gm.gyp modified: src/utils/SkPDFRasterizer.cpp modified: src/utils/SkPDFRasterizer.h R=scroggo@google.com, borenet@google.com Author: edisonn@google.com Review URL: https://codereview.chromium.org/26269002 git-svn-id: http://skia.googlecode.com/svn/trunk@12214 2bbb7eff-a529-9590-31e7-b0007b416f81
* Removed deprecated API calls that have crept inGravatar robertphillips@google.com2013-11-10
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12210 2bbb7eff-a529-9590-31e7-b0007b416f81
* "Fix" bug in debug canvasGravatar robertphillips@google.com2013-11-07
| | | | | | | | https://codereview.chromium.org/59073008/ git-svn-id: http://skia.googlecode.com/svn/trunk@12180 2bbb7eff-a529-9590-31e7-b0007b416f81
* New SkRTConf macro SK_CONF_TRY_SET: no complaint on missing configurationGravatar halcanary@google.com2013-11-06
| | | | | | | | | | | | | | | | | | | | | | | | | | SK_CONF_TRY_SET() is like SK_CONF_SET(), but doesn't complain if confname can't be found. This is useful if the SK_CONF_DECLARE is inside a source file whose linkage is dependent on the system. Internally to the SkRTConf system, SkRTConfRegistry::set() was given an additional parameter controling wanrings. A new RuntimeConfig unit test was introduced. It should run silently. In the future, it should be expanded to cover all of the SkRTConf functionality. (For example, the images.jpeg.suppressDecoderWarnings variable is defined and used only in SkImageDecoder_libjpeg.cpp, but on MacOS, we use Core Graphics via SkImageDecoder_CG.cpp - SkImageDecoder_libjpeg is never linked in. The same is true of the Windows Imaging Component on Windows.) BUG= R=reed@google.com Review URL: https://codereview.chromium.org/54503007 git-svn-id: http://skia.googlecode.com/svn/trunk@12155 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix a bug which caused crash in SkRTConfig whith string values in ↵Gravatar halcanary@google.com2013-11-06
| | | | | | | | | | | | | environment variables A minor change to SkRTConfRegistry::parse() fixes this BUG=skia:1717 R=scroggo@google.com Review URL: https://codereview.chromium.org/26373008 git-svn-id: http://skia.googlecode.com/svn/trunk@12152 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, ↵Gravatar reed@google.com2013-10-31
| | | | | | | | | | | | since it triggers a warning"" This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d. BUG= Review URL: https://codereview.chromium.org/54603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it ↵Gravatar reed@google.com2013-10-31
| | | | | | | | triggers a warning" This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497. git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers ↵Gravatar reed@google.com2013-10-31
| | | | | | | | | | | a warning BUG= R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/51033004 git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove SkMatrix44 float conversions without precision lossGravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | BUG=none R=reed@google.com Author: enne@chromium.org Review URL: https://codereview.chromium.org/50423004 git-svn-id: http://skia.googlecode.com/svn/trunk@12009 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix narrowing conversion errors from r11986Gravatar commit-bot@chromium.org2013-10-28
| | | | | | | | | | | | | | Although this function only gets used for SkMScalar=float, it gets compiled in when SkMScalar=double. R=epoger@google.com BUG=1764 Author: enne@chromium.org Review URL: https://codereview.chromium.org/49463005 git-svn-id: http://skia.googlecode.com/svn/trunk@11991 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove float/double conversions from SkMatrix44's map2_pfGravatar commit-bot@chromium.org2013-10-28
| | | | | | | | | | | BUG=chromium:303811 R=reed@google.com Author: enne@chromium.org Review URL: https://codereview.chromium.org/37693004 git-svn-id: http://skia.googlecode.com/svn/trunk@11986 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "If the path is a rect, call drawRect to raster the geometry in ↵Gravatar bsalomon@google.com2013-10-22
| | | | | | | | | | SkCanvas::drawPath to get better performance." This reverts commit r11904 Review URL: https://codereview.chromium.org/35543002 git-svn-id: http://skia.googlecode.com/svn/trunk@11909 2bbb7eff-a529-9590-31e7-b0007b416f81
* If the path is a rect, call drawRect to raster the geometry in ↵Gravatar bsalomon@google.com2013-10-22
| | | | | | | | | | | | SkCanvas::drawPath to get better performance. Committed: http://code.google.com/p/skia/source/detail?r=11842 R=bsalomon@google.com Review URL: https://codereview.chromium.org/23484007 git-svn-id: http://skia.googlecode.com/svn/trunk@11904 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkThreadPool: allow for Runnables that add other Runnables to the pool.Gravatar commit-bot@chromium.org2013-10-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's a scenario that we're currently not allowing for, but I'd really like to use in DM: 1) client calls add(SomeRunnable*) several times 2) client calls wait() 3) any of the runnables added by the client _themselves_ call add(SomeOtherRunnable*) 4-inf) maybe those SomeOtherRunnables too call add(SomeCrazyThirdRunnable*), etc. Right now in this scenario we'll assert in debug mode in step 3) when we call add() and we're waiting to stop, and do strange unspecified things in release mode. The old threadpool had basically two states: running, and waiting to stop. If a thread saw we were waiting to stop and the queue was empty, that thread shut down. This wasn't accounting for any work that other threads might be doing; potentially they were about to add to the queue. So now we have three states: running, waiting, and halting. When the client calls wait() (or the destructor triggers), we move into waiting. When a thread notices we're _really_ done, that is, have an empty queue and there are no active threads, we move into halting. The halting state actually triggers the threads to stop, which wait() is patiently join()ing on. BUG= R=bungeman@google.com, bsalomon@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/26389005 git-svn-id: http://skia.googlecode.com/svn/trunk@11852 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-18
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11850 2bbb7eff-a529-9590-31e7-b0007b416f81