| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
|
|
|
|
| |
This is an obviously const method, no reason not to mark it as such.
R=robertphillips@google.com, fmalita@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19289003
git-svn-id: http://skia.googlecode.com/svn/trunk@10094 2bbb7eff-a529-9590-31e7-b0007b416f81
|
| |
|
|
|
|
|
|
|
|
| |
Test one SaveFlags bit at a time instead of exploring the whole value space.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/18034028
git-svn-id: http://skia.googlecode.com/svn/trunk@10014 2bbb7eff-a529-9590-31e7-b0007b416f81
|
| |
|
|
|
|
| |
Review URL: https://codereview.chromium.org/17857003
git-svn-id: http://skia.googlecode.com/svn/trunk@9766 2bbb7eff-a529-9590-31e7-b0007b416f81
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
No only this is unused, but it's pulling in a static initializer (which makes SkDebugCanvas unusable in Chromium).
BUG=
R=robertphillips@google.com, bungeman@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17553006
git-svn-id: http://skia.googlecode.com/svn/trunk@9723 2bbb7eff-a529-9590-31e7-b0007b416f81
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkDrawCommand subclass names are too generic and likely to clash in the default namespace.
This makes the header unusable in Chrome - for example, on Mac builders:
../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment'
class Comment : public SkDrawCommand {
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here
struct Comment {
This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command".
R=robertphillips@google.com, bungeman@google.com, djsollen@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17101005
git-svn-id: http://skia.googlecode.com/svn/trunk@9667 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
SkDebugCanvas & friends are useful beyond the Qt debugger app - Chromium's picture inspector (in development) is at the point where it could take advantage of it.
This patch moves SkDrawCommand, SkDebugCanvas & SkObjectParser from trunk/debugger to trunk/src/utils (since several tools already use these, this seems appropriate), and makes SkDrawCommand & SkDebugCanvas' symbols visible externally (SK_API).
R=reed@google.com
Review URL: https://codereview.chromium.org/16638014
git-svn-id: http://skia.googlecode.com/svn/trunk@9598 2bbb7eff-a529-9590-31e7-b0007b416f81
|
commit-bot@chromium.org
fmalita@google.com
edisonn@google.com