aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/sksl
Commit message (Collapse)AuthorAge
* sksl: Add a "sk_Clockwise" built-inGravatar Chris Dalton2018-07-27
| | | | | | | | | | | This allows us to identify clockwise-winding triangles, in terms of Skia device space, in all backends and with all render target origins. Bug: skia: Change-Id: I220e1c459e0129d1cc4dee6458ef94277fbedd21 Reviewed-on: https://skia-review.googlesource.com/142662 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Fixed GLSL header line orderingGravatar Ethan Nicholas2018-07-27
| | | | | | | | | | | Under some circumstances, an extension could be written after a global variable. This should fix the ordering so that can never happen again. Bug: b/111582212 Change-Id: Id2f7645253fdc521ba85ca0e6863236baef63a4b Reviewed-on: https://skia-review.googlesource.com/143102 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* fixed geometry shaders when canUseFragCoord is falseGravatar Ethan Nicholas2018-07-24
| | | | | | | | Bug: chromium:859705 Change-Id: Ia5c5b15bd5d12bf2d1c3265664bec2c3eaef24d2 Reviewed-on: https://skia-review.googlesource.com/143114 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Revert "removed SkSLLayoutLexer""Gravatar Ethan Nicholas2018-07-24
| | | | | | | | | | This reverts commit 734b2a859784af0b16dbbe07570e6d2f5da34e76. Bug: skia: Change-Id: I1b8f49ab9d2ec1976f82f4feb70a8d0c5015b654 Reviewed-on: https://skia-review.googlesource.com/143109 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "removed SkSLLayoutLexer"Gravatar Ethan Nicholas2018-07-24
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 804f81786148cd3a4385d10ab7a31340fa47b10d. Reason for revert: breaking chrome roll: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940111858576531488/+/steps/compile__with_patch_/0/stdout Original change's description: > removed SkSLLayoutLexer > > Bug: skia: > Change-Id: Iad4c89fbde8bc1f6c3d022af9aec2ec5faa8a4ef > Reviewed-on: https://skia-review.googlesource.com/142583 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> TBR=mtklein@google.com,ethannicholas@google.com Change-Id: Ie07065ac43c5b8356665a7170adbe97ae8fd9f90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/143120 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* removed SkSLLayoutLexerGravatar Ethan Nicholas2018-07-24
| | | | | | | | Bug: skia: Change-Id: Iad4c89fbde8bc1f6c3d022af9aec2ec5faa8a4ef Reviewed-on: https://skia-review.googlesource.com/142583 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* added integration for non-moltenvk use of SkSLC MSL generatorGravatar Timothy Liang2018-07-23
| | | | | | | | Bug: skia: Change-Id: I4aa230fa25fccde0345b84384d9f7b1bb3045a73 Reviewed-on: https://skia-review.googlesource.com/142686 Commit-Queue: Timothy Liang <timliang@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* fixed a bug with SPIR-V ternariesGravatar Ethan Nicholas2018-07-23
| | | | | | | | | | | | | | When both the true and false values are constants, we use OpSelect to choose between them instead of branching. However, it turns out that this fails when the values are vectors, because then OpSelect does componentwise selection and expects the input condition to be a vector as well. Bug: skia: Change-Id: Ia30aadc590ac1d1760c7df933595c2c867c472cd Reviewed-on: https://skia-review.googlesource.com/142885 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* added byte type support to SkSLC MSL generatorGravatar Timothy Liang2018-07-20
| | | | | | | | | | Also cleaned up converting half to float Bug: skia: Change-Id: I4fbb01b887b40f9e6b8cf5cdd7e03e056b29db07 Reviewed-on: https://skia-review.googlesource.com/142582 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* Move fragCoord workaround declarationGravatar Brian Osman2018-07-20
| | | | | | | | | | | | | | This ensures that all extension directives occur before any non-preprocessor tokens, as required by the spec (§ 3.4). This was found by Qualcomm, and originally submitted as https://github.com/google/skia/pull/21 Bug: b/111525079 Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8 Reviewed-on: https://skia-review.googlesource.com/142697 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "Revert "added GrSkSLFP and converted DitherEffect to use it""Gravatar Ethan Nicholas2018-07-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 97ae0c89025dfd791047f5701e57d58da37c125c. Reason for revert: Breaking ANGLE. Original change's description: > Revert "Revert "added GrSkSLFP and converted DitherEffect to use it"" > > This reverts commit f2030783094e502fb74221077a5ee7cb41287fe4. > > Bug: skia: > Change-Id: Icaaa8b3ea652a8f126bfbcc788a360493a7ebe3e > Reviewed-on: https://skia-review.googlesource.com/137391 > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,robertphillips@google.com,ethannicholas@google.com Change-Id: I65d6d2707fceab0a99121c528d1b848d23e34bfa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/142588 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "Revert "added GrSkSLFP and converted DitherEffect to use it""Gravatar Ethan Nicholas2018-07-19
| | | | | | | | | | This reverts commit f2030783094e502fb74221077a5ee7cb41287fe4. Bug: skia: Change-Id: Icaaa8b3ea652a8f126bfbcc788a360493a7ebe3e Reviewed-on: https://skia-review.googlesource.com/137391 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* fixed SPIR-V memory layoutGravatar Ethan Nicholas2018-07-17
| | | | | | | | Bug: skia: Change-Id: Ib503e24e4cfcb3e064a9e34a4d9ca3230c989372 Reviewed-on: https://skia-review.googlesource.com/141838 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* added byte and ubyte types to SKSLGravatar Ruiqi Mao2018-07-17
| | | | | | | | | | | created new GMs for skinning Bug: skia: Change-Id: I15fb2bd02fba8beb6dd2dd3f3716da016ea92192 Reviewed-on: https://skia-review.googlesource.com/140241 Commit-Queue: Ruiqi Mao <ruiqimao@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Fixed SPIR-V geometry shadersGravatar Ethan Nicholas2018-07-13
| | | | | | | | | | | sk_in count was being computed incorrectly, and the capabilities and interfaces were incorrect. Bug: skia:8143 Change-Id: If9ac7c152a3b04be3b81ead09270af6d053e006e Reviewed-on: https://skia-review.googlesource.com/141230 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* fixed SPIR-V matrix operationsGravatar Ethan Nicholas2018-07-13
| | | | | | | | Bug: skia: Change-Id: I23be824cdd7d00ffd0c54516a168c07e77bb4f49 Reviewed-on: https://skia-review.googlesource.com/140182 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Remove texel buffer support.Gravatar Brian Salomon2018-07-13
| | | | | | | Change-Id: Ia6f21afe714208979a5bc384e436b28ea2b9a297 Reviewed-on: https://skia-review.googlesource.com/141051 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* update and skip accepts check in lexersGravatar Mike Klein2018-06-29
| | | | | | | | | | | | We think we're getting away with this because our tokens never go from legal to illegal to legal again, right? Change-Id: Iaaef797f7c4b487ba7b1d0e018846bd13086b34c Reviewed-on: https://skia-review.googlesource.com/138275 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Revert "added GrSkSLFP and converted DitherEffect to use it"Gravatar Kevin Lubick2018-06-19
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit dfbfc738a9edfff7a9804253175e380c230f3d21. Reason for revert: Seems to be breaking DDL/ASAN bots Original change's description: > added GrSkSLFP and converted DitherEffect to use it > > Bug: skia: > Change-Id: I84b71165eab1712355f3c7669cee2d33d259f3df > Reviewed-on: https://skia-review.googlesource.com/124504 > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,ethannicholas@google.com Change-Id: Ic4c3978aaba0391f2f8bb1316a456e3821a3a2f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/135700 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* added GrSkSLFP and converted DitherEffect to use itGravatar Ethan Nicholas2018-06-18
| | | | | | | | Bug: skia: Change-Id: I84b71165eab1712355f3c7669cee2d33d259f3df Reviewed-on: https://skia-review.googlesource.com/124504 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* consolidated writing fields logic and added more builtins for skslc msl backendGravatar Timothy Liang2018-06-13
| | | | | | | | Bug: skia: Change-Id: I6cad948bc68194322f031926ab9a49186ec2302b Reviewed-on: https://skia-review.googlesource.com/134502 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* renamed SkSL's assert macrosGravatar Ethan Nicholas2018-06-12
| | | | | | | | | | | | | | Since SkSL needs to run outside of Skia, it was originally using its own ASSERT macro, which mapped to SkASSERT when inside of Skia. This is causing conflicts with one or two other ASSERT macros defined around Skia, so to avoid that I am switching SkSL over to just use Skia's standard naming for these macros. Bug: skia: Change-Id: I115435d7282da03d076c6080f7b13d1972b9eb9f Reviewed-on: https://skia-review.googlesource.com/134322 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* fixed vec3 size differences and mod calculation of skslc msl backendGravatar Timothy Liang2018-06-08
| | | | | | | | Bug: skia: Change-Id: I5dc6d956463845627a1a2debee5ac8856e5e2e8d Reviewed-on: https://skia-review.googlesource.com/132500 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* fixed interface/in/out struct for mvk integration and added a few missing ↵Gravatar Timothy Liang2018-06-05
| | | | | | | | | | builtins to skslc msl backend Bug: skia: Change-Id: Id514dc6af64bb2a5eb71f2161ceba549a8a6836d Reviewed-on: https://skia-review.googlesource.com/131881 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* added interface block, vector comparison intrinsics, and mvk integration for ↵Gravatar Timothy Liang2018-05-24
| | | | | | | | | | metal sksl backend Bug: skia: Change-Id: Ia6984ba73482ec377f0890eb79f6ff92ff736749 Reviewed-on: https://skia-review.googlesource.com/129654 Commit-Queue: Timothy Liang <timliang@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* added global variable and multi-texture support to metal sksl backendGravatar Timothy Liang2018-05-18
| | | | | | | | Bug: skia: Change-Id: If676774ec0a30c5b536ccffbff2220d180b7fa59 Reviewed-on: https://skia-review.googlesource.com/129187 Commit-Queue: Timothy Liang <timliang@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* added basic texturing to metal sksl backendGravatar Timothy Liang2018-05-17
| | | | | | | | Bug: skia: Change-Id: I2e70efe53f5c2fb208979cc89be9c3c841944a48 Reviewed-on: https://skia-review.googlesource.com/128844 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* fixed incorrect index in SPIR-V matrix constructionGravatar Ethan Nicholas2018-05-11
| | | | | | | | Bug: skia:7908 Change-Id: I990e5f6e84afdc81d340f433d93a9061b9dd67ef Reviewed-on: https://skia-review.googlesource.com/127397 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Make GrCaps and GrShaderCaps private.Gravatar Brian Salomon2018-05-11
| | | | | | | | | Moves getCaps() from GrContext to GrContextPriv and removes unused refCaps(). Change-Id: Ic6a8951b656c0d1b2773eae73bff8e88af819866 Reviewed-on: https://skia-review.googlesource.com/127389 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* fix for SPIR-V sk_in definition which was upsetting Intel NUCGravatar Ethan Nicholas2018-05-04
| | | | | | | | Bug: skia:7852 Change-Id: Ife747f3531d19e69dc70c2e0b9a9c6cfe001da72 Reviewed-on: https://skia-review.googlesource.com/125743 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* workaround for Intel OpCompositeConstruct bugGravatar Ethan Nicholas2018-04-27
| | | | | | | | | | | | | | | | The SPIR-V spec permits constructing a vector from mixed vectors and scalars, e.g. vec3(vec2, float). Intel's Vulkan driver does not handle this correctly. We already have a workaround in place for vector construction (writing the code as vec3(vec2.x, vec2.y, float) instead), but missed that matrix construction can produce the same problem, as each column requires a vector to be constructed for it. This CL extends the workaround to handle matrix construction as well. Bug: skia:7851 Change-Id: I0fe5d300ec7ad5db87bcc6662cf8371bcd6deed8 Reviewed-on: https://skia-review.googlesource.com/124321 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Don't 'require' external image extensions, 'enable' themGravatar Brian Osman2018-04-25
| | | | | | | | | | | We trigger this when we don't necessarily have support for both extensions, so requiring them can cause compilation failures. Bug: https://github.com/flutter/flutter/issues/16178 Change-Id: I54c190709a677bc9ec2fa46f612e8958e3de38cb Reviewed-on: https://skia-review.googlesource.com/123683 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* cache SkSL headersGravatar Ethan Nicholas2018-04-25
| | | | | | | | | | | This reduces the cost of successive shader compilations by caching the results of compiling SkSL's headers. Bug: skia: Change-Id: If7fc21a9877021c4025ad99dd0981523a25855e0 Reviewed-on: https://skia-review.googlesource.com/123422 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* With ES3, enable both ES2 and ES3 external image extensionsGravatar Brian Osman2018-04-18
| | | | | | | | Bug: skia:7713 Change-Id: If06c0368e91c33bbac9e7715227d619c4834684f Reviewed-on: https://skia-review.googlesource.com/121884 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Move external texture extension logic into SkSLGravatar Brian Osman2018-04-17
| | | | | | | | | | Automatically enable the extension if any external samplers are used. Bug: skia:7713 Change-Id: I1de2faddd7c8eda864873941b90d7a4c4606497a Reviewed-on: https://skia-review.googlesource.com/121797 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* fix sksl standalone build errorGravatar Ethan Nicholas2018-04-13
| | | | | | | | Bug: skia: Change-Id: I7de6d46a5774b5820bb6468a418be7c56da8510b Reviewed-on: https://skia-review.googlesource.com/121421 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* added sk_LastFragColorGravatar Ethan Nicholas2018-04-13
| | | | | | | | Bug: skia: Change-Id: If64d8281beb8b7687db629eef2e956974ee9a979 Reviewed-on: https://skia-review.googlesource.com/121343 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* workaround for buggy macOS GLSL shader compilerGravatar Ethan Nicholas2018-04-12
| | | | | | | | Bug: skia: Change-Id: Ib77e11d80f93f76e65eac6119dbf2bd03523aaf9 Reviewed-on: https://skia-review.googlesource.com/117626 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Make generated effects from sksl fp files not need SK_SUPPORT_GPUGravatar Greg Daniel2018-04-06
| | | | | | | | Bug: skia: Change-Id: I42a5c7fe7dc35a23290c8daa754c9fcce07f76fb Reviewed-on: https://skia-review.googlesource.com/119010 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT ↵Gravatar Brian Salomon2018-04-04
| | | | | | | | | | | | fb fetch is used."" This reverts commit d40133092ae138b3d47a1158101faec3c53c6b1f. Bug: skia: Change-Id: I236505da047d5ad29e4952d8955eb7aa1bfb870b Reviewed-on: https://skia-review.googlesource.com/118621 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb ↵Gravatar Brian Salomon2018-04-04
| | | | | | | | | | | | | | | | | | | | | | | | | | fetch is used." This reverts commit 7e1dd2017a59a748c6cb10160868780d2dffdbc0. Reason for revert: breaking fp compilation Original change's description: > Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used. > > Change-Id: I5e6e3263bb49febc757cd63d5d6c1518f174322d > Reviewed-on: https://skia-review.googlesource.com/118420 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: I2aedfaff93150ba8cd1ed9fed22f3cfdd509695a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/118600 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.Gravatar Brian Salomon2018-04-04
| | | | | | | Change-Id: I5e6e3263bb49febc757cd63d5d6c1518f174322d Reviewed-on: https://skia-review.googlesource.com/118420 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* fix for frexp dataflow analysisGravatar Ethan Nicholas2018-04-01
| | | | | | | | Bug: skia: Change-Id: Ic20bedadfbf37fd78ce03872ece2d9552307cfcd Reviewed-on: https://skia-review.googlesource.com/117243 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* fixed type mismatches in SkSL comparison operatorsGravatar Ethan Nicholas2018-03-29
| | | | | | | | Bug: skia: Change-Id: I8f05088c561a80549264f7a65cb8161bbe7d8f4c Reviewed-on: https://skia-review.googlesource.com/116982 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* initial SkSLJIT checkinGravatar Ethan Nicholas2018-03-27
| | | | | | | | | Docs-Preview: https://skia.org/?cl=112204 Bug: skia: Change-Id: I10042a0200db00bd8ff8078467c409b1cf191f50 Reviewed-on: https://skia-review.googlesource.com/112204 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* added frexp support to SkSLGravatar Ethan Nicholas2018-03-26
| | | | | | | | | | | | | | | | | This includes an optimizer fix for the situation: int i; float f = frexp(foo, i); If we don't read the variable i, it is considered dead and eliminated - which then causes an error when we try to write the expression frexmp(foo, i). Bug: skia: Change-Id: Iac385e38e215455346fab62e1f4ec46fa65b3c21 Reviewed-on: https://skia-review.googlesource.com/116521 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Get @constructor feature of SKSL workingGravatar Robert Phillips2018-03-23
| | | | | | | | | | This is probably the only portion of https://skia-review.googlesource.com/c/skia/+/115900 that we want to keep TBR=ethannicholas@google.com Change-Id: Ife4d7bfbe454f705e93fb051b0bcf8e2b0a052b5 Reviewed-on: https://skia-review.googlesource.com/116192 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Remove std::move from GrSimpleTextureEffect"Gravatar Robert Phillips2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0a4b13cdea208946a59c612e0743f28533124166. Reason for revert: incorrect change Original change's description: > Remove std::move from GrSimpleTextureEffect > > Bug:822680 > Change-Id: I4780ce12a6ce244a2165bfb7b293adb06ae577c5 > Reviewed-on: https://skia-review.googlesource.com/115900 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com,ethannicholas@google.com Change-Id: Ib4123d50b02eeac3f5112bf2702b12fc080f0d1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822680 Reviewed-on: https://skia-review.googlesource.com/116140 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Remove std::move from GrSimpleTextureEffectGravatar Robert Phillips2018-03-22
| | | | | | | | | Bug:822680 Change-Id: I4780ce12a6ce244a2165bfb7b293adb06ae577c5 Reviewed-on: https://skia-review.googlesource.com/115900 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* switched SPIR-V vertexid to vertexindexGravatar Ethan Nicholas2018-03-22
| | | | | | | | Bug: skia: Change-Id: I32c10e2874feea63d7fa048057ef57e27d5874bc Reviewed-on: https://skia-review.googlesource.com/115880 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 09:48:52 +0000