| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc).
Refactoring pattern:
1. guard the existing constructor(readbuffer) with the legacy build-flag
2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL).
If you're a shader subclass
1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it.
R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/395603002
|
|
|
|
|
|
|
|
| |
R=bungeman@google.com, raph@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/495063002
|
|
|
|
|
|
|
|
|
|
| |
This enable Android to save space on emoji glyphs
R=bungeman@google.com, raph@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/492253002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new code is still rather bad, but has fewer steps.
The motivation for looking at this is that on Windows 8 the previous code
was occasionally asserting in such a way as to imply that GetGlyphIndices
might return different data the second time through the font. This avoids
that particular issue by only going through the font once.
R=mtklein@google.com, halcanary@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/472333003
|
|
|
|
|
|
|
|
|
|
| |
This define is no longer needed or set, so remove it from the code.
R=tomhudson@google.com, djsollen@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/488083004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL reverts to the NO_AUTOHINT behavior when autohinting is not
explicitly requested. This should be removed when Skia supports a
better API for selecting the correct variation.
This CL has landed in the Android repo and is being upstreamed to
avoid fragmenting the codebase.
R=bungeman@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/490913003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome/Chromium OS are getting a brand new CJK fonts (Noto Sans CJK).
We want them to be used in place of common Japanese and Simplified
Chinese sans-serif fonts.
BUG=chromium:399080
TEST=With CrOS CL
(https://chromium-review.googlesource.com/#/c/212624/), web pages
using 'Simhei' and 'MSP Gothic' are rendered with Noto Sans CJK.
R=reed@chromium.org, bungeman@google.com
Author: jshin@chromium.org
Review URL: https://codereview.chromium.org/476203003
|
|
|
|
|
|
|
|
|
|
| |
Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b
R=reed@google.com, mtklein@google.com, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/447873003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/447873003/)
Reason for revert:
Breaks the Chromium build: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-DRT/builds/2469/steps/BuildContentShell_1/logs/stdio
Original issue's description:
> Remove SkPaintOptionsAndroid
>
> Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/473543004
|
|
|
|
|
|
|
|
| |
R=reed@google.com, mtklein@google.com, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/447873003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/446473003/). This patch tries
the new path before falling back to the old path.
The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/462073002/ or the equivalent has turned on the
new SkFontManager.
BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com
Committed: https://skia.googlesource.com/skia/+/94fa4b99e2a53e997a90c7808cc5263f1bf40c9f
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/458543002
|
|
|
|
|
|
|
|
|
|
|
| |
SkFontConfigInterface, now that SkFontMgr_Android is live.
BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/445143002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new Android fonts.xml format doesn't explicitly tag fallback
fonts, or separate them from system fonts by putting them in a
separate file. We're assuming that any nameless font is a fallback
font.
Adds a unit test to track that we see as many fallback fonts as
expected when parsing a file.
BUG=chromium:400801
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/468893002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/446473003/). This patch tries
the new path before falling back to the old path.
The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/462073002/ or the equivalent has turned on the
new SkFontManager.
BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/458543002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Android font config parser was missing some SkAutoAsciiToLC
instantiations; this was discovered in https://crrev.com/458543002/
but should land independently.
BUG=chromium:400801
R=bungeman@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/465973002
|
|
|
|
|
|
|
|
| |
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/462013002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data structures produced consistent with expectations of previous versions of Skia.
R=bungeman@google.com, djsollen@google.com, palmer@chromium.org, reed@google.com, hcm@google.com, tomhudson@google.com
BUG=400801
Committed: https://skia.googlesource.com/skia/+/07544757c9fcf0f359f1686a3779eb2e75dd5b36
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/446473003
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:401954
R=tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/461673002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on every platform. In moving Android to the font manager, we broke those.
They're ugly, but this patch reinstates them.
R=tomhudson@google.com, djsollen@google.com, reed@google.com
TBR=reed@google.com
BUG=chromium:401954
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/451093002
|
|
|
|
|
|
| |
This reverts commit 27fb94999b8eec448423884e1d071e563c4c95d9.
Review URL: https://codereview.chromium.org/450513002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/447873003
|
|
|
|
|
|
|
|
| |
R=tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/447003002
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow us to replace SkGetFallbackFamilyNameForChar
and also eventually fix issues with it's reliance on names.
R=djsollen@google.com, tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/427293003
|
|
|
|
|
|
|
|
|
| |
BUG=392201
R=tomhudson@chromium.org, bungeman@google.com, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/433163002
|
|
|
|
|
|
|
|
| |
R=reed@google.com, bungeman@google.com, caryclark@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/434623002
|
|
|
|
|
|
|
|
|
|
| |
data structures produced consistent with expectations of previous versions of Skia.
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/446473003
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a basic unit test for the Android font configuration parser.
Add a check for the new LMP file format; on detection, switch to a new
(as-yet unwritten) parser.
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/439813002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/437253003
|
|
|
|
|
|
|
|
| |
R=djsollen@chromium.org, tomhudson@google.com, djsollen@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/433503003
|
|
|
|
|
|
|
|
| |
R=djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/420333002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly for brevity and matches better with Python:
Python | Old C++ | New C++
os.path.join | SkOSPath::SkPathJoin | SkOSPath::Join
os.path.basename | SkOSPath::SkBasename | SkOSPath::Basename
BUG=None
TEST=make all
R=mtklein@google.com, bsalomon@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/428443002
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:397549
R=tomhudson@chromium.org, tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/420223003
|
|
|
|
|
|
|
|
|
|
| |
deleted
R=tomhudson@google.com, bungeman@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/425753002
|
|
|
|
|
|
| |
R=tomhudson@google.com
Review URL: https://codereview.chromium.org/426643003
|
|
|
|
|
|
| |
R=tomhudson@google.com
Review URL: https://codereview.chromium.org/424663005
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2779
Committed: https://skia.googlesource.com/skia/+/d6aeb6dc8fe21066f1a2c4813a4256a3acd3edf5
R=robertphillips@google.com, mtklein@google.com, reed@android.com, bsalomon@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/419113002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2779
R=robertphillips@google.com, mtklein@google.com, reed@android.com, bsalomon@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/419113002
|
|
|
|
|
|
|
|
|
|
| |
Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06
R=djsollen@google.com, tomhudson@google.com, robertphillips@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/414483002
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:395043
R=eae@chromium.org, caryclark@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/412993002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert:
Reverting to unblock DEPS roll.
Original issue's description:
> SkFontMgr for Android.
>
> Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06
R=djsollen@google.com, tomhudson@google.com, bungeman@google.com
TBR=bungeman@google.com, djsollen@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/408143010
|
|
|
|
|
|
|
|
| |
R=djsollen@google.com, tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/414483002
|
|
|
|
|
|
|
|
|
|
| |
Use SK_DECLARE_UNFLATTENABLE_OBJECT if the subclass should not be directly instantiated.
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/399383007
|
|
|
|
|
|
|
|
| |
R=halcanary@google.com, reed@google.com, mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/400753004
|
|
|
|
|
|
|
|
| |
R=mtklein@google.com, reed@google.com, bsalomon@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/393913002
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operator= is ambiguous as to the state of the reference count.
Until we have rvalue assignment operators, just use 'reset' as the name
of the reference stealing assignment to AutoCFRelease.
R=reed@google.com, mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/400453002
|
|
|
|
|
|
|
|
| |
__sync operators.
R=mtklein@google.com, reed@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/398153002
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, I think we'll just be using sk_atomic_inc on 64-bit values, so
let's cut out the dead code for now.
NOTREECHECKS=true
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/398003004
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/skia/src/ports/SkFontHost_mac.cpp: don't increase retain count of
newly assigned CFTypeRef in AutoCFRelease::reset(). Each time CFTypeRef is
assigned to AutoCFRelease, AutoCFRelease becomes its sole owner.
BUG=skia:
R=reed@google.com, bungeman@google.com, rmistry@google.com, sheyang@chromium.org
Author: ljagielski@opera.com
Review URL: https://codereview.chromium.org/393513003
|
|
|
|
|
|
|
|
|
|
|
|
| |
va_list variable will be invalid after the first call. Use va_copy to
initialize the va_list for another call.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/394763004
|
|
|
|
|
|
|
|
| |
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/387313004
|