aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/ports/SkFontHost_mac.cpp
Commit message (Collapse)AuthorAge
* Expose API for gx font variation axes.Gravatar bungeman2016-01-21
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1590223003 Review URL: https://codereview.chromium.org/1590223003
* Implement onMatchFamilyStyle for Mac.Gravatar bungeman2016-01-21
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612653002 Review URL: https://codereview.chromium.org/1612653002
* Start making all .cpp files compile-able on all platforms.Gravatar mtklein2015-11-02
| | | | | | | | | | | | | | | | | | | | | | | I sometimes dream to hone our build process down to something as simple as $ find src -name '*.cpp' | xargs c++ <some cflags> -c -o skia.o To start, it helps if we can compile all files on all platforms. Each non-portable file guards itself with defines provided by SkTypes.h. This does not convert all non-portable code, but it's a good representative chunk. E.g. instead of having to remember which SkDebug_*.cpp to compile on which platform we can just compile all three and let the code itself sort it out. This has the nice side effect of making non-portable code declare the conditions under which it can compile explicitly. I've been testing mostly with the CMake build as it's easiest, but this should apply equally to BUILD, Gyp, and GN files... to any build system really. BUG=skia:4269 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Review URL: https://codereview.chromium.org/1411283005
* Use only one CGFont/CTFont per scaler context on Mac.Gravatar bungeman2015-10-29
| | | | | | | | | | The unrotated CTFont was introduced to fix color emoji scaling. Use only the unrotated CTFont and apply the rotations manually. This allows removal of one CTFont and allows us to apply (correctly) the transformation CoreText would otherwise need to apply (which it appears to do inconsistently). Review URL: https://codereview.chromium.org/1360663002
* Avoid last param to CTFontCreateWithGraphicsFont.Gravatar bungeman2015-09-23
| | | | | | | | | | | | | | | The last parameter of CTFontCreateWithGraphicsFont (CTFontDescriptorRef attributes) *must* be nullptr. If non-nullptr then with fonts with variation axes, the copy will fail in CGFontVariationFromDictCallback when it assumes kCGFontVariationAxisName is CFNumberRef which it quite obviously is not. TBR=reed@google.com Blocking dev builds, just removes code. BUG=chromium:535109 Review URL: https://codereview.chromium.org/1362053003
* Avoid CTFontCreateCopyWithAttributes.Gravatar bungeman2015-09-22
| | | | | | | | | | | | | | It appears that CTFontCreateCopyWithAttributes and CTFontCreateCopyWithSymbolicTraits share similar issues with the default font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as it will not work with webfonts. Since this is all low-level use, create the CTFonts from the underlying CGFonts directly. BUG=chromium:524646 Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f Review URL: https://codereview.chromium.org/1344213004
* Revert of Avoid CTFontCreateCopyWithAttributes. (patchset #4 id:60001 of ↵Gravatar bungeman2015-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1344213004/ ) Reason for revert: Causes issues with synthetic bold italic on all versions of OSX, with OSX10.10 resulting in many measurement related changes (this is expected though). fast/text/atsui-multiple-renderers.html fast/css/font-face-synthetic-bold-italic.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9__retina_/6168/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/4525/layout-test-results/results.html Original issue's description: > Avoid CTFontCreateCopyWithAttributes. > > It appears that CTFontCreateCopyWithAttributes and > CTFontCreateCopyWithSymbolicTraits share similar issues with the default > font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as > it will not work with webfonts. Since this is all low-level use, create the > CTFonts from the underlying CGFonts directly. > > BUG=chromium:524646 > > Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f TBR=erikchen@chromium.org,mtklein@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524646 Review URL: https://codereview.chromium.org/1354323002
* Avoid CTFontCreateCopyWithAttributes.Gravatar bungeman2015-09-18
| | | | | | | | | | | | It appears that CTFontCreateCopyWithAttributes and CTFontCreateCopyWithSymbolicTraits share similar issues with the default font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as it will not work with webfonts. Since this is all low-level use, create the CTFonts from the underlying CGFonts directly. BUG=chromium:524646 Review URL: https://codereview.chromium.org/1344213004
* Port SkLazyFnPtr users to SkOncePtr.Gravatar mtklein2015-09-08
| | | | | | | | | | | First baby step on road to replacing SkLazyFnPtr, SkLazyPtr, and SkOnce. One of those very unusual times you get to use a function type, not a function pointer type! BUG=skia: Review URL: https://codereview.chromium.org/1317263007
* Style Change: NULL->nullptrGravatar halcanary2015-08-27
| | | | | | DOCS_PREVIEW= https://skia.org/?cl=1316233002 Review URL: https://codereview.chromium.org/1316233002
* Style Change: SkNEW->new; SkDELETE->deleteGravatar halcanary2015-08-26
| | | | | | DOCS_PREVIEW= https://skia.org/?cl=1316123003 Review URL: https://codereview.chromium.org/1316123003
* Use SK_DECLARE_STATIC_MUTEX for global mutex.Gravatar mtklein2015-07-13
| | | | | | | | | This initializes the mutex at link time on non-Windows platforms, rather than at pre-main-runtime like `static SkMutex gFoo;` BUG=skia: Review URL: https://codereview.chromium.org/1226403007
* add option to use global mutex-lock in mac-scalercontextGravatar reed2015-07-10
| | | | | | BUG=413332 Review URL: https://codereview.chromium.org/1220873009
* SkAdvancedTypefaceMetrics zeroing constructorGravatar halcanary2015-07-08
| | | | Review URL: https://codereview.chromium.org/1221903004
* Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.Gravatar mtklein2015-07-07
| | | | | | | | | | | | | | SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc Review URL: https://codereview.chromium.org/1215393002
* Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as ↵Gravatar jvanverth2015-07-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/) Reason for revert: Breaking the roll. E.g. on android_chromium_gn_compile_dbg: FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/skia/ext/libskia.SkMemory_new_handler.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DDONT_EMBED_BUILD_METADATA -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DCOMPONENT_BUILD -D__GNU_SOURCE=1 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DSKIA_IMPLEMENTATION=1 -DSK_ARM_HAS_OPTIONAL_NEON -DSK_GAMMA_APPLY_TO_A8 -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSK_DEFAULT_FONT_CACHE_LIMIT=1048576 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DXML_STATIC -I../.. -Igen -I../../third_party/skia/include/private -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/zlib -I../../third_party/expat/files/lib -I../../third_party/freetype-android/include -I../../third_party/freetype-android/src/include -I../../third_party/android_tools/ndk/sources/android/cpufeatures -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fvisibility=hidden --sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm -Os -fdata-sections -ffunction-sections -fomit-frame-pointer -g1 -Wno-format -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -c ../../skia/ext/SkMemory_new_handler.cpp -o obj/skia/ext/libskia.SkMemory_new_handler.o ../../skia/ext/SkMemory_new_handler.cpp:12:52: fatal error: third_party/skia/include/core/SkThread.h: No such file or directory #include "third_party/skia/include/core/SkThread.h" Original issue's description: > Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. > > SkThread.h doesn't do anything anymore execept include those two, > and thankfully, it doesn't seem to be mentioned outside Skia. > > No public API changes. > TBR=reed@google.com > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1214603003
* Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.Gravatar mtklein2015-07-01
| | | | | | | | | | | | SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1215393002
* Fill capHeight and maxCharWidth on Mac.Gravatar bungeman2015-06-09
| | | | | | BUG=skia:3924 Review URL: https://codereview.chromium.org/1164423006
* Remove attempted bug mitigation in Mac typeface.Gravatar bungeman2015-06-08
| | | | | | | | An attempt was made to hold onto the 'sbix' table when it existed when drawing to mitigate an issue with vanishing font data. This code has not affected the crash rate, so remove it. Review URL: https://codereview.chromium.org/1168793003
* Provide tag-along for SkCreateTypefaceFromCTFont.Gravatar bungeman2015-06-08
| | | | | | | This provides a means of keeping an object alive for the entire lifetime of an SkTypeface. Review URL: https://codereview.chromium.org/1163573007
* Font variations.Gravatar bungeman2015-05-20
| | | | | | | | | | | | Multiple Master and TrueType fonts support variation axes. This implements back-end support for axes on platforms which support it. Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97 Committed: https://skia.googlesource.com/skia/+/3489ee0f4fa34f124f9de090d12bdc2107d52aa9 Review URL: https://codereview.chromium.org/1027373002
* Revert of Font variations. (patchset #26 id:500001 of ↵Gravatar robertphillips2015-05-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1027373002/) Reason for revert: Appears to be breaking Linux ARM bots: FAILED: /usr/local/google/home/mosaic-role/slave/repo_clients/chromium_tot/chromium/src/../../prebuilt/toolchain/armv7a/bin/armv7a-cros-linux-gnueabi-g++ ... -o obj/third_party/skia/src/ports/skia_library.SkFontHost_FreeType.o ../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:37:31: fatal error: freetype/ftmm.h: No such file or directory #include FT_MULTIPLE_MASTERS_H ^ compilation terminated. Original issue's description: > Font variations. > > Multiple Master and TrueType fonts support variation axes. > This implements back-end support for axes on platforms which > support it. > > Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97 > > Committed: https://skia.googlesource.com/skia/+/3489ee0f4fa34f124f9de090d12bdc2107d52aa9 TBR=reed@google.com,mtklein@google.com,djsollen@google.com,halcanary@google.com,bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1139123008
* Font variations.Gravatar bungeman2015-05-14
| | | | | | | | | | Multiple Master and TrueType fonts support variation axes. This implements back-end support for axes on platforms which support it. Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97 Review URL: https://codereview.chromium.org/1027373002
* Revert of Font variations. (patchset #21 id:400001 of ↵Gravatar bungeman2015-05-13
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1027373002/) Reason for revert: Mac failing to build due to CFNumberType in Chromium Canary. Original issue's description: > Font variations. > > Multiple Master and TrueType fonts support variation axes. > This implements back-end support for axes on platforms which > support it. > > Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97 TBR=reed@google.com,mtklein@google.com,djsollen@google.com,halcanary@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1128913008
* Font variations.Gravatar bungeman2015-05-13
| | | | | | | | Multiple Master and TrueType fonts support variation axes. This implements back-end support for axes on platforms which support it. Review URL: https://codereview.chromium.org/1027373002
* Make SkAdvancedTypefaceMetrics private.Gravatar reed2015-05-12
| | | | Review URL: https://codereview.chromium.org/1129283003
* Fix typeface ids on Mac.Gravatar bungeman2015-05-04
| | | | | | | | | | The current typeface ids with CoreText rely on ATS (which causes memory use issues) or font data (which is unreliable, and will not work with axes and synthetics). This changes the code so that stream fonts never end up in the cache and always get a unique id, and system fonts will be given an id as they are used. Review URL: https://codereview.chromium.org/1125763002
* Ammend font table data experiment on Mac.Gravatar bungeman2015-04-10
| | | | | | | | | | | Calling CGFontCopyTableForTag did not affect the runtime results, so try to actually access the data to see if that makes a difference. TBR=reed1 This is a test change, allow data to be collected. Review URL: https://codereview.chromium.org/1076183004
* Attempted mitigation of font tables released early.Gravatar bungeman2015-04-07
| | | | | | | | | On Mac, it appears that sometimes fonts created from data have their table data used after the table data copy is freed. This appears to be most common with 'sbix' fonts for some reason, so pin that table while in use. Review URL: https://codereview.chromium.org/1061123002
* C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}Gravatar mtklein2015-03-25
| | | | | | | | | NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
* For safety include SkTypes.h in SkFontHost_mac.cppGravatar mtklein2015-03-11
| | | | | | BUG=skia:3362 Review URL: https://codereview.chromium.org/996113003
* Draw glyphs on Mac without font transform.Gravatar bungeman2015-03-02
| | | | | | | | The transform on the font is increasingly going untested on Mac. As a result, only use the transform on the context when possible. This fixes color emoji on OSX10.2. Review URL: https://codereview.chromium.org/975493002
* Set the ttcIndex on Mac onOpenStream.Gravatar bungeman2015-03-02
| | | | | | | Since on Mac onOpenStream always creates a new stream of a non-collection font, be sure the out ttcIndex is always set to 0. Review URL: https://codereview.chromium.org/975473002
* Provide Mac 10.6 SDK support for kCTFontColorGlyphsTrait.Gravatar bungeman2015-02-23
| | | | | | | | | | kCTFontColorGlyphsTrait was introduced in Mac 10.7 and iPhone 4.3 SDKs. Chromium still builds with the 10.6 SDK, so provide this constant when it is otherwise unavailable. TBR=mtklein@google.com Review URL: https://codereview.chromium.org/951723003
* Use traits instead of table for color glyph detection.Gravatar bungeman2015-02-23
| | | | | | | The CTFont already knows if a font might contain color glyphs, so use that information directly instead of guessing ourselves. Review URL: https://codereview.chromium.org/949933003
* Remove SkFontHost includes and friends.Gravatar bungeman2015-02-23
| | | | | | | SkFontHost no longer exists as a class, so remove the includes and stop making it a friend. Review URL: https://codereview.chromium.org/943333004
* SkTypeface to use SkStreamAsset.Gravatar bungeman2015-01-27
| | | | | | | SkTypeface already requires typeface streams to support SkStreamAsset in practice, and in practice all users are already supplying them. Review URL: https://codereview.chromium.org/869763002
* Fix up all the easy virtual ... SK_OVERRIDE cases.Gravatar mtklein2015-01-09
| | | | | | | | | | | | This fixes every case where virtual and SK_OVERRIDE were on the same line, which should be the bulk of cases. We'll have to manually clean up the rest over time unless I level up in regexes. for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end BUG=skia: Review URL: https://codereview.chromium.org/806653007
* Work around changes in OSX 10.10.Gravatar bungeman2015-01-08
| | | | | | | | | | | | | | | | | In 10.10.1 CTFontGetAdvancesForGlyphs applies the font transform to the width of the advance but always sets the height of the advance to 0. Work around this by measuring the advance with an unrotated font and apply the transform manually. In 10.7 through 10.9 CTFontDrawGlyphs appears to take 'positions' in text space and acts like CGContextShowGlyphsAtPosition. In 10.10.1, these 'positions' now appear to be in glyph space, and CTFontDrawGlyphs maps the glyph positions internally. BUG=chromium:442574 Review URL: https://codereview.chromium.org/841843002
* Replace use of deprecated CG methods.Gravatar bungeman2014-12-10
| | | | | | | | | | | OSX10.9 and iOS7.0 deprecated CGContextShowGlyphsAtPoint so a new API should be used. OSX10.7 and iOS4.2 replace CGContextShowGlyphsAtPoint with CTFontDrawGlyphs. OSX10.5 and iOS2.0 have CGContextShowGlyphsAtPositions which works similarly to CTFontDrawGlyphs and has not yet been deprecated. This change allows the use of CTFontDrawGlyphs when it is available, falling back to CGContextShowGlyphsAtPositions when it isn't. Review URL: https://codereview.chromium.org/770383002
* Remove support for OSX 10.5.Gravatar bungeman2014-12-01
| | | | | | | No user supports OSX 10.5 at this point, so remove the last support for building there. Review URL: https://codereview.chromium.org/768133005
* Use text size on Mac.Gravatar bungeman2014-11-25
| | | | | | | | | | | | | | The current code assumes that text on Mac is freely scalable, or at least that the text size is just a part of the transform. However, it appears that application of the 'trak' table, as well as other optical adjustments, may rely on the text size directly. This change passes the text size requested directly to CoreText. BUG=chromium:427528 Review URL: https://codereview.chromium.org/752183002
* Enforce pure virtual behavior for onMatchFamilyStyleCharacterGravatar djsollen2014-11-14
| | | | | | | | | All impls that previously did not define the functions have been updated to return NULL. NOTRY=true Review URL: https://codereview.chromium.org/728873002
* remove unused kLCD_MaskFormatGravatar reed2014-11-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/728673002
* With ↵Gravatar bungeman2014-11-10
| | | | | | | | | | https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. BUG=chromium:425566 Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3 Review URL: https://codereview.chromium.org/693213002
* Revert of Bisect Mac performance regression. (patchset #6 id:100001 of ↵Gravatar egdaniel2014-11-05
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/693213002/) Reason for revert: Block deps roll by breaking webkit test hit-test-counts on mac. Original issue's description: > With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. > > BUG=chromium:425566 > > Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3 TBR=reed@google.com,bungeman@google.com NOTREECHECKS=true NOTRY=true BUG=chromium:425566 Review URL: https://codereview.chromium.org/683753003
* With ↵Gravatar bungeman2014-11-04
| | | | | | | | https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. BUG=chromium:425566 Review URL: https://codereview.chromium.org/693213002
* Combine nameFontStyleProc and FindByNameStyle.Gravatar bungeman2014-10-30
| | | | | | These two functions do the same thing, combine them. Review URL: https://codereview.chromium.org/688133003
* Replace SkTypeface::Style with SkFontStyle.Gravatar bungeman2014-10-20
| | | | | | Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 Review URL: https://codereview.chromium.org/488143002
* Revert of Replace SkTypeface::Style with SkFontStyle. (patchset #9 id:160001 ↵Gravatar mtklein2014-10-20
| | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/488143002/) Reason for revert: CrOS GM failures: [*] 2 ExpectationsMismatch: fontmgr_iter_565.png fontmgr_iter_8888.png Original issue's description: > Replace SkTypeface::Style with SkFontStyle. > > Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 TBR=reed@google.com,bungeman@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/667023002
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-04 06:00:39 +0000