aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/gpu/GrAutoLocaleSetter.h
Commit message (Collapse)AuthorAge
* Convert NULL and 0 to nullptr.Gravatar Ben Wagner2017-08-28
| | | | | | | | | | | | | | This was created by looking at warnings produced by clang's -Wzero-as-null-pointer-constant. This updates most issues in Skia code. However, there are places where GL and Vulkan want pointer values which are explicitly 0, external headers which use NULL directly, and possibly more uses in un-compiled sources (for other platforms). Change-Id: Id22fbac04d5c53497a53d734f0896b4f06fe8345 Reviewed-on: https://skia-review.googlesource.com/39521 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Pass LC_ALL_MASK to newlocaleGravatar Eric Karl2017-04-17
| | | | | | | | | | | | | | | This change fixes an issue with GrAutoLocaleSetter, which was using the C library LC_ALL mask with newlocale. Instead the xlocale LC_ALL_MASK should be used (these do not match on all platforms). See: http://man7.org/linux/man-pages/man3/newlocale.3.html Bug: 711683 Change-Id: I6dba140e72b095f75667f0dcc98480d8d4562191 Reviewed-on: https://skia-review.googlesource.com/13601 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Use nullptr to indicate C locale when using xlocaleGravatar Brian Salomon2017-01-05
| | | | | | | | | BUG=chromium:666228 Change-Id: I951102eba2b79ddaa5eb134834471a4a3ec8aed7 Reviewed-on: https://skia-review.googlesource.com/6603 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Style bikeshed - remove extraneous whitespaceGravatar halcanary2016-03-29
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002 Review URL: https://codereview.chromium.org/1842753002
* Porting Skia for newlib compatibility.Gravatar smklein2015-12-15
| | | | | | | | "locale_t" is not defined for Newlib. BUG=https://github.com/domokit/mojo/issues/431 Review URL: https://codereview.chromium.org/1526703003
* Try to fix intermittent GrAutoLocaleSetter crashes on WindowsGravatar kkinnunen2015-12-13
| | | | | | | | | | | | Try to fix intermittent GrAutoLocaleSetter crashes on Windows. The string returned by setlocale() is only valid up to next setlocale(), so it can not be fed to setlocale(). Also, libraries such as ANGLE might call setlocale when inside a callstack containing GrAutoLocaleSetter. This would render the old locale pointer invalid. Review URL: https://codereview.chromium.org/1514083002
* Speculative fix for win8 bot crash in ~GrAutoLocaleSetterGravatar bsalomon2015-12-04
| | | | Review URL: https://codereview.chromium.org/1493913008
* Fix maybe unintialized warning for GrAutoLocaleSetterGravatar kkinnunen2015-11-19
| | | | | | | | | | | In function void test_GLPrograms(skiatest::Reporter*, GrContextFactory*): ../../../src/gpu/GrAutoLocaleSetter.h:47:35: error: als.GrAutoLocaleSetter::fOldLocale may be used uninitialized in this function [-Werror=maybe-uninitialized] From Build-Ubuntu-GCC-x86_64-Release-Trybot Review URL: https://codereview.chromium.org/1456383002
* Fix build for UCLIBC platforms (newlocale/freelocale)Gravatar smcgruer2015-06-09
| | | | | | | | UCLIBC does not have locale support by default. BUG=skia: Review URL: https://codereview.chromium.org/1162953003
* Move GrAutoLocaleSetter to new file and fix issue with null localeGravatar bsalomon2015-03-16
TBR=egdaniel@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/1002623004