aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core
Commit message (Collapse)AuthorAge
* validate offsetToRestoreGravatar Mike Reed2018-01-16
| | | | | | | | | Bug: skia:7425 Change-Id: I6451058bc5194853440f08a053fb974bc8f377a2 Reviewed-on: https://skia-review.googlesource.com/95161 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* it is not an error to have no flattenableGravatar Mike Reed2018-01-16
| | | | | | | | Bug:801768 Change-Id: Ib6a0a27a1e6828819879c4b5eef9fe0fd319b225 Reviewed-on: https://skia-review.googlesource.com/94761 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove legacy 2pt conical gradientGravatar Yuqian Li2018-01-16
| | | | | | | | Bug: skia:7459 Change-Id: Iccc2588f80e22b13ed5d23656b8c75d7b7058a36 Reviewed-on: https://skia-review.googlesource.com/92700 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@google.com>
* detect if the computed rgn bounds is too bigGravatar Mike Reed2018-01-16
| | | | | | | | Bug:801869 Change-Id: I7380bfb86aedc719cf67e20e918ef39d1b143aee Reviewed-on: https://skia-review.googlesource.com/95020 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* relax path bounds checkGravatar Mike Reed2018-01-16
| | | | | | | | | | | | Revert of https://skia-review.googlesource.com/c/skia/+/94100 Reduced the "big" value by the amount we super-sample shift Bug: skia: Change-Id: I7b37b7db841312b0863f76cb353cc916aff1cfa8 Reviewed-on: https://skia-review.googlesource.com/94801 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "Revert "Revert "Snap alpha for small rects""""Gravatar Yuqian Li2018-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ea560af463c2a791c7c320a81828e5f407360c84. Reason for revert: the guard flag is now in Google3 Original change's description: > Revert "Revert "Revert "Snap alpha for small rects""" > > This reverts commit 15150a60ebea7b268493d0595cec7db9a5465fac. > > Reason for revert: we suspect this is behind the roll failures > > Original change's description: > > Revert "Revert "Snap alpha for small rects"" > > > > This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. > > > > Reason for revert: the CL does not seem to have caused any failures > > > > Original change's description: > > > Revert "Snap alpha for small rects" > > > > > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > > > > > Reason for revert: possibly causing Google3 roll failure? > > > > > > Original change's description: > > > > Snap alpha for small rects > > > > > > > > This is more similar to our alpha snapping in AAA. More critically, we > > > > may have a tiny alpha difference after some 90 degree rotations and that > > > > breaks the Chromium svg layout tests (where the expected reference is a > > > > rotated svg...) > > > > > > > > TBR: fmalita@google.com > > > > Bug: skia: > > > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > > > Reviewed-on: https://skia-review.googlesource.com/92940 > > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > > > > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: skia: > > > Reviewed-on: https://skia-review.googlesource.com/93323 > > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > > > TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > > > Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/93680 > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: If00c7c8cb6b44c489615444b9aca5a2f25b2d5fe > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93860 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I68d6b968460f0541d658a8641ca5e147405292d0 Reviewed-on: https://skia-review.googlesource.com/94540 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Revert "relax path bounds check so we can draw larger paths"Gravatar Mike Reed2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e2330261a704e2db762e2de0d297bf8b4dc510f1. Reason for revert: triggered assert 48.3s start tiles_rt-8888 gm bigrect 48.3s start tiles_rt-8888 gm big_rrect_circle_aa_effect 48.3s start tiles_rt-8888 gm big_rrect_ellipse_aa_effect ../../../src/core/SkScan_Path.cpp(229): fatal error: "assert(leftE->fFirstY <= stop_y)" Original change's description: > relax path bounds check so we can draw larger paths > > Bug:800804 > Change-Id: Ief0679de95887d8e11aa5853228c2bdef27d07a2 > Reviewed-on: https://skia-review.googlesource.com/94100 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=egdaniel@google.com,liyuqian@google.com,reed@google.com Change-Id: I63509625b8afaa2064f0b187c17b73bd7739cdb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800804 Reviewed-on: https://skia-review.googlesource.com/94481 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* relax path bounds check so we can draw larger pathsGravatar Mike Reed2018-01-12
| | | | | | | | Bug:800804 Change-Id: Ief0679de95887d8e11aa5853228c2bdef27d07a2 Reviewed-on: https://skia-review.googlesource.com/94100 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Bitmap: clearing pixelref keeps rowbytesGravatar Hal Canary2018-01-12
| | | | | | | Change-Id: Ibf8b69adcb4e9df597079a8d9ada75b4a31194e6 Reviewed-on: https://skia-review.googlesource.com/94040 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "Revert "Revert "Snap alpha for small rects"""Gravatar Ethan Nicholas2018-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 15150a60ebea7b268493d0595cec7db9a5465fac. Reason for revert: we suspect this is behind the roll failures Original change's description: > Revert "Revert "Snap alpha for small rects"" > > This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. > > Reason for revert: the CL does not seem to have caused any failures > > Original change's description: > > Revert "Snap alpha for small rects" > > > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > > > Reason for revert: possibly causing Google3 roll failure? > > > > Original change's description: > > > Snap alpha for small rects > > > > > > This is more similar to our alpha snapping in AAA. More critically, we > > > may have a tiny alpha difference after some 90 degree rotations and that > > > breaks the Chromium svg layout tests (where the expected reference is a > > > rotated svg...) > > > > > > TBR: fmalita@google.com > > > Bug: skia: > > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > > Reviewed-on: https://skia-review.googlesource.com/92940 > > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/93323 > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93680 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: If00c7c8cb6b44c489615444b9aca5a2f25b2d5fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93860 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Avoid nullptr deference when deserializing SkPictureGravatar Kevin Lubick2018-01-11
| | | | | | | | | | | | Avoid resetting SkAutoSTArray values to negatives. Additionally, clean up some misc logs that aren't helpful. Bug: skia:7405 Change-Id: Ied353a4e415e2efd5ab8180e7f6c681248dd9134 Reviewed-on: https://skia-review.googlesource.com/93240 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Revert "Revert "Snap alpha for small rects""Gravatar Yuqian Li2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 131c8ea4b7ffad7ebf6c49cf9337602f1249806d. Reason for revert: the CL does not seem to have caused any failures Original change's description: > Revert "Snap alpha for small rects" > > This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. > > Reason for revert: possibly causing Google3 roll failure? > > Original change's description: > > Snap alpha for small rects > > > > This is more similar to our alpha snapping in AAA. More critically, we > > may have a tiny alpha difference after some 90 degree rotations and that > > breaks the Chromium svg layout tests (where the expected reference is a > > rotated svg...) > > > > TBR: fmalita@google.com > > Bug: skia: > > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > > Reviewed-on: https://skia-review.googlesource.com/92940 > > Reviewed-by: Yuqian Li <liyuqian@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/93323 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> TBR=mtklein@google.com,ethannicholas@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I0cb343fa5448ecf0e6a2073bb4e3603275d6984c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93680 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Revert "Snap alpha for small rects"Gravatar Ethan Nicholas2018-01-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 52f8e71a45ead72f257317f82775eb3459b71eae. Reason for revert: possibly causing Google3 roll failure? Original change's description: > Snap alpha for small rects > > This is more similar to our alpha snapping in AAA. More critically, we > may have a tiny alpha difference after some 90 degree rotations and that > breaks the Chromium svg layout tests (where the expected reference is a > rotated svg...) > > TBR: fmalita@google.com > Bug: skia: > Change-Id: I59b750153488083f65b731643e0baca823cb78e4 > Reviewed-on: https://skia-review.googlesource.com/92940 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=mtklein@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I2ca0b9375caa473dc2f407655b17603b68337c1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/93323 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Snap alpha for small rectsGravatar Yuqian Li2018-01-10
| | | | | | | | | | | | | | This is more similar to our alpha snapping in AAA. More critically, we may have a tiny alpha difference after some 90 degree rotations and that breaks the Chromium svg layout tests (where the expected reference is a rotated svg...) TBR: fmalita@google.com Bug: skia: Change-Id: I59b750153488083f65b731643e0baca823cb78e4 Reviewed-on: https://skia-review.googlesource.com/92940 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Compare drawBounds with MakeLargest instead of isFiniteGravatar Yuqian Li2018-01-09
| | | | | | | | | | | | In some cases, transformedBounds is finite but its rounded out IRect is empty so we can't do that. TBR: reed@google.com Bug: skia: Change-Id: Ife78e91a494964042fa09b8cbe86cabbd2572fb9 Reviewed-on: https://skia-review.googlesource.com/92625 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* support gray8 destinations on CPUGravatar Mike Klein2018-01-09
| | | | | | | | | | | | | | | | | - fill in a couple switches to allow software to rasterize gray8 - add a gray8 config to DM so we can test it - enable this config on some bots Today we draw gray8 using SkRasterPipeline, loading it as {g,g,g,1} and storing using the same fixed luma math as SkLumaColorFilter. One day it'd be nice to use the color space's luma vector if present. Can we support this on GPU? Change-Id: I4ee661c8bd5f33f5db2433ffb6e1bc2483af8397 Reviewed-on: https://skia-review.googlesource.com/92681 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* shrink our 'largest' so that its non-emptyGravatar Mike Reed2018-01-09
| | | | | | | | Bug: skia: Change-Id: Ib12fd9491069440c85d5aa9c9d6d26787f03ef0d Reviewed-on: https://skia-review.googlesource.com/92643 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* detect bad conic weightsGravatar Mike Reed2018-01-09
| | | | | | | | Bug: skia:7478 Change-Id: I5fb254e10f3f38184fe41eb01e543f04b1a03081 Reviewed-on: https://skia-review.googlesource.com/92641 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* fix bad counts deserializing SkVerticesGravatar Mike Reed2018-01-09
| | | | | | | | Bug: skia:7475 Change-Id: I8064de3f564385f085720772d95934845f3c1dc3 Reviewed-on: https://skia-review.googlesource.com/92741 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
* handle text error in pictureplaybackGravatar Mike Reed2018-01-09
| | | | | | | | Bug: skia:7476 Change-Id: Iae78ea9c446681e7c2459ed9083a8f76a26e3c48 Reviewed-on: https://skia-review.googlesource.com/92622 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove macro in the threaded backendGravatar Yuqian Li2018-01-09
| | | | | | | | | | | | This is a smaller CL distilled from our init-once CL (87784). Note that the thread alloc is unused here but it will be used by init-once. Bug: skia: Change-Id: If4bc2febfb3fbcd85bf973a01e60b9b64c873a19 Reviewed-on: https://skia-review.googlesource.com/92621 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Herb Derby <herb@google.com>
* use 64bit math to compute is a rect is emptyGravatar Mike Reed2018-01-09
| | | | | | | | | | | Will work next to try to make isEmpty() private Bug: skia:7470 Bug:799715 Change-Id: I7b43028ecd86dca68e0c67225712516d2f2f88a2 Reviewed-on: https://skia-review.googlesource.com/92620 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* SkBitmap now *has* a SkPixmap.Gravatar Hal Canary2018-01-09
| | | | | | | | | | | | | | | | | | | | | | | | | | Before: class SkBitmap { sk_sp<SkPixelRef> fPixelRef; void* fPixels; SkImageInfo fInfo; uint32_t fRowBytes; uint8_t fFlags; }; After: class SkBitmap { sk_sp<SkPixelRef> fPixelRef; SkPixmap fPixmap; uint8_t fFlags; }; Change-Id: I62d59ca3e702b7adea022cd3cfbf0cc3186af957 Reviewed-on: https://skia-review.googlesource.com/85560 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Remove legacy containedInClip codeGravatar Yuqian Li2018-01-09
| | | | | | | | | | | It seems that we've already rebaselined the golden images TBR: reed@google.com Bug: skia:7271 Change-Id: I841dc4933f0cad015c3c6da7bd08ddfb2a35c5a2 Reviewed-on: https://skia-review.googlesource.com/92060 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* make growToInclude privateGravatar Mike Reed2018-01-08
| | | | | | | | | Bug: skia: Change-Id: Id55344ba2f33563d22c2bf4d5829a9a31095a47d Reviewed-on: https://skia-review.googlesource.com/92143 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* SkDocument: remove unused fDoneProcGravatar Hal Canary2018-01-08
| | | | | | | Change-Id: I9a0739992e90a0a6d44a75b0b570097553343f1d Reviewed-on: https://skia-review.googlesource.com/92141 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* move largest apis into privateGravatar Mike Reed2018-01-08
| | | | | | | | | Related to https://skia-review.googlesource.com/c/skia/+/91860 Bug: skia: Change-Id: Ia8fd981b422bbab75541b078277d2e09e1fc9d41 Reviewed-on: https://skia-review.googlesource.com/91940 Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add GrProxyProviderGravatar Robert Phillips2018-01-08
| | | | | | | | | This pulls all the proxy tracking & creation functionality out of the GrResourceCache and GrResourceProvider and consolidates it in the GrProxyProvider. Change-Id: I7256f7c544319a70c1bd93dd5a9ccbe5fa0a544f Reviewed-on: https://skia-review.googlesource.com/91501 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Make SkMatrixPriv stride mapping functions take separate src and dst stridesGravatar Brian Salomon2018-01-08
| | | | | | | Change-Id: Ib7600a7611e3ca78f6a8ca091fa383ceddb751cf Reviewed-on: https://skia-review.googlesource.com/91402 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* SkBitmap::fPixelRefOrigin removedGravatar Hal Canary2018-01-08
| | | | | | | | | | | | | | Motivation: makes SkBitmap 8 bytes smaller. fPixelRefOrigin is rarely used, and can be recaluated when needed. Also, remove two of SkBitmap's private methods and fold in their functions. Change-Id: I2cddb9e4b5480404bf6da3edfb0155ab82cf47d2 Reviewed-on: https://skia-review.googlesource.com/91300 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* begin cleanup of malloc porting layerGravatar Mike Reed2018-01-05
| | | | | | | | | | | | | | 1. Merge some of the allocators into sk_malloc_flags by redefining a flag to mean zero-init 2. Add more private helpers to simplify our call-sites (and handle some overflow mul checks) 3. The 2-param helpers rely on the saturating SkSafeMath::Mul to pass max_size_t as the request, which should always fail. Bug:508641 Change-Id: I322f1e6ed91113467e0fdb12c91c3dad33d890c8 Reviewed-on: https://skia-review.googlesource.com/90940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Add fp-friendly check for zero-width BlurImageFiltersGravatar Jim Van Verth2018-01-05
| | | | | | | | Bug: skia:7453 Change-Id: I9fc2d8f97e7a1264479c3a759d4bec06fd15f17d Reviewed-on: https://skia-review.googlesource.com/91505 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Update 2pt conical gradient in raster pipelineGravatar Yuqian Li2018-01-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | The updated algorithm matches our new GPU algorithm (https://skia.org/dev/design/conical) and it brings about 7%-26% speedup. In the next CL, I'll simplify the GPU code by reusing the CPU code in this CL. 7.20% faster in gradient_conical_clamp_hicolor 8.94% faster in gradient_conicalZero_clamp_hicolor 10.00% faster in gradient_conicalOut_clamp_hicolor 11.72% faster in gradient_conicalOutZero_clamp_hicolor 13.62% faster in gradient_conical_clamp_3color 16.52% faster in gradient_conicalZero_clamp_3color 17.48% faster in gradient_conical_clamp 17.70% faster in gradient_conical_clamp_shallow 20.60% faster in gradient_conicalOut_clamp_3color 20.98% faster in gradient_conicalOutZero_clamp_3color 21.79% faster in gradient_conicalZero_clamp 22.48% faster in gradient_conicalOut_clamp 26.13% faster in gradient_conicalOutZero_clamp Bug: skia: Change-Id: Ia159495e1c77658cb28e48c9edf84938464e501c Reviewed-on: https://skia-review.googlesource.com/90262 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove public version of SkMatrix::mapPointsWithStride.Gravatar Brian Salomon2018-01-05
| | | | | | | | | Use private version already in SkMatrixPriv. Change-Id: I6e9546afdf2b072402f9deecec99a6d236e2c7f4 Reviewed-on: https://skia-review.googlesource.com/91400 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Privatize separate src/dst version of SkMatrix::mapPointsWithStride.Gravatar Brian Salomon2018-01-05
| | | | | | | Change-Id: I0bd6a4ded3667029c8c8336217e12eb93174911e Reviewed-on: https://skia-review.googlesource.com/91380 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Enable conditional-uninitialized flagGravatar Kevin Lubick2018-01-05
| | | | | | | | | Bug: skia:7462 Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-SKNX_NO_SIMD Change-Id: I1c0a09984bf28a5c620a89af56040f018bae6310 Reviewed-on: https://skia-review.googlesource.com/90941 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* cubic-map for non-linear tGravatar Mike Reed2018-01-05
| | | | | | | | Bug: skia: Change-Id: I248864bd853361c1abfc2d8af61a27ab27a49a91 Reviewed-on: https://skia-review.googlesource.com/38882 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Prepare rebaseline for removing legacy containedInClipGravatar Yuqian Li2018-01-05
| | | | | | | | Bug: skia:7271 Change-Id: I291d07d1d6c2513bf4a4d75474caab8ee5c07f54 Reviewed-on: https://skia-review.googlesource.com/90401 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* don't include SkMalloc.h from SkTypes.hGravatar Mike Reed2018-01-04
| | | | | | | | | | | | Needed chrome CLs https://chromium-review.googlesource.com/c/chromium/src/+/850741 https://chromium-review.googlesource.com/c/chromium/src/+/850920 Bug: skia: Change-Id: Ic568174a56590a65bfa284c59fd104275ee78da9 Reviewed-on: https://skia-review.googlesource.com/90823 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* check for irect with overflow width/heightGravatar Mike Reed2018-01-03
| | | | | | | | Bug:798066 Change-Id: Iac324ac5a32fae241a528751c84279ce60ac4baf Reviewed-on: https://skia-review.googlesource.com/90544 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "remove legacy support for old old picture versions""Gravatar Mike Reed2018-01-03
| | | | | | | | | | | | This reverts commit 6f1151140f331c78d99ede3cac10462dc8b32cde. Chrome has been updated, so this should be able to land. Bug: skia: Change-Id: I5a66782a39fecfac00edeb66fbd03dae4df1712c Reviewed-on: https://skia-review.googlesource.com/90205 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove unneeded readbuffer flagsGravatar Mike Reed2018-01-03
| | | | | | | | | | | - buffers are always 'cross-process' - readbuffer is always validating Bug:796107 Change-Id: I59614e9c29490c0b029c60d2aafe2806671bc9e1 Reviewed-on: https://skia-review.googlesource.com/90560 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
* partial revert of https://skia-review.googlesource.com/c/skia/+/90026 for ↵Gravatar Mike Reed2018-01-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | android Some errors: frameworks/base/core/jni/android/graphics/Bitmap.cpp:385: error: undefined reference to 'gDitherMatrix_4Bit_16' frameworks/base/core/jni/android/graphics/Bitmap.cpp:397: error: undefined reference to 'gDitherMatrix_4Bit_16' frameworks/base/core/jni/android/graphics/Bitmap.cpp:373: error: undefined reference to 'gDitherMatrix_3Bit_16' frameworks/base/core/jni/android/graphics/Bitmap.cpp:322: error: undefined reference to 'SkPM4f::toF16() const' frameworks/base/core/jni/android/graphics/Bitmap.cpp:333: error: undefined reference to 'SkFloatToHalf(float)' frameworks/base/core/jni/android/graphics/Bitmap.cpp:334: error: undefined reference to 'SkFloatToHalf(float)' frameworks/base/core/jni/android/graphics/Bitmap.cpp:335: error: undefined reference to 'SkFloatToHalf(float)' frameworks/base/core/jni/android/graphics/Bitmap.cpp:336: error: undefined reference to 'SkFloatToHalf(float)' frameworks/base/core/jni/android/graphics/Bitmap.cpp:639: error: undefined reference to 'SkPM4f::toF16() const' frameworks/base/core/jni/android/graphics/Bitmap.cpp:494: error: undefined reference to 'SkPM4f::FromF16(unsigned short const*)' frameworks/base/core/jni/android/graphics/Bitmap.cpp:494: error: undefined reference to 'SkPM4f::unpremul() const' external/skia/src/core/SkUtils.h:24: error: undefined reference to 'SkOpts::memset32' frameworks/base/core/jni/android/graphics/NinePatch.cpp:112: error: undefined reference to 'SkLatticeIter::Valid(int, int, SkCanvas::Lattice const&)' frameworks/base/core/jni/android/graphics/NinePatch.cpp:113: error: undefined reference to 'SkLatticeIter::SkLatticeIter(SkCanvas::Lattice const&, SkRect const&)' frameworks/base/core/jni/android/graphics/NinePatch.cpp:118: error: undefined reference to 'SkLatticeIter::next(SkRect*, SkRect*, bool*, unsigned int*)' frameworks/base/core/jni/android/graphics/NinePatch.cpp:118: error: undefined reference to 'SkLatticeIter::next(SkRect*, SkRect*, bool*, unsigned int*)' frameworks/base/core/jni/android/graphics/NinePatch.cpp:118: error: undefined reference to 'SkLatticeIter::next(SkRect*, SkRect*, bool*, unsigned int*)' external/skia/src/core/SkGeometry.h:427: error: undefined reference to 'SkConic::computeQuadPOW2(float) const' external/skia/src/core/SkGeometry.h:430: error: undefined reference to 'SkConic::chopIntoQuadsPOW2(SkPoint*, int) const' frameworks/base/core/jni/android/graphics/Shader.cpp:77: error: undefined reference to 'SkMakeImageFromRasterBitmap(SkBitmap const&, SkCopyPixelsMode)' Bug: skia:7454 Change-Id: I49b7c0890ac38b576b39e1ce76b22e2420c99889 Reviewed-on: https://skia-review.googlesource.com/90524 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* update pipe for lattice and shadowrecGravatar Mike Reed2018-01-03
| | | | | | | | | | | - move some lattice routines into shared helper (SkCanvasPriv) Bug: skia: Change-Id: Ibbb80dd7461c7fd3082a0220604ab42cbb8815be Reviewed-on: https://skia-review.googlesource.com/90540 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove unused declarationsGravatar Mike Reed2018-01-03
| | | | | | | | Bug: skia: Change-Id: If8ca5e3d649dab3cf8b2bdb1cf072ff23cea9465 Reviewed-on: https://skia-review.googlesource.com/90026 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* fix skipT to use sizeof TGravatar Mike Reed2018-01-02
| | | | | | | | | Bug: skia: Change-Id: Ifd6d3cfc4499afda763353ceaeecbbb28a97ff2c Reviewed-on: https://skia-review.googlesource.com/90265 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* simplify/cleanup readbuffer implGravatar Mike Reed2018-01-02
| | | | | | | | | | | - rely more on readPad32 - try to use signed or unsigned read-int correctly Bug: skia: Change-Id: Idd9c9b52f54cb47717dbba0d6da654419b3466e8 Reviewed-on: https://skia-review.googlesource.com/89902 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "remove legacy support for old old picture versions"Gravatar Mike Reed2017-12-29
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f3504d430cec35330017aa2af3a51083801c7dd9. Reason for revert: breaks unittest in Printing unittest in chrome Original change's description: > remove legacy support for old old picture versions > > Bug: skia: > Change-Id: Ieb97eabdb18e8c7bfa86e6a1fc6e0389cd096daa > Reviewed-on: https://skia-review.googlesource.com/89860 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@google.com> TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com Change-Id: I9f90da5dcfb9543f2f575fa7dc3b9c82996b041d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/90020 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove legacy support for old old picture versionsGravatar Mike Reed2017-12-29
| | | | | | | | Bug: skia: Change-Id: Ieb97eabdb18e8c7bfa86e6a1fc6e0389cd096daa Reviewed-on: https://skia-review.googlesource.com/89860 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove usage of SkGammas in SkColorSpace serializationGravatar Brian Osman2017-12-27
| | | | | | | | Bug: skia:7419 Change-Id: I613d9d19eaa05402aadff12d022a4471605d7ec0 Reviewed-on: https://skia-review.googlesource.com/89183 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-04 05:25:54 +0000