| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of teaching TSAN than SkMutex is a lock to get around it not
understanding Mach semaphore_t routines, teach it that there is a
happens-before relationship between semaphore_signal() and
semaphore_wait().
This reverts commit e395bf2d189e22822ddf2b46541c510d6d8fbcc0.
New changes are entirely restricted to SkSemaphore.cpp.
Change-Id: I27f647b93c48e81e8327db849881d669c4cd3d04
Reviewed-on: https://skia-review.googlesource.com/49180
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
TSAN does not intercept Mach semaphore_t calls used to implement
SkBaseMutex's fSemaphore (its OSSemaphore field). We can teach
it that Sk[Base]Mutex is a mutex anyway with the same annotations
we use for SkSharedMutex.
Change-Id: Ib91928bb9fcfa94f5cea985b46dea31ff2b56963
Reviewed-on: https://skia-review.googlesource.com/48580
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
And reindent.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293063002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot
Review-Url: https://codereview.chromium.org/2293063002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1371303003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1373253003
|
|
|
|
|
|
|
|
|
|
| |
There are no API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1369333004
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implementation improves performance of SkMutex acquire / release pair from 42ns -> 13 ns.
SkSharedMutex and SkSpinlock have the same performance.
It also removes specialized windows and linux/mac code.
BUG=skia:
Review URL: https://codereview.chromium.org/1359733002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1307863009
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1348173003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1285973003
|
|
|
|
|
|
| |
BUG=skia:4050
Review URL: https://codereview.chromium.org/1232003008
|
|
|
|
|
|
| |
BUG=skia:3997
Review URL: https://codereview.chromium.org/1213663004
|
|
BUG=skia:
Review URL: https://codereview.chromium.org/1215503005
|