aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkMatrix44.cpp
Commit message (Collapse)AuthorAge
* Fix argument names and documentation for SkMatrix44::set3x3()Gravatar Brian Osman2018-04-20
| | | | | | | | | | | | | | | Column-major is an implementation choice, not an interface. There is exactly one acceptable subscript notation for indexing matrix elements, and it's row first, then column. Having these named backwards was unnecessarily confusing. Note that this doesn't alter behavior in any way, it just brings this function in line with expectations from any reasonable mathematician. Change-Id: Ie4ceb40281ef507889d25403afbf24116514c45a Reviewed-on: https://skia-review.googlesource.com/122790 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Make SkMatrix44:dump() print out a recognizable matrix.Gravatar Mike Klein2016-12-01
| | | | | | | Change-Id: I7b64d8aee335eef39924ab65f46f196892ea2a39 Reviewed-on: https://skia-review.googlesource.com/5465 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix storage of gamut transform matrices in SkColorSpaceGravatar brianosman2016-09-09
| | | | | | | | | | | | | | | We were effectively storing the transpose, which made all of our operations on individual colors, and our concatenation of matrices awkward and backwards. I'm planning to push this further into Ganesh, where I had incorrectly adjusted to the previous layout, treating colors as row vectors in the shaders. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324843003 Review-Url: https://codereview.chromium.org/2324843003
* SkMatrix44 clarifications and clean-upsGravatar msarett2016-06-23
| | | | | | | | | | | | | | Fixed row/col major bug and added comments to the header. Made SkMatrix::I() thread safe using constexpr. Added a test set3x3RowMajorf(). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2098583002 Review-Url: https://codereview.chromium.org/2098583002
* Enable flattening and unflattening of SkColorSpaceGravatar msarett2016-06-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085653003 Review-Url: https://codereview.chromium.org/2085653003
* return 4x4 matrix from SkColorSpaceGravatar reed2016-05-03
move SkMatrix44 into core (with alias in utils to transition chrome) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1943833002 Review-Url: https://codereview.chromium.org/1943833002