aboutsummaryrefslogtreecommitdiffhomepage
path: root/public.bzl
Commit message (Collapse)AuthorAge
* rm guard for google3Gravatar Mike Reed2018-03-15
| | | | | | | | Bug: skia: Change-Id: I86495e0fefff2dbd34e39e3a0be891bfc62ec08b Reviewed-on: https://skia-review.googlesource.com/114581 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* hide SkBlurMaskFilter and SkBlurQualityGravatar Mike Reed2018-03-14
| | | | | | | | | | SK_SUPPORT_LEGACY_BLURMASKFILTER Bug: skia: Change-Id: Ic3e27e08e6e3cd2ffc1cd13b044e197bebc96236 Reviewed-on: https://skia-review.googlesource.com/113940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Remove dm excludes from public.bzl.Gravatar Ben Wagner2018-03-07
| | | | | | | | | | Several text tests are excluded from dm, presumably because previously there were no fonts. Now that there are, these tests pass. Change-Id: I5cb30cc5658ab77294ac4479902c932ddf490289 Reviewed-on: https://skia-review.googlesource.com/112721 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Add "--nonativeFonts" to public.bzl for running dm.Gravatar Ben Wagner2018-03-06
| | | | | | | | | | We don't know under what conditions dm will run or which fontmgr will be available, so run it with its own default portable font manager. Change-Id: I050e0b8e3d7c265ca7ef6d1b64b2fb9dc8350e82 Reviewed-on: https://skia-review.googlesource.com/112600 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* prepare Google3 for the return of SkOpts_hsw.cppGravatar Mike Klein2018-02-27
| | | | | | | | | | | Will follow up with a Google3 CL to hook up the other side. c.f. https://skia-review.googlesource.com/c/skia/+/110641 for why. That CL takes care of Chromium and Android inline. Change-Id: I0a83ced632f5f3079174a4d4b29c1ecd523d67de Reviewed-on: https://skia-review.googlesource.com/110760 Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Add nativeFonts flag to Viewer.Gravatar Ben Wagner2018-02-21
| | | | | | | | | | | This moves DMFontMgr and several related files which are tightly related to fonts into tools/fonts, moves some flags around to prevent duplication, and adds the nativeFonts handling to Viewer. Change-Id: Id1bdad708a6b74319ac5ac9adfe21025db4ca0b2 Reviewed-on: https://skia-review.googlesource.com/108904 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Reland "remove third_party/etc1"Gravatar Mike Klein2018-02-20
| | | | | | | | | | | | | | | | | | | This is a reland of 9d7a73527a6df7d3523e93a6a1f964df08b94510. Original change's description: > remove third_party/etc1 > > Nothing seems to reference it. > > Change-Id: Ib009a7dc33d31439b11588758015a07485f56eaa > Reviewed-on: https://skia-review.googlesource.com/99861 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> Change-Id: I3a6428074896c7b3c80cb23db61f70d7cb0c785f Reviewed-on: https://skia-review.googlesource.com/108460 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove unused SkpSkGrTest.cppGravatar Greg Daniel2018-02-08
| | | | | | | | | | | Doesn't look like this is used or even built anymore. If we ever find a future use for it we can add it back. Bug: skia: Change-Id: I736df90d984756b2dd14d95e8e5b4f3ec72ce8f7 Reviewed-on: https://skia-review.googlesource.com/105602 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "remove third_party/etc1"Gravatar Mike Klein2018-01-26
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9d7a73527a6df7d3523e93a6a1f964df08b94510. Reason for revert: still used by Fiber in Google3 Original change's description: > remove third_party/etc1 > > Nothing seems to reference it. > > Change-Id: Ib009a7dc33d31439b11588758015a07485f56eaa > Reviewed-on: https://skia-review.googlesource.com/99861 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,robertphillips@google.com Change-Id: I12b950931f0680576faefd1907a26afe22cf680f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/100460 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove third_party/etc1Gravatar Mike Klein2018-01-26
| | | | | | | | | Nothing seems to reference it. Change-Id: Ib009a7dc33d31439b11588758015a07485f56eaa Reviewed-on: https://skia-review.googlesource.com/99861 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* [bazel] Add third_party to skia_all_hdrsGravatar Ben Wagner2018-01-24
| | | | | | | | No-Try: true Change-Id: I15d274bb7c63a3ddfd1d9143b472454cffcf0644 Reviewed-on: https://skia-review.googlesource.com/99541 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* remove SK_SUPPORT_LEGACY_RECTMAKELARGEST flagGravatar Mike Reed2018-01-11
| | | | | | | Bug: skia: Change-Id: Ic36f1282d23f3f92b250e44685149505cad74bf2 Reviewed-on: https://skia-review.googlesource.com/93423 Reviewed-by: Mike Reed <reed@google.com>
* move largest apis into privateGravatar Mike Reed2018-01-08
| | | | | | | | | Related to https://skia-review.googlesource.com/c/skia/+/91860 Bug: skia: Change-Id: Ia8fd981b422bbab75541b078277d2e09e1fc9d41 Reviewed-on: https://skia-review.googlesource.com/91940 Reviewed-by: Brian Salomon <bsalomon@google.com>
* remove guard for new memory porting layerGravatar Mike Reed2018-01-06
| | | | | | | | Bug: skia: Change-Id: I14f1b421bc4055ea5a7c22735b2605eb883e4f81 Reviewed-on: https://skia-review.googlesource.com/91462 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* begin cleanup of malloc porting layerGravatar Mike Reed2018-01-05
| | | | | | | | | | | | | | 1. Merge some of the allocators into sk_malloc_flags by redefining a flag to mean zero-init 2. Add more private helpers to simplify our call-sites (and handle some overflow mul checks) 3. The 2-param helpers rely on the saturating SkSafeMath::Mul to pass max_size_t as the request, which should always fail. Bug:508641 Change-Id: I322f1e6ed91113467e0fdb12c91c3dad33d890c8 Reviewed-on: https://skia-review.googlesource.com/90940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Revert "add flag to fix google3"Gravatar Mike Reed2017-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3eec5f322b51c2565d4a1c99b7b5fcb0eb91bf9c. Reason for revert: google3 updated Original change's description: > add flag to fix google3 > > Bug: skia: > Change-Id: Icbaf4737d4f8d45c969811cebc53da20b0f5d954 > Reviewed-on: https://skia-review.googlesource.com/88422 > Reviewed-by: Mike Reed <reed@google.com> TBR=reed@google.com Change-Id: I07f9334d0531cf18a6e76a6f9177808ba3310a09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/88600 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* add flag to fix google3Gravatar Mike Reed2017-12-21
| | | | | | | Bug: skia: Change-Id: Icbaf4737d4f8d45c969811cebc53da20b0f5d954 Reviewed-on: https://skia-review.googlesource.com/88422 Reviewed-by: Mike Reed <reed@google.com>
* GOOGLE3 -> SK_BUILD_FOR_GOOGLE3Gravatar Mike Klein2017-12-19
| | | | | | | | | | | | | This is more consistent with our other SK_BUILD_FOR_... macros, and less likely to collide with other preprocessor logic. (Luckily, this was defined in public.bzl, so we can do this all in one CL in the Skia repo.) Change-Id: I5f232888288c9c53fad445545d983d0fb0b4add8 Reviewed-on: https://skia-review.googlesource.com/86940 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code""Gravatar Mike Reed2017-12-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 800f5541bb0f4ea0f6923592355bdb64f156d8b3. Reason for revert: google3 updated Original change's description: > Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code" > > This reverts commit 7f846f273ceaa5a3a8880e9af260f94bd1e614b6. > > Reason for revert: missed callsite in google3 > > Original change's description: > > remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code > > > > Bug: skia: > > Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2 > > Reviewed-on: https://skia-review.googlesource.com/85500 > > Commit-Queue: Mike Reed <reed@google.com> > > Reviewed-by: Hal Canary <halcanary@google.com> > > TBR=halcanary@google.com,reed@google.com > > Change-Id: I232dc24831bd8d52e9cbbc7ee58177af0617574a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/85600 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=halcanary@google.com,reed@google.com Change-Id: I6ccd032caf87020cba8d515ffb25d07b87267363 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/86101 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code"Gravatar Mike Reed2017-12-15
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7f846f273ceaa5a3a8880e9af260f94bd1e614b6. Reason for revert: missed callsite in google3 Original change's description: > remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code > > Bug: skia: > Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2 > Reviewed-on: https://skia-review.googlesource.com/85500 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Hal Canary <halcanary@google.com> TBR=halcanary@google.com,reed@google.com Change-Id: I232dc24831bd8d52e9cbbc7ee58177af0617574a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/85600 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead codeGravatar Mike Reed2017-12-15
| | | | | | | | Bug: skia: Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2 Reviewed-on: https://skia-review.googlesource.com/85500 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Moving extra options/parameters into PDFMetadataGravatar Mike Reed2017-12-14
| | | | | | | | Bug: skia: Change-Id: I29aa69e5765a7f8ba05b0361912d1f5276d77de3 Reviewed-on: https://skia-review.googlesource.com/84501 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Mike Reed <reed@google.com>
* clean up float-cast-overflow blacklistGravatar Mike Klein2017-12-13
| | | | | | | | | | These should be free of overflows now. Bug: skia:7052 Change-Id: I05118fb8f565ffb0d973b6d93a8cd8d8e27f31a9 Reviewed-on: https://skia-review.googlesource.com/84561 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix Google3 link errors(?)Gravatar Brian Salomon2017-12-11
| | | | | | | Change-Id: If2d689dd34065fa5e71808170164adcb97580c75 Reviewed-on: https://skia-review.googlesource.com/83563 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add GrGLMakeNativeInterface factory that returns sk_sp<const GrGLInterface>.Gravatar Brian Salomon2017-12-11
| | | | | | | | | | | | | | | Removes the concept of a configurable "default" interface and makes the default always be the "native" interface. Also removes unused functions: GrGLInterfaceAddTestDebugMarker and GrGLInterface::NewClone. Keeps around legacy GrGLCreateNativeInterface() until clients can be weened. Change-Id: I4a3bdafa8cf8c68ed13318393abd55686b045ccb Reviewed-on: https://skia-review.googlesource.com/83000 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Exclude tools/gpu/atlastext from public.bzlGravatar Brian Salomon2017-11-19
| | | | | | Change-Id: I6506519860d48417d525c48e1e60a4eb6e5070d9 Reviewed-on: https://skia-review.googlesource.com/73560 Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Revert "Add Atlas Text interface for rendering SDF glyphs.""Gravatar Brian Salomon2017-11-19
| | | | | | | | | | This reverts commit 9c2202ffc22b4293b48a4edeafa1b5d2bab8bb83. Bug: skia: Change-Id: I482ddf74f8e40d3d0908c840ba5c6ff981ccefbd Reviewed-on: https://skia-review.googlesource.com/73345 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Drop support for OSMesa in test tools and remove build botGravatar Brian Salomon2017-11-13
| | | | | | | | Change-Id: Ic85ee05fe292a36a053ca7a20ccce24a4da4fae2 Reviewed-on: https://skia-review.googlesource.com/70026 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* move Sk{Test,Random}ScalerContext to toolsGravatar Mike Klein2017-11-10
| | | | | | | | | There's no need for Skia users to link this test code. Change-Id: I9d6ef2a053d0cf5cb916aa254389ca819c48bae1 Reviewed-on: https://skia-review.googlesource.com/69922 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* clean up cruft about --portableFonts and --resourceFontsGravatar Mike Klein2017-11-06
| | | | | | | | | | --portableFonts exists but does nothing. --resourceFonts doesn't even exist. Change-Id: I7880208de4aaa9674ba720b9e70c34c145561ac0 Reviewed-on: https://skia-review.googlesource.com/67800 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* remove SkThread, using std::thread insteadGravatar Mike Klein2017-10-30
| | | | | | | Change-Id: I871dd5eea4496e87c206b46d9eae81cb521b11ce Reviewed-on: https://skia-review.googlesource.com/65103 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* support Clang 3.8 and -no-integrated-asGravatar Mike Klein2017-10-24
| | | | | | Change-Id: I7eb3ef28513858446de4392044785bd3148e7aa5 Reviewed-on: https://skia-review.googlesource.com/63262 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Synchronize public.bzl float-cast-overflow omit list with test.py.Gravatar Ben Wagner2017-10-18
| | | | | | | | No-Try: true Change-Id: If4320eae12e4967ee59a230549bbd34fca2fed94 Reviewed-on: https://skia-review.googlesource.com/60883 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [Bazel] Separate OS and CPU dimensions in Skia sources.Gravatar Ben Wagner2017-10-17
| | | | | | | | | | | | | Patching from internal cl/171888276. No-Try: true Change-Id: I6919769ad4e367ded394f1094944cea2b3901fd0 Reviewed-on: https://skia-review.googlesource.com/60583 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove legacy computeByteSize flag, now returns max_size_tGravatar Mike Reed2017-10-09
| | | | | | | Bug: skia: Change-Id: Ia2f2627ba4ea81e715f27e94d900951ba5e19f79 Reviewed-on: https://skia-review.googlesource.com/57106 Reviewed-by: Mike Reed <reed@google.com>
* Revert "Revert "change computeByteSize to return max_size_t on overflow""Gravatar Mike Reed2017-10-09
| | | | | | | | | | | This reverts commit 384f0a7d6626026f21313e85e51890d747171ee8. Bug: skia: Change-Id: I392ef5c1a5172181caf81ae270befeba6e778241 Reviewed-on: https://skia-review.googlesource.com/57084 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert "change computeByteSize to return max_size_t on overflow"Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 24295462722fd5a298d108a80b0aacbb0964da53. Reason for revert: broke running dm on google3 Original change's description: > change computeByteSize to return max_size_t on overflow > > Bug: skia:7132 > Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf > Reviewed-on: https://skia-review.googlesource.com/56620 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=bungeman@google.com,herb@google.com,reed@google.com Change-Id: I5f58ec37241d2fae3ebdb7a3d6b41f9fd6d3c2ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7132 Reviewed-on: https://skia-review.googlesource.com/56880 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* change computeByteSize to return max_size_t on overflowGravatar Mike Reed2017-10-06
| | | | | | | | Bug: skia:7132 Change-Id: I41045640ee62b2c988a84370ead5034bbccc6daf Reviewed-on: https://skia-review.googlesource.com/56620 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "remove guard for computeByteSize api""Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 297e4d3f2763f5163011afceff59b2a685aa7965. Reason for revert: landed fix in google3 Original change's description: > Revert "remove guard for computeByteSize api" > > This reverts commit d72747c5c3b3aaaa9e5957242bd478980cac942e. > > Reason for revert: broke //htmlrender/webkit_headless/engine/testing:platform_web_unittests > > Original change's description: > > remove guard for computeByteSize api > > > > Bug: skia: > > Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665 > > Reviewed-on: https://skia-review.googlesource.com/56402 > > Reviewed-by: Mike Reed <reed@google.com> > > TBR=reed@google.com,reed@chromium.org > > Change-Id: If721607583204df9f32e54a041ecc8b34ad1a749 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/56321 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=reed@google.com,reed@chromium.org Change-Id: I6d26a8623122e69af550d9a257c21943fe70b9f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56640 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "remove guard for computeByteSize api"Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d72747c5c3b3aaaa9e5957242bd478980cac942e. Reason for revert: broke //htmlrender/webkit_headless/engine/testing:platform_web_unittests Original change's description: > remove guard for computeByteSize api > > Bug: skia: > Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665 > Reviewed-on: https://skia-review.googlesource.com/56402 > Reviewed-by: Mike Reed <reed@google.com> TBR=reed@google.com,reed@chromium.org Change-Id: If721607583204df9f32e54a041ecc8b34ad1a749 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56321 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove guard for computeByteSize apiGravatar Mike Reed2017-10-06
| | | | | | | Bug: skia: Change-Id: I5c66a7c79c4e71ec82194e8d37de04a516028665 Reviewed-on: https://skia-review.googlesource.com/56402 Reviewed-by: Mike Reed <reed@google.com>
* Revert[4] "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"Gravatar Mike Reed2017-10-03
| | | | | | | | | | This reverts commit 5a2e50edc51006ce91366e177a9d21a16775d7fd. Bug: skia: Change-Id: I8d28b5c07d90130e5a1653923740eaf189ecb954 Reviewed-on: https://skia-review.googlesource.com/53900 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "Revert "guard old apis for querying byte-size of a ↵Gravatar Mike Reed2017-10-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bitmap/imageinfo/pixmap""" This reverts commit cd284c532376d16fcc4ed75baf3da65c3e4a2e95. Reason for revert: assert fired in SkMallocPixelRef.cpp:61: fatal error: "assert(info.computeByteSize(rowBytes) == info.getSafeSize(rowBytes))" google3 thinks it was from surface_rowbytes Original change's description: > Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"" > > This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0. > > Bug: skia: > Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d > Reviewed-on: https://skia-review.googlesource.com/52665 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> TBR=fmalita@chromium.org,reed@google.com Change-Id: I41e3f7a3f791cc8183291847e783ed8a53bc91d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/53802 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "guard old apis for querying byte-size of a ↵Gravatar Mike Reed2017-10-02
| | | | | | | | | | | | bitmap/imageinfo/pixmap"" This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0. Bug: skia: Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d Reviewed-on: https://skia-review.googlesource.com/52665 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"Gravatar Jim Van Verth2017-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 88757dacd4f532a0f647c02ae0ee596d31ab5c68. Reason for revert: Still seems to be failing Chromium "telemetry_perf_unittests (with patch) on Android" on android_n5x_swarming_rel. Original change's description: > guard old apis for querying byte-size of a bitmap/imageinfo/pixmap > > Now with legacy behavior for allocpixels > > This was reverted, so the current CL is a "fix" on top of ... > https://skia-review.googlesource.com/c/skia/+/50980 > > Related update to Chrome (in preparation for this change) > https://chromium-review.googlesource.com/c/chromium/src/+/685719 > > Bug: skia: > Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9 > Reviewed-on: https://skia-review.googlesource.com/51341 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@google.com> TBR=fmalita@chromium.org,reed@google.com Change-Id: I827a0ca1d1e3909e648fde3342cdb8601d34da8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/52381 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* guard old apis for querying byte-size of a bitmap/imageinfo/pixmapGravatar Mike Reed2017-09-27
| | | | | | | | | | | | | | | | Now with legacy behavior for allocpixels This was reverted, so the current CL is a "fix" on top of ... https://skia-review.googlesource.com/c/skia/+/50980 Related update to Chrome (in preparation for this change) https://chromium-review.googlesource.com/c/chromium/src/+/685719 Bug: skia: Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9 Reviewed-on: https://skia-review.googlesource.com/51341 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"Gravatar Greg Daniel2017-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 98a6216b18b57c2f7a0d58f542c60503686aed69. Reason for revert: breaking the chrome roll. Looks like they may be writing data to create an image across all the row bytes and thus writing to unalloced data on the last row. Link to example failing bot: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/539960 Original change's description: > guard old apis for querying byte-size of a bitmap/imageinfo/pixmap > > Previously we had size_t and uint64_t variations. > > The new (simpler) API always.. > - returns size_t, or 0 if the calculation overflowed > - returns the trimmed size (does not include rowBytes padding for the last row) > > Bug: skia: > Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e > Reviewed-on: https://skia-review.googlesource.com/50980 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Leon Scroggins <scroggo@google.com> TBR=mtklein@google.com,herb@google.com,scroggo@google.com,fmalita@chromium.org,reed@google.com Change-Id: I726f6ab1b36b14979ba6f37105e0a469b3f0dbc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/51262 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* guard old apis for querying byte-size of a bitmap/imageinfo/pixmapGravatar Mike Reed2017-09-26
| | | | | | | | | | | | | | | Previously we had size_t and uint64_t variations. The new (simpler) API always.. - returns size_t, or 0 if the calculation overflowed - returns the trimmed size (does not include rowBytes padding for the last row) Bug: skia: Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e Reviewed-on: https://skia-review.googlesource.com/50980 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Revert "Revert "try to remove google3 flag""Gravatar Mike Reed2017-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c86d0794ed37c69dad8b967c53ebd8f504167e45. Reason for revert: google3 updated Original change's description: > Revert "try to remove google3 flag" > > This reverts commit f0317e603a1c945d60e448ce2c9e6053817649df. > > Reason for revert: breaks headless webkit, fix on the way > > Original change's description: > > try to remove google3 flag > > > > Bug: skia: > > Change-Id: I8baaf48e366932e3a90d0db57279201025c4d2b6 > > Reviewed-on: https://skia-review.googlesource.com/48182 > > Reviewed-by: Mike Reed <reed@google.com> > > TBR=mtklein@google.com,reed@google.com,reed@chromium.org > > Change-Id: Ic331e8707531c970b577314db997b372356e6439 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/48320 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=mtklein@google.com,reed@google.com,reed@chromium.org Change-Id: I09a706b2035b6c52087b1a3f26fc2c97d17c712b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/48480 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "try to remove google3 flag"Gravatar Mike Reed2017-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f0317e603a1c945d60e448ce2c9e6053817649df. Reason for revert: breaks headless webkit, fix on the way Original change's description: > try to remove google3 flag > > Bug: skia: > Change-Id: I8baaf48e366932e3a90d0db57279201025c4d2b6 > Reviewed-on: https://skia-review.googlesource.com/48182 > Reviewed-by: Mike Reed <reed@google.com> TBR=mtklein@google.com,reed@google.com,reed@chromium.org Change-Id: Ic331e8707531c970b577314db997b372356e6439 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/48320 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-23 02:05:12 +0000