aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra
Commit message (Collapse)AuthorAge
* Fix Seal_of_Mississippi URL and update version of SVG asset.Gravatar rmistry2016-09-16
| | | | | | | | | BUG=skia:5757 BUG=skia:5767 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342323002 Review-Url: https://codereview.chromium.org/2342323002
* GN: enable Vulkan on Android when API >= 24.Gravatar mtklein2016-09-16
| | | | | | | | | | | Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'. If for some reason you wanted to turn it off, you can still override skia_use_vulkan. The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003 Review-Url: https://codereview.chromium.org/2347843003
* GN: port Valgrind bots.Gravatar mtklein2016-09-15
| | | | | | | | | This was suspiciously easy... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342923002 Review-Url: https://codereview.chromium.org/2342923002
* Revert of Update version of SVG asset (patchset #1 id:1 of ↵Gravatar djsollen2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2341043003/ ) Reason for revert: breaking the build Original issue's description: > Update version of SVG asset > > BUG=skia:5757 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003 > > Committed: https://skia.googlesource.com/skia/+/ab00f4222c9fff8c08873e1218e79f49845f95a1 TBR=borenet@google.com,rmistry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5757 Review-Url: https://codereview.chromium.org/2337763007
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot Review-Url: https://codereview.chromium.org/2340463008
* Update version of SVG assetGravatar rmistry2016-09-15
| | | | | | | BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003 Review-Url: https://codereview.chromium.org/2341043003
* Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of ↵Gravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2340463008/ ) Reason for revert: https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304 Original issue's description: > GN: support 32-bit x86 builds > > Take over Ubuntu -x86- bots. > > Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. > We'll want target_cpu="x86" there too. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 > > Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 TBR=jcgregorio@google.com,borenet@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2338173004
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Review-Url: https://codereview.chromium.org/2340463008
* Blacklist slsrgb + image decoding.Gravatar mtklein2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345723003 Review-Url: https://codereview.chromium.org/2345723003
* Add ability to create and upload SVGs from a local dirGravatar rmistry2016-09-15
| | | | | | | BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346663003 Review-Url: https://codereview.chromium.org/2346663003
* Fix NoGPU bot, which is compiling in GPU supportGravatar borenet2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342683003 Review-Url: https://codereview.chromium.org/2342683003
* Pass rietveld as the default patch_storage.Gravatar mtklein2016-09-15
| | | | | | | | | | | | Passing around empty strings as command line arguments requires us to be really careful about command line quoting, parsing, etc. It seems easy enough here to just supply the implied value. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003 Review-Url: https://codereview.chromium.org/2323233003
* Tidy up DM blacklists.Gravatar mtklein2016-09-15
| | | | | | | | | | | No need to blacklist specific instances of configs that won't be run. There's no bug or anything here... this is entirely about keeping the command lines as noise-free as possible. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341963003 Review-Url: https://codereview.chromium.org/2341963003
* Roll recipe DEPSGravatar rmistry2016-09-15
| | | | | | | | BUG=skia:5749 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2339443003
* CQ updateGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | | | | - swap the N5 experiment over to the new GN N5 bot - cut down on the Windows build duplication: the other two bots cover x86, x86-64, Release, Debug, _and_ Vulkan already. - remove the Release-Shared tester: I added this bot to act as a proxy for the also Shared-build Android bots, but 1) they're fast enough to no longer need a proxy (see N5 above) and 2) they're no longer Shared builds. I intend to completely drop support for dm and nanobench in Shared builds, so this bot will not just drop from the CQ but completely disappear. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346463002 Review-Url: https://codereview.chromium.org/2346463002
* merge run and check-rc stepsGravatar mtklein2016-09-14
| | | | | | | | | | | This'll make the 'dm' or 'nanobench' step go red like you'd hope. The N5 should pass and the N10 and N7 should fail, showing us both sides. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003 Review-Url: https://codereview.chromium.org/2339713003
* 565 is not this important.Gravatar mtklein2016-09-14
| | | | | | | | | | Reduce its testing and perfing to just the fast Linux bots, and remove it from the default set of dm/nanobench configs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002 Review-Url: https://codereview.chromium.org/2344553002
* update derive_compile_bot_name() for GN_Android_VulkanGravatar mtklein2016-09-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005 Review-Url: https://codereview.chromium.org/2336233005
* Android GN scripts: distingush directories for data and binaries.Gravatar mtklein2016-09-14
| | | | | | | | | This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004 Review-Url: https://codereview.chromium.org/2335203004
* Update gn_android_flavor for Vulkan.Gravatar mtklein2016-09-13
| | | | | | | | | C.f. https://codereview.chromium.org/2336343002 for basic GN support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004 Review-Url: https://codereview.chromium.org/2333293004
* Android GN: don't reboot before runningGravatar mtklein2016-09-13
| | | | | | | | | We're already rebooting after running, so we should already be ready to go when the task starts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003 Review-Url: https://codereview.chromium.org/2334223003
* Remove clear /data/local/tmp steps.Gravatar mtklein2016-09-13
| | | | | | | | | | | | | | | | | | | These were intended to prevent GN and GYP Android bots from stomping on each other. Turns out, they don't, even without this... they're writing most files to completely separate paths: - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher) in /data/local/tmp; - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench) don't overlap GYP's. So clearing /data/local/tmp was essentially just removing GN's data; GYP's data file caching was never affected and can't conflict with GN's. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002 Review-Url: https://codereview.chromium.org/2340473002
* Implement Fill() for incomplete decodes to RGBA_F16Gravatar msarett2016-09-13
| | | | | | | | | Before this patch, we would hit an SkASSERT(false). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203002 Review-Url: https://codereview.chromium.org/2335203002
* Add Nexus5 to CQ as an experimentGravatar kjlubick2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332353002 Review-Url: https://codereview.chromium.org/2332353002
* I missed an infra_step, pushing directories.Gravatar mtklein2016-09-13
| | | | | | | | | NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337793003 Review-Url: https://codereview.chromium.org/2337793003
* Mark infra steps as infra_step in GN recipe flavors.Gravatar mtklein2016-09-13
| | | | | | | | | NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329943004 Review-Url: https://codereview.chromium.org/2329943004
* Add back the GalaxyS3 and GalaxyS4 entries in recipesGravatar borenet2016-09-12
| | | | | | | | | | S3 is needed for some recipe simulation stuff and in general having these present does not hurt us. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003 Review-Url: https://codereview.chromium.org/2336513003
* GN: Android perf/testsGravatar mtklein2016-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone. All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts. The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell. Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away. Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware. The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today. It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other. The marked parts can go away when bots are either gn_ or non-gn_ but not both. I have omitted a few steps that may be important, but which are easy independent follow-ups: - running as root - locking clocks - waiting on battery levels - fancier wait-for-ready than adb wait-for-usb-device It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy. I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later. As of PS 41 or so, it looks like the trybots are all behaving as expected. We should expect no new images in Gold. Can we see trybots in Perf yet? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320153002 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot Review-Url: https://codereview.chromium.org/2320153002
* Fix device cfg for GalaxyS7Gravatar borenet2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330093002 Review-Url: https://codereview.chromium.org/2330093002
* Run recipes.py with --timestampsGravatar borenet2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330123002 Review-Url: https://codereview.chromium.org/2330123002
* Update SKP versionGravatar update-skps2016-09-11
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334483002 Review-Url: https://codereview.chromium.org/2334483002
* Fix issues in assets scriptsGravatar borenet2016-09-09
| | | | | | | | | | - Delete unconditionally uses 'gsutil' - args.gsutil not plumbed properly BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326663002 Review-Url: https://codereview.chromium.org/2326663002
* Fix strange failures on Android NGravatar kjlubick2016-09-08
| | | | | | | | | | | We were seeing problems where dm ended with exit code 0, but the step still failed. It seems they changed what N returns when a thing completes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319843003 TBR=bugsbunny Review-Url: https://codereview.chromium.org/2319843003
* most is fine for *SAN bots nowGravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326553002 Review-Url: https://codereview.chromium.org/2326553002
* Clean up target_os=llvm now that it does nothing.Gravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004 Review-Url: https://codereview.chromium.org/2317373004
* GN: add sanitize argGravatar mtklein2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Attempt to take over all *SAN builds. MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py. I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier to use locally. The compile steps should be much faster now. We no longer build CMake and Clang for every run, instead using the clang_linux CIPD package. This removes the need for all the third_party/externals/llvm/... dependencies. Similarly, since we're using the clang_linux package, we no longer depend on Chrome's Clang, and thus no longer need to sync chromium on these bots. Instead of packaging up MSAN libraries and llvm-symbolizer in the compile output, I have the test / perf bots also depend on the clang_linux package. These do not vary from build to build. No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja all track changes to xsan.blacklist without our help. This has the incidental effect of upgrading the compiler used by *SAN bots from Clang 3.8 to Clang 3.9. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002 Review-Url: https://codereview.chromium.org/2289343002
* Asset management: Download from GS store instead of CIPDGravatar borenet2016-09-08
| | | | | | | | | This avoids strange CIPD symlink/permissions issues BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321623003 Review-Url: https://codereview.chromium.org/2321623003
* GN: do not set default GN argsGravatar mtklein2016-09-08
| | | | | | | | | | It's just visual noise... this should make future gn_flavor.py changes show fewer incidental diffs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002 Review-Url: https://codereview.chromium.org/2324573002
* Add color xform support to SkWebpCodecGravatar msarett2016-09-08
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b Review-Url: https://codereview.chromium.org/2294993002
* Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of ↵Gravatar msarett2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2294993002/ ) Reason for revert: Windows bots hate it when I upload new images. Original issue's description: > Add color xform support to SkWebpCodec > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 > > Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b TBR=scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2318253004
* Add color xform support to SkWebpCodecGravatar msarett2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 Review-Url: https://codereview.chromium.org/2294993002
* clang_linux: also build an MSAN libc++Gravatar mtklein2016-09-07
| | | | | | | | | | This will be used by MSAN bots: build with -stdlib=libc++, then run with LD_LIBRARY_PATH=/path/to/clang_linux/msan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324503002 Review-Url: https://codereview.chromium.org/2324503002
* Run install-sysroot script before 'gn gen' on PDFium botGravatar borenet2016-09-07
| | | | | | | BUG=skia:5727 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317013002 Review-Url: https://codereview.chromium.org/2317013002
* Add 6p to other device mappingGravatar kjlubick2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319593002 Review-Url: https://codereview.chromium.org/2319593002
* New gamut GM, to test gamut conversion in various code-pathsGravatar brianosman2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | After several different strategies, this one appears to work well. The basic test: 1) For a variety of drawing techniques, we render fixed size rectangles. (Solid colors via paint color, bitmap, etc...) 2) For each method in #1, we render to both an sRGB and WideGamutRGB offscreen surface. (AdobeRGB isn't wide enough to clearly demonstrate if things are working or not). 3) Use readPixels to fetch the raw (still in wide gamut) pixel data, then draw that directly to the final canvas. So, for each pair of squares, they should look clearly different. Currently, with the GPU backend, only the bicubic bitmap paths have that behavior. Adding more test cases (and fixing the ones that are already incorrect) will be the long tail of gamut transformation. Current output (with my other patchset, which fixes all bitmap draws): https://screenshot.googleplex.com/wsL3x7eCtWE.png BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293173002 Review-Url: https://codereview.chromium.org/2293173002
* GN: turn off ccacheGravatar mtklein2016-09-07
| | | | | | | | | | | | | | I just burned 2 days debugging a confusing interaction between ccache and the -fsanitize-blacklist argument to Clang. Let's see if we can live without ccache (swarming affinity + Ninja seems pretty decent). As a point of reference, the Mac bots have been looking for ccache but failing to find it. They're proof this will be fine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2310063003 Review-Url: https://codereview.chromium.org/2310063003
* Update Windows build to use VULKAN_SDK rather than VK_SDK_PATHGravatar bsalomon2016-09-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318633002 Review-Url: https://codereview.chromium.org/2318633002
* Add device mapping for Nexus 6p (angler)Gravatar kjlubick2016-09-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311253002 Review-Url: https://codereview.chromium.org/2311253002
* Update SKP versionGravatar update-skps2016-09-04
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311643002 Review-Url: https://codereview.chromium.org/2311643002
* pdfium: Fix the pdfium builder.Gravatar jcgregorio2016-09-02
| | | | | | | BUG=skia:5715 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300703007 Review-Url: https://codereview.chromium.org/2300703007