| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
| |
Needed for the CQ to see Gerrit. Eg:
https://cs.chromium.org/chromium/tools/depot_tools/infra/config/cq.cfg?q=cq.cfg&sq=package:chromium&dr=C&l=9
BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2251643005
Review-Url: https://codereview.chromium.org/2251643005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding flags to the end of cc or cxx is pretty useful, but these always end up
on the command line before the GN generated flags, thus setting defaults that
GN will override.
For full flexibility we want to be able to add flags after the flags GN has
added, so that custom flags can override _it_.
I've updated the Fast bots with an example here: if we said cc="clang -O3 ...",
that '-O3' would be overriden later by the default Release-mode '-Os'. By
putting it in extra_cflags, we get the last word: our '-O3' overrides the
default '-Os'.
Another good use case is a hypothetical Actually-Shippable-Release mode. Our
Release mode bundles in tons of debug symbols via '-g'. libskia.a is about 10x
larger than it needs to be when built that way, but it helps us debug the bot
failures immensely. To build a libskia.{a,so} that you'd really ship, you can
now set extra_cflags="-g0" to override '-g'. You could set '-march' flags there
too, '-fomit-frame-pointer', etc.
There are lots of flags that won't matter where they end up in the command line.
To keep everything simple I've put them in extra_cflags with the rest. This means
the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241263003
Review-Url: https://codereview.chromium.org/2241263003
|
|
|
|
|
|
|
|
|
|
| |
Temporary suppression, pending bug fix.
BUG=skia:5636
R=robertphillips@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249763002
Review-Url: https://codereview.chromium.org/2249763002
|
|
|
|
|
|
|
|
|
| |
Follow up to https://codereview.chromium.org/2246943002/.
R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247903002
Review-Url: https://codereview.chromium.org/2247903002
|
|
|
|
|
|
|
|
|
|
| |
Group opacity support. Unlike the other presentation attributes we
support thus far, group opacity is not inherited.
R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002
Review-Url: https://codereview.chromium.org/2246943002
|
|
|
|
|
|
|
|
| |
BUG=skia:5641
TBR=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249523004
Review-Url: https://codereview.chromium.org/2249523004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is at least one of the failures making the bot red.
The particular signal indicates it's probably an alignment problem.
BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245063002
CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-GCC-Nexus6-CPU-NEON-Arm7-Debug-Trybot
TBR=robertphillips@google.com
Review-Url: https://codereview.chromium.org/2245063002
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249443002
Review-Url: https://codereview.chromium.org/2249443002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237033002
Review-Url: https://codereview.chromium.org/2237033002
|
|
|
|
|
|
|
| |
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240153002
Review-Url: https://codereview.chromium.org/2240153002
|
|
|
|
|
|
|
|
|
|
| |
Currently only turned on for one bot. May turn it on for more after more conversations.
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002
Review-Url: https://codereview.chromium.org/2231943002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As an experiment, instead of replacing these with -GN twins, take
them over in-place. This should take over:
-FAST
-SKFOO
CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
Review-Url: https://codereview.chromium.org/2229463002
|
|
|
|
|
|
|
|
|
| |
Removing the SVG due to the reason in https://docs.google.com/document/d/1kYRvUxZTnm1tI_0bTU0BX9jqSSTqPUhGXJVcD3Rcg2c/edit?disco=AAAAAqQSPSc
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232003002
Review-Url: https://codereview.chromium.org/2232003002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003
Review-Url: https://codereview.chromium.org/2230853003
|
|
|
|
|
|
|
| |
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2235763002
Review-Url: https://codereview.chromium.org/2235763002
|
|
|
|
|
|
|
|
|
| |
Also move the isolate file and script from Chromium repo to the Skia repo.
BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002
Review-Url: https://codereview.chromium.org/2221413002
|
|
|
|
|
|
|
| |
BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221423002
Review-Url: https://codereview.chromium.org/2221423002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229433002
Review-Url: https://codereview.chromium.org/2229433002
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219873003
Review-Url: https://codereview.chromium.org/2219873003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- makeThreadsafe()
- fix up some alignment problems
- drawVertices / drawPatch
- work around drawPicture() + default paint bugs?
- turn on tests.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219343002
Review-Url: https://codereview.chromium.org/2219343002
|
|
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2220833002
Review-Url: https://codereview.chromium.org/2220833002
|
|
|
|
|
|
|
|
|
| |
Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003
Review-Url: https://codereview.chromium.org/2215443003
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002
Review-Url: https://codereview.chromium.org/2205473002
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002
Review-Url: https://codereview.chromium.org/2209423002
|
|
|
|
|
|
|
|
|
|
| |
This will allow me to run these tests in sRGB mode, while
leaving most of the image tests disabled.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006
Review-Url: https://codereview.chromium.org/2206953006
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002
Review-Url: https://codereview.chromium.org/2217523002
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API. As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002
Review-Url: https://codereview.chromium.org/2209343002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
- no more buildbot_spec.py step
- "real" dm and nanobench flags, instead of --dummy-flags
- some inconsequential stuff in visualbench, which is removed anyway.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002
Review-Url: https://codereview.chromium.org/2215803002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002
Review-Url: https://codereview.chromium.org/2211973002
|
|
|
|
|
|
|
|
|
|
|
|
| |
If no one objects to my "GN bot plan" email, this unblocks us from removing
a bunch of non-GN bots.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207073002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot
Review-Url: https://codereview.chromium.org/2207073002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/2213973002/ )
Reason for revert:
Think this is going to break Windows again.
Original issue's description:
> Update skimage VERSION: attempt 2
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002
>
> Committed: https://skia.googlesource.com/skia/+/d6dec3f4a1365d34e147234acf3c4a3629146457
TBR=borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2216523003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002
Review-Url: https://codereview.chromium.org/2213973002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/2211633002/ )
Reason for revert:
The CIPD package is broken
Original issue's description:
> Update to new skimage VERSION
> TBR=borenet@google.com
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002
>
> Committed: https://skia.googlesource.com/skia/+/52d1be5ca7b1ba8cc450be7dd6377ea5bb73386a
TBR=msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2216613002
|
|
|
|
|
|
|
|
| |
TBR=borenet@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002
Review-Url: https://codereview.chromium.org/2211633002
|
|
|
|
|
|
|
|
|
| |
This looks like another big change, but I really just moved blocks of code around. Again, no expectations diffs because no behavior is changed.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002
Review-Url: https://codereview.chromium.org/2198973002
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002
Review-Url: https://codereview.chromium.org/2200763002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Break Skia recipe module into:
- skia_vars: defines and stores variables (eg. paths)
- skia_step: utilities for running Skia steps
- skia_flavor: flavor-specific stuff
- skia: top-level setup, checkout, test/perf steps, etc etc
This establishes a saner dependency structure for the recipes; skia_vars
is at the bottom level, skia_step depends on it, skia_flavor depends on
both of them, skia depends on all of the above, and the recipes
themselves may depend on any or all of them.
Next steps:
- Merge buildbot_spec into skia_vars
- Move test_steps and perf_steps from skia recipe_module into
swarm_test and swarm_perf recipes
- Cleaner checkout_steps process
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002
Review-Url: https://codereview.chromium.org/2198173002
|
|
|
|
|
|
|
| |
BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002
Review-Url: https://codereview.chromium.org/2199273002
|
|
|
|
|
|
|
|
| |
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true
Review-Url: https://codereview.chromium.org/2202053005
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205863002
Review-Url: https://codereview.chromium.org/2205863002
|
|
|
|
|
|
|
|
|
|
| |
We'll need to add Perf.*Debug bots to achieve the same coverage.
BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189393002
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2189393002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002
Review-Url: https://codereview.chromium.org/2197643002
|
|
|
|
|
|
|
|
|
| |
This parallels the set of bots we use to gate commits already.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189283003
Review-Url: https://codereview.chromium.org/2189283003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.
(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002
TBR=jcgregorio@google.com
NOTRY=true
Review-Url: https://codereview.chromium.org/2193203002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To fix:
ERROR at the command-line "--args":1:34: Unexpected token '+'
is_debug=true cc=clang cxx=clang++
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003
Review-Url: https://codereview.chromium.org/2193593003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006
Review-Url: https://codereview.chromium.org/2186553006
|
|
|
|
|
|
| |
BUG=skia:
Review-Url: https://codereview.chromium.org/2191933002
|
|
|
|
|
|
|
|
| |
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003
Review-Url: https://codereview.chromium.org/2185203003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003
Review-Url: https://codereview.chromium.org/2189713003
|
|
|
|
|
|
|
|
|
|
|
| |
- Print all build properties for debugging purposes.
- Use correct path root for swarmbucket.
- Write a dummy .gclient file if missing.
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190933002
Review-Url: https://codereview.chromium.org/2190933002
|