aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra
Commit message (Collapse)AuthorAge
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-09-28
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/a16ccaf11a5a0b145b166161b80d99eaef294f4b bot_update: use patch repo instead of project if it is mapped (agable@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5afc28d536d06546b1015d453dd49e33094622b6 Reviewed-on: https://skia-review.googlesource.com/52768 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Fix path separators on Windows in zip_utilsGravatar Eric Boren2017-09-28
| | | | | | | | Bug: skia:7077 Change-Id: I5119a7d6c7cd2317129d40ae3e0997dfc9978c25 Reviewed-on: https://skia-review.googlesource.com/52664 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-09-28
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/d86c80371561676c85680e80962733087607e1a3 Fix CheckPatchFormatted() when using inherit-review-settings-ok (agrieve@chromium.org) https://crrev.com/4145082558e22927a2dc85c8459533b106e1051f Roll "vpython". (dnj@chromium.org) https://crrev.com/2da7cbd767ab59dbe49171ad99bbae5b4e675e42 Add ability to pass extra flags to gclient.sync(). (mmoss@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib793caa190fe2ef095c2dee1d559ca486b8bd22c Reviewed-on: https://skia-review.googlesource.com/52780 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Fix truncated webp imagesGravatar Leon Scroggins III2017-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: b/65290323 If a webp file is truncated such that no rows can be decoded, WebPIDecGetRGB does not initialize its "last_y" parameter. We use rowsDecoded (passed as last_y) to determine which remaining rows to fill. Check the return value of WebPIDecGetRGB. If it fails (returns null), or rowsDecoded is <= 0 (matching Chromium's check), return kInvalidInput, since there is nothing to draw. Note that this is a change in behavior for Android. Previously we would decode an empty webp to just a transparent/black rectangle, whereas now we simply fail. I think this is a change for the better. Add a test which truncates a file to have 0 rows available and attempts to decode it. msan verifies that we no longer depend on the uninitialized value. Stop attempting to test decoding subsets from an incomplete webp (in CodecTest.cpp). Unless we have decoded the portion covered by the subset, this will fail. Remove test images inc0.webp (from both dm/ and colorspace/) and inc1.webp. These just decode to transparent rectangles. Replace them with inc2.webp and inc3.webp, which decode part of the image and then have to fill with transparent. Change-Id: I64d40be91c574b45963f9a43d8dd8f4929dd2939 Reviewed-on: https://skia-review.googlesource.com/50303 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: James Zern <jzern@google.com>
* Manually roll recipe DEPSGravatar Eric Boren2017-09-27
| | | | | | | | Bug: skia: Change-Id: I55641aa4bef5a7ac863e3aae3d2902ef408f0384 Reviewed-on: https://skia-review.googlesource.com/52121 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Add cpu dimension for Build tasks.Gravatar Ben Wagner2017-09-27
| | | | | | | | | | This has no functional impact, but it makes it easier to see how much bot capacity we are using. Change-Id: I4a882c6dec438bedff821dc5bf984adac8c0cf45 Reviewed-on: https://skia-review.googlesource.com/51540 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [recipes] Update example builder names.Gravatar Ben Wagner2017-09-26
| | | | | | | Change-Id: If3532bcb5bef5fad8c950d6844135ad3597d2674 Reviewed-on: https://skia-review.googlesource.com/51380 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update Pixel(XL)?s to OPR3.170623.008Gravatar Kevin Lubick2017-09-26
| | | | | | | | | | Bug: skia: NOTRY=true Change-Id: I978ac86fa7fd6b71660dd4afec20409cea199218 Reviewed-on: https://skia-review.googlesource.com/51340 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Specify more specific CPU dimensions.Gravatar Ben Wagner2017-09-26
| | | | | | | | | | | | | This is required in order to add Skylake GCE machines, in order to avoid existing Perf GCE tasks from switching between Haswell and Skylake. Bug: skia:6326 Change-Id: Ib05323f5476c7b9a40d9f752c5a7ee8731c4185d Reviewed-on: https://skia-review.googlesource.com/50740 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Specify CPU for CT Swarming tasks.Gravatar Ben Wagner2017-09-25
| | | | | | | | | | | | | This ensures we are doing apples-to-apples comparison across runs. The Chrome-GPU pool has different machines with the same GPU, so it's important to lock down to a specific CPU for perf testing. No-Try: true Change-Id: I66648c4ea58b835af0a63d36f4830b26d7c65c5f Reviewed-on: https://skia-review.googlesource.com/50760 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update SKP versionGravatar UpdateSKPs2017-09-25
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Id4f0a6ee03dab6c86546443f4c74a08a8541baf7 Reviewed-on: https://skia-review.googlesource.com/50640 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Make ct_skps and recreate_skps recipes shell to gsutilGravatar Ravi Mistry2017-09-25
| | | | | | | | | | # Trybots already ran @patchset3 NoTry: true Bug: skia:7065 Change-Id: Ib961c5d85f9b1491efe2539dae47f6813590b8fa Reviewed-on: https://skia-review.googlesource.com/50500 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [infra] Bring recipe DEPS up to dateGravatar Eric Boren2017-09-22
| | | | | | | | Bug: skia: Change-Id: Iee3a94e56d1c8992f844f2b67d0bb565dd896684 Reviewed-on: https://skia-review.googlesource.com/50262 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Set report_signal_unsafe=0 on TSAN bots.Gravatar Mike Klein2017-09-22
| | | | | | | | | | | | We don't really care about report_signal_unsafe. Our signal handlers all just dump out a stack trace and crash. If they crash themselves due to signal unsafe code, no big deal. (I've never seen that happen.) Change-Id: Ibb90b2b323d88a56d64e6ea62b9c0924a4e41444 Reviewed-on: https://skia-review.googlesource.com/50120 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Turn on GPU threading by default to get better test/perf coverageGravatar Brian Osman2017-09-22
| | | | | | | | | | | Explicitly disable it on PixelC. This is arbitrary, so we continue to get coverage of the single-threaded code. Bug: skia: Change-Id: I0ac91f7ca58652933db452720f353068cf2d0f2d Reviewed-on: https://skia-review.googlesource.com/50000 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* [WASM] Add POC compile bot for WebAssemblyGravatar Kevin Lubick2017-09-21
| | | | | | | | | | | | | | | | | | | | Fix core.gni to use not use Assembler for none cpu. Right now, there are no outputs because we aren't compiling dm or nanobench. However, this still compiles the skia library and creates two executables, so it's a good canary for a real WASM build. Additional note: the two executables in question don't draw anything to the screen via GL, which is still not possible with Skia+WASM. Bug: skia: Change-Id: I0d767467e94e40d01070e34223dd90e96f1c96f2 Reviewed-on: https://skia-review.googlesource.com/49540 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com>
* Fix float-cast-overflow in SkTypeface_FreeType::onGetAdvancedMetricsGravatar Ben Wagner2017-09-20
| | | | | | | | Bug: skia:4632 Change-Id: Id2ee217787e6741011f324951f11eeefc55f62b9 Reviewed-on: https://skia-review.googlesource.com/47321 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* add Mac TSAN Test botsGravatar Mike Klein2017-09-19
| | | | | | | | | The build should suceeed, but the test bots should fail miserably. Change-Id: I1b525255f01fd001b1cc8a45532ab5a911b36bd6 Reviewed-on: https://skia-review.googlesource.com/48581 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix float-cast-overflow in SkOpSpan::sortableTop.Gravatar Ben Wagner2017-09-19
| | | | | | | | Bug: skia:4632 Change-Id: I5af8bb7b04673307cdf7865bb7d56a041ba27d83 Reviewed-on: https://skia-review.googlesource.com/47320 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Change SkScalarTruncToInt to saturate.Gravatar Ben Wagner2017-09-18
| | | | | | | | | | | This is the same behavior as SkScalarFloorToInt, SkScalarCeilToInt, and SkScalarRoundToInt. Bug: skia:4632 Change-Id: Iec454e841b05c5b10f335b5b089718db56740323 Reviewed-on: https://skia-review.googlesource.com/47400 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Suppress float-cast-overflow for double-to-float in SkMatrix{,44}Gravatar Ben Wagner2017-09-18
| | | | | | | | | | No API change. Bug: skia:4632 Change-Id: Ic9cb9de7cce8aca43f0ce8066abcc44a0b04ca84 Reviewed-on: https://skia-review.googlesource.com/47681 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Update SKP versionGravatar UpdateSKPs2017-09-18
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I73dd583f3891dc49402068670d0fb0dabafe0e4d Reviewed-on: https://skia-review.googlesource.com/47701 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Suppress float-cast-overflow in SkPoint::Length.Gravatar Ben Wagner2017-09-16
| | | | | | | | Bug: skia:4632 Change-Id: I0f8a7d7a11fc76fcb315c3f0183577c3f0958926 Reviewed-on: https://skia-review.googlesource.com/47421 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Blacklist failing tests for IB1Gravatar Kevin Lubick2017-09-15
| | | | | | | | | | Bug: skia: NOTRY=true Change-Id: I2a774ca2533572eaf284101cd6ea11b816c1441a Reviewed-on: https://skia-review.googlesource.com/47080 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [infra] Use int for internal_hardware_labelGravatar Eric Boren2017-09-15
| | | | | | | | Bug: skia: Change-Id: I86c4160e0c65c9f8459087e34eaf39907a76c9da Reviewed-on: https://skia-review.googlesource.com/47182 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Rename internal_bot_id -> internal_hardware_labelGravatar Eric Boren2017-09-15
| | | | | | | | | Bug: skia: Change-Id: I1a2442898c8eca8cf36d8e85d2acf1d048ebfb54 Reviewed-on: https://skia-review.googlesource.com/46849 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Always upload Gold images to the same bucketGravatar Eric Boren2017-09-15
| | | | | | | | | | | But respect the passed-in bucket for verbose logs and JSON summary. Bug: skia: Change-Id: If57c16538802125c087b76991a0ca45b0a33beb2 Reviewed-on: https://skia-review.googlesource.com/46721 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Add internal_bot_id flag to recipesGravatar Eric Boren2017-09-15
| | | | | | | | | | Allows differentiation between internal bots in recipes. Bug: skia: Change-Id: I7130f2adc13dd01f7572856ea64c428a6adf56ba Reviewed-on: https://skia-review.googlesource.com/46844 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Remove redundant jobs.Gravatar Ben Wagner2017-09-14
| | | | | | | | | | | | | Replacements added in: https://skia-review.googlesource.com/c/skia/+/26365 https://skia-review.googlesource.com/c/skia/+/31143 Bug: skia:6881 No-Try: true Change-Id: I35a212f55b9f2cd1240f2f072321ee118a3feecc Reviewed-on: https://skia-review.googlesource.com/46306 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Use Chrome-GPU pool for CT GPU runsGravatar Ravi Mistry2017-09-13
| | | | | | | | | Bug: chromium:700053 NoTry: true Change-Id: Ib62ea29f5192df1b03e9d8caecb6af4daeee0e49 Reviewed-on: https://skia-review.googlesource.com/46060 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add new task to run the float-cast-overflow sanitizer.Gravatar Ben Wagner2017-09-13
| | | | | | | | | Bug: skia:4632 No-Try: true Change-Id: I85a0b23037d5885e5d762788d8bf5b7cc6fc19b2 Reviewed-on: https://skia-review.googlesource.com/45980 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Add Clang GPU tasks.Gravatar Ben Wagner2017-09-12
| | | | | | | | No-Try: true Change-Id: I5290942396a903fcaac94feaab83a5db31af1f93 Reviewed-on: https://skia-review.googlesource.com/45844 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Simpler version of wait-for-device.Gravatar Ben Wagner2017-09-12
| | | | | | | | | | This is a followup to https://skia-review.googlesource.com/43564 No-Try: true Change-Id: I4bc2a24fe08e6b07f5512e3a1e03eac7e3397155 Reviewed-on: https://skia-review.googlesource.com/45120 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Make output of all tests verboseGravatar Stephan Altmueller2017-09-12
| | | | | | | | | | | | | | | Re-enable more verbose output across all bots. There is no good reason why we shouldn't collect additional information that helps triaging failure. Some of the current output might have to be expanded down the road. Bug: skia: Change-Id: I5ff89a803f1e390bbd859756cba53a359d2801ba Reviewed-on: https://skia-review.googlesource.com/45140 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Retry adb commands on flaky devices.Gravatar Ben Wagner2017-09-11
| | | | | | | | No-Try: true Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f Reviewed-on: https://skia-review.googlesource.com/43564 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* update clang_linux package to Clang 5Gravatar Mike Klein2017-09-10
| | | | | | | | | Disable some new warning flags to get us building. Change-Id: I10299d667b06fb61d03e52329883c634bd42f45c Reviewed-on: https://skia-review.googlesource.com/44341 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update SKP versionGravatar UpdateSKPs2017-09-10
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Ie30d4614101383044b76c9c2dcb959ce447c1a67 Reviewed-on: https://skia-review.googlesource.com/44640 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Omit encode-platform also for Debug Mac CPU.Gravatar Ben Wagner2017-09-08
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: I824e44f0e9f08f607aa3aaa5e0074bce72a2b4ee Reviewed-on: https://skia-review.googlesource.com/44202 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update NexusPlayers to Android O PR6.Gravatar Ben Wagner2017-09-08
| | | | | | | | No-Try: true Change-Id: I0abb5e6d9d705d352089024a303d2f8be0f051aa Reviewed-on: https://skia-review.googlesource.com/43203 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Only run CPU SVG tests on a single botGravatar Chris Dalton2017-09-07
| | | | | | | | | | | | | Runs the testing on Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN. We only care about parsing SVGs CPU-side so there's no need to retest it on every bot. Bug: skia:6918 Change-Id: If2c5afbc41a600ece63d9a6a60f0dab5ca7b3676 Reviewed-on: https://skia-review.googlesource.com/43461 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Blacklist more flaky GMs in gltestthreading configGravatar Brian Osman2017-09-07
| | | | | | | | Bug: skia:7011 skia:6544 Change-Id: Idacb5ff8090bea6ddbdef710bc0f4dbb8bd23549 Reviewed-on: https://skia-review.googlesource.com/43560 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Update PixelC to Android O PR6.Gravatar Ben Wagner2017-09-06
| | | | | | | | No-Try: true Change-Id: I31dd6f12cb7ab4195bfe61b0f267ad5020d09a7c Reviewed-on: https://skia-review.googlesource.com/43161 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Omit flaky encode-platform test for pic-8888 Mac CPU.Gravatar Ben Wagner2017-09-05
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: I8141afb1706b1434bacc62f6b6f9b69876a92b2c Reviewed-on: https://skia-review.googlesource.com/42680 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Update SKP versionGravatar UpdateSKPs2017-09-03
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I255191f21e7b185b212b35502d6ce00f91fc45c2 Reviewed-on: https://skia-review.googlesource.com/42220 Commit-Queue: update-skps <update-skps@skia.org> Reviewed-by: update-skps <update-skps@skia.org>
* Blacklist (flaky) textbloblooper on gltestthreadingGravatar Brian Osman2017-08-31
| | | | | | | | Bug: skia: Change-Id: I10ddc36f39800e3d86145054b994a6899573a63a Reviewed-on: https://skia-review.googlesource.com/41501 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Fix chromecast perfsGravatar Kevin Lubick2017-08-31
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: I5efe4bc59efa4bc81e5f8811fed7867ec20447fb Reviewed-on: https://skia-review.googlesource.com/41541 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add Correctness tests for ChromecastGravatar Kevin Lubick2017-08-31
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Ib604bad8eda6ba4382b850f7c5f318fb0f114401 Reviewed-on: https://skia-review.googlesource.com/20051 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Threaded generation of software pathsGravatar Brian Osman2017-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | Re-land of: https://skia-review.googlesource.com/36560 All information needed by the thread is captured by the prepare callback object, the lambda captures a pointer to that, and does the mask render. Once it's done, it signals the semaphore (also owned by the callback). The callback defers the semaphore wait even longer (into the ASAP upload), so the odds of waiting for the thread are REALLY low. Also did a bunch of cleanup along the way, and put in some trace markers so we can monitor how well this is working. Traces of a GM that includes GPU and SW path rendering (path-reverse): Original: https://screenshot.googleplex.com/f5BG3901tQg.png Threaded, with wait in the callback (notice pre flush callback blocking): https://screenshot.googleplex.com/htOSZFE2s04.png Current version, with wait deferred to ASAP upload function: https://screenshot.googleplex.com/GHjD0U3C34q.png Bug: skia: Change-Id: Idb92f385590749f41328a9aec65b2a93f4775079 Reviewed-on: https://skia-review.googlesource.com/40775 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Update SKP versionGravatar UpdateSKPs2017-08-27
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Id92722fbb5c24e9cd7e1547fda974115cc866b2d Reviewed-on: https://skia-review.googlesource.com/39100 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Revert "Threaded generation of software paths"Gravatar Brian Salomon2017-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 76323bc0615044a5921afef0e19a350f3d04ffe0. Reason for revert: Breaking NUC bots in threaded gm comparison: https://chromium-swarm.appspot.com/task?id=382e589753187f10&refresh=10 Original change's description: > Threaded generation of software paths > > All information needed by the thread is captured by the prepare > callback object, the lambda captures a pointer to that, and does the > mask render. Once it's done, it signals the semaphore (also owned by the > callback). The callback defers the semaphore wait even longer (into the > ASAP upload), so the odds of waiting for the thread are REALLY low. > > Also did a bunch of cleanup along the way, and put in some trace markers > so we can monitor how well this is working. > > Traces of a GM that includes GPU and SW path rendering (path-reverse): > > Original: > https://screenshot.googleplex.com/f5BG3901tQg.png > Threaded, with wait in the callback (notice pre flush callback blocking): > https://screenshot.googleplex.com/htOSZFE2s04.png > Current version, with wait deferred to ASAP upload function: > https://screenshot.googleplex.com/GHjD0U3C34q.png > > Bug: skia: > Change-Id: I3d5a230bbd68eb35e1f0574b308485c691435790 > Reviewed-on: https://skia-review.googlesource.com/36560 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,mtklein@google.com,bsalomon@google.com,robertphillips@google.com,brianosman@google.com Change-Id: Icac0918a3771859f671b69ae07ae0fedd3ebb3db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/38560 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-20 17:15:53 +0000