aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots
Commit message (Collapse)AuthorAge
...
* Reduce ANGLE correctness testing blacklistsGravatar Brian Salomon2017-06-23
| | | | | | | | Bug: skia: Change-Id: Ie98d574a9840dd073a396da829aee041fb6595dc Reviewed-on: https://skia-review.googlesource.com/20601 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* run Test-iOS-... bots with --threads 0.Gravatar Mike Klein2017-06-23
| | | | | | | | | | | | | | | | Yet another attempt to get the iOS bots stable. As GPU testers, the iOS bots are already mostly single threaded, but farm a good chunk of work like image encoding out to threads. This will take them all the way to really single threaded. BUG=skia:6748 Change-Id: I222e3ca402eee9d191c8a413b29a65d19c13e88a Reviewed-on: https://skia-review.googlesource.com/20687 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Update Win Haswell/Broadwell driver.Gravatar Ben Wagner2017-06-23
| | | | | | | | No-Try: true Change-Id: I3bc19ac43e90de3009ca48a18284485efff21ad8 Reviewed-on: https://skia-review.googlesource.com/20690 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Roll isolate binaries to pick up some auth fixes.Gravatar Vadim Shtayura2017-06-23
| | | | | | | | | | | | | | | | | | Corresponds to infra/infra@33231bcea82e2f7d65d027ebc94afc3e95db26ee Built here: https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-precise-64/7888 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-mac-10.10-64/7131 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-win-64/8030 R=rmistry@google.com BUG=skia:6611 Change-Id: I25a961bfb931daac43d544babaad0b4b468de302 Reviewed-on: https://skia-review.googlesource.com/20555 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Vadim Shtayura <vadimsh@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Add correctness testing for ANGLE D3D11 ES3Gravatar Brian Salomon2017-06-23
| | | | | | | | | Bug=skia:6776 Change-Id: I51c851d6b80992039c87ae43037721db52958f0c Reviewed-on: https://skia-review.googlesource.com/20503 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Blacklist TransferPixelsTest on NVIDIA ShieldGravatar Jim Van Verth2017-06-22
| | | | | | | | Bug: skia:6784 Change-Id: I7dc870e4cac4d513103f6d61f220f87cf9cc77ef Reviewed-on: https://skia-review.googlesource.com/20508 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Update luci-go isolate.sha1 filesGravatar Ravi Mistry2017-06-21
| | | | | | | | | BUG=skia:6611 Change-Id: Ide847c4370f9fde959aec8723d9145791576460a Reviewed-on: https://skia-review.googlesource.com/20448 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Limit number of stages for Angle D3D for GLPrograms testGravatar Greg Daniel2017-06-19
| | | | | | | | Bug: skia:4717 Change-Id: I5ea613311d2c346bc45875040665a121b455f674 Reviewed-on: https://skia-review.googlesource.com/20228 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Omit multipicturedraw tests for Valgrind_PreAbandonGpuContext bot.Gravatar Ben Wagner2017-06-19
| | | | | | | | | Bug: skia:6575 Change-Id: Ie937962e6a4f2dd989efca8ad94d35ad058bc87c No-Try: true Reviewed-on: https://skia-review.googlesource.com/20226 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update Angle GLPrograms test blacklist to only be on the one broked configGravatar Greg Daniel2017-06-19
| | | | | | | | Bug: skia:4717, skia:6772 Change-Id: I7a50228722b6ea4034410a57e138de050398b20f Reviewed-on: https://skia-review.googlesource.com/20222 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Update SKP versionGravatar UpdateSKPs2017-06-18
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Iaa82decbf93652f412d4aa5649c953a20d50fdd2 Reviewed-on: https://skia-review.googlesource.com/20201 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* [recipes] Switch to file module from recipe_engineGravatar Eric Boren2017-06-16
| | | | | | | | Bug: skia:6704 Change-Id: Id3cefa643316e5676d2038a75240e16d929d6d63 Reviewed-on: https://skia-review.googlesource.com/20146 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Blacklist MSAA readPixels test on Iris540 VkGravatar Brian Osman2017-06-15
| | | | | | | | Bug: skia: Change-Id: Ifd184c71bbc33f6c1415fad464da9542071de13f Reviewed-on: https://skia-review.googlesource.com/20056 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add CPU Chromecast Perf JobGravatar Kevin Lubick2017-06-15
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Ieb4c05b5f430c125ad8fd1a360d82385279dcf29 Reviewed-on: https://skia-review.googlesource.com/20049 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Unit test to demonstrate Galaxy S6 MSAA readPixels bugGravatar Brian Osman2017-06-15
| | | | | | | | | | | | | | | | | | | | | | | | | | After lots of tinkering, this is the smallest test case I've found to reproduce the bug. Frequently, bitmap b4 will be cleared to blue, but not contain the oval drawn right before. Bitmap b5 will contain the oval, so the diff of the two bitmaps will detect the error. There may be something else that can be removed, but I haven't found it. Interesting note: In the original version, all surfaces were cleared to black. When I started trying to change the clear colors to figure out if we were getting an old surface, the bug went away. In particular, the first clear color is irrelevant, but the last three clears must all be the same color. If any are different, the bug doesn't occur. Bug: skia:6653 Change-Id: Iacafcc140b60594fab208e82987b0f37416975f3 Reviewed-on: https://skia-review.googlesource.com/19817 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* [infra] Disambiguate GTX960s with cpu dimension.Gravatar Ben Wagner2017-06-15
| | | | | | | | No-Try: true Change-Id: Ib55b96bd1ff80fe857b9fa551bb89bf6c2c81f2c Reviewed-on: https://skia-review.googlesource.com/19968 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fixes for internal repo infra testsGravatar Eric Boren2017-06-15
| | | | | | | | Bug: skia:6763 Change-Id: I51522693ec8b81ff3b7d4349808d0e6493c5dd5b Reviewed-on: https://skia-review.googlesource.com/19843 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Update PixelXL bots to O developer preview 3Gravatar Greg Daniel2017-06-14
| | | | | | | | Bug: skia:6724 Change-Id: I85a2ceed9a2dd662ddd51bfbee6cf185a3fa0eb0 Reviewed-on: https://skia-review.googlesource.com/19810 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* [infra] Specify GPU driver version in task dimensions.Gravatar Ben Wagner2017-06-14
| | | | | | | | Bug: skia:6637 Change-Id: I3f692e95efad4079f69fc451c7d4a4b2b8b5df63 Reviewed-on: https://skia-review.googlesource.com/19808 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [infra] Remove unused flags in gen_tasks.go.Gravatar Ben Wagner2017-06-14
| | | | | | | | | Bug: skia:6637 No-Try: true Change-Id: Ic2fba996a0fead3cfac61e86874cca13271bb595 Reviewed-on: https://skia-review.googlesource.com/19805 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [infra] Move Android and GPU maps into gen_tasks.go.Gravatar Ben Wagner2017-06-14
| | | | | | | | | Bug: skia:6637 No-Try: true Change-Id: I1aa47be9d039e8396f8bbf4e1c7e134fe258a1ce Reviewed-on: https://skia-review.googlesource.com/19095 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove IntelIris640 jobs.Gravatar Ben Wagner2017-06-13
| | | | | | | | | | | | Gold results for IntelIris640 (Kaby Lake) are nearly identical to IntelIris540 (Skylake). Bug: skia:6743 No-Try: true Change-Id: Ia865216cd10af8c11a893712b8e792947d8fcc31 Reviewed-on: https://skia-review.googlesource.com/19665 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [recipes] Fix internal_test tryjobs.Gravatar Ben Wagner2017-06-13
| | | | | | | | | | >>> 'internal_test.git'.rstrip('.git') 'internal_tes' Change-Id: If023784a7387a89b2ba1972ea43d68a0c07df635 Reviewed-on: https://skia-review.googlesource.com/19546 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [infra] Isolate tasks don't need compile task.Gravatar Ben Wagner2017-06-12
| | | | | | | | No-Try: true Change-Id: I4372c50b183d040e5145ac3ca665cd813da6256a Reviewed-on: https://skia-review.googlesource.com/19497 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Roll recipe dependencies (nontrivial).Gravatar recipe-roller2017-06-12
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/59a74ed5585087e85ff4b7fa2ac18ef3648d05b0 Add cleanup dir, use with bot_update. (dnj@chromium.org) Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9021158a90cb8ba0c939a45c2d480271506da65b Reviewed-on: https://skia-review.googlesource.com/19099 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Update SKP versionGravatar UpdateSKPs2017-06-11
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Id63ab69479d27e3e42179f29275d159de5c7fbbc Reviewed-on: https://skia-review.googlesource.com/19420 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Add another gm to Win Intel Vulkan blacklistGravatar Greg Daniel2017-06-09
| | | | | | | | | Bug: skia:6398 Change-Id: I3e4006ce1fbe1644c6d99467c5b9e785161dcc3d Reviewed-on: https://skia-review.googlesource.com/19277 Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Remove blacklisted native_image_to_raster_surface testsGravatar Brian Osman2017-06-09
| | | | | | | | Bug: skia:6457 skia:6401 Change-Id: I18e45617765aa55c3a2837bb735cefc3d93fad22 Reviewed-on: https://skia-review.googlesource.com/19273 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add new Kaby Lake bot Win IntelIris640.Gravatar Ben Wagner2017-06-09
| | | | | | | | | Bug: skia:6743 No-Try: true Change-Id: Ib670ce861ccf6568acfe0d0b27fcc112a51989bc Reviewed-on: https://skia-review.googlesource.com/19092 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Increase timeout for 32-bit Debug tests.Gravatar Ben Wagner2017-06-08
| | | | | | | | | Bug: skia:6737 No-Try: true Change-Id: I1e3751f1bce087980bf8f8e4317b1aae1a9fcf8f Reviewed-on: https://skia-review.googlesource.com/19051 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Use chrome-infra Git CIPD packageGravatar Eric Boren2017-06-06
| | | | | | | | | | | Add Git recipe module to easily use this version of Git anywhere. This fixes recipe bundling and unblocks the recipe roll. Bug: skia: Change-Id: Ib4d1361b7a52676e1992025b29e630ea3ada173b Reviewed-on: https://skia-review.googlesource.com/18833 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Remove blacklist of unit tests on Adreno VulkanGravatar Greg Daniel2017-06-05
| | | | | | | | Bug: skia:5777 Change-Id: I3cee2ffaf1b2858e660ca5d550d25f4a312395e6 Reviewed-on: https://skia-review.googlesource.com/18589 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Remove hardstop blacklist for nexus player vulkanGravatar Greg Daniel2017-06-05
| | | | | | | | | | | Local testing says this has been fixed by some series of SKSL changes over the past month or so Bug: skia:6037 Change-Id: Iffc8b63e495016ac9565459ddaf44db4049a33c0 Reviewed-on: https://skia-review.googlesource.com/14530 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Update SKP versionGravatar UpdateSKPs2017-06-04
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I95441583200a3ffc7a2dfe1b6671b5416278f902 Reviewed-on: https://skia-review.googlesource.com/18517 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Rename Chromecast CPU tests to GPU testsGravatar Kevin Lubick2017-06-02
| | | | | | | | | | Also fix command flags to use skps instead of svgs Bug: skia:6706 Change-Id: Ie099abac738e6eb8808db9aef513a51940c5ccb1 Reviewed-on: https://skia-review.googlesource.com/18441 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Rename example.py -> examples/full.py for all modulesGravatar Robert Iannucci2017-06-02
| | | | | | | | | | | | | `example.py` is going away; examples folder can now hold multiple example recipes. R=borenet@google.com Bug: skia: Change-Id: Ib28910987342217bc52040d4d966444174ce27a3 Reviewed-on: https://skia-review.googlesource.com/18432 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Use ssh to trigger chromecast testGravatar Kevin Lubick2017-06-01
| | | | | | | | | | | Using adb seemed to ignore errors in some cases, primarily if nanobench crashed/hung. Bug: skia:6706 Change-Id: I5def49d5b4d20bed6c486b7e85040190be856ac8 Reviewed-on: https://skia-review.googlesource.com/18404 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Roll recipe dependencies (nontrivial).Gravatar recipe-roller2017-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/fc1c6f4c1fac4de7647da83425f4398dde6e77ca Correct Git show's path format on Windows (manzagop@chromium.org) recipe_engine: https://crrev.com/458ce956c9d91d184e0107c5fa6b34a8267b8e9b [step_runner] run _merge_envs in simulation too. (iannucci@chromium.org) R=martiniss@chromium.org, tansell@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic938b59f304189fdfb78a466e6a4a0e47f0548a6 Reviewed-on: https://skia-review.googlesource.com/18300 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Robbie Iannucci <iannucci@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Convert last step.context stragglers.Gravatar Robert Iannucci2017-06-01
| | | | | | | | | | | | These methods are removed in an upcoming version of the recipe engine. R=borenet@google.com Bug: skia: Change-Id: I2db5cc683dac35b9ce65fe1b175e9f9a6d6b5efe Reviewed-on: https://skia-review.googlesource.com/18324 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Fix missing CIPD package for Valgrind perf botsGravatar Eric Boren2017-06-01
| | | | | | | Bug: skia: Change-Id: Ia9fb42373d3214ea78976fc140062d5d9b38781a Reviewed-on: https://skia-review.googlesource.com/18302 Reviewed-by: Eric Boren <borenet@google.com>
* Add CIPD asset for ValgrindGravatar Eric Boren2017-05-31
| | | | | | | | | Bug: skia:6668 Change-Id: I324602b1381f701ec780c02b26775c5e9e09cb84 Reviewed-on: https://skia-review.googlesource.com/17834 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Get known hashes from GS directlyGravatar Stephan Altmueller2017-05-31
| | | | | | | | Bug: skia: Change-Id: I8698aad706e2c9cc81280107cb08d83e08a9dc25 Reviewed-on: https://skia-review.googlesource.com/18145 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* [recipes] Try removing the possibly-over-conservative git stepGravatar Eric Boren2017-05-31
| | | | | | | | Bug: skia: Change-Id: Ie6ea54d26eff7a165f32afbb5c8037b6c1921a5d Reviewed-on: https://skia-review.googlesource.com/18138 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Fix glDrawRangeElementsGravatar Chris Dalton2017-05-30
| | | | | | | | | | | | | | | | | | Adds explicit min/max index value fields to GrMesh. This eliminates the previous assumption that the index values were within the range [0..vertexCount-1]. In the pattern case we still maintain this assumption. Updates GrMesh to hide its fields and handle its new complexity using a "helper" interface instead. Adds a unit test for GrMesh. Bug: skia: Change-Id: Ia23de72d510f8827cee56072b727fb70a6e46b8d Reviewed-on: https://skia-review.googlesource.com/17964 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Update SKP versionGravatar UpdateSKPs2017-05-28
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I8285e9dcf65280e5712d140a7d17a0f99a40bca5 Reviewed-on: https://skia-review.googlesource.com/18084 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Create blacklist for new SKP repositoryGravatar Ravi Mistry2017-05-26
| | | | | | | | | | | BUG=skia:6694 NOTREECHECKS=true Change-Id: Ic7eeda7086e51a259f961351fec5a06d1f8fa6ec Reviewed-on: https://skia-review.googlesource.com/18028 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Omit more shapes tests for ANGLE Release.Gravatar Ben Wagner2017-05-25
| | | | | | | | | Bug: skia:6534 Change-Id: I182a207ea827451daad5ed7f982289c0a29ce24d No-Try: true Reviewed-on: https://skia-review.googlesource.com/17929 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add NexusPlayer Vulkan perf botGravatar Greg Daniel2017-05-25
| | | | | | | | Bug: skia: Change-Id: I67594a109ea51bd8627cb47978e263b5493e7737 Reviewed-on: https://skia-review.googlesource.com/17933 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Rename HD4000 GPU to IntelHD4000 on botsGravatar Robert Phillips2017-05-25
| | | | | | | | | This is so the blanket disabling of MSAA on Intel bots (in test.py & perf.py) actually disables it on the HD4000. Change-Id: Ief3c0c85ed53e312f5e584ab51ba76f78fb8c036 Reviewed-on: https://skia-review.googlesource.com/17822 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Add animated webp images to DM testing"Gravatar Leon Scroggins2017-05-24
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6ecc373cde276ecf19d9599f7502b79ebf575936. Reason for revert: skbug.com/6682 Original change's description: > Add animated webp images to DM testing > > Change-Id: Idb6f95574136cbcb4fb45784a5bf1db3fa97ab32 > Reviewed-on: https://skia-review.googlesource.com/17832 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Leon Scroggins <scroggo@google.com> > TBR=borenet@google.com,msarett@google.com,scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I6674dbb66a24e425b3432309a8f37e19cf484d48 Reviewed-on: https://skia-review.googlesource.com/17846 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>