aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots
Commit message (Collapse)AuthorAge
...
* Turn up Nexus10 CPU frequenciesGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | | | | The previous list was created from scaling_min_freq and scaling_max_freq instead of cpuinfo_min_freq and cpuinfo_max_freq which are the actual mins and maxes, not the current (transient) settings of the governor. Before: Test-Release: 61 minutes Perf-Debug: 41 minutes After: Test-Release: 32 minutes Perf-Debug: 16 minutes NOTRY=true Bug: skia: Change-Id: I9b431e92d2abcecb4fe643389daddc912a1399e1 Reviewed-on: https://skia-review.googlesource.com/78141 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make cpu scaling more robustGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | Some bots, especially the Nexus 7s, seemed to occasionally fail when setting the CPU frequency. I was unable to repro this behavior, so this is a shotgun approach. We add a 5 second delay between setting and checking, checking frequency using scaling_cur_freq instead of scaling_setspeed, set the min_freq as well as max_freq, and retry up to 3 times if setting cpu frequency fails. NOTRY=true Bug: skia: Change-Id: Id4d85d8d509c9dba8e3a0e06b5992f5adadf36d2 Reviewed-on: https://skia-review.googlesource.com/78140 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Revert "Temporarily add Ubuntu IntelHD4400 jobs."Gravatar Ben Wagner2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 373588426b9d02576152e820eb7f870d930f1998. Reason for revert: Have enough digests on Gold now. Original change's description: > Temporarily add Ubuntu IntelHD4400 jobs. > > I want to compare this with the IntelBayTrail and if the results are > similar, replace those bots. > > No-Try: true > Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a > Reviewed-on: https://skia-review.googlesource.com/76900 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=benjaminwagner@google.com,kjlubick@google.com Change-Id: Ica07d1ee635e59e3d3da51ee73591ffe08310e34 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/77860 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Ignore deserialized path convexity and first direction.Gravatar Brian Salomon2017-11-29
| | | | | | | Change-Id: Ib7bfff6225774b83d9b6e9c5baae254aab17353b Reviewed-on: https://skia-review.googlesource.com/77680 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Isolate the biggest CIPD assets to trim down on overheadGravatar Kevin Lubick2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change, when combined with https://skia-review.googlesource.com/c/buildbot/+/77701 should cut down on the duplicated work of extracting the large toolchains from CIPD. Since the Isolate* steps can be cached (i.e. are idempotent) they will only run about 1/week (unless updated) and all subsequent tasks (primarily Builds) will go much faster. We estimate the overhead on Build-Debian-Android to go from about 90s (which was more time than the actual build) to about 10s. Build-Win-Vulkan's overhead will improve from about 180s to about 35s (1/3 of which is uploading to isolate). Other CIPD assets could be handled in a similar fashion; the ones here are the biggest offenders and the lowest hanging fruit. Doing this to other assets (e.g. clang_win) would have minimal improvements (<10s). There are other tasks with large amounts of overhead (e.g. Build-Mac-Android, Build-Win-Android, Build-WASM) but none of those are depended on by any Tests, so any speed-ups would have less wide-reaching-impact, at the cost of using more Isolate cache/diskspace. See https://docs.google.com/document/d/1DFlcpqg7XqEPE5oYT1V3so2ih2285heS5w3mPT-GMBA/edit# for more information. Bug: skia: Change-Id: I40dd87fe72c3d49292762a09dad6df0dfbe78f61 Reviewed-on: https://skia-review.googlesource.com/77560 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Update CT bots to Debian-9.2Gravatar Eric Boren2017-11-29
| | | | | | | | | | | This has the side effect of using the bots in the new GCE project as well. Bug: skia:7278 Change-Id: Ie14c93d6e3d12ccbfb679089bc50bca482fbf605 Reviewed-on: https://skia-review.googlesource.com/76261 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* [infra] Provide Buildbucket Build ID in dm.jsonGravatar Eric Boren2017-11-29
| | | | | | | | Bug: skia: Change-Id: Iefef7d617e58de2b3be2e27aac075f822641e4ce Reviewed-on: https://skia-review.googlesource.com/77641 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Upgrade Macs to 10.13.1.Gravatar Ben Wagner2017-11-29
| | | | | | | | | Bug: skia:7203 Change-Id: I741d15eabe502fd4c130e8ab3c3cfb92e3794e43 NoTry: true Reviewed-on: https://skia-review.googlesource.com/68080 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Temporarily add Ubuntu IntelHD4400 jobs.Gravatar Ben Wagner2017-11-29
| | | | | | | | | | | I want to compare this with the IntelBayTrail and if the results are similar, replace those bots. No-Try: true Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a Reviewed-on: https://skia-review.googlesource.com/76900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove temporary image Swarming dimension.Gravatar Ben Wagner2017-11-29
| | | | | | | Change-Id: Iee28f684bd6fa541e36f677ee4261e637cbd4611 Reviewed-on: https://skia-review.googlesource.com/77201 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Upgrade GalaxyS6.Gravatar Ben Wagner2017-11-28
| | | | | | | | | Bug: skia:7308 Change-Id: Ia84f67c310104fc75e81757de8cb8e57add763d0 Reviewed-on: https://skia-review.googlesource.com/76621 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Add create_bundle support for GNGravatar Jim Van Verth2017-11-28
| | | | | | | | | Docs-Preview: https://skia.org/?cl=75383 Bug: skia:7339 Change-Id: I985734e8b7b5af21a82cb8ee59acbfb5ff1d3ff7 Reviewed-on: https://skia-review.googlesource.com/75383 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Switch Coverage GPU bot to Golo.Gravatar Ben Wagner2017-11-28
| | | | | | | | No-Try: true Change-Id: I0b9f6ef3651e5309af316d7ea7e170b48f54cdeb Reviewed-on: https://skia-review.googlesource.com/76620 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Don't scale CPU for internal botsGravatar Kevin Lubick2017-11-28
| | | | | | | | | | | | For internal hardware, it tends not to work - they work at one clock speed, despite advertising others. Bug: skia: NOTRY=true Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435 Reviewed-on: https://skia-review.googlesource.com/76720 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Make EGL test context access GL via GrGLInterfaceGravatar Brian Salomon2017-11-27
| | | | | | | | Bug: skia:7334 Change-Id: I5153ef83ae350648a15d6dc427b03d464258608b Reviewed-on: https://skia-review.googlesource.com/75980 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Update SKP versionGravatar UpdateSKPs2017-11-26
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I327662727f6ab0bf2b22d94f707940bf50e9005d Reviewed-on: https://skia-review.googlesource.com/75821 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Rename AMDHD7770 to RadeonHD7770.Gravatar Ben Wagner2017-11-24
| | | | | | | | | | | Also drive-by cleanup of "Win8-MSVC-ShuttleB", none of which currently exist. No-Try: true Change-Id: Ide28481939b7ec2a0733ab07673379c951123f5d Reviewed-on: https://skia-review.googlesource.com/75361 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove obsolete iOSShell references from infra scriptsGravatar Brian Osman2017-11-22
| | | | | | | | Bug: skia: Change-Id: I36cb94877d513fc81c211b0e58b5c4be0451ac91 Reviewed-on: https://skia-review.googlesource.com/74601 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* VisualBench is not a thing anymoreGravatar Brian Osman2017-11-22
| | | | | | | | Bug: skia: Change-Id: I391cbc6cb2bf2ae88af0612964f4265788c8e771 Reviewed-on: https://skia-review.googlesource.com/74600 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Update SKP versionGravatar UpdateSKPs2017-11-22
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Ic62e7b8951a3a48521af18d2d660aca8802b7d8f Reviewed-on: https://skia-review.googlesource.com/75341 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Fix scaling on Nexus 7 botsGravatar Kevin Lubick2017-11-22
| | | | | | | | | | Bug: skia: NOTRY=true Change-Id: I1a1755dd03f2e6ebd8d9b2c9235cca8eb34f04ad Reviewed-on: https://skia-review.googlesource.com/75280 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make CPU scaling code cleanerGravatar Kevin Lubick2017-11-21
| | | | | | | | | | | | | | | | | This also makes *sure* the CPU frequency we set the device to actually "takes". Along the way, I learned if scaling_max_freq is < the frequency we set, the scaling_max_freq will be used instead, which was happening to the PixelCs and AndroidOnes. As a result, this may make those two Test- configs faster. Bug: skia: Change-Id: I10c98d37e296a19e1cf67bfe7269bb59cdd912d5 Reviewed-on: https://skia-review.googlesource.com/74360 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Remove Skolo NVIDIA Linux bots.Gravatar Ben Wagner2017-11-21
| | | | | | | | | Docs-Preview: https://skia.org/?cl=74160 No-Try: true Change-Id: Icb3a8ac00e640de345f4fbed89642bee569bbe9b Reviewed-on: https://skia-review.googlesource.com/74160 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* Update SKP versionGravatar UpdateSKPs2017-11-21
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I38b6170ddafd237af0bb77ab1a351edc7b3c28d5 Reviewed-on: https://skia-review.googlesource.com/74221 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Update SKP versionGravatar UpdateSKPs2017-11-21
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Ib8cf343936639298d468f3655d07ad400fc136b7 Reviewed-on: https://skia-review.googlesource.com/74260 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Remove Nexus 6psGravatar Kevin Lubick2017-11-21
| | | | | | | | | | | These will be replaced by the Nexus 5x. Bug: skia:7309 No-Try: true Change-Id: I2a56a494203f2af41f16dcfd55ebe1ca28e9e939 Reviewed-on: https://skia-review.googlesource.com/73881 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Update SKP versionGravatar UpdateSKPs2017-11-20
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I01733172ab89cb19aae8fae95f70be4802664998 Reviewed-on: https://skia-review.googlesource.com/73941 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Add gm to win vulkan intell blacklistGravatar Greg Daniel2017-11-20
| | | | | | | | Bug: skia:6398 Change-Id: Ic04fa93dfe59c3c2b9322ffbe24e4791da9056ee Reviewed-on: https://skia-review.googlesource.com/73802 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Put CPU frequency scaling in recipesGravatar Kevin Lubick2017-11-20
| | | | | | | | Bug: skia: Change-Id: I994f67c3043306d7fa612feb03f8fbe8d7bf4c91 Reviewed-on: https://skia-review.googlesource.com/73760 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add bug number to comment.Gravatar Ben Wagner2017-11-20
| | | | | | | | No-Try: true Change-Id: I9fe2b133264eb74b066364d5a490aae2de232bd3 Reviewed-on: https://skia-review.googlesource.com/73820 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Switch to new Windows image.Gravatar Ben Wagner2017-11-20
| | | | | | | Change-Id: I667e0b8206461df797f0f5e481fe78a3f928481a Reviewed-on: https://skia-review.googlesource.com/73261 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Expand Windows GPU test configs.Gravatar Ben Wagner2017-11-20
| | | | | | | | No-Try: true Change-Id: I2511801c746d3e434cd5eb7cc553bdc7b35fcf74 Reviewed-on: https://skia-review.googlesource.com/72680 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Linux IntelHD405 Vulkan jobs.Gravatar Ben Wagner2017-11-20
| | | | | | | | No-Try: true Change-Id: Id2631fc8df97b2a76775b01db212085d94c82906 Reviewed-on: https://skia-review.googlesource.com/72902 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Nexus5xGravatar Ben Wagner2017-11-17
| | | | | | | | | Bug: skia:7309 NoTry: true Change-Id: I9d9e18f8fe8bc53a54de26533485b262ba825ea7 Reviewed-on: https://skia-review.googlesource.com/72980 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Specify image dimension for all Win2016 tasks.Gravatar Ben Wagner2017-11-17
| | | | | | | | | | Followup to https://skia-review.googlesource.com/c/skia/+/73260, which missed Build tasks. Change-Id: I73c346adea2af9180cdf69b7fba0f586c35a6a47 Reviewed-on: https://skia-review.googlesource.com/73341 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Specify image dimension for Win2016.Gravatar Ben Wagner2017-11-17
| | | | | | | | | Will remove after transition to new image. Change-Id: I4254643aa1279b6e2046d2cdef9ff1d481f85531 Reviewed-on: https://skia-review.googlesource.com/73260 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix webp bug compositing alpha frames on opaque (better fix)Gravatar Leon Scroggins III2017-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old code made the wrong assumptions about premultiplication. There are three relevant steps here for decoding a webp frame: 1 tell libwebp to decode 2 colorXform the result (sometimes) 3 blend with the prior frame (sometimes) Rearrange the code to premultiply at the blend step, in a linear space. If the client wants unpremul, the blend step will unpremul after. If there is no blending, the colorXform (if any) will premultiply. If only step 1 is necessary, let libwebp premultiply. This fixes an animated image that has an opaque frame 0 followed by a frame with alpha that blends with it. Add the test image that failed (https://mathiasbynens.be/demo/animated-webp) The prior fix is in 42bae8faa4b9b6a3341b15c6ac7c6b466e95625c. It did not properly handle the colorXform when there was no blending step. Change-Id: I2b9d265ba162eaf7e55a106c8f79341826cee0d3 Reviewed-on: https://skia-review.googlesource.com/72281 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* remove Win10 GDI botGravatar Mike Klein2017-11-16
| | | | | | | | | One (Win7) GDI bot is enough. Change-Id: I03312c21e7b6da2a50225fd5dbc50bc69a6bd4c2 Reviewed-on: https://skia-review.googlesource.com/72640 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove Win7/Win8 Perf-Release jobs.Gravatar Ben Wagner2017-11-15
| | | | | | | | | | The bots that execute these jobs produce noisy perf numbers. No-Try: true Change-Id: Icb3a54e324e0823f680042838b6f883ff5937f93 Reviewed-on: https://skia-review.googlesource.com/72200 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove/move remaining Win2k8 GCE jobs.Gravatar Ben Wagner2017-11-15
| | | | | | | | Bug: skia:7305 Change-Id: Ifb270cba27daaef75d3930f990e19215a251ca28 Reviewed-on: https://skia-review.googlesource.com/71921 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove support for image load/storeGravatar Brian Salomon2017-11-15
| | | | | | | | | This isn't used and has become a maintenance burden. Change-Id: I5f3af8f91e5c4f073fe4ea30e0a7f1f61efeea47 Reviewed-on: https://skia-review.googlesource.com/70640 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Move FxAA jobs to Win2016.Gravatar Ben Wagner2017-11-15
| | | | | | | | | Bug: skia:7305 Change-Id: I3cfdb15c11d08143dce66046d66b0ce633277384 No-Try: true Reviewed-on: https://skia-review.googlesource.com/71862 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* remove COLR from the big Vulkan blacklistGravatar Mike Klein2017-11-15
| | | | | | | Change-Id: I15b76d5da795ee01eb7e403721beebf5f67d1bc4 Reviewed-on: https://skia-review.googlesource.com/71920 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update GCE bots to Debian 9.2Gravatar Eric Boren2017-11-15
| | | | | | | | Bug: skia: Change-Id: Ie56f848889cfc7331109aed997a85bc42e27f60e Reviewed-on: https://skia-review.googlesource.com/70724 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Switch Win builders from Win2k8 to Win2016.Gravatar Ben Wagner2017-11-15
| | | | | | | | Bug: skia:7296 Change-Id: Id30df3ed2264679338913f275caa69b8e2278075 Reviewed-on: https://skia-review.googlesource.com/70661 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add back more nexus player blacklists for VulkanGravatar Greg Daniel2017-11-15
| | | | | | | | Bug: skia: Change-Id: I020fe58771d2bd6fd029b5b6a688f78530ef359c Reviewed-on: https://skia-review.googlesource.com/71760 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Fix webp bug compositing alpha frames on opaque"Gravatar Leon Scroggins2017-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 42bae8faa4b9b6a3341b15c6ac7c6b466e95625c. Reason for revert: Breaking GMs. A more extensive fix is needed. Original change's description: > Fix webp bug compositing alpha frames on opaque > > select_xform_alpha is used to determine how the color transform should > handle alpha values. In a similar way, we're using it here to determine > whether to premultiply pixels before blending them. In this case, the > source is unpremul, so we should be premultiplying them, but since we > are compositing on an opaque frame, the dst must be opaque and > select_xform_alpha returns kOpaque. As a result, we do not premultiply > (and even hint to the transform that the pixels are opaque). Since this > all applies to the pre-blended pixels, we should not care that the dst > is opaque. So drop the call to select_xform_alpha and just use the alpha > type of the source. This matches the comment on the lines above. > > Add the test image that failed (https://mathiasbynens.be/demo/animated-webp) > > Change-Id: Ibd13c1f067bdf369ce1c882d4f6057aadccfa313 > Reviewed-on: https://skia-review.googlesource.com/71560 > Commit-Queue: Leon Scroggins <scroggo@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,scroggo@google.com Change-Id: I6f535ff9b773a93e02a0358b830291594a6e738c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/71720 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Fix webp bug compositing alpha frames on opaqueGravatar Leon Scroggins III2017-11-14
| | | | | | | | | | | | | | | | | | | | select_xform_alpha is used to determine how the color transform should handle alpha values. In a similar way, we're using it here to determine whether to premultiply pixels before blending them. In this case, the source is unpremul, so we should be premultiplying them, but since we are compositing on an opaque frame, the dst must be opaque and select_xform_alpha returns kOpaque. As a result, we do not premultiply (and even hint to the transform that the pixels are opaque). Since this all applies to the pre-blended pixels, we should not care that the dst is opaque. So drop the call to select_xform_alpha and just use the alpha type of the source. This matches the comment on the lines above. Add the test image that failed (https://mathiasbynens.be/demo/animated-webp) Change-Id: Ibd13c1f067bdf369ce1c882d4f6057aadccfa313 Reviewed-on: https://skia-review.googlesource.com/71560 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* remove Win2016 NativeFonts botsGravatar Mike Klein2017-11-14
| | | | | | | Change-Id: I7df9d1a9118fbd9c545912a38af4f94276f20b0f Reviewed-on: https://skia-review.googlesource.com/71521 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add Win2016 jobs.Gravatar Ben Wagner2017-11-14
| | | | | | | | | Bug: skia:7197 No-Try: true Change-Id: If2c8939739bc0583a08c0fcb400d28a90599f047 Reviewed-on: https://skia-review.googlesource.com/69401 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-02 15:58:14 +0000