aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipes
Commit message (Collapse)AuthorAge
* Tidy up DM blacklists.Gravatar mtklein2016-09-15
| | | | | | | | | | | No need to blacklist specific instances of configs that won't be run. There's no bug or anything here... this is entirely about keeping the command lines as noise-free as possible. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341963003 Review-Url: https://codereview.chromium.org/2341963003
* Roll recipe DEPSGravatar rmistry2016-09-15
| | | | | | | | BUG=skia:5749 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2339443003
* merge run and check-rc stepsGravatar mtklein2016-09-14
| | | | | | | | | | | This'll make the 'dm' or 'nanobench' step go red like you'd hope. The N5 should pass and the N10 and N7 should fail, showing us both sides. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003 Review-Url: https://codereview.chromium.org/2339713003
* 565 is not this important.Gravatar mtklein2016-09-14
| | | | | | | | | | Reduce its testing and perfing to just the fast Linux bots, and remove it from the default set of dm/nanobench configs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002 Review-Url: https://codereview.chromium.org/2344553002
* update derive_compile_bot_name() for GN_Android_VulkanGravatar mtklein2016-09-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005 Review-Url: https://codereview.chromium.org/2336233005
* Android GN scripts: distingush directories for data and binaries.Gravatar mtklein2016-09-14
| | | | | | | | | This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004 Review-Url: https://codereview.chromium.org/2335203004
* Update gn_android_flavor for Vulkan.Gravatar mtklein2016-09-13
| | | | | | | | | C.f. https://codereview.chromium.org/2336343002 for basic GN support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004 Review-Url: https://codereview.chromium.org/2333293004
* Android GN: don't reboot before runningGravatar mtklein2016-09-13
| | | | | | | | | We're already rebooting after running, so we should already be ready to go when the task starts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003 Review-Url: https://codereview.chromium.org/2334223003
* Remove clear /data/local/tmp steps.Gravatar mtklein2016-09-13
| | | | | | | | | | | | | | | | | | | These were intended to prevent GN and GYP Android bots from stomping on each other. Turns out, they don't, even without this... they're writing most files to completely separate paths: - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher) in /data/local/tmp; - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench) don't overlap GYP's. So clearing /data/local/tmp was essentially just removing GN's data; GYP's data file caching was never affected and can't conflict with GN's. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002 Review-Url: https://codereview.chromium.org/2340473002
* Add back the GalaxyS3 and GalaxyS4 entries in recipesGravatar borenet2016-09-12
| | | | | | | | | | S3 is needed for some recipe simulation stuff and in general having these present does not hurt us. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003 Review-Url: https://codereview.chromium.org/2336513003
* GN: Android perf/testsGravatar mtklein2016-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone. All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts. The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell. Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away. Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware. The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today. It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other. The marked parts can go away when bots are either gn_ or non-gn_ but not both. I have omitted a few steps that may be important, but which are easy independent follow-ups: - running as root - locking clocks - waiting on battery levels - fancier wait-for-ready than adb wait-for-usb-device It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy. I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later. As of PS 41 or so, it looks like the trybots are all behaving as expected. We should expect no new images in Gold. Can we see trybots in Perf yet? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320153002 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot Review-Url: https://codereview.chromium.org/2320153002
* Fix device cfg for GalaxyS7Gravatar borenet2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330093002 Review-Url: https://codereview.chromium.org/2330093002
* most is fine for *SAN bots nowGravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326553002 Review-Url: https://codereview.chromium.org/2326553002
* Clean up target_os=llvm now that it does nothing.Gravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004 Review-Url: https://codereview.chromium.org/2317373004
* GN: add sanitize argGravatar mtklein2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Attempt to take over all *SAN builds. MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py. I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier to use locally. The compile steps should be much faster now. We no longer build CMake and Clang for every run, instead using the clang_linux CIPD package. This removes the need for all the third_party/externals/llvm/... dependencies. Similarly, since we're using the clang_linux package, we no longer depend on Chrome's Clang, and thus no longer need to sync chromium on these bots. Instead of packaging up MSAN libraries and llvm-symbolizer in the compile output, I have the test / perf bots also depend on the clang_linux package. These do not vary from build to build. No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja all track changes to xsan.blacklist without our help. This has the incidental effect of upgrading the compiler used by *SAN bots from Clang 3.8 to Clang 3.9. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002 Review-Url: https://codereview.chromium.org/2289343002
* GN: do not set default GN argsGravatar mtklein2016-09-08
| | | | | | | | | | It's just visual noise... this should make future gn_flavor.py changes show fewer incidental diffs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002 Review-Url: https://codereview.chromium.org/2324573002
* Run install-sysroot script before 'gn gen' on PDFium botGravatar borenet2016-09-07
| | | | | | | BUG=skia:5727 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317013002 Review-Url: https://codereview.chromium.org/2317013002
* New gamut GM, to test gamut conversion in various code-pathsGravatar brianosman2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | After several different strategies, this one appears to work well. The basic test: 1) For a variety of drawing techniques, we render fixed size rectangles. (Solid colors via paint color, bitmap, etc...) 2) For each method in #1, we render to both an sRGB and WideGamutRGB offscreen surface. (AdobeRGB isn't wide enough to clearly demonstrate if things are working or not). 3) Use readPixels to fetch the raw (still in wide gamut) pixel data, then draw that directly to the final canvas. So, for each pair of squares, they should look clearly different. Currently, with the GPU backend, only the bicubic bitmap paths have that behavior. Adding more test cases (and fixing the ones that are already incorrect) will be the long tail of gamut transformation. Current output (with my other patchset, which fixes all bitmap draws): https://screenshot.googleplex.com/wsL3x7eCtWE.png BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293173002 Review-Url: https://codereview.chromium.org/2293173002
* GN: turn off ccacheGravatar mtklein2016-09-07
| | | | | | | | | | | | | | I just burned 2 days debugging a confusing interaction between ccache and the -fsanitize-blacklist argument to Clang. Let's see if we can live without ccache (swarming affinity + Ninja seems pretty decent). As a point of reference, the Mac bots have been looking for ccache but failing to find it. They're proof this will be fine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2310063003 Review-Url: https://codereview.chromium.org/2310063003
* Update Windows build to use VULKAN_SDK rather than VK_SDK_PATHGravatar bsalomon2016-09-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318633002 Review-Url: https://codereview.chromium.org/2318633002
* Add device mapping for Nexus 6p (angler)Gravatar kjlubick2016-09-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311253002 Review-Url: https://codereview.chromium.org/2311253002
* pdfium: Fix the pdfium builder.Gravatar jcgregorio2016-09-02
| | | | | | | BUG=skia:5715 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300703007 Review-Url: https://codereview.chromium.org/2300703007
* GN: Build and link with LLD when using our Clang toolchain.Gravatar mtklein2016-09-01
| | | | | | | | | | | | I am hoping this makes it easier to get *SAN bots going. Today we're generating a libcompiler_rt.a that's using a relocation type that the ld on the bots doesn't know about. This lld is will know about anything our Clang generates. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301273002 Review-Url: https://codereview.chromium.org/2301273002
* The *SAN bots are now all Clang bots.Gravatar mtklein2016-09-01
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306733002 Review-Url: https://codereview.chromium.org/2306733002
* Remove tsan.supp.Gravatar mtklein2016-09-01
| | | | | | | | | | | | The remaining suppression (libwebp) is already covered by the compile-time blacklist, tools/xsan.blacklist. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300193002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-Clang-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot Review-Url: https://codereview.chromium.org/2300193002
* GN: expunge all environment variables that have no effect on GNGravatar mtklein2016-09-01
| | | | | | | | | | This should have no practical effect. I just want to make sure no environment variables beyond $PATH have any effect on GN builds. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300173002 Review-Url: https://codereview.chromium.org/2300173002
* preserve GN_Android in compile -> test mapperGravatar mtklein2016-09-01
| | | | | | | | | doesn't seem anything tests this? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306603002 Review-Url: https://codereview.chromium.org/2306603002
* Remove empty {lsan,ubsan}.supp files.Gravatar mtklein2016-09-01
| | | | | | | | | | | | We never used ubsan.supp, and LSAN suppressions are now built into the test binaries. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Review-Url: https://codereview.chromium.org/2302803003
* Add and use a clang_linux asset.Gravatar mtklein2016-08-31
| | | | | | | | | | This gives us a consistent Clang toolchain on Linux bots, most importantly for *SAN bots. It's ~300MB unpacked. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002 Review-Url: https://codereview.chromium.org/2294353002
* GN: forgot Clang+ccache fix on Android. And sort.Gravatar mtklein2016-08-31
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298203002 No trybots for these yet... NOTRY=true TBR=jcgregorio@google.com Review-Url: https://codereview.chromium.org/2298203002
* add gn_android_flavorGravatar mtklein2016-08-29
| | | | | | | | | | | | | | | | | | | | | | | This ought to support compiles for now. Am I picking up my CIPD ndk packages right? The main thing to note is that I'm passing the target_arch directly through as target_cpu. This means these bots will have a slightly different naming convention than we've been using, but it'll agree with what you must type yourself when using GN to build for Android: - Arm7 -> arm - Arm64 -> arm64 - Mips -> mipsel - Mips64 -> mips64el - x86 -> x86 (unchanged) - x86_64 -> x64 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292663002 Review-Url: https://codereview.chromium.org/2292663002
* GN: support compiler_prefix, use it for ccache on bots.Gravatar mtklein2016-08-26
| | | | | | | | | | | | | | | | | This makes it considerably easier to use ccache with the Android NDK. You can now just set compiler_prefix = "ccache" ndk = "/path/to/ndk" and we'll use the NDK clang, wrapped with ccache. The name compiler_prefix is stolen from / compatible with Chrome. If you have ccache, you can just always leave compiler_prefix="ccache" enabled. This should make it an unusual thing for humans to have to change cc or cxx. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281163002 Review-Url: https://codereview.chromium.org/2281163002
* Add Mac NDK asset, and fetch NDK on Android compile bots.Gravatar mtklein2016-08-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2284813002 Review-Url: https://codereview.chromium.org/2284813002
* Remove SVG serialization suppressionsGravatar fmalita2016-08-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282883002 Review-Url: https://codereview.chromium.org/2282883002
* Add imagemasksubset GMGravatar fmalita2016-08-26
| | | | | | | | | | (GM for non-N32 SkImage subsetting) BUG=skia:5687 R=bsalomon@google.com,robertphillips@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286733002 Review-Url: https://codereview.chromium.org/2286733002
* Apply gerrit ref if it is a Gerrit patch.Gravatar rmistry2016-08-24
| | | | | | | | | | | Also: * Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This will be used by the different frameworks to figure out if it is Rietveld or Gerrit issue. * Calculate issue and patchset for Gerrit patches similar to Rietveld. BUG=skia:5627 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002 Review-Url: https://codereview.chromium.org/2263323002
* compress_r11eac_blocks() required more alignment than dst has.Gravatar mtklein2016-08-22
| | | | | | | | | | | | | | This shouldn't change any behavior except that the stores to dst will no longer require 8-byte alignment. Empirically it seems like we can use 4-byte alignment here, but u8 (i.e. 1-byte alignment) is always safe. BUG=skia:5637 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2264103002
* GN: add extra_cflags et al.Gravatar mtklein2016-08-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding flags to the end of cc or cxx is pretty useful, but these always end up on the command line before the GN generated flags, thus setting defaults that GN will override. For full flexibility we want to be able to add flags after the flags GN has added, so that custom flags can override _it_. I've updated the Fast bots with an example here: if we said cc="clang -O3 ...", that '-O3' would be overriden later by the default Release-mode '-Os'. By putting it in extra_cflags, we get the last word: our '-O3' overrides the default '-Os'. Another good use case is a hypothetical Actually-Shippable-Release mode. Our Release mode bundles in tons of debug symbols via '-g'. libskia.a is about 10x larger than it needs to be when built that way, but it helps us debug the bot failures immensely. To build a libskia.{a,so} that you'd really ship, you can now set extra_cflags="-g0" to override '-g'. You could set '-march' flags there too, '-fomit-frame-pointer', etc. There are lots of flags that won't matter where they end up in the command line. To keep everything simple I've put them in extra_cflags with the rest. This means the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241263003 Review-Url: https://codereview.chromium.org/2241263003
* Disable Nebraska-StateSeal.svg on Win8 botsGravatar fmalita2016-08-16
| | | | | | | | | | Temporary suppression, pending bug fix. BUG=skia:5636 R=robertphillips@google.com,senorblanco@chromium.org GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249763002 Review-Url: https://codereview.chromium.org/2249763002
* Fix up infra bot changeGravatar fmalita2016-08-15
| | | | | | | | | Follow up to https://codereview.chromium.org/2246943002/. R=mtklein@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247903002 Review-Url: https://codereview.chromium.org/2247903002
* [SVGDom] Add opacity supportGravatar fmalita2016-08-15
| | | | | | | | | | Group opacity support. Unlike the other presentation attributes we support thus far, group opacity is not inherited. R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002 Review-Url: https://codereview.chromium.org/2246943002
* Increase hard and io timeouts for CT builds.Gravatar rmistry2016-08-15
| | | | | | | | BUG=skia:5641 TBR=borenet GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249523004 Review-Url: https://codereview.chromium.org/2249523004
* Skip CompressCheckerboard unit test on N6.Gravatar mtklein2016-08-15
| | | | | | | | | | | | | | This is at least one of the failures making the bot red. The particular signal indicates it's probably an alignment problem. BUG=skia:5637 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245063002 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-GCC-Nexus6-CPU-NEON-Arm7-Debug-Trybot TBR=robertphillips@google.com Review-Url: https://codereview.chromium.org/2245063002
* Add extracting GM comments to the housekeeper bot.Gravatar jcgregorio2016-08-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237033002 Review-Url: https://codereview.chromium.org/2237033002
* Turn on SVGs for all Test botsGravatar rmistry2016-08-12
| | | | | | | BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240153002 Review-Url: https://codereview.chromium.org/2240153002
* Use SVGs CIPD package and use SVG as a DM source.Gravatar rmistry2016-08-11
| | | | | | | | | | Currently only turned on for one bot. May turn it on for more after more conversations. BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002 Review-Url: https://codereview.chromium.org/2231943002
* GN: take over some exisiting botsGravatar mtklein2016-08-11
| | | | | | | | | | | | | | | As an experiment, instead of replacing these with -GN twins, take them over in-place. This should take over: -FAST -SKFOO CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002 Review-Url: https://codereview.chromium.org/2229463002
* Move ct_skps recipe from tools repo to Skia repo.Gravatar rmistry2016-08-09
| | | | | | | | | Also move the isolate file and script from Chromium repo to the Skia repo. BUG=skia:5620 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002 Review-Url: https://codereview.chromium.org/2221413002
* [recipes] Smush the rest of builder_spec into appropriate places, other cleanupGravatar borenet2016-08-08
| | | | | | | BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219873003 Review-Url: https://codereview.chromium.org/2219873003
* finish SkLiteDLGravatar mtklein2016-08-07
| | | | | | | | | | | | | - makeThreadsafe() - fix up some alignment problems - drawVertices / drawPatch - work around drawPicture() + default paint bugs? - turn on tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219343002 Review-Url: https://codereview.chromium.org/2219343002
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-30 06:28:27 +0000