aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipes
Commit message (Collapse)AuthorAge
* Fix dm/nanobench uploads for Gerrit-based trybotsGravatar Eric Boren2016-09-27
| | | | | | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2710 Change-Id: I43f03b19a9d7223b67de7dc7c4efea8cb75dba05 Reviewed-on: https://skia-review.googlesource.com/2710 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add swarming task for upload_dm_resultsGravatar borenet2016-09-27
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360203004 Review-Url: https://codereview.chromium.org/2360203004
* Include timestamp in nanobench JSON file nameGravatar borenet2016-09-26
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366623003 TBR=jcgregorio Review-Url: https://codereview.chromium.org/2366623003
* Disable msaa on iHD530 bot.Gravatar benjaminwagner2016-09-23
| | | | | | | BUG=skia:5792 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356213005 Review-Url: https://codereview.chromium.org/2356213005
* GN: ANGLEGravatar mtklein2016-09-23
| | | | | | | | | | | | | | | | Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gl --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 Review-Url: https://codereview.chromium.org/2361983002
* Add swarming task for nanobench uploadGravatar borenet2016-09-23
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003 Review-Url: https://codereview.chromium.org/2364693003
* Run commandbuffer config on CommandBuffer Perf bots.Gravatar mtklein2016-09-22
| | | | | | | | | | | | | Uh, so hey, I just noticed that while the CommandBuffer Test bot runs with --config commandbuffer, the Perf bot just runs as a vanilla GPU bot. Shouldn't we pass --config commandbuffer? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364483002 CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer-Trybot Review-Url: https://codereview.chromium.org/2364483002
* Add recipe support for Intel HD Graphics 530.Gravatar benjaminwagner2016-09-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358183002 Review-Url: https://codereview.chromium.org/2358183002
* GN: take over CommandBuffer botGravatar mtklein2016-09-21
| | | | | | | | | | As you suspected, I see nothing preventing us from building our side of things unconditionally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2358173002
* Add define of SK_ENABLE_VK_LAYERS to gn buildGravatar egdaniel2016-09-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357953002 Review-Url: https://codereview.chromium.org/2357953002
* Blacklist serialize-8888 typefacerendering_pfaMacGravatar mtklein2016-09-20
| | | | | | | | | | | BUG=skia:5778 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356753003 TBR=halcanary@google.com NOTREECHECKS=true CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug-GN-Trybot Review-Url: https://codereview.chromium.org/2356753003
* GN: add skia_use_mesa for OSMesa in tools.Gravatar mtklein2016-09-20
| | | | | | | | | | | | I tested by running $ out/dm --src gm --config mesa $ out/nanobench --config mesa --match Xfermode ... but I ran out of patience waiting for nanobench to finish. Probably works. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357703002 Review-Url: https://codereview.chromium.org/2357703002
* Attempt to fix nanobench uploadGravatar borenet2016-09-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356813003 Review-Url: https://codereview.chromium.org/2356813003
* Disable failing unit tests on adreno vulkanGravatar egdaniel2016-09-20
| | | | | | | | | | As mentioned in the attached bug, these failures all seem to be caused by driver issues that have no workarounds at this time. BUG=skia:5777 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355883002 Review-Url: https://codereview.chromium.org/2355883002
* Revert of Skia recipe: Use [depot_tools]/gsutil.py instead of ↵Gravatar borenet2016-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | [depot_tools]/third_party/gsutil/gsutil (patchset #1 id:1 of https://codereview.chromium.org/2298293002/ ) Reason for revert: Broke all nanobench uploads, eg. https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-Clang-Nexus6p-CPU-Snapdragon810-arm64-Release-GN_Android/builds/154/steps/Upload%20perf%20results/logs/stdio Original issue's description: > Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil > > The latter is being removed in https://codereview.chromium.org/2280023003/ > Is also pinned to 3.25, whereas the former is updated more often. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002 > > Committed: https://skia.googlesource.com/skia/+/f15590f803596f51d0950994b2aeb623d2d1fc24 TBR=hinoka@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2355943002
* GN: add skia_enable_gpu (default true)Gravatar mtklein2016-09-20
| | | | | | | | | | | This lets us replace the NoGPU bot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356853002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2356853002
* Snazzier dump log step on Android bots.Gravatar mtklein2016-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (The failing NexusPlayer bot is a demo.) This should make stack traces more useful, turning this sort of thing 09-20 11:29:39.536 2978 2978 F DEBUG : #00 pc 00970fd0 /data/local/tmp/dm into something like this 09-20 11:29:39.536 2978 2978 F DEBUG : #00 pc 00970fd0 adjust_bounds_to_granularity(SkIRect*, SkIRect const&, VkExtent2D const&, int, int) at /b/work/skia/out/Build-Ubuntu-Clang-x86-Debug-GN_Android_Vulkan/Debug/../../../src/gpu/vk/GrVkGpu.cpp:1803 /data/local/tmp/dm Some bots like the S7 already have good enough stack traces, e.g. 09-20 11:35:12.567 936 936 F DEBUG : #00 pc 00000000000bed6c /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN13QglManagedBuf14ConfirmEntriesEv+108) 09-20 11:35:12.567 936 936 F DEBUG : #01 pc 00000000000b098c /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN9QglBltLib6FillHwEPK10QglBltFillPK15QglBltColorFillPK15QglBltDepthFillPjP12QglBltStatusSB_+588) 09-20 11:35:12.567 936 936 F DEBUG : #02 pc 00000000000b23bc /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN9QglBltLib9FillImageEPK10QglBltFillPK15QglBltColorFillPK15QglBltDepthFillPjP12QglBltStatusSB_+348) 09-20 11:35:12.567 936 936 F DEBUG : #03 pc 000000000009bb00 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16A5xCommandBuffer22PerformConditionalFillEiiP10QglBltFillPK15QglBltColorFillP15QglBltDepthFillP12QglBltStatusS8_+256) 09-20 11:35:12.567 936 936 F DEBUG : #04 pc 000000000009c0c0 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16A5xCommandBuffer23HwWriteSubpassInitClearEP10QglBltFillPK15QglBltColorFillP15QglBltDepthFillP12QglBltStatusS8_+224) 09-20 11:35:12.567 936 936 F DEBUG : #05 pc 0000000000072610 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16QglCommandBuffer18WriteSubpassClearsEv+464) 09-20 11:35:12.567 936 936 F DEBUG : #06 pc 0000000000073ae0 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16QglCommandBuffer12BeginSubpassEv+32) 09-20 11:35:12.567 936 936 F DEBUG : #07 pc 0000000000063120 /system/vendor/lib64/hw/vulkan.msm8996.so (vkCmdBeginRenderPass+224) 09-20 11:35:12.567 936 936 F DEBUG : #08 pc 0000000000635f60 /data/local/tmp/nanobench (_ZN24GrVkPrimaryCommandBuffer15beginRenderPassEPK7GrVkGpuPK14GrVkRenderPassjPK12VkClearValueRK16GrVkRenderTargetRK7SkIRectb+132) or 09-20 11:42:24.557 937 937 F DEBUG : backtrace: 09-20 11:42:24.557 937 937 F DEBUG : #00 pc 0000000000069404 /system/lib64/libc.so (tgkill+8) 09-20 11:42:24.557 937 937 F DEBUG : #01 pc 0000000000066b94 /system/lib64/libc.so (pthread_kill+68) 09-20 11:42:24.557 937 937 F DEBUG : #02 pc 0000000000023a28 /system/lib64/libc.so (raise+28) 09-20 11:42:24.557 937 937 F DEBUG : #03 pc 000000000001e358 /system/lib64/libc.so (abort+60) 09-20 11:42:24.557 937 937 F DEBUG : #04 pc 000000000076430c /data/local/tmp/dm (_Z17sk_abort_no_printv+8) These won't be affected. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351243002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2351243002
* Blacklist incomplete pngs on CGGravatar msarett2016-09-20
| | | | | | | BUG=skia:5774 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351083002 Review-Url: https://codereview.chromium.org/2351083002
* Reland of Run SVGs through nanobench on all Perf bots (patchset #1 id:1 of ↵Gravatar rmistry2016-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2348563003/ ) Reason for revert: skbug/5770 has been fixed. Trying out trybots to see if this can be relanded. Original issue's description: > Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 of https://codereview.chromium.org/2343903002/ ) > > Reason for revert: > Causing failures: > https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812 > > Original issue's description: > > Run SVGs through nanobench on all Perf bots. > > > > Tested with: > > python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001 > > > > Example output is here: > > https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410 > > Nanobench did run on SVGs. > > > > BUG=skia:5757 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002 > > > > Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52 > > TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:5757 > > Committed: https://skia.googlesource.com/skia/+/be7e3c0db3caa7a86ae233a6bd26281817b83882 TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350233002 Review-Url: https://codereview.chromium.org/2350233002
* Skia recipe: Use [depot_tools]/gsutil.py instead of ↵Gravatar hinoka2016-09-19
| | | | | | | | | | | | [depot_tools]/third_party/gsutil/gsutil The latter is being removed in https://codereview.chromium.org/2280023003/ Is also pinned to 3.25, whereas the former is updated more often. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002 Review-Url: https://codereview.chromium.org/2298293002
* GN: remove old Android recipe code.Gravatar mtklein2016-09-19
| | | | | | | | | | | All the Android builders, testers, and perfers are on gn_android_flavor now. Not as scary as it looks... all the big line count changes are deletes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002 Review-Url: https://codereview.chromium.org/2352653002
* Delete unused coverage recipe code.Gravatar mtklein2016-09-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353483003 Review-Url: https://codereview.chromium.org/2353483003
* Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 ↵Gravatar rmistry2016-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/2343903002/ ) Reason for revert: Causing failures: https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812 Original issue's description: > Run SVGs through nanobench on all Perf bots. > > Tested with: > python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001 > > Example output is here: > https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410 > Nanobench did run on SVGs. > > BUG=skia:5757 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002 > > Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52 TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5757 Review-Url: https://codereview.chromium.org/2348563003
* Build with GN on CT bots.Gravatar mtklein2016-09-16
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347203002 Review-Url: https://codereview.chromium.org/2347203002
* Run SVGs through nanobench on all Perf bots.Gravatar rmistry2016-09-16
| | | | | | | | | | | | | | Tested with: python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001 Example output is here: https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410 Nanobench did run on SVGs. BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002 Review-Url: https://codereview.chromium.org/2343903002
* GN: enable Vulkan on Android when API >= 24.Gravatar mtklein2016-09-16
| | | | | | | | | | | Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'. If for some reason you wanted to turn it off, you can still override skia_use_vulkan. The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003 Review-Url: https://codereview.chromium.org/2347843003
* GN: port Valgrind bots.Gravatar mtklein2016-09-15
| | | | | | | | | This was suspiciously easy... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342923002 Review-Url: https://codereview.chromium.org/2342923002
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot Review-Url: https://codereview.chromium.org/2340463008
* Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of ↵Gravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2340463008/ ) Reason for revert: https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304 Original issue's description: > GN: support 32-bit x86 builds > > Take over Ubuntu -x86- bots. > > Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. > We'll want target_cpu="x86" there too. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 > > Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 TBR=jcgregorio@google.com,borenet@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2338173004
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Review-Url: https://codereview.chromium.org/2340463008
* Blacklist slsrgb + image decoding.Gravatar mtklein2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345723003 Review-Url: https://codereview.chromium.org/2345723003
* Fix NoGPU bot, which is compiling in GPU supportGravatar borenet2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342683003 Review-Url: https://codereview.chromium.org/2342683003
* Pass rietveld as the default patch_storage.Gravatar mtklein2016-09-15
| | | | | | | | | | | | Passing around empty strings as command line arguments requires us to be really careful about command line quoting, parsing, etc. It seems easy enough here to just supply the implied value. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003 Review-Url: https://codereview.chromium.org/2323233003
* Tidy up DM blacklists.Gravatar mtklein2016-09-15
| | | | | | | | | | | No need to blacklist specific instances of configs that won't be run. There's no bug or anything here... this is entirely about keeping the command lines as noise-free as possible. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341963003 Review-Url: https://codereview.chromium.org/2341963003
* Roll recipe DEPSGravatar rmistry2016-09-15
| | | | | | | | BUG=skia:5749 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2339443003
* merge run and check-rc stepsGravatar mtklein2016-09-14
| | | | | | | | | | | This'll make the 'dm' or 'nanobench' step go red like you'd hope. The N5 should pass and the N10 and N7 should fail, showing us both sides. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003 Review-Url: https://codereview.chromium.org/2339713003
* 565 is not this important.Gravatar mtklein2016-09-14
| | | | | | | | | | Reduce its testing and perfing to just the fast Linux bots, and remove it from the default set of dm/nanobench configs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002 Review-Url: https://codereview.chromium.org/2344553002
* update derive_compile_bot_name() for GN_Android_VulkanGravatar mtklein2016-09-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005 Review-Url: https://codereview.chromium.org/2336233005
* Android GN scripts: distingush directories for data and binaries.Gravatar mtklein2016-09-14
| | | | | | | | | This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004 Review-Url: https://codereview.chromium.org/2335203004
* Update gn_android_flavor for Vulkan.Gravatar mtklein2016-09-13
| | | | | | | | | C.f. https://codereview.chromium.org/2336343002 for basic GN support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004 Review-Url: https://codereview.chromium.org/2333293004
* Android GN: don't reboot before runningGravatar mtklein2016-09-13
| | | | | | | | | We're already rebooting after running, so we should already be ready to go when the task starts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003 Review-Url: https://codereview.chromium.org/2334223003
* Remove clear /data/local/tmp steps.Gravatar mtklein2016-09-13
| | | | | | | | | | | | | | | | | | | These were intended to prevent GN and GYP Android bots from stomping on each other. Turns out, they don't, even without this... they're writing most files to completely separate paths: - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher) in /data/local/tmp; - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench) don't overlap GYP's. So clearing /data/local/tmp was essentially just removing GN's data; GYP's data file caching was never affected and can't conflict with GN's. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002 Review-Url: https://codereview.chromium.org/2340473002
* Add back the GalaxyS3 and GalaxyS4 entries in recipesGravatar borenet2016-09-12
| | | | | | | | | | S3 is needed for some recipe simulation stuff and in general having these present does not hurt us. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003 Review-Url: https://codereview.chromium.org/2336513003
* GN: Android perf/testsGravatar mtklein2016-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone. All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts. The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell. Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away. Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware. The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today. It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other. The marked parts can go away when bots are either gn_ or non-gn_ but not both. I have omitted a few steps that may be important, but which are easy independent follow-ups: - running as root - locking clocks - waiting on battery levels - fancier wait-for-ready than adb wait-for-usb-device It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy. I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later. As of PS 41 or so, it looks like the trybots are all behaving as expected. We should expect no new images in Gold. Can we see trybots in Perf yet? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320153002 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot Review-Url: https://codereview.chromium.org/2320153002
* Fix device cfg for GalaxyS7Gravatar borenet2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330093002 Review-Url: https://codereview.chromium.org/2330093002
* most is fine for *SAN bots nowGravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326553002 Review-Url: https://codereview.chromium.org/2326553002
* Clean up target_os=llvm now that it does nothing.Gravatar mtklein2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004 Review-Url: https://codereview.chromium.org/2317373004
* GN: add sanitize argGravatar mtklein2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Attempt to take over all *SAN builds. MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py. I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier to use locally. The compile steps should be much faster now. We no longer build CMake and Clang for every run, instead using the clang_linux CIPD package. This removes the need for all the third_party/externals/llvm/... dependencies. Similarly, since we're using the clang_linux package, we no longer depend on Chrome's Clang, and thus no longer need to sync chromium on these bots. Instead of packaging up MSAN libraries and llvm-symbolizer in the compile output, I have the test / perf bots also depend on the clang_linux package. These do not vary from build to build. No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja all track changes to xsan.blacklist without our help. This has the incidental effect of upgrading the compiler used by *SAN bots from Clang 3.8 to Clang 3.9. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002 Review-Url: https://codereview.chromium.org/2289343002
* GN: do not set default GN argsGravatar mtklein2016-09-08
| | | | | | | | | | It's just visual noise... this should make future gn_flavor.py changes show fewer incidental diffs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002 Review-Url: https://codereview.chromium.org/2324573002
* Run install-sysroot script before 'gn gen' on PDFium botGravatar borenet2016-09-07
| | | | | | | BUG=skia:5727 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317013002 Review-Url: https://codereview.chromium.org/2317013002
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-08 12:26:33 +0000