aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipes
Commit message (Collapse)AuthorAge
* Specify CPU for CT Swarming tasks.Gravatar Ben Wagner2017-09-25
| | | | | | | | | | | | | This ensures we are doing apples-to-apples comparison across runs. The Chrome-GPU pool has different machines with the same GPU, so it's important to lock down to a specific CPU for perf testing. No-Try: true Change-Id: I66648c4ea58b835af0a63d36f4830b26d7c65c5f Reviewed-on: https://skia-review.googlesource.com/50760 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Make ct_skps and recreate_skps recipes shell to gsutilGravatar Ravi Mistry2017-09-25
| | | | | | | | | | # Trybots already ran @patchset3 NoTry: true Bug: skia:7065 Change-Id: Ib961c5d85f9b1491efe2539dae47f6813590b8fa Reviewed-on: https://skia-review.googlesource.com/50500 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [infra] Bring recipe DEPS up to dateGravatar Eric Boren2017-09-22
| | | | | | | | Bug: skia: Change-Id: Iee3a94e56d1c8992f844f2b67d0bb565dd896684 Reviewed-on: https://skia-review.googlesource.com/50262 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Set report_signal_unsafe=0 on TSAN bots.Gravatar Mike Klein2017-09-22
| | | | | | | | | | | | We don't really care about report_signal_unsafe. Our signal handlers all just dump out a stack trace and crash. If they crash themselves due to signal unsafe code, no big deal. (I've never seen that happen.) Change-Id: Ibb90b2b323d88a56d64e6ea62b9c0924a4e41444 Reviewed-on: https://skia-review.googlesource.com/50120 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Turn on GPU threading by default to get better test/perf coverageGravatar Brian Osman2017-09-22
| | | | | | | | | | | Explicitly disable it on PixelC. This is arbitrary, so we continue to get coverage of the single-threaded code. Bug: skia: Change-Id: I0ac91f7ca58652933db452720f353068cf2d0f2d Reviewed-on: https://skia-review.googlesource.com/50000 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* [WASM] Add POC compile bot for WebAssemblyGravatar Kevin Lubick2017-09-21
| | | | | | | | | | | | | | | | | | | | Fix core.gni to use not use Assembler for none cpu. Right now, there are no outputs because we aren't compiling dm or nanobench. However, this still compiles the skia library and creates two executables, so it's a good canary for a real WASM build. Additional note: the two executables in question don't draw anything to the screen via GL, which is still not possible with Skia+WASM. Bug: skia: Change-Id: I0d767467e94e40d01070e34223dd90e96f1c96f2 Reviewed-on: https://skia-review.googlesource.com/49540 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com>
* Fix float-cast-overflow in SkTypeface_FreeType::onGetAdvancedMetricsGravatar Ben Wagner2017-09-20
| | | | | | | | Bug: skia:4632 Change-Id: Id2ee217787e6741011f324951f11eeefc55f62b9 Reviewed-on: https://skia-review.googlesource.com/47321 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Fix float-cast-overflow in SkOpSpan::sortableTop.Gravatar Ben Wagner2017-09-19
| | | | | | | | Bug: skia:4632 Change-Id: I5af8bb7b04673307cdf7865bb7d56a041ba27d83 Reviewed-on: https://skia-review.googlesource.com/47320 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Change SkScalarTruncToInt to saturate.Gravatar Ben Wagner2017-09-18
| | | | | | | | | | | This is the same behavior as SkScalarFloorToInt, SkScalarCeilToInt, and SkScalarRoundToInt. Bug: skia:4632 Change-Id: Iec454e841b05c5b10f335b5b089718db56740323 Reviewed-on: https://skia-review.googlesource.com/47400 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Suppress float-cast-overflow for double-to-float in SkMatrix{,44}Gravatar Ben Wagner2017-09-18
| | | | | | | | | | No API change. Bug: skia:4632 Change-Id: Ic9cb9de7cce8aca43f0ce8066abcc44a0b04ca84 Reviewed-on: https://skia-review.googlesource.com/47681 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Suppress float-cast-overflow in SkPoint::Length.Gravatar Ben Wagner2017-09-16
| | | | | | | | Bug: skia:4632 Change-Id: I0f8a7d7a11fc76fcb315c3f0183577c3f0958926 Reviewed-on: https://skia-review.googlesource.com/47421 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Blacklist failing tests for IB1Gravatar Kevin Lubick2017-09-15
| | | | | | | | | | Bug: skia: NOTRY=true Change-Id: I2a774ca2533572eaf284101cd6ea11b816c1441a Reviewed-on: https://skia-review.googlesource.com/47080 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [infra] Use int for internal_hardware_labelGravatar Eric Boren2017-09-15
| | | | | | | | Bug: skia: Change-Id: I86c4160e0c65c9f8459087e34eaf39907a76c9da Reviewed-on: https://skia-review.googlesource.com/47182 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Rename internal_bot_id -> internal_hardware_labelGravatar Eric Boren2017-09-15
| | | | | | | | | Bug: skia: Change-Id: I1a2442898c8eca8cf36d8e85d2acf1d048ebfb54 Reviewed-on: https://skia-review.googlesource.com/46849 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Always upload Gold images to the same bucketGravatar Eric Boren2017-09-15
| | | | | | | | | | | But respect the passed-in bucket for verbose logs and JSON summary. Bug: skia: Change-Id: If57c16538802125c087b76991a0ca45b0a33beb2 Reviewed-on: https://skia-review.googlesource.com/46721 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Add internal_bot_id flag to recipesGravatar Eric Boren2017-09-15
| | | | | | | | | | Allows differentiation between internal bots in recipes. Bug: skia: Change-Id: I7130f2adc13dd01f7572856ea64c428a6adf56ba Reviewed-on: https://skia-review.googlesource.com/46844 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Use Chrome-GPU pool for CT GPU runsGravatar Ravi Mistry2017-09-13
| | | | | | | | | Bug: chromium:700053 NoTry: true Change-Id: Ib62ea29f5192df1b03e9d8caecb6af4daeee0e49 Reviewed-on: https://skia-review.googlesource.com/46060 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add new task to run the float-cast-overflow sanitizer.Gravatar Ben Wagner2017-09-13
| | | | | | | | | Bug: skia:4632 No-Try: true Change-Id: I85a0b23037d5885e5d762788d8bf5b7cc6fc19b2 Reviewed-on: https://skia-review.googlesource.com/45980 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Make output of all tests verboseGravatar Stephan Altmueller2017-09-12
| | | | | | | | | | | | | | | Re-enable more verbose output across all bots. There is no good reason why we shouldn't collect additional information that helps triaging failure. Some of the current output might have to be expanded down the road. Bug: skia: Change-Id: I5ff89a803f1e390bbd859756cba53a359d2801ba Reviewed-on: https://skia-review.googlesource.com/45140 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Omit encode-platform also for Debug Mac CPU.Gravatar Ben Wagner2017-09-08
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: I824e44f0e9f08f607aa3aaa5e0074bce72a2b4ee Reviewed-on: https://skia-review.googlesource.com/44202 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update NexusPlayers to Android O PR6.Gravatar Ben Wagner2017-09-08
| | | | | | | | No-Try: true Change-Id: I0abb5e6d9d705d352089024a303d2f8be0f051aa Reviewed-on: https://skia-review.googlesource.com/43203 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Only run CPU SVG tests on a single botGravatar Chris Dalton2017-09-07
| | | | | | | | | | | | | Runs the testing on Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN. We only care about parsing SVGs CPU-side so there's no need to retest it on every bot. Bug: skia:6918 Change-Id: If2c5afbc41a600ece63d9a6a60f0dab5ca7b3676 Reviewed-on: https://skia-review.googlesource.com/43461 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Blacklist more flaky GMs in gltestthreading configGravatar Brian Osman2017-09-07
| | | | | | | | Bug: skia:7011 skia:6544 Change-Id: Idacb5ff8090bea6ddbdef710bc0f4dbb8bd23549 Reviewed-on: https://skia-review.googlesource.com/43560 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Omit flaky encode-platform test for pic-8888 Mac CPU.Gravatar Ben Wagner2017-09-05
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: I8141afb1706b1434bacc62f6b6f9b69876a92b2c Reviewed-on: https://skia-review.googlesource.com/42680 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Blacklist (flaky) textbloblooper on gltestthreadingGravatar Brian Osman2017-08-31
| | | | | | | | Bug: skia: Change-Id: I10ddc36f39800e3d86145054b994a6899573a63a Reviewed-on: https://skia-review.googlesource.com/41501 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Fix chromecast perfsGravatar Kevin Lubick2017-08-31
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: I5efe4bc59efa4bc81e5f8811fed7867ec20447fb Reviewed-on: https://skia-review.googlesource.com/41541 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add Correctness tests for ChromecastGravatar Kevin Lubick2017-08-31
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Ib604bad8eda6ba4382b850f7c5f318fb0f114401 Reviewed-on: https://skia-review.googlesource.com/20051 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Threaded generation of software pathsGravatar Brian Osman2017-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | Re-land of: https://skia-review.googlesource.com/36560 All information needed by the thread is captured by the prepare callback object, the lambda captures a pointer to that, and does the mask render. Once it's done, it signals the semaphore (also owned by the callback). The callback defers the semaphore wait even longer (into the ASAP upload), so the odds of waiting for the thread are REALLY low. Also did a bunch of cleanup along the way, and put in some trace markers so we can monitor how well this is working. Traces of a GM that includes GPU and SW path rendering (path-reverse): Original: https://screenshot.googleplex.com/f5BG3901tQg.png Threaded, with wait in the callback (notice pre flush callback blocking): https://screenshot.googleplex.com/htOSZFE2s04.png Current version, with wait deferred to ASAP upload function: https://screenshot.googleplex.com/GHjD0U3C34q.png Bug: skia: Change-Id: Idb92f385590749f41328a9aec65b2a93f4775079 Reviewed-on: https://skia-review.googlesource.com/40775 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Threaded generation of software paths"Gravatar Brian Salomon2017-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 76323bc0615044a5921afef0e19a350f3d04ffe0. Reason for revert: Breaking NUC bots in threaded gm comparison: https://chromium-swarm.appspot.com/task?id=382e589753187f10&refresh=10 Original change's description: > Threaded generation of software paths > > All information needed by the thread is captured by the prepare > callback object, the lambda captures a pointer to that, and does the > mask render. Once it's done, it signals the semaphore (also owned by the > callback). The callback defers the semaphore wait even longer (into the > ASAP upload), so the odds of waiting for the thread are REALLY low. > > Also did a bunch of cleanup along the way, and put in some trace markers > so we can monitor how well this is working. > > Traces of a GM that includes GPU and SW path rendering (path-reverse): > > Original: > https://screenshot.googleplex.com/f5BG3901tQg.png > Threaded, with wait in the callback (notice pre flush callback blocking): > https://screenshot.googleplex.com/htOSZFE2s04.png > Current version, with wait deferred to ASAP upload function: > https://screenshot.googleplex.com/GHjD0U3C34q.png > > Bug: skia: > Change-Id: I3d5a230bbd68eb35e1f0574b308485c691435790 > Reviewed-on: https://skia-review.googlesource.com/36560 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,mtklein@google.com,bsalomon@google.com,robertphillips@google.com,brianosman@google.com Change-Id: Icac0918a3771859f671b69ae07ae0fedd3ebb3db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/38560 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Threaded generation of software pathsGravatar Brian Osman2017-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | | All information needed by the thread is captured by the prepare callback object, the lambda captures a pointer to that, and does the mask render. Once it's done, it signals the semaphore (also owned by the callback). The callback defers the semaphore wait even longer (into the ASAP upload), so the odds of waiting for the thread are REALLY low. Also did a bunch of cleanup along the way, and put in some trace markers so we can monitor how well this is working. Traces of a GM that includes GPU and SW path rendering (path-reverse): Original: https://screenshot.googleplex.com/f5BG3901tQg.png Threaded, with wait in the callback (notice pre flush callback blocking): https://screenshot.googleplex.com/htOSZFE2s04.png Current version, with wait deferred to ASAP upload function: https://screenshot.googleplex.com/GHjD0U3C34q.png Bug: skia: Change-Id: I3d5a230bbd68eb35e1f0574b308485c691435790 Reviewed-on: https://skia-review.googlesource.com/36560 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Omit flakily failing test.Gravatar Ben Wagner2017-08-23
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: Ie2726fd80f0baf03bdea5148e45b909ac88340f6 Reviewed-on: https://skia-review.googlesource.com/37740 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Disable questionable bmps on Mac platform decoderGravatar Leon Scroggins III2017-08-18
| | | | | | | | | | These are already disabled on WIC, but they are supported by SkCodec. Bug: skia:6984 Change-Id: Ib248749f357debcc173dfaa2bcd5adc8da52df22 Reviewed-on: https://skia-review.googlesource.com/36440 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Rename Mac bots to match reality.Gravatar Ben Wagner2017-08-18
| | | | | | | | | | | | Doing this separately from https://skia-review.googlesource.com/c/36040 to avoid confusion. No-Try: true Change-Id: I2d9e03c6da6096f9e14145d9654b9da7a8670036 Reviewed-on: https://skia-review.googlesource.com/35823 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add SurfacePro2017 tasks.Gravatar Ben Wagner2017-08-17
| | | | | | | | | | | | Not adding Vulkan configs because it mostly produces garbage -- see skia:6398. Bug: skia:6978 NoTry: true Change-Id: I8f9fa7ecc5d195658944f8f29a91ddaf47c066fc Reviewed-on: https://skia-review.googlesource.com/35321 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Blacklist svgparse_* svgs on non-8888Gravatar Chris Dalton2017-08-15
| | | | | | | | | | | This also required extending the blacklist argument to support negative matching and wildcards. Bug: skia:6918 Change-Id: I915e305c75fe23fc3e11c2dd3e91570967da0aaa Reviewed-on: https://skia-review.googlesource.com/31444 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add tasks for Acer R13Gravatar Kevin Lubick2017-08-15
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Iafc9a00ff2a41919214cdea89251ceb0c5b443c5 Reviewed-on: https://skia-review.googlesource.com/34721 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Run perf tests on glsrgb and glessrgb configs.Gravatar Ben Wagner2017-08-14
| | | | | | | | No-Try: true Change-Id: I41dfddf21f8ed80582d5dc88150e1fbaf98326e6 Reviewed-on: https://skia-review.googlesource.com/33803 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Omit failing test for IntelIris640 Ubuntu Vulkan.Gravatar Ben Wagner2017-08-11
| | | | | | | | | Bug: skia:6245 Change-Id: Id5e0704f51537abf4ed2794d67ab8424a725e1bc No-Try: true Reviewed-on: https://skia-review.googlesource.com/33801 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add new Linux IntelIris640 jobs.Gravatar Ben Wagner2017-08-11
| | | | | | | | | Bug: skia:6761 Change-Id: I635958a482a16fc7027d33152db431cb8c5bbe2c No-Try: true Reviewed-on: https://skia-review.googlesource.com/33740 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Abort dm/nanobench on bad configs.Gravatar Ben Wagner2017-08-11
| | | | | | | | | Adjust the configs specified by recipes to avoid the new error. Change-Id: I23e31355e2faaab919d92abdb37a6f70cd2da1ff Reviewed-on: https://skia-review.googlesource.com/32862 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix undefined flag for MSAN.Gravatar Ben Wagner2017-08-10
| | | | | | | | | | | | MSAN started failing after https://skia-review.googlesource.com/c/32722. This should fix it. No-Try: true Change-Id: I8956c8c211507923f078fe96921fedaadefae8a8 Reviewed-on: https://skia-review.googlesource.com/32942 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Test non-msaa instanced rendering on MacGravatar Brian Salomon2017-08-10
| | | | | | | Change-Id: I28b67ccef7bb72e4853a0eb02d1de00b1ed40cce Reviewed-on: https://skia-review.googlesource.com/33001 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove --undefok from recipes.Gravatar Ben Wagner2017-08-10
| | | | | | | | | | Since recipes are now versioned with the code, this is unnecessary and could mask recipe bugs. Change-Id: Ic5aafbd3a7e9ccd3fd529c71b282cf6b037b78df Reviewed-on: https://skia-review.googlesource.com/32722 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add duplicate Valgrind tasks on QuadroP400.Gravatar Ben Wagner2017-08-09
| | | | | | | | | | | | | | | | | Valgrind 3.13.0 only supports up to AVX2, so I used SK_CPU_LIMIT_SSE41 to avoid failing with "Unrecognised instruction." (The existing Valgrind tasks run on a ShuttleA machine, whose CPU only supports AVX.) Needed to enable verbose output on all Valgrind tasks to avoid Swarming I/O timeout. Opportunistically removed verbose output for Linux Intel bots that are no longer failing. Bug: skia:6881 Change-Id: I2ffa6efe901c97bd2e0bbc9b26632aafbb3cf9a6 No-Try: true Reviewed-on: https://skia-review.googlesource.com/31143 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Revert "Bring recipes up to date."Gravatar Eric Boren2017-08-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e4024d5dabe022bf988490162251d96cf717cdcb. Reason for revert: Breaking Win bots Original change's description: > Bring recipes up to date. > > * Move recipe_engine URL to new canonical URL > * Add README.recipes.md (auto-generated doc from docstrings in repo, > regenerated with `recipes.py test train`). > * Bring depot_tools up to date > > recipe_engine: > 464fc26 Update a couple more URLs. > 38808d0 Switch recipes-py CQ to Gerrit > c7cdc9c Update canonical URL. > 6bac51f Fix urls to googlesource. > 5cf5e58 Convert code review to Gerrit > e92def4 Add source manifest proto to recipe_engine. > e0ddd60 Move internal downstream recipe roll trybots to production > 3cae8e9 Add file.filesizes to recipe engine core modules. > 862f333 Vendor 'luci_context' library. > 6de5241 Add add_json_log='on_failure' to json module. > e183af0 [recipe_engine] Set presentation.status before OutputPlaceholder.result. > 3b99cdd Fix "recipes.py test diff" not raising a failure > 8e8339a [path] Fix root path mocking. > 00799cc Add experimental internal downstream recipe trybots > 0ca88ae Pretty up all recipe_engine documentation. > de3238c Fix UnboundLocalError in find_recipe. > 9b47d24 Move downstream recipe roll trybots to production > da3467b Recursively apply recipe overrides > 3d76281 [uuid] Remove unused uuid module > 9959b07 Remove shutil module. > 26475d6 Add more experimental downstream trybots > 5c349eb [file] allow glob to handle nested patterns > 12e7ca4 recipes.py test: enforce recipe expectations literally > 241ddc2 [file] fix glob_paths when NO paths match, add tests. > 11d7598 [file] Allow placeholders in file.copy > 9419a0e [doc] Put all external URLs in a single section. > 4b6b21e [doc] Fix randomization of DEPS link order, give DEPS links fully qualified names > 3ac778e [recipe_autoroller] regen docs on trivial rolls too. > c8d78bf [doc] Automatically generate and update cross-indexed recipe markdown files. > 5873ef2 Fix "env_prefixes" rendering. > > depot_tools: > fb3fa785 Roll recipe dependencies (trivial). > a643e9e3 Update patch_projects crap for googlesource repos in infra. > fb391fcd [gclient config] Update luci project URLs (ugh) > 590a4189 Roll recipe dependencies (trivial). > 8e6a5e6e Roll recipe dependencies (trivial). > 0e5f57ec [recipes.cfg] Update recipes.cfg to new canonical recipe URL. > 704d6ad8 Roll recipe dependencies (trivial). > f1205599 Roll recipe dependencies (trivial). > 243c9643 Roll recipe dependencies (trivial). > e866182f depot_tools: Fix executable bit for gerrit_*.py > 4759fc62 Roll recipe dependencies (trivial). > 7ab47354 Roll recipe dependencies (trivial). > 554e2bff Roll recipe dependencies (trivial). > 9e8c78d2 Roll recipe dependencies (trivial). > b0ad16ee gclient flatten: do not recurse into deps not in recursedeps > d9f97bc5 Use https for short URLs wherever applicable (MoarTLS). > c9353605 gclient flatten: fixes for chromium/src > ecdfa41d Fix quoting in update_depot_tools. > 1407d00d gclient: make variables from parent DEPS scope override ones in inner scope > 07a6bea9 Expose ast via InputApi > e864a3f2 Remove presubmit check for DISALLOW_* macros > e1054034 fetch_end_to_end_test: add recipe > 8b478f04 PRESUBMIT: Be resilient to changes with no Code-Review label > 8038dfe3 bot_update recipe: parameterize step name in apply_gerrit_ref > 5aeeb72c [bootstraps] Sync at gclient, suppress output (#2) > eb1feb90 [cipd] Bump version, log at warning (#2). > 9f9d82ac Revert "[cipd] Bump version, log at warning." > 18aa2d93 [cipd] Bump version, log at warning. > fc6196b3 gclient flatten: preserve variable placeholders (reland #1) > 5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref() > 56766f1d Add experimental downstream recipe trybots to depot_tools > 44855b94 Revert "[bootstraps] Sync at gclient, suppress output." > 393ba066 Revert "gclient flatten: preserve variable placeholders" > e79ddeaa gclient flatten: preserve variable placeholders > 5a80eab0 Use -prerelease flag to vswhere when packaging VS > 4d92fe43 [bootstraps] Sync at gclient, suppress output. > 357415cb gclient flatten: fix a bug with some recursedeps not being processed > 3d6363b3 Roll recipe dependencies (trivial). > b396315c Bump led version. > a3a515a4 Revert "Generalize git index refresh to bot_update." > 06e1aa07 Generalize git index refresh to bot_update. > 7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat. > f7543cdd git-cl: accept --force for -f everywhere > 642dd84c [win/bootstrap] Use "for" instead of "set". > ca01e2c8 git cl issue 0: Remove Change-Id from message, not description > 290f5f56 Remove "create-ntfs-junction". > ff9a5dec Roll recipe dependencies (trivial). > d2dbea66 Roll recipe dependencies (trivial). > fc62f768 Simplify notify behavior in git-cl > cfbb775f Roll recipe dependencies (trivial). > ae895075 Use doseq=True when re-encoding url query parameters > 98681d11 Remove obsolete destination-branch-check flag > 8aa774cf Fix bot_update example > dd1bc7c0 [cipd] Generate other platform suffixes. > 383ace4b Fix git-crrev-parse on Mac. > e5adf612 Fix typo with --send-email [sic] flags > 0ed616a4 Roll recipe dependencies (trivial). > 636b13fc Let Changelist().AddComment() mark changes as Ready > 68b54e78 [bootstrap/win] Upgrade Python to 2.7.13. > f3d5a114 Enable Gerrit-destination-branch check by default > 31f3e63c Revert "Revert "[tryserver] Remove unused methods."" > c4dd3e82 [bootstrap/win] Remove support for legacy installs > cc27ecb0 Revert "[tryserver] Remove unused methods." > 68f6f279 [bootstrap/win] Always use "cipd.bat". > 3a8717e1 [bootstrap/win] Remove legacy Git support. > 6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug. > 4e5207d6 git-cl issue 0: Don't operate on empty description > 22a9cf54 git_footers: fix bug stdin-based message input. > 02e59414 Fix bot_update's usage of the destination branch > 83eb1cd5 Roll recipe dependencies (trivial). > 400e989b 'git cl issue 0': Remove Change-Id > 133ac1ab [tryserver] Remove unused methods. > b08ba657 git_footer: be more resilient to malformed footers > 9d842bab [recipe_modules/git] Remove logging. > 3d9b5881 [win_tools] Use bundled Python CIPD packages (#2). > 209a681f [git] Remove hard-coded "depot_tools" Git. > e8eed65f Always copy "python.bat". > aab09ca6 Whitelist "python_bin_reldir.txt". > af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages." > 7dadf05d Query Gerrit for destination branch in bot_update > bf144679 [win_tools] Use bundled Python CIPD packages. > b80fac66 Roll recipe dependencies (trivial). > 265255f5 [bootstrap/win] Replace "python.bat" only on downgrade. > 24025d3e tryserver: add support for gerrit footers > 903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages > 49b8147b Add support to query a CL's branch to gerrit recipe module > 4cb9d742 [bootstrap/win] Enable revert from upcoming patch. > 13e88538 Ignore the ".bleeding_edge" file. > c8173825 git cl creds-check: improve report and give better recommendation. > 4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move > 9cb802ca Improve gerrit recipe_module example > 79e897b0 [git_bootstrap] Support new Git bundles. > 8af46469 Roll recipe dependencies (trivial). > 1f767e17 Fix autoninja.py for ninja -t compatibility > 7466d1a9 [cipd] Run client in .bat to preserve STDIN. > 13f258bf Remove SVN bootstrapping and some tooling. > b12c5256 Roll recipe dependencies (trivial). > 016f92e6 Roll recipe dependencies (trivial). > 68506985 Roll recipe dependencies (trivial). > 215ded77 Fix testFlattenPinAllDeps > 271a1680 gclient flatten: implement --pin-all-deps > fb022017 gclient flatten: include vars > e36a8431 Roll recipe dependencies (trivial). > de37c012 Fix git-numberer swallowing of footers for Rietveld. > 4e89144a git-cl: fix auth error message computation > 7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently. > aaf93f48 gclient flatten: refactor flatten code to a class > 807caf84 gclient flatten: remove --require-pinned-revisions > 6fbf12f2 Enable query for changes in gerrit recipe module > c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps > 4baaa11c gclient: avoid adding potentially duplicate entries to work queue > d3790251 gclient: apply custom_vars when evaluating conditions > a8fdab96 Roll recipe dependencies (trivial). > e82c0dec [cipd] Fail if setup has an error. > b1ad2f04 Update CIPD client, vpython and "LUCI editor". > 6a1ab843 Roll recipe dependencies (trivial). > 32f0e5d7 Roll recipe dependencies (trivial). > bc9c5ccf Roll recipe dependencies (trivial). > 54adb2a3 Generate initial recipes README. > 603545b7 Roll recipe dependencies (trivial). > e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps > 6014b566 gclient flatten: also handle allowed_hosts > 70b3f3aa [bot_update] Pass spec as file. > 1af0a337 Roll recipe dependencies (trivial). > dc598e82 [bot_update] Prefix PATH, cleanup. > > Bug: skia: > Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563 > Reviewed-on: https://skia-review.googlesource.com/32420 > Reviewed-by: Eric Boren <borenet@google.com> > Commit-Queue: Eric Boren <borenet@google.com> TBR=borenet@google.com,iannucci@google.com Change-Id: I6ed89db0757ffeb366da96d655372e9710aa589e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/32520 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Bring recipes up to date.Gravatar Robert Iannucci2017-08-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move recipe_engine URL to new canonical URL * Add README.recipes.md (auto-generated doc from docstrings in repo, regenerated with `recipes.py test train`). * Bring depot_tools up to date recipe_engine: 464fc26 Update a couple more URLs. 38808d0 Switch recipes-py CQ to Gerrit c7cdc9c Update canonical URL. 6bac51f Fix urls to googlesource. 5cf5e58 Convert code review to Gerrit e92def4 Add source manifest proto to recipe_engine. e0ddd60 Move internal downstream recipe roll trybots to production 3cae8e9 Add file.filesizes to recipe engine core modules. 862f333 Vendor 'luci_context' library. 6de5241 Add add_json_log='on_failure' to json module. e183af0 [recipe_engine] Set presentation.status before OutputPlaceholder.result. 3b99cdd Fix "recipes.py test diff" not raising a failure 8e8339a [path] Fix root path mocking. 00799cc Add experimental internal downstream recipe trybots 0ca88ae Pretty up all recipe_engine documentation. de3238c Fix UnboundLocalError in find_recipe. 9b47d24 Move downstream recipe roll trybots to production da3467b Recursively apply recipe overrides 3d76281 [uuid] Remove unused uuid module 9959b07 Remove shutil module. 26475d6 Add more experimental downstream trybots 5c349eb [file] allow glob to handle nested patterns 12e7ca4 recipes.py test: enforce recipe expectations literally 241ddc2 [file] fix glob_paths when NO paths match, add tests. 11d7598 [file] Allow placeholders in file.copy 9419a0e [doc] Put all external URLs in a single section. 4b6b21e [doc] Fix randomization of DEPS link order, give DEPS links fully qualified names 3ac778e [recipe_autoroller] regen docs on trivial rolls too. c8d78bf [doc] Automatically generate and update cross-indexed recipe markdown files. 5873ef2 Fix "env_prefixes" rendering. depot_tools: fb3fa785 Roll recipe dependencies (trivial). a643e9e3 Update patch_projects crap for googlesource repos in infra. fb391fcd [gclient config] Update luci project URLs (ugh) 590a4189 Roll recipe dependencies (trivial). 8e6a5e6e Roll recipe dependencies (trivial). 0e5f57ec [recipes.cfg] Update recipes.cfg to new canonical recipe URL. 704d6ad8 Roll recipe dependencies (trivial). f1205599 Roll recipe dependencies (trivial). 243c9643 Roll recipe dependencies (trivial). e866182f depot_tools: Fix executable bit for gerrit_*.py 4759fc62 Roll recipe dependencies (trivial). 7ab47354 Roll recipe dependencies (trivial). 554e2bff Roll recipe dependencies (trivial). 9e8c78d2 Roll recipe dependencies (trivial). b0ad16ee gclient flatten: do not recurse into deps not in recursedeps d9f97bc5 Use https for short URLs wherever applicable (MoarTLS). c9353605 gclient flatten: fixes for chromium/src ecdfa41d Fix quoting in update_depot_tools. 1407d00d gclient: make variables from parent DEPS scope override ones in inner scope 07a6bea9 Expose ast via InputApi e864a3f2 Remove presubmit check for DISALLOW_* macros e1054034 fetch_end_to_end_test: add recipe 8b478f04 PRESUBMIT: Be resilient to changes with no Code-Review label 8038dfe3 bot_update recipe: parameterize step name in apply_gerrit_ref 5aeeb72c [bootstraps] Sync at gclient, suppress output (#2) eb1feb90 [cipd] Bump version, log at warning (#2). 9f9d82ac Revert "[cipd] Bump version, log at warning." 18aa2d93 [cipd] Bump version, log at warning. fc6196b3 gclient flatten: preserve variable placeholders (reland #1) 5aa5cd76 depot_tools: add gerrit repo and ref to apply_gerrit_ref() 56766f1d Add experimental downstream recipe trybots to depot_tools 44855b94 Revert "[bootstraps] Sync at gclient, suppress output." 393ba066 Revert "gclient flatten: preserve variable placeholders" e79ddeaa gclient flatten: preserve variable placeholders 5a80eab0 Use -prerelease flag to vswhere when packaging VS 4d92fe43 [bootstraps] Sync at gclient, suppress output. 357415cb gclient flatten: fix a bug with some recursedeps not being processed 3d6363b3 Roll recipe dependencies (trivial). b396315c Bump led version. a3a515a4 Revert "Generalize git index refresh to bot_update." 06e1aa07 Generalize git index refresh to bot_update. 7f12a2e4 [bootstrap/win] Roll bleeding edge entry bat. f7543cdd git-cl: accept --force for -f everywhere 642dd84c [win/bootstrap] Use "for" instead of "set". ca01e2c8 git cl issue 0: Remove Change-Id from message, not description 290f5f56 Remove "create-ntfs-junction". ff9a5dec Roll recipe dependencies (trivial). d2dbea66 Roll recipe dependencies (trivial). fc62f768 Simplify notify behavior in git-cl cfbb775f Roll recipe dependencies (trivial). ae895075 Use doseq=True when re-encoding url query parameters 98681d11 Remove obsolete destination-branch-check flag 8aa774cf Fix bot_update example dd1bc7c0 [cipd] Generate other platform suffixes. 383ace4b Fix git-crrev-parse on Mac. e5adf612 Fix typo with --send-email [sic] flags 0ed616a4 Roll recipe dependencies (trivial). 636b13fc Let Changelist().AddComment() mark changes as Ready 68b54e78 [bootstrap/win] Upgrade Python to 2.7.13. f3d5a114 Enable Gerrit-destination-branch check by default 31f3e63c Revert "Revert "[tryserver] Remove unused methods."" c4dd3e82 [bootstrap/win] Remove support for legacy installs cc27ecb0 Revert "[tryserver] Remove unused methods." 68f6f279 [bootstrap/win] Always use "cipd.bat". 3a8717e1 [bootstrap/win] Remove legacy Git support. 6bac8a84 GitHyperBlameMainTest.testBadFilename: Work around git-blame bug. 4e5207d6 git-cl issue 0: Don't operate on empty description 22a9cf54 git_footers: fix bug stdin-based message input. 02e59414 Fix bot_update's usage of the destination branch 83eb1cd5 Roll recipe dependencies (trivial). 400e989b 'git cl issue 0': Remove Change-Id 133ac1ab [tryserver] Remove unused methods. b08ba657 git_footer: be more resilient to malformed footers 9d842bab [recipe_modules/git] Remove logging. 3d9b5881 [win_tools] Use bundled Python CIPD packages (#2). 209a681f [git] Remove hard-coded "depot_tools" Git. e8eed65f Always copy "python.bat". aab09ca6 Whitelist "python_bin_reldir.txt". af5c20f5 Revert "[win_tools] Use bundled Python CIPD packages." 7dadf05d Query Gerrit for destination branch in bot_update bf144679 [win_tools] Use bundled Python CIPD packages. b80fac66 Roll recipe dependencies (trivial). 265255f5 [bootstrap/win] Replace "python.bat" only on downgrade. 24025d3e tryserver: add support for gerrit footers 903ea731 [activity.py] Identify Gerrit-style bug annotations in commit messages 49b8147b Add support to query a CL's branch to gerrit recipe module 4cb9d742 [bootstrap/win] Enable revert from upcoming patch. 13e88538 Ignore the ".bleeding_edge" file. c8173825 git cl creds-check: improve report and give better recommendation. 4978917c Adjust CQ config for luci.infra.try -> luci.infra.depot_tools.try bucket move 9cb802ca Improve gerrit recipe_module example 79e897b0 [git_bootstrap] Support new Git bundles. 8af46469 Roll recipe dependencies (trivial). 1f767e17 Fix autoninja.py for ninja -t compatibility 7466d1a9 [cipd] Run client in .bat to preserve STDIN. 13f258bf Remove SVN bootstrapping and some tooling. b12c5256 Roll recipe dependencies (trivial). 016f92e6 Roll recipe dependencies (trivial). 68506985 Roll recipe dependencies (trivial). 215ded77 Fix testFlattenPinAllDeps 271a1680 gclient flatten: implement --pin-all-deps fb022017 gclient flatten: include vars e36a8431 Roll recipe dependencies (trivial). de37c012 Fix git-numberer swallowing of footers for Rietveld. 4e89144a git-cl: fix auth error message computation 7c2e05b4 [cipd] Fix CIPD bootstraps run concurrently. aaf93f48 gclient flatten: refactor flatten code to a class 807caf84 gclient flatten: remove --require-pinned-revisions 6fbf12f2 Enable query for changes in gerrit recipe module c6846aa2 gclient flatten: fix a bug with deps_os getting omitted for recursed deps 4baaa11c gclient: avoid adding potentially duplicate entries to work queue d3790251 gclient: apply custom_vars when evaluating conditions a8fdab96 Roll recipe dependencies (trivial). e82c0dec [cipd] Fail if setup has an error. b1ad2f04 Update CIPD client, vpython and "LUCI editor". 6a1ab843 Roll recipe dependencies (trivial). 32f0e5d7 Roll recipe dependencies (trivial). bc9c5ccf Roll recipe dependencies (trivial). 54adb2a3 Generate initial recipes README. 603545b7 Roll recipe dependencies (trivial). e015878d gclient flatten: fix an issue with an deps_os entry getting added to deps 6014b566 gclient flatten: also handle allowed_hosts 70b3f3aa [bot_update] Pass spec as file. 1af0a337 Roll recipe dependencies (trivial). dc598e82 [bot_update] Prefix PATH, cleanup. Bug: skia: Change-Id: I0eea2dd126c130299ac39fe9b54a714cb0612563 Reviewed-on: https://skia-review.googlesource.com/32420 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Bot updates for SkiaCT tasks.Gravatar Ravi Mistry2017-08-08
| | | | | | | | | | | | | | | | | | | | | Use gcc-4.8 when compiling for Ubuntu14. Rename the CT tasks to make it clear their child tasks run on Ubuntu14. Move to Debian-9.1 bots created with the changes in https://skia-review.googlesource.com/c/31281 and https://skia-review.googlesource.com/c/31820 Change the cache dir used by the ct_skps recipe so that changing the bot name doesn't invalidate the cache. Bug: skia:6921 Bug: skia:6818 No-Try: true Change-Id: Idaac8187427b5c2c7bffe66ad6674496b8cd0c0e Reviewed-on: https://skia-review.googlesource.com/31242 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Add another blacklist for win Intel perfGravatar Greg Daniel2017-08-07
| | | | | | | | | | | | Started happening after an SKP updated. This looks to be another bug in the llvm compiler Intel is using for windows vulkan. Bug: skia:6863 Change-Id: If2bf4c4b61d0958a21e1e56eae6497310fcff3f8 Reviewed-on: https://skia-review.googlesource.com/31640 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove blacklist of win nvidia vulkan skimage testGravatar Greg Daniel2017-08-07
| | | | | | | | Bug: skia:6554 Change-Id: I59aaf6115aa33d73078386ba8e0791ae9e334fe7 Reviewed-on: https://skia-review.googlesource.com/31421 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Chromium lkgr is no longer updated. Use lkcrGravatar Ravi Mistry2017-08-03
| | | | | | | | Bug: skia:6916 Change-Id: I16badf80c3b34e517b8baab161150c9434f325aa Reviewed-on: https://skia-review.googlesource.com/30100 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>