| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
| |
[depot_tools]/third_party/gsutil/gsutil
The latter is being removed in https://codereview.chromium.org/2280023003/
Is also pinned to 3.25, whereas the former is updated more often.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002
Review-Url: https://codereview.chromium.org/2298293002
|
|
|
|
|
|
|
|
|
|
|
| |
All the Android builders, testers, and perfers are on gn_android_flavor now.
Not as scary as it looks... all the big line count changes are deletes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002
Review-Url: https://codereview.chromium.org/2352653002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353483003
Review-Url: https://codereview.chromium.org/2353483003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/2343903002/ )
Reason for revert:
Causing failures:
https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812
Original issue's description:
> Run SVGs through nanobench on all Perf bots.
>
> Tested with:
> python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001
>
> Example output is here:
> https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
> Nanobench did run on SVGs.
>
> BUG=skia:5757
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
>
> Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52
TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5757
Review-Url: https://codereview.chromium.org/2348563003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347203002
Review-Url: https://codereview.chromium.org/2347203002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001
Example output is here:
https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
Nanobench did run on SVGs.
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
Review-Url: https://codereview.chromium.org/2343903002
|
|
|
|
|
|
|
|
|
|
|
| |
Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'. If for some reason you wanted to turn it off, you can still override skia_use_vulkan.
The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
Review-Url: https://codereview.chromium.org/2347843003
|
|
|
|
|
|
|
|
|
| |
This was suspiciously easy...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342923002
Review-Url: https://codereview.chromium.org/2342923002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Take over Ubuntu -x86- bots.
Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
We'll want target_cpu="x86" there too.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008
Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot
Review-Url: https://codereview.chromium.org/2340463008
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/2340463008/ )
Reason for revert:
https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304
Original issue's description:
> GN: support 32-bit x86 builds
>
> Take over Ubuntu -x86- bots.
>
> Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
> We'll want target_cpu="x86" there too.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008
>
> Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542
TBR=jcgregorio@google.com,borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2338173004
|
|
|
|
|
|
|
|
|
|
|
|
| |
Take over Ubuntu -x86- bots.
Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
We'll want target_cpu="x86" there too.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008
Review-Url: https://codereview.chromium.org/2340463008
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345723003
Review-Url: https://codereview.chromium.org/2345723003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342683003
Review-Url: https://codereview.chromium.org/2342683003
|
|
|
|
|
|
|
|
|
|
|
|
| |
Passing around empty strings as command line arguments requires
us to be really careful about command line quoting, parsing, etc.
It seems easy enough here to just supply the implied value.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003
Review-Url: https://codereview.chromium.org/2323233003
|
|
|
|
|
|
|
|
|
|
|
| |
No need to blacklist specific instances of configs that won't be run.
There's no bug or anything here... this is entirely about keeping the
command lines as noise-free as possible.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341963003
Review-Url: https://codereview.chromium.org/2341963003
|
|
|
|
|
|
|
|
| |
BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2339443003
|
|
|
|
|
|
|
|
|
|
|
| |
This'll make the 'dm' or 'nanobench' step go red like you'd hope.
The N5 should pass and the N10 and N7 should fail, showing us both sides.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003
Review-Url: https://codereview.chromium.org/2339713003
|
|
|
|
|
|
|
|
|
|
| |
Reduce its testing and perfing to just the fast Linux bots,
and remove it from the default set of dm/nanobench configs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002
Review-Url: https://codereview.chromium.org/2344553002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005
Review-Url: https://codereview.chromium.org/2336233005
|
|
|
|
|
|
|
|
|
| |
This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004
Review-Url: https://codereview.chromium.org/2335203004
|
|
|
|
|
|
|
|
|
| |
C.f. https://codereview.chromium.org/2336343002 for basic GN support.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004
Review-Url: https://codereview.chromium.org/2333293004
|
|
|
|
|
|
|
|
|
| |
We're already rebooting after running, so we should already be ready to go when the task starts.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003
Review-Url: https://codereview.chromium.org/2334223003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were intended to prevent GN and GYP Android bots from stomping on
each other. Turns out, they don't, even without this... they're writing
most files to completely separate paths:
- GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
in /data/local/tmp;
- GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
don't overlap GYP's.
So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002
Review-Url: https://codereview.chromium.org/2340473002
|
|
|
|
|
|
|
|
|
|
| |
S3 is needed for some recipe simulation stuff and in general having
these present does not hurt us.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003
Review-Url: https://codereview.chromium.org/2336513003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone. All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts.
The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell. Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away. Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware.
The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today. It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other. The marked parts can go away when bots are either gn_ or non-gn_ but not both.
I have omitted a few steps that may be important, but which are easy independent follow-ups:
- running as root
- locking clocks
- waiting on battery levels
- fancier wait-for-ready than adb wait-for-usb-device
It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy. I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later.
As of PS 41 or so, it looks like the trybots are all behaving as expected.
We should expect no new images in Gold. Can we see trybots in Perf yet?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320153002
CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot
Review-Url: https://codereview.chromium.org/2320153002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330093002
Review-Url: https://codereview.chromium.org/2330093002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326553002
Review-Url: https://codereview.chromium.org/2326553002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004
Review-Url: https://codereview.chromium.org/2317373004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to take over all *SAN builds.
MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py.
I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier
to use locally.
The compile steps should be much faster now. We no longer build CMake
and Clang for every run, instead using the clang_linux CIPD package. This
removes the need for all the third_party/externals/llvm/... dependencies.
Similarly, since we're using the clang_linux package, we no longer depend
on Chrome's Clang, and thus no longer need to sync chromium on these bots.
Instead of packaging up MSAN libraries and llvm-symbolizer in the compile
output, I have the test / perf bots also depend on the clang_linux package.
These do not vary from build to build.
No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja
all track changes to xsan.blacklist without our help.
This has the incidental effect of upgrading the compiler used by *SAN
bots from Clang 3.8 to Clang 3.9.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002
Review-Url: https://codereview.chromium.org/2289343002
|
|
|
|
|
|
|
|
|
|
| |
It's just visual noise... this should make future gn_flavor.py
changes show fewer incidental diffs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002
Review-Url: https://codereview.chromium.org/2324573002
|
|
|
|
|
|
|
| |
BUG=skia:5727
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317013002
Review-Url: https://codereview.chromium.org/2317013002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After several different strategies, this one appears to work
well. The basic test:
1) For a variety of drawing techniques, we render fixed size
rectangles. (Solid colors via paint color, bitmap, etc...)
2) For each method in #1, we render to both an sRGB and
WideGamutRGB offscreen surface. (AdobeRGB isn't wide enough
to clearly demonstrate if things are working or not).
3) Use readPixels to fetch the raw (still in wide gamut) pixel
data, then draw that directly to the final canvas.
So, for each pair of squares, they should look clearly
different. Currently, with the GPU backend, only the bicubic
bitmap paths have that behavior. Adding more test cases (and
fixing the ones that are already incorrect) will be the long
tail of gamut transformation.
Current output (with my other patchset, which fixes all
bitmap draws): https://screenshot.googleplex.com/wsL3x7eCtWE.png
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293173002
Review-Url: https://codereview.chromium.org/2293173002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I just burned 2 days debugging a confusing interaction between ccache
and the -fsanitize-blacklist argument to Clang. Let's see if we can
live without ccache (swarming affinity + Ninja seems pretty decent).
As a point of reference, the Mac bots have been looking for ccache but
failing to find it. They're proof this will be fine.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2310063003
Review-Url: https://codereview.chromium.org/2310063003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318633002
Review-Url: https://codereview.chromium.org/2318633002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311253002
Review-Url: https://codereview.chromium.org/2311253002
|
|
|
|
|
|
|
| |
BUG=skia:5715
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300703007
Review-Url: https://codereview.chromium.org/2300703007
|
|
|
|
|
|
|
|
|
|
|
|
| |
I am hoping this makes it easier to get *SAN bots going.
Today we're generating a libcompiler_rt.a that's using a
relocation type that the ld on the bots doesn't know about.
This lld is will know about anything our Clang generates.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301273002
Review-Url: https://codereview.chromium.org/2301273002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306733002
Review-Url: https://codereview.chromium.org/2306733002
|
|
|
|
|
|
|
|
|
|
|
|
| |
The remaining suppression (libwebp) is already covered by the
compile-time blacklist, tools/xsan.blacklist.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300193002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-Clang-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot
Review-Url: https://codereview.chromium.org/2300193002
|
|
|
|
|
|
|
|
|
|
| |
This should have no practical effect. I just want to make sure no
environment variables beyond $PATH have any effect on GN builds.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300173002
Review-Url: https://codereview.chromium.org/2300173002
|
|
|
|
|
|
|
|
|
| |
doesn't seem anything tests this?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306603002
Review-Url: https://codereview.chromium.org/2306603002
|
|
|
|
|
|
|
|
|
|
|
|
| |
We never used ubsan.supp,
and LSAN suppressions are now built into the test binaries.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot
Review-Url: https://codereview.chromium.org/2302803003
|
|
|
|
|
|
|
|
|
|
| |
This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots. It's ~300MB unpacked.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002
Review-Url: https://codereview.chromium.org/2294353002
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298203002
No trybots for these yet...
NOTRY=true
TBR=jcgregorio@google.com
Review-Url: https://codereview.chromium.org/2298203002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ought to support compiles for now.
Am I picking up my CIPD ndk packages right?
The main thing to note is that I'm passing the target_arch directly through
as target_cpu. This means these bots will have a slightly different naming
convention than we've been using, but it'll agree with what you must type
yourself when using GN to build for Android:
- Arm7 -> arm
- Arm64 -> arm64
- Mips -> mipsel
- Mips64 -> mips64el
- x86 -> x86 (unchanged)
- x86_64 -> x64
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292663002
Review-Url: https://codereview.chromium.org/2292663002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it considerably easier to use ccache with the Android NDK.
You can now just set
compiler_prefix = "ccache"
ndk = "/path/to/ndk"
and we'll use the NDK clang, wrapped with ccache.
The name compiler_prefix is stolen from / compatible with Chrome.
If you have ccache, you can just always leave compiler_prefix="ccache" enabled.
This should make it an unusual thing for humans to have to change cc or cxx.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281163002
Review-Url: https://codereview.chromium.org/2281163002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2284813002
Review-Url: https://codereview.chromium.org/2284813002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282883002
Review-Url: https://codereview.chromium.org/2282883002
|
|
|
|
|
|
|
|
|
|
| |
(GM for non-N32 SkImage subsetting)
BUG=skia:5687
R=bsalomon@google.com,robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286733002
Review-Url: https://codereview.chromium.org/2286733002
|
|
|
|
|
|
|
|
|
|
|
| |
Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This will be used by the different frameworks to figure out if it is Rietveld or Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.
BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002
Review-Url: https://codereview.chromium.org/2263323002
|