aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipes/test.py
Commit message (Collapse)AuthorAge
* Turn on GPU threading by default to get better test/perf coverageGravatar Brian Osman2017-09-22
| | | | | | | | | | | Explicitly disable it on PixelC. This is arbitrary, so we continue to get coverage of the single-threaded code. Bug: skia: Change-Id: I0ac91f7ca58652933db452720f353068cf2d0f2d Reviewed-on: https://skia-review.googlesource.com/50000 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Fix float-cast-overflow in SkTypeface_FreeType::onGetAdvancedMetricsGravatar Ben Wagner2017-09-20
| | | | | | | | Bug: skia:4632 Change-Id: Id2ee217787e6741011f324951f11eeefc55f62b9 Reviewed-on: https://skia-review.googlesource.com/47321 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Fix float-cast-overflow in SkOpSpan::sortableTop.Gravatar Ben Wagner2017-09-19
| | | | | | | | Bug: skia:4632 Change-Id: I5af8bb7b04673307cdf7865bb7d56a041ba27d83 Reviewed-on: https://skia-review.googlesource.com/47320 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Change SkScalarTruncToInt to saturate.Gravatar Ben Wagner2017-09-18
| | | | | | | | | | | This is the same behavior as SkScalarFloorToInt, SkScalarCeilToInt, and SkScalarRoundToInt. Bug: skia:4632 Change-Id: Iec454e841b05c5b10f335b5b089718db56740323 Reviewed-on: https://skia-review.googlesource.com/47400 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Suppress float-cast-overflow for double-to-float in SkMatrix{,44}Gravatar Ben Wagner2017-09-18
| | | | | | | | | | No API change. Bug: skia:4632 Change-Id: Ic9cb9de7cce8aca43f0ce8066abcc44a0b04ca84 Reviewed-on: https://skia-review.googlesource.com/47681 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Suppress float-cast-overflow in SkPoint::Length.Gravatar Ben Wagner2017-09-16
| | | | | | | | Bug: skia:4632 Change-Id: I0f8a7d7a11fc76fcb315c3f0183577c3f0958926 Reviewed-on: https://skia-review.googlesource.com/47421 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Blacklist failing tests for IB1Gravatar Kevin Lubick2017-09-15
| | | | | | | | | | Bug: skia: NOTRY=true Change-Id: I2a774ca2533572eaf284101cd6ea11b816c1441a Reviewed-on: https://skia-review.googlesource.com/47080 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [infra] Use int for internal_hardware_labelGravatar Eric Boren2017-09-15
| | | | | | | | Bug: skia: Change-Id: I86c4160e0c65c9f8459087e34eaf39907a76c9da Reviewed-on: https://skia-review.googlesource.com/47182 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Rename internal_bot_id -> internal_hardware_labelGravatar Eric Boren2017-09-15
| | | | | | | | | Bug: skia: Change-Id: I1a2442898c8eca8cf36d8e85d2acf1d048ebfb54 Reviewed-on: https://skia-review.googlesource.com/46849 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Add internal_bot_id flag to recipesGravatar Eric Boren2017-09-15
| | | | | | | | | | Allows differentiation between internal bots in recipes. Bug: skia: Change-Id: I7130f2adc13dd01f7572856ea64c428a6adf56ba Reviewed-on: https://skia-review.googlesource.com/46844 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add new task to run the float-cast-overflow sanitizer.Gravatar Ben Wagner2017-09-13
| | | | | | | | | Bug: skia:4632 No-Try: true Change-Id: I85a0b23037d5885e5d762788d8bf5b7cc6fc19b2 Reviewed-on: https://skia-review.googlesource.com/45980 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Make output of all tests verboseGravatar Stephan Altmueller2017-09-12
| | | | | | | | | | | | | | | Re-enable more verbose output across all bots. There is no good reason why we shouldn't collect additional information that helps triaging failure. Some of the current output might have to be expanded down the road. Bug: skia: Change-Id: I5ff89a803f1e390bbd859756cba53a359d2801ba Reviewed-on: https://skia-review.googlesource.com/45140 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Omit encode-platform also for Debug Mac CPU.Gravatar Ben Wagner2017-09-08
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: I824e44f0e9f08f607aa3aaa5e0074bce72a2b4ee Reviewed-on: https://skia-review.googlesource.com/44202 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update NexusPlayers to Android O PR6.Gravatar Ben Wagner2017-09-08
| | | | | | | | No-Try: true Change-Id: I0abb5e6d9d705d352089024a303d2f8be0f051aa Reviewed-on: https://skia-review.googlesource.com/43203 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Only run CPU SVG tests on a single botGravatar Chris Dalton2017-09-07
| | | | | | | | | | | | | Runs the testing on Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN. We only care about parsing SVGs CPU-side so there's no need to retest it on every bot. Bug: skia:6918 Change-Id: If2c5afbc41a600ece63d9a6a60f0dab5ca7b3676 Reviewed-on: https://skia-review.googlesource.com/43461 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Blacklist more flaky GMs in gltestthreading configGravatar Brian Osman2017-09-07
| | | | | | | | Bug: skia:7011 skia:6544 Change-Id: Idacb5ff8090bea6ddbdef710bc0f4dbb8bd23549 Reviewed-on: https://skia-review.googlesource.com/43560 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Omit flaky encode-platform test for pic-8888 Mac CPU.Gravatar Ben Wagner2017-09-05
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: I8141afb1706b1434bacc62f6b6f9b69876a92b2c Reviewed-on: https://skia-review.googlesource.com/42680 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Blacklist (flaky) textbloblooper on gltestthreadingGravatar Brian Osman2017-08-31
| | | | | | | | Bug: skia: Change-Id: I10ddc36f39800e3d86145054b994a6899573a63a Reviewed-on: https://skia-review.googlesource.com/41501 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add Correctness tests for ChromecastGravatar Kevin Lubick2017-08-31
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Ib604bad8eda6ba4382b850f7c5f318fb0f114401 Reviewed-on: https://skia-review.googlesource.com/20051 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Threaded generation of software pathsGravatar Brian Osman2017-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | Re-land of: https://skia-review.googlesource.com/36560 All information needed by the thread is captured by the prepare callback object, the lambda captures a pointer to that, and does the mask render. Once it's done, it signals the semaphore (also owned by the callback). The callback defers the semaphore wait even longer (into the ASAP upload), so the odds of waiting for the thread are REALLY low. Also did a bunch of cleanup along the way, and put in some trace markers so we can monitor how well this is working. Traces of a GM that includes GPU and SW path rendering (path-reverse): Original: https://screenshot.googleplex.com/f5BG3901tQg.png Threaded, with wait in the callback (notice pre flush callback blocking): https://screenshot.googleplex.com/htOSZFE2s04.png Current version, with wait deferred to ASAP upload function: https://screenshot.googleplex.com/GHjD0U3C34q.png Bug: skia: Change-Id: Idb92f385590749f41328a9aec65b2a93f4775079 Reviewed-on: https://skia-review.googlesource.com/40775 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Threaded generation of software paths"Gravatar Brian Salomon2017-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 76323bc0615044a5921afef0e19a350f3d04ffe0. Reason for revert: Breaking NUC bots in threaded gm comparison: https://chromium-swarm.appspot.com/task?id=382e589753187f10&refresh=10 Original change's description: > Threaded generation of software paths > > All information needed by the thread is captured by the prepare > callback object, the lambda captures a pointer to that, and does the > mask render. Once it's done, it signals the semaphore (also owned by the > callback). The callback defers the semaphore wait even longer (into the > ASAP upload), so the odds of waiting for the thread are REALLY low. > > Also did a bunch of cleanup along the way, and put in some trace markers > so we can monitor how well this is working. > > Traces of a GM that includes GPU and SW path rendering (path-reverse): > > Original: > https://screenshot.googleplex.com/f5BG3901tQg.png > Threaded, with wait in the callback (notice pre flush callback blocking): > https://screenshot.googleplex.com/htOSZFE2s04.png > Current version, with wait deferred to ASAP upload function: > https://screenshot.googleplex.com/GHjD0U3C34q.png > > Bug: skia: > Change-Id: I3d5a230bbd68eb35e1f0574b308485c691435790 > Reviewed-on: https://skia-review.googlesource.com/36560 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,mtklein@google.com,bsalomon@google.com,robertphillips@google.com,brianosman@google.com Change-Id: Icac0918a3771859f671b69ae07ae0fedd3ebb3db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/38560 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Threaded generation of software pathsGravatar Brian Osman2017-08-24
| | | | | | | | | | | | | | | | | | | | | | | | | | All information needed by the thread is captured by the prepare callback object, the lambda captures a pointer to that, and does the mask render. Once it's done, it signals the semaphore (also owned by the callback). The callback defers the semaphore wait even longer (into the ASAP upload), so the odds of waiting for the thread are REALLY low. Also did a bunch of cleanup along the way, and put in some trace markers so we can monitor how well this is working. Traces of a GM that includes GPU and SW path rendering (path-reverse): Original: https://screenshot.googleplex.com/f5BG3901tQg.png Threaded, with wait in the callback (notice pre flush callback blocking): https://screenshot.googleplex.com/htOSZFE2s04.png Current version, with wait deferred to ASAP upload function: https://screenshot.googleplex.com/GHjD0U3C34q.png Bug: skia: Change-Id: I3d5a230bbd68eb35e1f0574b308485c691435790 Reviewed-on: https://skia-review.googlesource.com/36560 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Omit flakily failing test.Gravatar Ben Wagner2017-08-23
| | | | | | | | | Bug: skia:6992 No-Try: true Change-Id: Ie2726fd80f0baf03bdea5148e45b909ac88340f6 Reviewed-on: https://skia-review.googlesource.com/37740 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Disable questionable bmps on Mac platform decoderGravatar Leon Scroggins III2017-08-18
| | | | | | | | | | These are already disabled on WIC, but they are supported by SkCodec. Bug: skia:6984 Change-Id: Ib248749f357debcc173dfaa2bcd5adc8da52df22 Reviewed-on: https://skia-review.googlesource.com/36440 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Rename Mac bots to match reality.Gravatar Ben Wagner2017-08-18
| | | | | | | | | | | | Doing this separately from https://skia-review.googlesource.com/c/36040 to avoid confusion. No-Try: true Change-Id: I2d9e03c6da6096f9e14145d9654b9da7a8670036 Reviewed-on: https://skia-review.googlesource.com/35823 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Blacklist svgparse_* svgs on non-8888Gravatar Chris Dalton2017-08-15
| | | | | | | | | | | This also required extending the blacklist argument to support negative matching and wildcards. Bug: skia:6918 Change-Id: I915e305c75fe23fc3e11c2dd3e91570967da0aaa Reviewed-on: https://skia-review.googlesource.com/31444 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add tasks for Acer R13Gravatar Kevin Lubick2017-08-15
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Iafc9a00ff2a41919214cdea89251ceb0c5b443c5 Reviewed-on: https://skia-review.googlesource.com/34721 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Omit failing test for IntelIris640 Ubuntu Vulkan.Gravatar Ben Wagner2017-08-11
| | | | | | | | | Bug: skia:6245 Change-Id: Id5e0704f51537abf4ed2794d67ab8424a725e1bc No-Try: true Reviewed-on: https://skia-review.googlesource.com/33801 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add new Linux IntelIris640 jobs.Gravatar Ben Wagner2017-08-11
| | | | | | | | | Bug: skia:6761 Change-Id: I635958a482a16fc7027d33152db431cb8c5bbe2c No-Try: true Reviewed-on: https://skia-review.googlesource.com/33740 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Abort dm/nanobench on bad configs.Gravatar Ben Wagner2017-08-11
| | | | | | | | | Adjust the configs specified by recipes to avoid the new error. Change-Id: I23e31355e2faaab919d92abdb37a6f70cd2da1ff Reviewed-on: https://skia-review.googlesource.com/32862 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix undefined flag for MSAN.Gravatar Ben Wagner2017-08-10
| | | | | | | | | | | | MSAN started failing after https://skia-review.googlesource.com/c/32722. This should fix it. No-Try: true Change-Id: I8956c8c211507923f078fe96921fedaadefae8a8 Reviewed-on: https://skia-review.googlesource.com/32942 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Test non-msaa instanced rendering on MacGravatar Brian Salomon2017-08-10
| | | | | | | Change-Id: I28b67ccef7bb72e4853a0eb02d1de00b1ed40cce Reviewed-on: https://skia-review.googlesource.com/33001 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove --undefok from recipes.Gravatar Ben Wagner2017-08-10
| | | | | | | | | | Since recipes are now versioned with the code, this is unnecessary and could mask recipe bugs. Change-Id: Ic5aafbd3a7e9ccd3fd529c71b282cf6b037b78df Reviewed-on: https://skia-review.googlesource.com/32722 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add duplicate Valgrind tasks on QuadroP400.Gravatar Ben Wagner2017-08-09
| | | | | | | | | | | | | | | | | Valgrind 3.13.0 only supports up to AVX2, so I used SK_CPU_LIMIT_SSE41 to avoid failing with "Unrecognised instruction." (The existing Valgrind tasks run on a ShuttleA machine, whose CPU only supports AVX.) Needed to enable verbose output on all Valgrind tasks to avoid Swarming I/O timeout. Opportunistically removed verbose output for Linux Intel bots that are no longer failing. Bug: skia:6881 Change-Id: I2ffa6efe901c97bd2e0bbc9b26632aafbb3cf9a6 No-Try: true Reviewed-on: https://skia-review.googlesource.com/31143 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove blacklist of win nvidia vulkan skimage testGravatar Greg Daniel2017-08-07
| | | | | | | | Bug: skia:6554 Change-Id: I59aaf6115aa33d73078386ba8e0791ae9e334fe7 Reviewed-on: https://skia-review.googlesource.com/31421 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Don't write .pdfs in DM on the bots.Gravatar Mike Klein2017-07-24
| | | | | | | | | | | They take a long time to upload, and we don't do anything with them. BUG=skia:6821 Change-Id: I16c5fc423953fa3e9d0dcb184ecbbe23f3918357 Reviewed-on: https://skia-review.googlesource.com/26142 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Enable verbose output on iOS and AndroidGravatar Stephan Altmueller2017-07-21
| | | | | | | | Bug: skia: Change-Id: Ia2c40b01d78257dd7e30805a034a581b708d0b90 Reviewed-on: https://skia-review.googlesource.com/25563 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Only run GL congs on CCPR botsGravatar Chris Dalton2017-07-20
| | | | | | | | Bug: skia: Change-Id: Ief012869b740bbfb947a77c91c4478a851f2517e Reviewed-on: https://skia-review.googlesource.com/25062 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add option to ignore SIGINT when running DM on Android.Gravatar Derek Sollenberger2017-07-20
| | | | | | | | | Bug: skia:6856 Change-Id: Iaaad2c22988cf8058304b7396c7d24eacd2f3edb Reviewed-on: https://skia-review.googlesource.com/24745 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* Add two test bots for coverage counting path rendererGravatar Chris Dalton2017-07-18
| | | | | | | | Bug: skia: Change-Id: Ib8e89e5e9a75d24b69c23873168fcc23f9eb5c45 Reviewed-on: https://skia-review.googlesource.com/24063 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Remove dependency on recipe_engine/shutil.Gravatar Robert Iannucci2017-07-10
| | | | | | | | | | R=borenet@google.com Bug: chromium:739984 Change-Id: I077c4e6f494eb7e93851201120048ba1ef5faa07 Reviewed-on: https://skia-review.googlesource.com/21921 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix recipes/tests for new Debian botsGravatar Eric Boren2017-06-28
| | | | | | | | Bug: skia:6612 Change-Id: I2920bb7b1aa3ebb021223ed6345f13f1f9c8bc24 Reviewed-on: https://skia-review.googlesource.com/21141 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Turn on verbose logging on flakily dying bots.Gravatar Ben Wagner2017-06-27
| | | | | | | | | No-Try: true Change-Id: I2c1b598f03d8536aa3ef118630a0aed63fe54f9e Reviewed-on: https://skia-review.googlesource.com/10526 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix TransferBufferTest for TegraX1Gravatar Jim Van Verth2017-06-27
| | | | | | | | | Bug: skia: Change-Id: Ia64f48581e8003baec2eeaa4821354350b3333f4 Reviewed-on: https://skia-review.googlesource.com/20504 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* run NexusPlayer CPU tests verboselyGravatar Mike Klein2017-06-26
| | | | | | | | | | | | These were relying on a 15-minute status thread to keep them from timing out. --verbose ought to do the same. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Debug-Android Change-Id: I1d1467a5e777df6ec5e79d2d9ea992e69bfaeeb7 Reviewed-on: https://skia-review.googlesource.com/20821 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Remove deadcode for sRGB image shading."Gravatar Mike Reed2017-06-26
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit 51f6a0f89e55b2c0f102aa7963320a23c586e71d. Reason for revert: try to fix chrome roll Original change's description: > Remove deadcode for sRGB image shading. > > Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca > Reviewed-on: https://skia-review.googlesource.com/20695 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Herb Derby <herb@google.com> TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I90409a08409177d9dc3b094d736af0fdaf7d6cdd Reviewed-on: https://skia-review.googlesource.com/20824 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "Remove deadcode for sRGB image shading.""Gravatar Mike Reed2017-06-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e08e639063dd5476b5a1a24c0f0dc8f1139bfd8d. Reason for revert: revert was not clean Original change's description: > Revert "Remove deadcode for sRGB image shading." > > This reverts commit 51f6a0f89e55b2c0f102aa7963320a23c586e71d. > > Reason for revert: crazy attempt to fix chrome roll > > Original change's description: > > Remove deadcode for sRGB image shading. > > > > Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca > > Reviewed-on: https://skia-review.googlesource.com/20695 > > Reviewed-by: Mike Klein <mtklein@chromium.org> > > Commit-Queue: Herb Derby <herb@google.com> > > TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Icab02936d6c18e50b8de353aa1cd4c225e15e0bf > Reviewed-on: https://skia-review.googlesource.com/20800 > Reviewed-by: Mike Reed <reed@google.com> TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com Change-Id: Ibc579a5a95e78cb257e8d443dbb905db3761e84a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/20802 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Remove deadcode for sRGB image shading."Gravatar Mike Reed2017-06-25
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 51f6a0f89e55b2c0f102aa7963320a23c586e71d. Reason for revert: crazy attempt to fix chrome roll Original change's description: > Remove deadcode for sRGB image shading. > > Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca > Reviewed-on: https://skia-review.googlesource.com/20695 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Herb Derby <herb@google.com> TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Icab02936d6c18e50b8de353aa1cd4c225e15e0bf Reviewed-on: https://skia-review.googlesource.com/20800 Reviewed-by: Mike Reed <reed@google.com>
* Remove deadcode for sRGB image shading.Gravatar Herb Derby2017-06-23
| | | | | | | Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca Reviewed-on: https://skia-review.googlesource.com/20695 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com>
* Reduce ANGLE correctness testing blacklistsGravatar Brian Salomon2017-06-23
| | | | | | | | Bug: skia: Change-Id: Ie98d574a9840dd073a396da829aee041fb6595dc Reviewed-on: https://skia-review.googlesource.com/20601 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>