aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipe_modules
Commit message (Collapse)AuthorAge
* Couple small changes to speed up Goma compilesGravatar Ben Wagner2018-01-25
| | | | | | | | | | | | - Use more threads - Avoid failures due to Goma compiler_proxy running after Swarming task terminates, e.g. https://chromium-swarm.appspot.com/task?id=3b309dfecdaa9b10 Change-Id: I8521ad0dbaead6f22a2d3a3401dfe0b2695742b9 Reviewed-on: https://skia-review.googlesource.com/99020 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Upload multiple dm images at onceGravatar Kevin Lubick2018-01-17
| | | | | | | | | | | | Use the -m file, as recommended in https://luci-milo.appspot.com/swarming/task/3b197fbd667a1510/steps/upload_images/0/stdout Bug: skia: Change-Id: I58d101f58594bf221d11a787057ee7950b197f86 Reviewed-on: https://skia-review.googlesource.com/94965 Reviewed-by: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Fix Test-Chromecast from running out of memory on testsGravatar Kevin Lubick2018-01-16
| | | | | | | | Bug: skia:7166 Change-Id: Iefc8c6c1b72805dfe3ec8bd06d6ba6a878307582 Reviewed-on: https://skia-review.googlesource.com/93620 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add Android ASAN botGravatar Kevin Lubick2018-01-12
| | | | | | | | | | | It should work on 32 and 64 bit android running M or newer. Bug: skia: Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c Reviewed-on: https://skia-review.googlesource.com/93700 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* [recipes] Define variables in __init__Gravatar Eric Boren2018-01-12
| | | | | | | | | | This may fix weird races in tests. Bug: skia: Change-Id: I41c36424c7b559301e915a0892590c74931ae463 Reviewed-on: https://skia-review.googlesource.com/93942 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Trying gpu scaling on Nexus 5 and 5xGravatar Kevin Lubick2018-01-11
| | | | | | | | | | We do some of this already in skpbench. Bug: skia: Change-Id: Ia698466e83f9b476644c126747a2f89346361d13 Reviewed-on: https://skia-review.googlesource.com/93561 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Separate compile task from calmbench taskGravatar Yuqian Li2018-01-05
| | | | | | | | | Bug: skia:7344 Change-Id: I019fe5e3178d13ccf3a510bdcf1c81915149def5 Reviewed-on: https://skia-review.googlesource.com/89900 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Add support for Build...ParentRevision tasks.Gravatar Ben Wagner2018-01-04
| | | | | | | | Bug: skia:7344 Change-Id: I458afe4abe5edff8b8ccbd5abdaf4ebbf892ee00 Reviewed-on: https://skia-review.googlesource.com/90245 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Only uninstall if install failed.Gravatar Ben Wagner2018-01-04
| | | | | | | | | | | | | This is a followup to https://skia-review.googlesource.com/c/skia/+/90343, which causes task durations to increase due to copying over images, skps, etc. on every run. Bug: skia:7408 Change-Id: I42e829e287b7343e969159ac19c587a87ebe99e8 No-Try: true Reviewed-on: https://skia-review.googlesource.com/90942 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Switch to updated Mac bots.Gravatar Ben Wagner2018-01-04
| | | | | | | | Bug: skia:7408 Change-Id: I26273df7871e3ee01e227636421962fcc6251e7d Reviewed-on: https://skia-review.googlesource.com/88080 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix absolute path for recipesGravatar Kevin Lubick2018-01-04
| | | | | | | | Bug: skia: Change-Id: I42c528d86f19d369609b26763334e055501a9b9b Reviewed-on: https://skia-review.googlesource.com/90880 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* In iOS recipe, uninstall before install.Gravatar Ben Wagner2018-01-03
| | | | | | | | Bug: skia:7408 Change-Id: Iea55fe9199db7fc841ed0ba4a2451a84cd57213f Reviewed-on: https://skia-review.googlesource.com/90343 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Update isolate binaries and update isolate recipe"Gravatar Ravi Mistry2017-12-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8bc327bffb7ae7d10b93ee75c3d207caeb37f93b. Reason for revert: Isolate tests step in CT_ bots taking 5x longer. Original change's description: > Update isolate binaries and update isolate recipe > > Context: Email to skiabot@ from mcgreevy@ > > Bug: skia: > Change-Id: Ic3bc19600809bde5adcd9edd23ba4d8b126ec852 > Reviewed-on: https://skia-review.googlesource.com/88540 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> TBR=benjaminwagner@google.com,rmistry@google.com,kjlubick@google.com Change-Id: Ifda029a65bf6414dc40502356870101ac3f88cb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/89280 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Quarantine android bots instead of shutting off deviceGravatar Kevin Lubick2017-12-22
| | | | | | | | | | | | | | This should make it easier to diagnose and remotely fix the devices/hosts. Only works because of https://chrome-internal-review.googlesource.com/c/infradata/config/+/535542 Bug: skia: Change-Id: Idf11a09da6c7367212a0ac0b0b959cbf49fed85b Reviewed-on: https://skia-review.googlesource.com/89181 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Update isolate binaries and update isolate recipeGravatar Ravi Mistry2017-12-22
| | | | | | | | | | Context: Email to skiabot@ from mcgreevy@ Bug: skia: Change-Id: Ic3bc19600809bde5adcd9edd23ba4d8b126ec852 Reviewed-on: https://skia-review.googlesource.com/88540 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove Linux IntelIris540 jobs.Gravatar Ben Wagner2017-12-21
| | | | | | | | | | | | | | Replacing IntelIris540 with IntelIris640, added in https://skia-review.googlesource.com/c/skia/+/87202. I verified that Gold results are still identical (modulo flakes). See also https://skia-review.googlesource.com/c/skia/+/87721 and https://skia-review.googlesource.com/c/skia/+/78640. No-Try: true Change-Id: Ifc7e80e92d6203d922e00b59127b136632af7afc Reviewed-on: https://skia-review.googlesource.com/88427 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Make sure we get the LITTLE cores out of powersaveGravatar Kevin Lubick2017-12-19
| | | | | | | | | Bug: skia:7420 NOTRY=true Change-Id: I785135a3abc17f63d715d459668c768a6014d9b3 Reviewed-on: https://skia-review.googlesource.com/87001 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Enable Goma fallback by default.Gravatar Ben Wagner2017-12-14
| | | | | | | | | | Add a job that doesn't allow fallback so we know when things aren't working as expected. Change-Id: If993976d6807635bde455c2091f8a1ba18c41e27 Reviewed-on: https://skia-review.googlesource.com/83700 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "Disable extra CPUs during Nanobench""Gravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 43307c09b97c5a5c5174f0c4ccb79bdaf3ebf557. Reason for revert: Fixed this time. Echo 1 > already online cpu returns exit code 1, which makes python over-react. Original change's description: > Revert "Disable extra CPUs during Nanobench" > > This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. > > Reason for revert: many unhappy android bots > > Original change's description: > > Disable extra CPUs during Nanobench > > > > The previous experiment revealed that nanobench can > > run on any of the online CPUs, so rather than put > > the ones we don't need/want into powersave mode, just > > disable them. > > > > Maybe in the future we can run CPU tests on the big > > or LITTLE cpus to get perf data on higher end or > > lower end cpus, but only if we get very stable > > results from this. > > > > Bug: skia:7378 > > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > > Reviewed-on: https://skia-review.googlesource.com/84820 > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > Commit-Queue: Kevin Lubick <kjlubick@google.com> > > TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com > > Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 > Bug: skia:7378 > Reviewed-on: https://skia-review.googlesource.com/84921 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> No-Tree-Checks: true Change-Id: Ie7f0a3dc6ba55c124c796aba16a0f0497f285f3a Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84865 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Revert "Disable extra CPUs during Nanobench"Gravatar Mike Klein2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. Reason for revert: many unhappy android bots Original change's description: > Disable extra CPUs during Nanobench > > The previous experiment revealed that nanobench can > run on any of the online CPUs, so rather than put > the ones we don't need/want into powersave mode, just > disable them. > > Maybe in the future we can run CPU tests on the big > or LITTLE cpus to get perf data on higher end or > lower end cpus, but only if we get very stable > results from this. > > Bug: skia:7378 > notry=true > notreechecks=true > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > Reviewed-on: https://skia-review.googlesource.com/84820 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84921 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Disable extra CPUs during NanobenchGravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | The previous experiment revealed that nanobench can run on any of the online CPUs, so rather than put the ones we don't need/want into powersave mode, just disable them. Maybe in the future we can run CPU tests on the big or LITTLE cpus to get perf data on higher end or lower end cpus, but only if we get very stable results from this. Bug: skia:7378 notry=true notreechecks=true Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 Reviewed-on: https://skia-review.googlesource.com/84820 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add Goma for all Windows Clang Builds.Gravatar Ben Wagner2017-12-13
| | | | | | | Change-Id: I26e75cf6cd865ec6c47b7766679177bfd30387da Reviewed-on: https://skia-review.googlesource.com/82921 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [recipes] Provide tokenized extra_config and use it most places.Gravatar Ben Wagner2017-12-13
| | | | | | | Change-Id: I7baae5f90b2e510b66443cda449071c7c6ec9ec7 Reviewed-on: https://skia-review.googlesource.com/83520 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Experiment with turning CPUs off during perfGravatar Kevin Lubick2017-12-13
| | | | | | | | | | | | | | | | | | | | | | | Perf was nice and flat after https://skia-review.googlesource.com/c/skia/+/83240 but there was a 4-5x slowdown on the benchmarks themselves, indicating that perhaps we were running nanobench on the LITTLE cores (now on powersave) instead of the big cores we thought (which were recently scaled down). This experiment will show us FOR CERTAIN that we are running on core 0 or 1 which is at .6 max frequency. We expect to see a speedup from the previous results. This is leading to turning of CPUs we don't need to make sure nanobench is running on the ones we expect. Bug: skia: NOTRY=true Change-Id: Ida65181e4d90e778e65e3f22d761288b9ade64f6 Reviewed-on: https://skia-review.googlesource.com/84201 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Store skiaserve binary in GS from Release Android compile botsGravatar Ravi Mistry2017-12-12
| | | | | | | | Bug: skia:7399 Change-Id: Id60773f77694b06a938f9a126f30ca56e4965d30 Reviewed-on: https://skia-review.googlesource.com/83981 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix scaling logic for NexusPlayer and AndroidOneGravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | They seem to be their own special cases for what governors they support. Bug: skia: NOTRY=true Change-Id: I7bb220e1d3ba6851c17c7e6ef327aab24ffdba42 Reviewed-on: https://skia-review.googlesource.com/83900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Search more for stacktrace to symbolizeGravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | | | | | If the stacktrace wasn't in the last 200 lines, we couldn't find and symbolize it. https://chromium-swarm.appspot.com/task?id=3a5e86a9d0e04e10&refresh=10 We increase the window to 500 lines to account for large memory maps. Bug: skia:7397 NOTRY=true Change-Id: Ic8583e383663a9beb62a32e90a5bd5d73d7446a7 Reviewed-on: https://skia-review.googlesource.com/83540 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Scale extra CPUs to powersave during nanobench.Gravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | This scaling logic correctly accounts for some devices which have multiple CPUs. Previously, we were scaling the smaller of these CPUs, which likely had a negative impact on nanobench, given nanobench was single threaded and the CPUs weren't allowed to idle much (because we set the CPU). This CL sets those additional CPUs to powersave when we run nanobench and then correctly scales down the beefier CPU we want to run nanobench on. For DM, we just run it in ondemand mode, which will hopefully be "as fast as possible", but allow the CPU governor to scale down if overheating becomes a problem. Bug: skia:7378 notry=TRUE Change-Id: I45ca5d9fb32182233d1b2d094842c879f2b84da4 Reviewed-on: https://skia-review.googlesource.com/83240 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* resources: optionally link them into our binaryGravatar Hal Canary2017-12-11
| | | | | | | | | | | To enable, set skia_embed_resources=true in args.gn. Also add *-EmbededResouces bots. Change-Id: Ia69b26e926a3ad4676a4fa021894432ea2104538 Reviewed-on: https://skia-review.googlesource.com/82626 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Add new Bookmaker bot that runs nightlyGravatar Ravi Mistry2017-12-08
| | | | | | | | | | | | | | | | | | | | The new bot: 1) Extracts all fiddles out of markdown files. 2) Forces fiddle.skia.org to compile all those fiddles and get output in JSON. 3) Scans the output and reports any compiletime/runtime errors. 4) Updates markdown in site/user/api/ using the new hashes (if any) from fiddle.skia.org. To ensure the bot does not check in unexpected changes: * upload_md.py makes sure that all modified files are under site/user/api/. It errors out if this is not the case. * CLs with docs only changes normally have 'NoTry: true' added to their descriptions. This is not done for the new bot because we want to run it through trybots to make sure nothing unexpected snuck in. * rmistry@ and caryclark@ are automatically CC'ed on all uploaded changes. I plan to watch the bot closely for at least a couple of weeks. Bug: skia:7310 Change-Id: I759fc8bae1e32a6f175e3b1a895947d14ca5fe3a Reviewed-on: https://skia-review.googlesource.com/79941 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Remove Nexus10.Gravatar Ben Wagner2017-12-08
| | | | | | | | | Bug: skia:7381 Change-Id: I8e151c5c57f6344c9cdf165bbb78a4ed308491c8 NoTry: true Reviewed-on: https://skia-review.googlesource.com/82804 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Goma support in gn_flavor.Gravatar Ben Wagner2017-12-08
| | | | | | | | | | | | Using full paths in skia.h causes "file not found" with Goma. All other Builds seem fine without the path, so I changed find_headers.py to use the basename. Change-Id: Ib520e91a92ebffe36a736eb53f643d359f5bb2ce Reviewed-on: https://skia-review.googlesource.com/79360 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix scaling issues for some devices (e.g. Pixel)Gravatar Kevin Lubick2017-12-08
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Ia6a80ecb97b5d30197932ec7d340163624e315bd Reviewed-on: https://skia-review.googlesource.com/82682 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Roll recipe dependencies (nontrivial).Gravatar recipe-roller2017-12-08
| | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/bb85b3636b13b7a3514a198b30c583439c009970 bot_update source manifest: fix test_api.py to match the actual output (hinoka@google.com) R=kjlubick@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If6efa9cbe00163301023a847c06f10e37067f4c0 Reviewed-on: https://skia-review.googlesource.com/82540 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Updated MSVC toolchain to 2017, and further refactored GNGravatar Brian Osman2017-12-08
| | | | | | | | | | | | | | | | | | | | | | 'windk' is no longer a thing. There are two separate variables to point at your compiler (win_vc), and SDK (win_sdk). 'msvc' is no longer a thing, either. By default, we look for 2017 and then 2015 (in the default locations). If neither is located, use an assert to let users know they should set win_vc. Then, detect if win_vc points at a 2017 or 2015 installation, and configure it automatically. Because the toolchain is now 2017, update the GN files to handle building x86 in that configuration. In fact, we only support x86 builds (with 2017 or 2015) using the toolchain assets. Keep a 2015 toolchain around as a new asset, so we can add bot coverage. Docs-Preview: https://skia.org/?cl=81841 Bug: skia: Change-Id: I8c68a6f949e54c0e798a219450bbb9406f8dc6ac Reviewed-on: https://skia-review.googlesource.com/81841 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Use full paths for adbGravatar Kevin Lubick2017-12-07
| | | | | | | | | | Add logic to run on Nexus 5xs in Golo. Bug:788839 Change-Id: I12290d11a0b1b0f012ada216da3e5b2599979c5e Reviewed-on: https://skia-review.googlesource.com/81861 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add Nexus7 CPU jobs.Gravatar Ben Wagner2017-12-07
| | | | | | | | | | Bug: skia:7381 Change-Id: I2dd5443c81cd895eb1d68b0cd90221a7e2e07d46 No-Try: true Reviewed-on: https://skia-review.googlesource.com/80843 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Reland "Always use the Win 10 SDK, and optionally detect/use the latest version"Gravatar Brian Osman2017-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 6da1d32c16a0598e9b32a4e5b60f99aca871a399 Original change's description: > Always use the Win 10 SDK, and optionally detect/use the latest version > > For bot toolchain builds, we were already using the Win 10 SDK. Local > 2015 builds were using a strange hybrid of Win 10 and Win 8 SDKs. Now > we always use the Win 10 SDK exclusively. > > This adds two new GN arguments: win_sdk, which points at the top level > Windows 10 SDK directory, and win_sdk_version, which can be used to > pin to a specific version. (Otherwise we use a script to detect the > most recent version). > > Bug: skia: > Change-Id: I5aabb5eb9e7f483e3676b67b50356ddd0421cf7d > Reviewed-on: https://skia-review.googlesource.com/81304 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Brian Osman <brianosman@google.com> Bug: skia: Change-Id: Ide0d6bd3413c4fe7a8bada7d3d32bdba9709d11b Reviewed-on: https://skia-review.googlesource.com/81501 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Revert "Always use the Win 10 SDK, and optionally detect/use the latest version"Gravatar Ravi Mistry2017-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6da1d32c16a0598e9b32a4e5b60f99aca871a399. Reason for revert: Caused Build-Win-Clang-arm64-Release-Android to fail. Eg: https://chromium-swarm.appspot.com/task?id=3a467f1ddd15fb10&refresh=10 Original change's description: > Always use the Win 10 SDK, and optionally detect/use the latest version > > For bot toolchain builds, we were already using the Win 10 SDK. Local > 2015 builds were using a strange hybrid of Win 10 and Win 8 SDKs. Now > we always use the Win 10 SDK exclusively. > > This adds two new GN arguments: win_sdk, which points at the top level > Windows 10 SDK directory, and win_sdk_version, which can be used to > pin to a specific version. (Otherwise we use a script to detect the > most recent version). > > Bug: skia: > Change-Id: I5aabb5eb9e7f483e3676b67b50356ddd0421cf7d > Reviewed-on: https://skia-review.googlesource.com/81304 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=mtklein@chromium.org,borenet@google.com,bungeman@google.com,brianosman@google.com Change-Id: Id044114fc685d570741e3f5ed003c4be2ffa84a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/81500 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Always use the Win 10 SDK, and optionally detect/use the latest versionGravatar Brian Osman2017-12-06
| | | | | | | | | | | | | | | | | For bot toolchain builds, we were already using the Win 10 SDK. Local 2015 builds were using a strange hybrid of Win 10 and Win 8 SDKs. Now we always use the Win 10 SDK exclusively. This adds two new GN arguments: win_sdk, which points at the top level Windows 10 SDK directory, and win_sdk_version, which can be used to pin to a specific version. (Otherwise we use a script to detect the most recent version). Bug: skia: Change-Id: I5aabb5eb9e7f483e3676b67b50356ddd0421cf7d Reviewed-on: https://skia-review.googlesource.com/81304 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Don't set min frequency for Android devicesGravatar Kevin Lubick2017-12-05
| | | | | | | | | | Bug: skia:7378 NOTRY=true No-Tree-Checks: true Change-Id: Iaacbc8eadaa4da9832a53d4794a2214625bef9b6 Reviewed-on: https://skia-review.googlesource.com/80842 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Merge UBSAN_float_cast_overflow into ASAN.Gravatar Ben Wagner2017-12-04
| | | | | | | | | | | | The new check was a different config while we fixed the errors. Most errors are now fixed, and merging these will help with running both on the CQ. No-Try: true Change-Id: I5804ecea84a8dbbaacf6a4ea96e2af9505641d49 Reviewed-on: https://skia-review.googlesource.com/79323 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Turn up Nexus10 CPU frequenciesGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | | | | The previous list was created from scaling_min_freq and scaling_max_freq instead of cpuinfo_min_freq and cpuinfo_max_freq which are the actual mins and maxes, not the current (transient) settings of the governor. Before: Test-Release: 61 minutes Perf-Debug: 41 minutes After: Test-Release: 32 minutes Perf-Debug: 16 minutes NOTRY=true Bug: skia: Change-Id: I9b431e92d2abcecb4fe643389daddc912a1399e1 Reviewed-on: https://skia-review.googlesource.com/78141 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make cpu scaling more robustGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | Some bots, especially the Nexus 7s, seemed to occasionally fail when setting the CPU frequency. I was unable to repro this behavior, so this is a shotgun approach. We add a 5 second delay between setting and checking, checking frequency using scaling_cur_freq instead of scaling_setspeed, set the min_freq as well as max_freq, and retry up to 3 times if setting cpu frequency fails. NOTRY=true Bug: skia: Change-Id: Id4d85d8d509c9dba8e3a0e06b5992f5adadf36d2 Reviewed-on: https://skia-review.googlesource.com/78140 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Update CT bots to Debian-9.2Gravatar Eric Boren2017-11-29
| | | | | | | | | | | This has the side effect of using the bots in the new GCE project as well. Bug: skia:7278 Change-Id: Ie14c93d6e3d12ccbfb679089bc50bca482fbf605 Reviewed-on: https://skia-review.googlesource.com/76261 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Add create_bundle support for GNGravatar Jim Van Verth2017-11-28
| | | | | | | | | Docs-Preview: https://skia.org/?cl=75383 Bug: skia:7339 Change-Id: I985734e8b7b5af21a82cb8ee59acbfb5ff1d3ff7 Reviewed-on: https://skia-review.googlesource.com/75383 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Don't scale CPU for internal botsGravatar Kevin Lubick2017-11-28
| | | | | | | | | | | | For internal hardware, it tends not to work - they work at one clock speed, despite advertising others. Bug: skia: NOTRY=true Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435 Reviewed-on: https://skia-review.googlesource.com/76720 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Make EGL test context access GL via GrGLInterfaceGravatar Brian Salomon2017-11-27
| | | | | | | | Bug: skia:7334 Change-Id: I5153ef83ae350648a15d6dc427b03d464258608b Reviewed-on: https://skia-review.googlesource.com/75980 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove obsolete iOSShell references from infra scriptsGravatar Brian Osman2017-11-22
| | | | | | | | Bug: skia: Change-Id: I36cb94877d513fc81c211b0e58b5c4be0451ac91 Reviewed-on: https://skia-review.googlesource.com/74601 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* VisualBench is not a thing anymoreGravatar Brian Osman2017-11-22
| | | | | | | | Bug: skia: Change-Id: I391cbc6cb2bf2ae88af0612964f4265788c8e771 Reviewed-on: https://skia-review.googlesource.com/74600 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Brian Osman <brianosman@google.com>