| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
| |
Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This will be used by the different frameworks to figure out if it is Rietveld or Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.
BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002
Review-Url: https://codereview.chromium.org/2263323002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding flags to the end of cc or cxx is pretty useful, but these always end up
on the command line before the GN generated flags, thus setting defaults that
GN will override.
For full flexibility we want to be able to add flags after the flags GN has
added, so that custom flags can override _it_.
I've updated the Fast bots with an example here: if we said cc="clang -O3 ...",
that '-O3' would be overriden later by the default Release-mode '-Os'. By
putting it in extra_cflags, we get the last word: our '-O3' overrides the
default '-Os'.
Another good use case is a hypothetical Actually-Shippable-Release mode. Our
Release mode bundles in tons of debug symbols via '-g'. libskia.a is about 10x
larger than it needs to be when built that way, but it helps us debug the bot
failures immensely. To build a libskia.{a,so} that you'd really ship, you can
now set extra_cflags="-g0" to override '-g'. You could set '-march' flags there
too, '-fomit-frame-pointer', etc.
There are lots of flags that won't matter where they end up in the command line.
To keep everything simple I've put them in extra_cflags with the rest. This means
the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241263003
Review-Url: https://codereview.chromium.org/2241263003
|
|
|
|
|
|
|
|
|
|
| |
Currently only turned on for one bot. May turn it on for more after more conversations.
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002
Review-Url: https://codereview.chromium.org/2231943002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As an experiment, instead of replacing these with -GN twins, take
them over in-place. This should take over:
-FAST
-SKFOO
CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002
Review-Url: https://codereview.chromium.org/2229463002
|
|
|
|
|
|
|
|
|
| |
Also move the isolate file and script from Chromium repo to the Skia repo.
BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002
Review-Url: https://codereview.chromium.org/2221413002
|
|
|
|
|
|
|
| |
BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221423002
Review-Url: https://codereview.chromium.org/2221423002
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219873003
Review-Url: https://codereview.chromium.org/2219873003
|
|
|
|
|
|
|
|
|
| |
Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003
Review-Url: https://codereview.chromium.org/2215443003
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002
Review-Url: https://codereview.chromium.org/2205473002
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002
Review-Url: https://codereview.chromium.org/2209423002
|
|
|
|
|
|
|
|
|
|
| |
This will allow me to run these tests in sRGB mode, while
leaving most of the image tests disabled.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006
Review-Url: https://codereview.chromium.org/2206953006
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002
Review-Url: https://codereview.chromium.org/2217523002
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API. As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002
Review-Url: https://codereview.chromium.org/2209343002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
- no more buildbot_spec.py step
- "real" dm and nanobench flags, instead of --dummy-flags
- some inconsequential stuff in visualbench, which is removed anyway.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002
Review-Url: https://codereview.chromium.org/2215803002
|
|
|
|
|
|
|
|
|
| |
This looks like another big change, but I really just moved blocks of code around. Again, no expectations diffs because no behavior is changed.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002
Review-Url: https://codereview.chromium.org/2198973002
|
|
|
|
|
|
|
| |
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002
Review-Url: https://codereview.chromium.org/2200763002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Break Skia recipe module into:
- skia_vars: defines and stores variables (eg. paths)
- skia_step: utilities for running Skia steps
- skia_flavor: flavor-specific stuff
- skia: top-level setup, checkout, test/perf steps, etc etc
This establishes a saner dependency structure for the recipes; skia_vars
is at the bottom level, skia_step depends on it, skia_flavor depends on
both of them, skia depends on all of the above, and the recipes
themselves may depend on any or all of them.
Next steps:
- Merge buildbot_spec into skia_vars
- Move test_steps and perf_steps from skia recipe_module into
swarm_test and swarm_perf recipes
- Cleaner checkout_steps process
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002
Review-Url: https://codereview.chromium.org/2198173002
|
|
|
|
|
|
|
| |
BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002
Review-Url: https://codereview.chromium.org/2199273002
|
|
|
|
|
|
|
|
| |
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true
Review-Url: https://codereview.chromium.org/2202053005
|
|
|
|
|
|
|
|
|
|
| |
We'll need to add Perf.*Debug bots to achieve the same coverage.
BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189393002
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2189393002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002
Review-Url: https://codereview.chromium.org/2197643002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.
(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002
TBR=jcgregorio@google.com
NOTRY=true
Review-Url: https://codereview.chromium.org/2193203002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To fix:
ERROR at the command-line "--args":1:34: Unexpected token '+'
is_debug=true cc=clang cxx=clang++
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003
Review-Url: https://codereview.chromium.org/2193593003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006
Review-Url: https://codereview.chromium.org/2186553006
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003
Review-Url: https://codereview.chromium.org/2189713003
|
|
|
|
|
|
|
|
|
|
| |
_UploadJSONResults does '/'.join() so the trailing / is unnecessary.
BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187903003
Review-Url: https://codereview.chromium.org/2187903003
|
|
|
|
|
|
|
|
|
|
| |
Ouch...
TBR=rmistry
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191663002
Review-Url: https://codereview.chromium.org/2191663002
|
|
|
|
|
|
|
|
|
| |
This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188543002
Review-Url: https://codereview.chromium.org/2188543002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186993002
Review-Url: https://codereview.chromium.org/2186993002
|
|
|
|
|
|
|
| |
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187603005
Review-Url: https://codereview.chromium.org/2187603005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.
With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.
TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
Review-Url: https://codereview.chromium.org/2185953003
|
|
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002
Review-Url: https://codereview.chromium.org/2175373002
|