aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipe_modules/vars
Commit message (Collapse)AuthorAge
* Recipes: remove some pragma: no coverGravatar Eric Boren2017-04-19
| | | | | | | | | | | | | | | | These are the remaining instances, and they're harder to deal with: $ git grep pragma recipe_modules/swarming/api.py: except self.m.step.StepFailure as e: # pragma: no cover recipe_modules/swarming/api.py: if len(ids) > 1: # pragma: nocover recipes/ct_skps.py: if api.path.exists(version_file): # pragma: nocover recipes/ct_skps.py: if api.path.exists(blacklist_file): # pragma: nocover recipes/upload_nano_results.py: if len(results) != 1: # pragma: nocover Bug: skia:6473 Change-Id: If75e2ffcf39a944b513b9005bbc4bd9c4fb031f6 Reviewed-on: https://skia-review.googlesource.com/13867 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Reland Recipes: Use strict coverage, part 2Gravatar Eric Boren2017-04-19
| | | | | | | | Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Recipes: Use strict coverage, part 1Gravatar Eric Boren2017-04-19
| | | | | | | | | | Shouldn't change any behavior. Bug: skia: Change-Id: I953e0da886a6d61096eba7915101f245a6cec741 Reviewed-on: https://skia-review.googlesource.com/13765 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Recipes: Remove depot_tools path hackGravatar Eric Boren2017-04-10
| | | | | | | | Bug: skia:6473 Change-Id: I722059844bb0bc9d58347b4f6002ee62043b9e20 Reviewed-on: https://skia-review.googlesource.com/13006 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Clean up no-longer-used recipes stuffGravatar Eric Boren2017-04-10
| | | | | | | | | | | | - Remove buildbot logic - Remove non-Gerrit logic - Remove master, slave, and build number properties Bug: skia:6473 Change-Id: I203d523f3a0e03f933c0c48d29c7aabac503b2b9 Reviewed-on: https://skia-review.googlesource.com/12625 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add ChromeOS Test/Perf jobs and recipe changesGravatar Kevin Lubick2017-04-07
| | | | | | | | | Minor cleanup of left over Tab3 tests. Bug: skia:6442 Change-Id: I03bb4a034101a2773619abd2be7a300a70f6ac3d Reviewed-on: https://skia-review.googlesource.com/11414 Reviewed-by: Eric Boren <borenet@google.com>
* Bundle recipes for use on RPiGravatar Eric Boren2017-04-04
| | | | | | | | | | This saves ~1:30 of overhead when the isolate cache is warm. Bug: skia:5813 Change-Id: I5053d66e865ca6500b82567f83be8042568e22cf Reviewed-on: https://skia-review.googlesource.com/11063 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add Chromecast Perf jobsGravatar Kevin Lubick2017-03-21
| | | | | | | | | | | | It starts out with some skps and resource-based perf because all skps wouldn't fit and skimages are far too large BUG=skia: Change-Id: Icb07ffa84d39a85a8bc595e74ef934df921e749a Reviewed-on: https://skia-review.googlesource.com/9901 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Followup fixes for recipe rollGravatar Eric Boren2017-03-21
| | | | | | | | | | | | | | Simplifying some environment madness. Nobody gets to modify default_env. Always apply it in run.__call__(). Add depot_tools path to PATH in default_env. Result is simpler but now default_env is applied in many more places, which should be harmless. BUG=skia: Change-Id: I8299d50bde2bc3e2d47568a267d1d962a3fc3d56 Reviewed-on: https://skia-review.googlesource.com/9916 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll recipe DEPS againGravatar Eric Boren2017-02-21
| | | | | | | | | | | | This time with coverage bypass BUG=skia: Change-Id: I7f51dcad7bad53c7209ac512876a0d72c6181b8e Reviewed-on: https://skia-review.googlesource.com/8768 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add Flutter compile botGravatar Ravi Mistry2017-02-17
| | | | | | | | | BUG=skia:6227 Change-Id: I997663e49c407e3ec64c8e67a2ca27700d5081b4 Reviewed-on: https://skia-review.googlesource.com/8448 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Copy modules back in from skia-recipes repoGravatar Eric Boren2017-02-02
| | | | | | | | | BUG=skia:6070 Change-Id: I86b3f039c27bd8287516c1db8bd1cae62888171b Reviewed-on: https://skia-review.googlesource.com/7890 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Move recipe modules to shared repoGravatar Eric Boren2017-01-17
| | | | | | | | | | BUG=skia:6070 Change-Id: I6c487e77ddfddb6164b983981dff5ee8ae870376 Reviewed-on: https://skia-review.googlesource.com/6946 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* [nobuildbot] Housekeeper-PerCommitGravatar Eric Boren2016-12-02
| | | | | | | | | BUG=skia: Change-Id: I9a6a8970bd70dc52334fc44ed29ea942c29132fc Reviewed-on: https://skia-review.googlesource.com/5507 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Fix is_trybot for no-buildbot botsGravatar Eric Boren2016-11-23
| | | | | | | | | | | | | | | | This was breaking gold/perf trybot results for no-buildbot bots. Note that: - Upload destination was correct, due to upload_nano_results using the correct property names. - Patches were properly applied, since bot_update uses the properties independently of our logic. BUG=skia: Change-Id: I16f2e2d24d4602dc73233784d098f00b745e061a Reviewed-on: https://skia-review.googlesource.com/5201 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll recipe DEPSGravatar Ravi Mistry2016-11-22
| | | | | | | | | | | | | Looks like slave_build and cwd changed to start_dir in https://bugs.chromium.org/p/chromium/issues/detail?id=662586 BUG=skia:5979 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5104 Change-Id: I46d080b9089ea9b4adc2ed45fc81fdc192bdb2b2 Reviewed-on: https://skia-review.googlesource.com/5104 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Add skpbench jobGravatar Kevin Lubick2016-11-14
| | | | | | | | | | | | | | | | | | | | | | | | This entails a few parts: 1. Isolating tools/skpbench/ to be used by the perf task. 2. Adding skpbench to BUILD_PRODUCTS_ISOLATE_WHITELIST 3. Add recipe commands to run skpbench. While it is conceptually similar to nanobench, it doesn't support images nor svgs, only skps, so we don't need to copy those to devices or bring them in via CIPD. 4. Add recipe commands to parse skpbench output and upload to Perf. 5. Update gen_tasks.go to handle skpbench jobs and tasks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4551 Change-Id: I09bf0b078067279e138e95eca9316e55539ec735 Reviewed-on: https://skia-review.googlesource.com/4551 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix recipes for Gerrit property renameGravatar borenet2016-10-27
| | | | | | | | NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2455523004 Review-Url: https://codereview.chromium.org/2455523004
* Recipe fix for buildbotless botsGravatar borenet2016-10-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2435803003 Review-Url: https://chromiumcodereview.appspot.com/2435803003
* Add key params for buildbotless bots in DM/nanobenchGravatar borenet2016-10-19
| | | | | | | BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2424793005 Review-Url: https://chromiumcodereview.appspot.com/2424793005
* Add infra_tests.py, recipe, buildbotless botGravatar borenet2016-10-14
| | | | | | | | | Have the presubmit (upload) run infra_tests.py if anything in infra/ changed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002 Review-Url: https://codereview.chromium.org/2415193002
* Recipe fixes to support try jobs in task schedulerGravatar borenet2016-10-13
| | | | | | | BUG=skia:5723 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410843002 Review-Url: https://codereview.chromium.org/2410843002
* Add swarm_presubmit recipeGravatar borenet2016-10-05
| | | | | | | | | This allows us to add a Housekeeper-PerCommit-Presubmit bot/trybot BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392663004 Review-Url: https://codereview.chromium.org/2392663004
* Make the housekeeper upload doxygen to a newer bucketGravatar borenet2016-10-04
| | | | | | | | BUG=skia:2969 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370153003 DOCS_PREVIEW= https://skia.org/?cl=2370153003 Review-Url: https://codereview.chromium.org/2370153003
* Stop uploading nanobench results on Valgrind botGravatar borenet2016-09-30
| | | | | | | | | It's not needed, and it's probably making the bot a lot slower. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382313003 Review-Url: https://codereview.chromium.org/2382313003
* Pass rietveld as the default patch_storage.Gravatar mtklein2016-09-15
| | | | | | | | | | | | Passing around empty strings as command line arguments requires us to be really careful about command line quoting, parsing, etc. It seems easy enough here to just supply the implied value. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003 Review-Url: https://codereview.chromium.org/2323233003
* GN: add sanitize argGravatar mtklein2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Attempt to take over all *SAN builds. MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py. I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier to use locally. The compile steps should be much faster now. We no longer build CMake and Clang for every run, instead using the clang_linux CIPD package. This removes the need for all the third_party/externals/llvm/... dependencies. Similarly, since we're using the clang_linux package, we no longer depend on Chrome's Clang, and thus no longer need to sync chromium on these bots. Instead of packaging up MSAN libraries and llvm-symbolizer in the compile output, I have the test / perf bots also depend on the clang_linux package. These do not vary from build to build. No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja all track changes to xsan.blacklist without our help. This has the incidental effect of upgrading the compiler used by *SAN bots from Clang 3.8 to Clang 3.9. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002 Review-Url: https://codereview.chromium.org/2289343002
* Apply gerrit ref if it is a Gerrit patch.Gravatar rmistry2016-08-24
| | | | | | | | | | | Also: * Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This will be used by the different frameworks to figure out if it is Rietveld or Gerrit issue. * Calculate issue and patchset for Gerrit patches similar to Rietveld. BUG=skia:5627 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002 Review-Url: https://codereview.chromium.org/2263323002
* Use SVGs CIPD package and use SVG as a DM source.Gravatar rmistry2016-08-11
| | | | | | | | | | Currently only turned on for one bot. May turn it on for more after more conversations. BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002 Review-Url: https://codereview.chromium.org/2231943002
* Move ct_skps recipe from tools repo to Skia repo.Gravatar rmistry2016-08-09
| | | | | | | | | Also move the isolate file and script from Chromium repo to the Skia repo. BUG=skia:5620 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002 Review-Url: https://codereview.chromium.org/2221413002
* [recipes] Smush the rest of builder_spec into appropriate places, other cleanupGravatar borenet2016-08-08
| | | | | | | BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219873003 Review-Url: https://codereview.chromium.org/2219873003
* [recipes] Increase test coverageGravatar borenet2016-08-05
| | | | | | | | | Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover. BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003 Review-Url: https://codereview.chromium.org/2215443003
* [recipes] Separate builder_spec into compile/test/perf recipesGravatar borenet2016-08-05
| | | | | | | BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002 Review-Url: https://codereview.chromium.org/2205473002
* [recipes] Remove build environment vars from default_envGravatar borenet2016-08-05
| | | | | | | BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002 Review-Url: https://codereview.chromium.org/2209423002
* Create a separate src for colorspace testsGravatar msarett2016-08-04
| | | | | | | | | | This will allow me to run these tests in sRGB mode, while leaving most of the image tests disabled. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006 Review-Url: https://codereview.chromium.org/2206953006
* [recipes] Fixes for Coverage botGravatar borenet2016-08-04
| | | | | | | BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002 Review-Url: https://codereview.chromium.org/2217523002
* [recipes] Stop pretending that buildbot_spec is a step, simplifyGravatar borenet2016-08-04
| | | | | | | | | | | | Since we no longer have to call out to obtain the buildbot_spec, merge the two functions in vars API. As a side effect, this applies default_env to the sync steps as well, which shouldn't have an appreciable effect on bot behavior. BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002 Review-Url: https://codereview.chromium.org/2209343002
* Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipesGravatar borenet2016-08-04
| | | | | | | | | | | | | | - builder_name_schema becomes its own recipe module. - builder_spec, dm, and nanobench flags move into vars module. - recipe expectation diffs include: - no more buildbot_spec.py step - "real" dm and nanobench flags, instead of --dummy-flags - some inconsequential stuff in visualbench, which is removed anyway. BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002 Review-Url: https://codereview.chromium.org/2215803002
* Re-organize Skia recipesGravatar borenet2016-08-03
Break Skia recipe module into: - skia_vars: defines and stores variables (eg. paths) - skia_step: utilities for running Skia steps - skia_flavor: flavor-specific stuff - skia: top-level setup, checkout, test/perf steps, etc etc This establishes a saner dependency structure for the recipes; skia_vars is at the bottom level, skia_step depends on it, skia_flavor depends on both of them, skia depends on all of the above, and the recipes themselves may depend on any or all of them. Next steps: - Merge buildbot_spec into skia_vars - Move test_steps and perf_steps from skia recipe_module into swarm_test and swarm_perf recipes - Cleaner checkout_steps process BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002 Review-Url: https://codereview.chromium.org/2198173002