aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipe_modules/flavor/examples
Commit message (Collapse)AuthorAge
* Revert "Reland "[infra] Run recipes through Kitchen""Gravatar Eric Boren2018-04-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f39bbe5a31542396a8aabf8066ee46862312d7d8. Reason for revert: Broke lots of bots Original change's description: > Reland "[infra] Run recipes through Kitchen" > > Bug: skia:7050 > Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7 > Reviewed-on: https://skia-review.googlesource.com/121481 > Commit-Queue: Eric Boren <borenet@google.com> > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com Change-Id: I4548c66a9cb0b4f105e2bc3b1c7185d14549172f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7050 Reviewed-on: https://skia-review.googlesource.com/121463 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Reland "[infra] Run recipes through Kitchen"Gravatar Eric Boren2018-04-17
| | | | | | | | | Bug: skia:7050 Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7 Reviewed-on: https://skia-review.googlesource.com/121481 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Revert "[infra] Run recipes through Kitchen"Gravatar Eric Boren2018-04-16
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7bbb26fee0dcd7c53c1f5b80f62966654dd823ba. Reason for revert: uploads broke task scheduler Original change's description: > [infra] Run recipes through Kitchen > > Bug: skia:7050 > Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4 > Reviewed-on: https://skia-review.googlesource.com/82500 > Commit-Queue: Eric Boren <borenet@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> TBR=borenet@google.com,rmistry@google.com Change-Id: Ic3a5404fde844f01eca551d50039a84a20e84e11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7050 Reviewed-on: https://skia-review.googlesource.com/121423 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [infra] Run recipes through KitchenGravatar Eric Boren2018-04-16
| | | | | | | | Bug: skia:7050 Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4 Reviewed-on: https://skia-review.googlesource.com/82500 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Add loongson3a Build jobs.Gravatar Ben Wagner2018-04-04
| | | | | | | Change-Id: I4a0259f82272099e08df0e7dea91489f6d641ca4 Reviewed-on: https://skia-review.googlesource.com/113670 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* add Mac ASAN botsGravatar Mike Klein2018-04-04
| | | | | | | | Change-Id: I783c0ad51a33e4731470f457132a1d20025a3431 Reviewed-on: https://skia-review.googlesource.com/118342 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* limit cpu features of skcms on bots we limit skiaGravatar Mike Klein2018-04-03
| | | | | | | | | | | | | | Valgrind doesn't support half<->float x86 conversion instructions, so we build those bots with SK_CPU_LIMIT_SSE41. We now also need to limit skcms on those same bots. Easiest thing to do is build completely portable scalar code, using the existing -DSKCMS_PORTABLE. We can get fancier later if needed. Change-Id: Icf14c72a220818be9df7b97bcf203e4412c3c6b7 Reviewed-on: https://skia-review.googlesource.com/118264 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* update Ubuntu14 CT bots to ClangGravatar Mike Klein2018-03-22
| | | | | | | | | | To run on these older bots, looks like we need to statically link libstdc++ and libgcc. Luckily that is straightforward. Change-Id: If523067df196e943c2ba2f64c52eea0711dbfcbd Reviewed-on: https://skia-review.googlesource.com/115743 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Reland "Switch Win Exceptions Build to Clang."Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f2419b936150e24ca1aea891ba405c8ea8ebdc7. Reason for revert: Creating CL to reland Original change's description: > Revert "Switch Win Exceptions Build to Clang." > > This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551. > > Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 > > Original change's description: > > Switch Win Exceptions Build to Clang. > > > > No-Try: true > > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 > > Reviewed-on: https://skia-review.googlesource.com/113673 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,benjaminwagner@google.com > > Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/114420 > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=mtklein@google.com,benjaminwagner@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie4ba6c264b3ab2b3c63ac0e225638b0a4e70cda1 Reviewed-on: https://skia-review.googlesource.com/114822 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [recipes] Add toolchain version to extra_cflags.Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | In compile recipes, add a dummy define (e.g. -DDUMMY_clang_linux_version=42) to the compiler flags so that ninja will recompile from scratch when the toolchain changes. Bug: skia:7720 Change-Id: I9a330b21af364b3aa6a1eebbe6ac2022cfa82fdc Reviewed-on: https://skia-review.googlesource.com/115160 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [recipes] Add asset_version utility function.Gravatar Ben Wagner2018-03-20
| | | | | | | | Bug: skia:7720 Change-Id: I044ca5281354b21c9deffa408ad7ec20c51d2e2e Reviewed-on: https://skia-review.googlesource.com/115122 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [recipes] Band-aid on top of a hack: pin depot_toolsGravatar Eric Boren2018-03-19
| | | | | | | | Bug: skia:7050 Change-Id: I53b141bf76ab4773909df968f69ba04dc29e0dc9 Reviewed-on: https://skia-review.googlesource.com/114960 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "Scale the GPU when running perf on Pixel(2)"Gravatar Ravi Mistry2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit aa504cddb9196a3f5e798a280061ba6eb3c22901. Reason for revert: Kevin asked me to revert since this broke things Original change's description: > Scale the GPU when running perf on Pixel(2) > > This is a similar followup to: > https://skia-review.googlesource.com/c/skia/+/93561 > > Bug: skia: > Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc > Reviewed-on: https://skia-review.googlesource.com/114340 > Reviewed-by: Eric Boren <borenet@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,kjlubick@google.com Change-Id: Idbc7234f2b7ff8c5e632680903836e1f4eaa50d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114425 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Scale the GPU when running perf on Pixel(2)Gravatar Kevin Lubick2018-03-14
| | | | | | | | | | | This is a similar followup to: https://skia-review.googlesource.com/c/skia/+/93561 Bug: skia: Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc Reviewed-on: https://skia-review.googlesource.com/114340 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Revert "Switch Win Exceptions Build to Clang."Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551. Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 Original change's description: > Switch Win Exceptions Build to Clang. > > No-Try: true > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 > Reviewed-on: https://skia-review.googlesource.com/113673 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,benjaminwagner@google.com Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/114420 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove Goma builds and support in gn_flavor.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | The experiment with using Goma to speed up Windows compiles was very close to being successful, but at this point the ongoing maintenance does not seem to be worth the 50-70 seconds saved. Change-Id: Ie3900b9a681e448a3e47634efbab7695ebccad33 Reviewed-on: https://skia-review.googlesource.com/114363 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Switch Win Exceptions Build to Clang.Gravatar Ben Wagner2018-03-14
| | | | | | | | No-Try: true Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 Reviewed-on: https://skia-review.googlesource.com/113673 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Use goma ensure_stop.Gravatar Ben Wagner2018-03-12
| | | | | | | | | Bug: b/72128121 No-Try: true Change-Id: I34ae57e1e6caa18fd22c0a9151206142323c094e Reviewed-on: https://skia-review.googlesource.com/107560 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add ProcDump support to gn_flavor.py.Gravatar Ben Wagner2018-03-10
| | | | | | | | | | | | | | Adds procdump_win asset. Enable ProcDump for some of the jobs failing in skia:7177 as a test case. If it has no ill effect, we can proceed with enabling it for all Win bots (and remove "ProcDump" tag). Bug: skia:7626, skia:7177 Change-Id: I50c67ecfca86fe0c6d91d5f970f81485cc9cfd0a Reviewed-on: https://skia-review.googlesource.com/113265 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Test SKQP on Firebase Testlab and UploadGravatar Stephan Altmueller2018-03-07
| | | | | | | | | | | | | | - adds building the testlab driver (run_testlab) as a separate step - adds gcloud isolate necessary to run testlab - adds Testlab support and uploading a verified AKP to GCS (with meta data attached). Bug: skia: Change-Id: I1bf265f46c99360eb3a9eb684886f93de48085fe Reviewed-on: https://skia-review.googlesource.com/111603 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Change force_quarantine to use bot idGravatar Kevin Lubick2018-03-01
| | | | | | | | Bug: skia:7639 Change-Id: I4b8337bac996062c41fb9ae7460cf214b7524a46 Reviewed-on: https://skia-review.googlesource.com/111300 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add bot which builds without DEPSGravatar Eric Boren2018-02-22
| | | | | | | | Bug: skia:7646 Change-Id: Iddf55940230c99fea9d838a1b03a8c3bb476262e Reviewed-on: https://skia-review.googlesource.com/109360 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Remove SkQP bot from masterGravatar Stephan Altmueller2018-02-22
| | | | | | | | Bug: skia: Change-Id: I0415690911a52059eaaf7f32c81b7a4c66117d5b Reviewed-on: https://skia-review.googlesource.com/109162 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add SKQP bot to build universal APK to masterGravatar Stephan Altmueller2018-02-20
| | | | | | | | Bug: skia: Change-Id: Ib0e9ddb621056ddce2422b53f312ec42d4d7aa3c Reviewed-on: https://skia-review.googlesource.com/107880 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Revert "Increase ninja thread count for Android build on Linux."Gravatar Stephan Altmueller2018-02-20
| | | | | | | | | | | | | | | also Revert "Increase ninja thread count for Windows builds." This reverts commit 98c4231592bfadbe92d906f707d28508c50b0c16. This reverts commit 50a808a518c895c956c6d30d07e1e81e5e7abddb. Bug: skia: Change-Id: I7cc50b0bec6e1ad9f9d971a5c88c029488bb80ed Reviewed-on: https://skia-review.googlesource.com/108504 Reviewed-by: Stephan Altmueller <stephana@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* [recipes] Expand depot_tools DEPS hack for flutter and PDFium buildsGravatar Eric Boren2018-02-16
| | | | | | | | Bug: skia:7609 Change-Id: Iaaaa2390d87656a4fa40e44fc31c35573abec7b5 Reviewed-on: https://skia-review.googlesource.com/108186 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Increase ninja thread count for Android build on Linux.Gravatar Ben Wagner2018-02-15
| | | | | | | Change-Id: Ib637360e2f09cd2851771595590203da6195a314 Reviewed-on: https://skia-review.googlesource.com/107600 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Increase ninja thread count for Windows builds.Gravatar Ben Wagner2018-02-15
| | | | | | | Change-Id: Icc3f3cc144d6d3d2ee467822436df94559d6ff37 Reviewed-on: https://skia-review.googlesource.com/107580 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Use libc++ for all XSAN buildsGravatar Kevin Lubick2018-02-15
| | | | | | | | Docs-Preview: https://skia.org/?cl=107306 Bug: oss-fuzz:6347 Change-Id: I59c3b1b2e693fd97be0091ba2df406f51461fd10 Reviewed-on: https://skia-review.googlesource.com/107306 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Do not copy vulkan-1.dll to Win bots.Gravatar Ben Wagner2018-02-14
| | | | | | | | | | | | | Previously, we needed vulkan-1.dll from the Vulkan runtime because some drivers did not include the Vulkan loader. Now, all drivers include this DLL and using the version from assets causes problems for newer Intel drivers. Bug: skia:7490 Change-Id: I7bd37fb0d2c88a4753f354ab2bc88761562ced2f Reviewed-on: https://skia-review.googlesource.com/107060 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* [recipes] Check out a separate depot_tools for syncing ChromeGravatar Eric Boren2018-02-12
| | | | | | | | | | | | This is a hack to get around the fact that we can't update the normal version of depot_tools we receive through recipe deps, since we are not yet using kitchen (See skia:7050). Bug: skia:7609 Change-Id: I7d39e1e5db716960b2df2c8e3d4325c4b20c774e Reviewed-on: https://skia-review.googlesource.com/106720 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* target Android M for -arm- ASAN buildsGravatar Mike Klein2018-01-30
| | | | | | | Change-Id: I8154b9a0b2fcf76fa02af0efa6b57425c6f9ac31 Reviewed-on: https://skia-review.googlesource.com/101580 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Couple small changes to speed up Goma compilesGravatar Ben Wagner2018-01-25
| | | | | | | | | | | | - Use more threads - Avoid failures due to Goma compiler_proxy running after Swarming task terminates, e.g. https://chromium-swarm.appspot.com/task?id=3b309dfecdaa9b10 Change-Id: I8521ad0dbaead6f22a2d3a3401dfe0b2695742b9 Reviewed-on: https://skia-review.googlesource.com/99020 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix Test-Chromecast from running out of memory on testsGravatar Kevin Lubick2018-01-16
| | | | | | | | Bug: skia:7166 Change-Id: Iefc8c6c1b72805dfe3ec8bd06d6ba6a878307582 Reviewed-on: https://skia-review.googlesource.com/93620 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add Android ASAN botGravatar Kevin Lubick2018-01-12
| | | | | | | | | | | It should work on 32 and 64 bit android running M or newer. Bug: skia: Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c Reviewed-on: https://skia-review.googlesource.com/93700 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Trying gpu scaling on Nexus 5 and 5xGravatar Kevin Lubick2018-01-11
| | | | | | | | | | We do some of this already in skpbench. Bug: skia: Change-Id: Ia698466e83f9b476644c126747a2f89346361d13 Reviewed-on: https://skia-review.googlesource.com/93561 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Only uninstall if install failed.Gravatar Ben Wagner2018-01-04
| | | | | | | | | | | | | This is a followup to https://skia-review.googlesource.com/c/skia/+/90343, which causes task durations to increase due to copying over images, skps, etc. on every run. Bug: skia:7408 Change-Id: I42e829e287b7343e969159ac19c587a87ebe99e8 No-Try: true Reviewed-on: https://skia-review.googlesource.com/90942 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Switch to updated Mac bots.Gravatar Ben Wagner2018-01-04
| | | | | | | | Bug: skia:7408 Change-Id: I26273df7871e3ee01e227636421962fcc6251e7d Reviewed-on: https://skia-review.googlesource.com/88080 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix absolute path for recipesGravatar Kevin Lubick2018-01-04
| | | | | | | | Bug: skia: Change-Id: I42c528d86f19d369609b26763334e055501a9b9b Reviewed-on: https://skia-review.googlesource.com/90880 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* In iOS recipe, uninstall before install.Gravatar Ben Wagner2018-01-03
| | | | | | | | Bug: skia:7408 Change-Id: Iea55fe9199db7fc841ed0ba4a2451a84cd57213f Reviewed-on: https://skia-review.googlesource.com/90343 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Quarantine android bots instead of shutting off deviceGravatar Kevin Lubick2017-12-22
| | | | | | | | | | | | | | This should make it easier to diagnose and remotely fix the devices/hosts. Only works because of https://chrome-internal-review.googlesource.com/c/infradata/config/+/535542 Bug: skia: Change-Id: Idf11a09da6c7367212a0ac0b0b959cbf49fed85b Reviewed-on: https://skia-review.googlesource.com/89181 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove Linux IntelIris540 jobs.Gravatar Ben Wagner2017-12-21
| | | | | | | | | | | | | | Replacing IntelIris540 with IntelIris640, added in https://skia-review.googlesource.com/c/skia/+/87202. I verified that Gold results are still identical (modulo flakes). See also https://skia-review.googlesource.com/c/skia/+/87721 and https://skia-review.googlesource.com/c/skia/+/78640. No-Try: true Change-Id: Ifc7e80e92d6203d922e00b59127b136632af7afc Reviewed-on: https://skia-review.googlesource.com/88427 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Make sure we get the LITTLE cores out of powersaveGravatar Kevin Lubick2017-12-19
| | | | | | | | | Bug: skia:7420 NOTRY=true Change-Id: I785135a3abc17f63d715d459668c768a6014d9b3 Reviewed-on: https://skia-review.googlesource.com/87001 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Enable Goma fallback by default.Gravatar Ben Wagner2017-12-14
| | | | | | | | | | Add a job that doesn't allow fallback so we know when things aren't working as expected. Change-Id: If993976d6807635bde455c2091f8a1ba18c41e27 Reviewed-on: https://skia-review.googlesource.com/83700 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "Disable extra CPUs during Nanobench""Gravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 43307c09b97c5a5c5174f0c4ccb79bdaf3ebf557. Reason for revert: Fixed this time. Echo 1 > already online cpu returns exit code 1, which makes python over-react. Original change's description: > Revert "Disable extra CPUs during Nanobench" > > This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. > > Reason for revert: many unhappy android bots > > Original change's description: > > Disable extra CPUs during Nanobench > > > > The previous experiment revealed that nanobench can > > run on any of the online CPUs, so rather than put > > the ones we don't need/want into powersave mode, just > > disable them. > > > > Maybe in the future we can run CPU tests on the big > > or LITTLE cpus to get perf data on higher end or > > lower end cpus, but only if we get very stable > > results from this. > > > > Bug: skia:7378 > > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > > Reviewed-on: https://skia-review.googlesource.com/84820 > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > Commit-Queue: Kevin Lubick <kjlubick@google.com> > > TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com > > Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 > Bug: skia:7378 > Reviewed-on: https://skia-review.googlesource.com/84921 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> No-Tree-Checks: true Change-Id: Ie7f0a3dc6ba55c124c796aba16a0f0497f285f3a Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84865 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Revert "Disable extra CPUs during Nanobench"Gravatar Mike Klein2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. Reason for revert: many unhappy android bots Original change's description: > Disable extra CPUs during Nanobench > > The previous experiment revealed that nanobench can > run on any of the online CPUs, so rather than put > the ones we don't need/want into powersave mode, just > disable them. > > Maybe in the future we can run CPU tests on the big > or LITTLE cpus to get perf data on higher end or > lower end cpus, but only if we get very stable > results from this. > > Bug: skia:7378 > notry=true > notreechecks=true > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > Reviewed-on: https://skia-review.googlesource.com/84820 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84921 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Disable extra CPUs during NanobenchGravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | The previous experiment revealed that nanobench can run on any of the online CPUs, so rather than put the ones we don't need/want into powersave mode, just disable them. Maybe in the future we can run CPU tests on the big or LITTLE cpus to get perf data on higher end or lower end cpus, but only if we get very stable results from this. Bug: skia:7378 notry=true notreechecks=true Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 Reviewed-on: https://skia-review.googlesource.com/84820 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add Goma for all Windows Clang Builds.Gravatar Ben Wagner2017-12-13
| | | | | | | Change-Id: I26e75cf6cd865ec6c47b7766679177bfd30387da Reviewed-on: https://skia-review.googlesource.com/82921 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Experiment with turning CPUs off during perfGravatar Kevin Lubick2017-12-13
| | | | | | | | | | | | | | | | | | | | | | | Perf was nice and flat after https://skia-review.googlesource.com/c/skia/+/83240 but there was a 4-5x slowdown on the benchmarks themselves, indicating that perhaps we were running nanobench on the LITTLE cores (now on powersave) instead of the big cores we thought (which were recently scaled down). This experiment will show us FOR CERTAIN that we are running on core 0 or 1 which is at .6 max frequency. We expect to see a speedup from the previous results. This is leading to turning of CPUs we don't need to make sure nanobench is running on the ones we expect. Bug: skia: NOTRY=true Change-Id: Ida65181e4d90e778e65e3f22d761288b9ade64f6 Reviewed-on: https://skia-review.googlesource.com/84201 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Store skiaserve binary in GS from Release Android compile botsGravatar Ravi Mistry2017-12-12
| | | | | | | | Bug: skia:7399 Change-Id: Id60773f77694b06a938f9a126f30ca56e4965d30 Reviewed-on: https://skia-review.googlesource.com/83981 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>