aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/jobs.json
Commit message (Collapse)AuthorAge
...
* Add Win UBSAN jobs.Gravatar Ben Wagner2018-01-03
| | | | | | | | Bug: skia:2679 Change-Id: Ia462af01b9832da90206b9e9be2278cb48c6c502 Reviewed-on: https://skia-review.googlesource.com/86401 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Housekeeper-PerCommit-Bookmaker bot to verify that docs match includesGravatar Ravi Mistry2018-01-02
| | | | | | | | | | | Example failure- https://chromium-swarm.appspot.com/task?id=3a97e6c00ff78010 Example success- https://chromium-swarm.appspot.com/task?id=3a9814b474fcf910 Bug: skia:7432 Change-Id: I2459b7568ac2d12a0ed81b1eec9ddd61cff5b643 Reviewed-on: https://skia-review.googlesource.com/87767 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Remove Linux IntelIris540 jobs.Gravatar Ben Wagner2017-12-21
| | | | | | | | | | | | | | Replacing IntelIris540 with IntelIris640, added in https://skia-review.googlesource.com/c/skia/+/87202. I verified that Gold results are still identical (modulo flakes). See also https://skia-review.googlesource.com/c/skia/+/87721 and https://skia-review.googlesource.com/c/skia/+/78640. No-Try: true Change-Id: Ifc7e80e92d6203d922e00b59127b136632af7afc Reviewed-on: https://skia-review.googlesource.com/88427 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Re-add IntelIris640 Linux bots.Gravatar Ben Wagner2017-12-19
| | | | | | | | | | | | | These were removed in https://skia-review.googlesource.com/c/skia/+/78640 However, we've now decided on the 640 rather than the 540 due to inventory. No-Try: true Change-Id: Icf6db636287e151d3dd3ac74cfddf8f6bd3bea6a Reviewed-on: https://skia-review.googlesource.com/87202 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Enable Goma fallback by default.Gravatar Ben Wagner2017-12-14
| | | | | | | | | | Add a job that doesn't allow fallback so we know when things aren't working as expected. Change-Id: If993976d6807635bde455c2091f8a1ba18c41e27 Reviewed-on: https://skia-review.googlesource.com/83700 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Switch Goma test jobs to ANGLE/Vulkan.Gravatar Ben Wagner2017-12-14
| | | | | | | | No-Try: true Change-Id: I229c2839d423d543ea7bd1aedec893d7bfeb27ea Reviewed-on: https://skia-review.googlesource.com/83701 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Goma for all Windows Clang Builds.Gravatar Ben Wagner2017-12-13
| | | | | | | Change-Id: I26e75cf6cd865ec6c47b7766679177bfd30387da Reviewed-on: https://skia-review.googlesource.com/82921 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* cleanup {ASAN,MSAN}_{FAAA,FDAA,FSAA} botsGravatar Mike Klein2017-12-13
| | | | | | | | | | | | | We no longer have any reason to suspect there's anything wrong with these configurations, and we're not actively debugging anything related to them anymore. I've kept the normal Debug/Release bots. Change-Id: I1a3d8087b519d6f01223d3b33bce762511056d1a Reviewed-on: https://skia-review.googlesource.com/84522 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* resources: optionally link them into our binaryGravatar Hal Canary2017-12-11
| | | | | | | | | | | To enable, set skia_embed_resources=true in args.gn. Also add *-EmbededResouces bots. Change-Id: Ia69b26e926a3ad4676a4fa021894432ea2104538 Reviewed-on: https://skia-review.googlesource.com/82626 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Re-add '--gpuThreads 0' tests.Gravatar Ben Wagner2017-12-11
| | | | | | | | | Bug: skia:7394 Change-Id: I2e7ed586d81d19a0b7895ff81ce6670eb7cc5003 No-Try: true Reviewed-on: https://skia-review.googlesource.com/83445 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove PixelC CPU jobs.Gravatar Ben Wagner2017-12-11
| | | | | | | | | | | | | The Nexus5x took these jobs in https://skia-review.googlesource.com/c/skia/+/82624 Also filed skia:7394 for missing coverage of "--gpuThreads 0". Bug: skia:7382 Change-Id: If0fd823722d8b8cc3845f8d96a0a285fec935f74 No-Try: true Reviewed-on: https://skia-review.googlesource.com/83360 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Goma Test/Perf jobs.Gravatar Ben Wagner2017-12-11
| | | | | | | | | No-Try: true Change-Id: I9c07250623603be1baccdc177191326017784aa2 Reviewed-on: https://skia-review.googlesource.com/82604 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add new Bookmaker bot that runs nightlyGravatar Ravi Mistry2017-12-08
| | | | | | | | | | | | | | | | | | | | The new bot: 1) Extracts all fiddles out of markdown files. 2) Forces fiddle.skia.org to compile all those fiddles and get output in JSON. 3) Scans the output and reports any compiletime/runtime errors. 4) Updates markdown in site/user/api/ using the new hashes (if any) from fiddle.skia.org. To ensure the bot does not check in unexpected changes: * upload_md.py makes sure that all modified files are under site/user/api/. It errors out if this is not the case. * CLs with docs only changes normally have 'NoTry: true' added to their descriptions. This is not done for the new bot because we want to run it through trybots to make sure nothing unexpected snuck in. * rmistry@ and caryclark@ are automatically CC'ed on all uploaded changes. I plan to watch the bot closely for at least a couple of weeks. Bug: skia:7310 Change-Id: I759fc8bae1e32a6f175e3b1a895947d14ca5fe3a Reviewed-on: https://skia-review.googlesource.com/79941 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Remove Nexus10.Gravatar Ben Wagner2017-12-08
| | | | | | | | | Bug: skia:7381 Change-Id: I8e151c5c57f6344c9cdf165bbb78a4ed308491c8 NoTry: true Reviewed-on: https://skia-review.googlesource.com/82804 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Goma support in gn_flavor.Gravatar Ben Wagner2017-12-08
| | | | | | | | | | | | Using full paths in skia.h causes "file not found" with Goma. All other Builds seem fine without the path, so I changed find_headers.py to use the basename. Change-Id: Ib520e91a92ebffe36a736eb53f643d359f5bb2ce Reviewed-on: https://skia-review.googlesource.com/79360 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Nexus5x CPU jobs.Gravatar Ben Wagner2017-12-08
| | | | | | | | | Bug: skia:7382 Change-Id: Ie6d86bba408b59825263f35345f415352a095f1f NoTry: true Reviewed-on: https://skia-review.googlesource.com/82624 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Nexus5 CPU jobs.Gravatar Ben Wagner2017-12-08
| | | | | | | | | Bug: skia:7381 Change-Id: I4e5446420e38e0a6fdeba6f8f89e0685e5f8ac41 NoTry: true Reviewed-on: https://skia-review.googlesource.com/82301 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Nexus7 CPU jobs.Gravatar Ben Wagner2017-12-07
| | | | | | | | | | Bug: skia:7381 Change-Id: I2dd5443c81cd895eb1d68b0cd90221a7e2e07d46 No-Try: true Reviewed-on: https://skia-review.googlesource.com/80843 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Move PixelXL jobs to the Pixel.Gravatar Ben Wagner2017-12-07
| | | | | | | | NoTry: true Change-Id: I3964ed7c18af1204cc7b11d2d0ac673512f5f5ed Reviewed-on: https://skia-review.googlesource.com/81860 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* ANGLE -> ClangGravatar Mike Klein2017-12-05
| | | | | | | | | | | | | | Switch all ANGLE bots to build with Clang, sort, and dedup. And remove -x86- ANGLE builders... there's no good reason to have builders for this config unless we're going to Test/Perf it. Bug: skia:7377 Change-Id: I1daf8ffa98e098274a4de0ff2c40a4a7e958b211 Reviewed-on: https://skia-review.googlesource.com/80740 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove mips support and botsGravatar Mike Klein2017-12-05
| | | | | | | | | | | The NDK has deprecated mips and mips64: https://developer.android.com/ndk/guides/abis.html Might as well clean this up now while I remember. Change-Id: Ie4b2334c75208082067cc16fe355d0349c7e0904 Reviewed-on: https://skia-review.googlesource.com/80560 Reviewed-by: Derek Sollenberger <djsollen@google.com>
* Merge UBSAN_float_cast_overflow into ASAN.Gravatar Ben Wagner2017-12-04
| | | | | | | | | | | | The new check was a different config while we fixed the errors. Most errors are now fixed, and merging these will help with running both on the CQ. No-Try: true Change-Id: I5804ecea84a8dbbaacf6a4ea96e2af9505641d49 Reviewed-on: https://skia-review.googlesource.com/79323 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove IntelIris640 bot.Gravatar Ben Wagner2017-11-30
| | | | | | | | | | IntelIris640 is 100% identical to IntelIris540 on Gold. No-Try: true Change-Id: I0e5342b182267a7d6ee510329b7c8ab7cb3a479e Reviewed-on: https://skia-review.googlesource.com/78640 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Temporarily add Ubuntu IntelHD4400 jobs."Gravatar Ben Wagner2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 373588426b9d02576152e820eb7f870d930f1998. Reason for revert: Have enough digests on Gold now. Original change's description: > Temporarily add Ubuntu IntelHD4400 jobs. > > I want to compare this with the IntelBayTrail and if the results are > similar, replace those bots. > > No-Try: true > Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a > Reviewed-on: https://skia-review.googlesource.com/76900 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=benjaminwagner@google.com,kjlubick@google.com Change-Id: Ica07d1ee635e59e3d3da51ee73591ffe08310e34 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/77860 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Temporarily add Ubuntu IntelHD4400 jobs.Gravatar Ben Wagner2017-11-29
| | | | | | | | | | | I want to compare this with the IntelBayTrail and if the results are similar, replace those bots. No-Try: true Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a Reviewed-on: https://skia-review.googlesource.com/76900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Switch Coverage GPU bot to Golo.Gravatar Ben Wagner2017-11-28
| | | | | | | | No-Try: true Change-Id: I0b9f6ef3651e5309af316d7ea7e170b48f54cdeb Reviewed-on: https://skia-review.googlesource.com/76620 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Rename AMDHD7770 to RadeonHD7770.Gravatar Ben Wagner2017-11-24
| | | | | | | | | | | Also drive-by cleanup of "Win8-MSVC-ShuttleB", none of which currently exist. No-Try: true Change-Id: Ide28481939b7ec2a0733ab07673379c951123f5d Reviewed-on: https://skia-review.googlesource.com/75361 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove Skolo NVIDIA Linux bots.Gravatar Ben Wagner2017-11-21
| | | | | | | | | Docs-Preview: https://skia.org/?cl=74160 No-Try: true Change-Id: Icb3a8ac00e640de345f4fbed89642bee569bbe9b Reviewed-on: https://skia-review.googlesource.com/74160 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* Remove Nexus 6psGravatar Kevin Lubick2017-11-21
| | | | | | | | | | | These will be replaced by the Nexus 5x. Bug: skia:7309 No-Try: true Change-Id: I2a56a494203f2af41f16dcfd55ebe1ca28e9e939 Reviewed-on: https://skia-review.googlesource.com/73881 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Expand Windows GPU test configs.Gravatar Ben Wagner2017-11-20
| | | | | | | | No-Try: true Change-Id: I2511801c746d3e434cd5eb7cc553bdc7b35fcf74 Reviewed-on: https://skia-review.googlesource.com/72680 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Linux IntelHD405 Vulkan jobs.Gravatar Ben Wagner2017-11-20
| | | | | | | | No-Try: true Change-Id: Id2631fc8df97b2a76775b01db212085d94c82906 Reviewed-on: https://skia-review.googlesource.com/72902 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Nexus5xGravatar Ben Wagner2017-11-17
| | | | | | | | | Bug: skia:7309 NoTry: true Change-Id: I9d9e18f8fe8bc53a54de26533485b262ba825ea7 Reviewed-on: https://skia-review.googlesource.com/72980 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* remove Win10 GDI botGravatar Mike Klein2017-11-16
| | | | | | | | | One (Win7) GDI bot is enough. Change-Id: I03312c21e7b6da2a50225fd5dbc50bc69a6bd4c2 Reviewed-on: https://skia-review.googlesource.com/72640 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove Win7/Win8 Perf-Release jobs.Gravatar Ben Wagner2017-11-15
| | | | | | | | | | The bots that execute these jobs produce noisy perf numbers. No-Try: true Change-Id: Icb3a54e324e0823f680042838b6f883ff5937f93 Reviewed-on: https://skia-review.googlesource.com/72200 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove/move remaining Win2k8 GCE jobs.Gravatar Ben Wagner2017-11-15
| | | | | | | | Bug: skia:7305 Change-Id: Ifb270cba27daaef75d3930f990e19215a251ca28 Reviewed-on: https://skia-review.googlesource.com/71921 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Move FxAA jobs to Win2016.Gravatar Ben Wagner2017-11-15
| | | | | | | | | Bug: skia:7305 Change-Id: I3cfdb15c11d08143dce66046d66b0ce633277384 No-Try: true Reviewed-on: https://skia-review.googlesource.com/71862 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* remove Win2016 NativeFonts botsGravatar Mike Klein2017-11-14
| | | | | | | Change-Id: I7df9d1a9118fbd9c545912a38af4f94276f20b0f Reviewed-on: https://skia-review.googlesource.com/71521 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add Win2016 jobs.Gravatar Ben Wagner2017-11-14
| | | | | | | | | Bug: skia:7197 No-Try: true Change-Id: If2c8939739bc0583a08c0fcb400d28a90599f047 Reviewed-on: https://skia-review.googlesource.com/69401 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* streamline GDI botsGravatar Mike Klein2017-11-13
| | | | | | | | | | | | | - Replace build-time GDI support in all of Skia with run-time GDI support only in DM. - Make the GDI bots NativeFont bots paralelling the other NativeFonts bots. Change-Id: I424b20f6983d8a8ba8574650efefea2b8776bbe2 Reviewed-on: https://skia-review.googlesource.com/70721 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Drop support for OSMesa in test tools and remove build botGravatar Brian Salomon2017-11-13
| | | | | | | | Change-Id: Ic85ee05fe292a36a053ca7a20ccce24a4da4fae2 Reviewed-on: https://skia-review.googlesource.com/70026 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* make NativeFonts bots Debug botsGravatar Mike Klein2017-11-10
| | | | | | Change-Id: I590b60862891c4232d90f9c6dbd93cb1bedc0672 Reviewed-on: https://skia-review.googlesource.com/69903 Reviewed-by: Ben Wagner <bungeman@google.com>
* Switch CT_BENCH_10k_SKPs bot to use QuadroP400Gravatar Ravi Mistry2017-11-08
| | | | | | | | Bug: skia:7272 Change-Id: I634f00c57b0c999a65d22a748b83a6ff5c35fd74 Reviewed-on: https://skia-review.googlesource.com/68940 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Restore Pixelbook jobsGravatar Kevin Lubick2017-11-07
| | | | | | | | | | | These were accidentally deleted on https://skia-review.googlesource.com/c/skia/+/66880 Bug: skia: NOTRY=true Change-Id: I99a13b236aa626ed224dbc503707d16c08b5219d Reviewed-on: https://skia-review.googlesource.com/68204 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* add a few NativeFonts botsGravatar Mike Klein2017-11-06
| | | | | | | | | | | | | These are no different from other bots yet, except that they only run 8888 GMs and unit tests. They will in the future pass --nativeFonts true, while other bots will pass --nativeFonts false, the effect of which has not quite yet been pinned down. Change-Id: I467852269856dda05330957bc357ef15a2c2a1eb Reviewed-on: https://skia-review.googlesource.com/67769 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Add a GPU calmbench botGravatar Yuqian Li2017-11-02
| | | | | | | | Bug: skia: Change-Id: I354c295ce04f5e478e88f724e0b17ce90496a4cc Reviewed-on: https://skia-review.googlesource.com/65341 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Rename chromebook jobs to be more human friendlyGravatar Kevin Lubick2017-11-02
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: I500eae85ec334dc7121266ebd2f41dc526ec4695 Reviewed-on: https://skia-review.googlesource.com/66880 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add Pixelbook to treeGravatar Kevin Lubick2017-11-02
| | | | | | | | | Bug: skia:7249 NOTRY=true Change-Id: I7ab6bc28d567ca5ae75df9c1e56b46c307032024 Reviewed-on: https://skia-review.googlesource.com/66143 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make CPU coverage bot a bit fasterGravatar Kevin Lubick2017-11-02
| | | | | | | | | | | | | | | | | | | | | | | | | Adding -O1 and reducing the shards to cut down on overhead in post-production. This seems to save us a few minutes (e.g. ~26 -> ~23 minutes). The optimized code has about 600 fewer reachable lines of code (according to the Coverage measurement), which is acceptable given our tests run on -O1 or better. Experiments (in this review) show that O3 is faster than O1, but not significantly enough where we want to deviate from our normal Debug bots: Control: 73 minutes -O1: 59 minutes -O2: 60 minutes -O3: 50 minutes Bug: skia: NOTRY=true Change-Id: I33344c1cd2408373004d010e36ce27d6aa03deb2 Reviewed-on: https://skia-review.googlesource.com/65503 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add Win2k8 QuadroP400 jobs.Gravatar Ben Wagner2017-11-01
| | | | | | | | | | | This is a placeholder until we can get ANGLE working on these bots. Bug: skia:6734 Change-Id: I8361da10acaa3c85faaa8ebfc1f1797d3f5e90f7 No-Try: true Reviewed-on: https://skia-review.googlesource.com/26368 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Pixel 2 XL to waterfallGravatar Kevin Lubick2017-10-31
| | | | | | | | | Bug: skia:7249 NOTRY=true Change-Id: I877c8aa40c4529fdf7ae98b61e5742b93ce78c70 Reviewed-on: https://skia-review.googlesource.com/65821 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>