aboutsummaryrefslogtreecommitdiffhomepage
path: root/include
Commit message (Collapse)AuthorAge
* harden line2d effectGravatar Mike Reed2018-05-18
| | | | | | | | | | Suggested by https://fuzzer.skia.org/category/n32_canvas/file/c3JjL2NvcmUvU2tTdHJva2UuY3Bw? Bug: skia: Change-Id: I8ec48f844bfa5d063f0ab1bdfe0612ec4673ada3 Reviewed-on: https://skia-review.googlesource.com/129260 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Driver bug workaround: unbind_attachments_on_bound_render_fbo_deleteGravatar Adrienne Walker2018-05-18
| | | | | | | | Bug: chromium: 829614 Change-Id: Ic6bc276d1203d24f96fe92b41655871e25f69623 Reviewed-on: https://skia-review.googlesource.com/128395 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* Make SkStream readers report failure.Gravatar Ben Wagner2018-05-18
| | | | | | | | | | This also fixes an issue noticed while making this change where SkFontDescriptor improperly round trips negative axis values. Change-Id: Iacc5929a185659dcacc18c802c4908e4f34c6899 Reviewed-on: https://skia-review.googlesource.com/128341 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Add SkIRect::adjust methodGravatar Robert Phillips2018-05-18
| | | | | | | Change-Id: Ib18d1a82944524e20d5d72912d8db7a823c470de Reviewed-on: https://skia-review.googlesource.com/128884 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* fonts: Handle fallback to using paths for text rendering for remoting.Gravatar Khushal2018-05-17
| | | | | | | | | | | | | | | | | | SkRemoteGlyphCache only sends images for glyphs, even for cases where the gpu falls back to drawing text as paths. This includes cases in SkDraw::ShouldDrawTextAsPaths and when the glyph exceeds the max bounds that can fit on the atlas. Fix this by identifying these cases in the renderer and sending paths instead. Note: We still don't handle distance field text correctly. R=herb@google.com, bsalomon@google.com Bug: skia:7913 Change-Id: I17d4eccbeaa2e995ae67b61c76cebd27f8280329 Reviewed-on: https://skia-review.googlesource.com/128203 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
* Remove SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE.Gravatar Ben Wagner2018-05-17
| | | | | | | | | All implementers have been updated, so remove the flag and old code. Change-Id: Ie9747f37dd0ea3f1db682891bcae2496a470bc3a Reviewed-on: https://skia-review.googlesource.com/128883 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix srcBounds computation in SkMatrixConvolutionImageFilterGravatar Robert Phillips2018-05-17
| | | | | | | | | | | Note that this does change the behavior of the cropRect for the repeated case. The cropRect now only acts as a hard clip on the output. BUG= skia:7766 Change-Id: I1d66678bc797cd4835701cd20c36e68b22ac880a Reviewed-on: https://skia-review.googlesource.com/127338 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* mapRect should not fiddle with nonfinite values.Gravatar Cary Clark2018-05-17
| | | | | | | | | Docs-Preview: https://skia.org/?cl=128682 Bug: skia:7967 Change-Id: Ic43387b7705ee8385b8df2430886484ff856077c Reviewed-on: https://skia-review.googlesource.com/128682 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Driver bug workaround: pack_parameters_workaround_with_pack_bufferGravatar Adrienne Walker2018-05-16
| | | | | | | | Bug: chromium: 829614 Change-Id: I3fae2b4181e4a6e37fb31fe2f2e9a6cfacb1860f Reviewed-on: https://skia-review.googlesource.com/128206 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* SkImage::onRefEncoded to return sk_sp.Gravatar Ben Wagner2018-05-16
| | | | | | | | | | | | This changes SkImage::onRefEncoded and downstack calls to return sk_sp. All of the values returned are already sk_sp, so this just updates the API. This change is currently behind the new flag SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE so that Chromium can be updated. Change-Id: Ic53a88ae23fa8b3b41b84c4abdc4b74e9879da38 Reviewed-on: https://skia-review.googlesource.com/128311 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Driver bug workaround: gl_clear_brokenGravatar Adrienne Walker2018-05-16
| | | | | | | | | | | | | Skia does not appear to use depth buffers and this appears to be identical to ClearFramebufferResourceManager::ClearFramebuffer in Chromium code. Therefore, just hook up this workaround to turn on these internal Skia workarounds. Bug: chromium: 829614 Change-Id: Icc5f2eb981e39ffef487efa16940d2e50cdbc399 Reviewed-on: https://skia-review.googlesource.com/127220 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* Driver bug workaround: restore_scissor_on_fbo_changeGravatar Adrienne Walker2018-05-16
| | | | | | | | Bug: chromium: 829614 Change-Id: I333aed9a378ab9b7aafaa96bb495378d1db4a61d Reviewed-on: https://skia-review.googlesource.com/127118 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Reland "Reland "remove obsolete color defines""Gravatar Cary Clark2018-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d286aa73f13ee10d778381c20d4f0c7dd4bfa354. Reason for revert: fuchsia has rolled forward Original change's description: > Revert "Reland "remove obsolete color defines"" > > This reverts commit 05cfcff70ced3af834e0c9c5309f98bd6662f851. > > Reason for revert: breaks flutter > > Original change's description: > > Reland "remove obsolete color defines" > > > > This reverts commit 3155d9c912ec71c95d8f210d86a1c6deba0f78d9. > > > > Reason for revert: pdfium bots are no more > > > > Original change's description: > > > Revert "remove obsolete color defines" > > > > > > This reverts commit 8afbecbcc05412fadc66cc9d29955064145b8ba5. > > > > > > Reason for revert: broke pdfium > > > > > > Original change's description: > > > > remove obsolete color defines > > > > > > > > The uses in Skia, Chrome, and Google3 have already > > > > been removed. If I missed one or more, please let > > > > me know (and feel free to revert). > > > > > > > > TBR=reed@google.com,brianosman@google.com > > > > Bug: skia:6898 > > > > Change-Id: I9d15b1a06f5abfc3a0fc6f3f1b4d348916c3d362 > > > > Reviewed-on: https://skia-review.googlesource.com/124840 > > > > Reviewed-by: Cary Clark <caryclark@skia.org> > > > > Commit-Queue: Cary Clark <caryclark@skia.org> > > > > Auto-Submit: Cary Clark <caryclark@skia.org> > > > > > > TBR=brianosman@google.com,reed@google.com,caryclark@skia.org > > > > > > Change-Id: Ic7c1003261cda5dee80e222da123c6717b4ea707 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: skia:6898 > > > Reviewed-on: https://skia-review.googlesource.com/124880 > > > Reviewed-by: Cary Clark <caryclark@skia.org> > > > Commit-Queue: Cary Clark <caryclark@skia.org> > > > > TBR=brianosman@google.com,reed@google.com,caryclark@skia.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: skia:6898 > > Change-Id: I3605fa0ebb2bfecc26d198e9de008c82d31d747b > > Reviewed-on: https://skia-review.googlesource.com/126001 > > Reviewed-by: Cary Clark <caryclark@google.com> > > Commit-Queue: Cary Clark <caryclark@google.com> > > TBR=brianosman@google.com,caryclark@google.com,reed@google.com,caryclark@skia.org > > Change-Id: I469794b86487322c385e50275d548c1895c30cff > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:6898 > Reviewed-on: https://skia-review.googlesource.com/126040 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Cary Clark <caryclark@google.com> TBR=brianosman@google.com,caryclark@google.com,reed@google.com,caryclark@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:6898 Change-Id: I03bd75d28dfad86455b48dea7930bebc95bf82d3 Reviewed-on: https://skia-review.googlesource.com/128500 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Fix UBSAN warnings in SkPerlinNoiseShaderImplGravatar Kevin Lubick2018-05-16
| | | | | | | | | | Also update the docs in places. Bug: oss-fuzz:6138, oss-fuzz:6275, oss-fuzz:6118 Change-Id: Idfef4118dd6e58f8aa528365895f7d7b8ebc50e5 Reviewed-on: https://skia-review.googlesource.com/128300 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Driver bug workaround: max_msaa_sample_count_4Gravatar Adrienne Walker2018-05-15
| | | | | | | | Bug: chromium: 829614 Change-Id: I54054191815ace6159585dab7dd811ebdc863095 Reviewed-on: https://skia-review.googlesource.com/126983 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Driver bug workaround: disallow_large_instanced_drawGravatar Adrienne Walker2018-05-15
| | | | | | | | Bug: chromium: 829614 Change-Id: I3c64cd360674f08b4ca3c4a2d0ef946e40a5c60a Reviewed-on: https://skia-review.googlesource.com/126751 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Chris Dalton <csmartdalton@google.com>
* remove typedef InfoGravatar Cary Clark2018-05-15
| | | | | | | | | | | | | | | | | | typedef SkImageInfo Info saves a little typing at the cost of obfuscating the parameter type. It's only used in a couple of places so remove it. The documentation catalog has gotten a bit stale, so update that as well. Docs-Preview: https://skia.org/?cl=128400 Bug: skia:6898 Change-Id: I621743a2b2d9a78d5f62742501eebf5f4327efa0 Reviewed-on: https://skia-review.googlesource.com/128400 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Driver bug workaround: max_texture_size_limit_4096Gravatar Adrienne Walker2018-05-15
| | | | | | | | Bug: chromium: 829614 Change-Id: I127157fa04df2ec6505411aa42f1232910e251d4 Reviewed-on: https://skia-review.googlesource.com/126608 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* remove unused SkColorSpace::MakeGravatar Mike Klein2018-05-15
| | | | | | | | | Since we reverted the dst-color-space CL, this is no longer used. Change-Id: I50c5c1fbea2b94a1da130d50a17670c152615fb3 Reviewed-on: https://skia-review.googlesource.com/128317 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove non-smart SkFontConfigInterface::SetGlobal.Gravatar Ben Wagner2018-05-15
| | | | | | | | | This method is no longer used and is superseded by the 'smart' version. Change-Id: Ic27545a2ec2666d77966727630ba7e960eac5506 Reviewed-on: https://skia-review.googlesource.com/128316 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Reland "Driver bug workaround: disable_discard_framebuffer"Gravatar Adrienne Walker2018-05-15
| | | | | | | | | | | | | | | | | | | | | | | This is a reland of f31fece6581a46b40403fc78c83c7eebe50816ba Original change's description: > Driver bug workaround: disable_discard_framebuffer > > Bug: chromium: 829614 > Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 > Reviewed-on: https://skia-review.googlesource.com/126749 > Commit-Queue: Adrienne Walker <enne@chromium.org> > Commit-Queue: Brian Salomon <bsalomon@google.com> > Auto-Submit: Adrienne Walker <enne@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> Bug: chromium: 829614 Change-Id: I6cc2de11a6315ff224c90551e8dd3e1d1dd4139a Reviewed-on: https://skia-review.googlesource.com/128108 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Reland "Driver bug workaround: disable_blend_equation_advanced"Gravatar Adrienne Walker2018-05-15
| | | | | | | | | | | | | | | | | | | | | This is a reland of f31fece6581a46b40403fc78c83c7eebe50816ba Original change's description: > Driver bug workaround: disable_blend_equation_advanced > > Bug: chromium: 829614 > Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 > Reviewed-on: https://skia-review.googlesource.com/126748 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> Bug: chromium: 829614 Change-Id: Idd36ff90a99336521ef5d47f0d7baf079c1bda09 Reviewed-on: https://skia-review.googlesource.com/128107 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Reland "Add driver bug workarounds to GrCaps"Gravatar Adrienne Walker2018-05-14
| | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 328490c6a1625ce51d0e81688e0c85c79c400d86 Original change's description: > Add driver bug workarounds to GrCaps > > This moves GrDriverBugWorkarounds to include so that it can be included > by GrCaps. This also makes GrContextOptions a nearly empty class in > the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build > in GrDriverBugWorkarounds.cpp. > > Bug: chromium: 829614 > Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d > Reviewed-on: https://skia-review.googlesource.com/126581 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> Bug: chromium: 829614 Change-Id: I7b539f99caa3032c8c595dd5068dc3b179747ccd Reviewed-on: https://skia-review.googlesource.com/127304 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Move SkFontConfigInterface to smart pointers.Gravatar Ben Wagner2018-05-14
| | | | | | | | | | This old interface may be easier to move away from if it isn't so difficult to understand. Change-Id: Ib04b00e55fd5c11aca8cc70bc6c7b0b5ba98dcae Reviewed-on: https://skia-review.googlesource.com/127969 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Revert "Revert "implement SkScalar versions in terms of float versions""Gravatar Mike Reed2018-05-14
| | | | | | | | | | This reverts commit 0e6db75eebab430e7f6665c8cfa1e7dcd2fef123. Bug: skia: Change-Id: I015d01efc58dfe03dae6bcc57c4b1102276e7566 Reviewed-on: https://skia-review.googlesource.com/127967 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "implement SkScalar versions in terms of float versions"Gravatar Mike Reed2018-05-14
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4c3cb3767f5af3860998b932702dc18619ab3e1e. Reason for revert: investigate asan failures Original change's description: > implement SkScalar versions in terms of float versions > > Bug: skia: > Change-Id: I44ce228290f7fda5b7e3553c8543dcf581b1ca3b > Reviewed-on: https://skia-review.googlesource.com/127128 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=caryclark@google.com,reed@google.com Change-Id: Ic790b15130a67f46a0a99fdf991c5c08d682be5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/128060 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* implement SkScalar versions in terms of float versionsGravatar Mike Reed2018-05-14
| | | | | | | | Bug: skia: Change-Id: I44ce228290f7fda5b7e3553c8543dcf581b1ca3b Reviewed-on: https://skia-review.googlesource.com/127128 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Minor refactoring to image filtersGravatar Robert Phillips2018-05-14
| | | | | | | | | | This pulls the boring parts out of: https://skia-review.googlesource.com/c/skia/+/127338 (Fix srcBounds computation in SkMatrixConvolutionImageFilter) TBR=bsalomon@google.com Change-Id: Iade788fcc96c4c16989d13e7592030a6a1d3f170 Reviewed-on: https://skia-review.googlesource.com/127573 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Include SkUnPremultiply.h in GrContext.h to fix Android compileGravatar Brian Salomon2018-05-11
| | | | | | | | | | Change-Id: Iab23ebbc0e3c639d4f0589ab3e8ae458b85b3298 Reviewed-on: https://skia-review.googlesource.com/127396 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com>
* Define ~GrContextThreadSafeProxy in GrContext.cppGravatar Brian Salomon2018-05-11
| | | | | | | | | | | | Otherwise GrCaps.h may be required in GrContext.h Change-Id: I67b2116b3bad2e7ebbb2157375c48023d2964f5c Reviewed-on: https://skia-review.googlesource.com/127394 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com>
* Make GrCaps and GrShaderCaps private.Gravatar Brian Salomon2018-05-11
| | | | | | | | | Moves getCaps() from GrContext to GrContextPriv and removes unused refCaps(). Change-Id: Ic6a8951b656c0d1b2773eae73bff8e88af819866 Reviewed-on: https://skia-review.googlesource.com/127389 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Fix unchecked allocation in kImageFilter::Common::unflatten()Gravatar Florin Malita2018-05-10
| | | | | | | | | | | | | | | | | | | The bad news is we don't have a good way to validate the count against the available data size. The good news is we don't have to: most filters only use two inputs, which will fit in the stack-reserved storage; for those who don't, growing the input vector during deserialization should not be problematic. The CL drops the prea-allocation, and instead appends inputs iteratively. Also switches the storage to SkSTArray for append/push_back() support. Bug: oss-fuzz:8219 Change-Id: Ic6bf6e435e6e18b9e026aeb393612210c9e6e57a Reviewed-on: https://skia-review.googlesource.com/127306 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Revert "Remove GrBackendObject and all related functions from Skia."Gravatar Brian Osman2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ccd4cfc23ebbbecbc6b292359352aad335ad7b73. Reason for revert: Fuchsia not building again. (Flutter roll may have been reverted?) Original change's description: > Remove GrBackendObject and all related functions from Skia. > > Bug: skia: > Change-Id: I59434b7477c0bc26fd982bd81eb97ab94bbba073 > Reviewed-on: https://skia-review.googlesource.com/125822 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Ie2c518b84b0c9513c0c622082de2831088b1ad8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/127480 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "strip down SkICC.cpp"Gravatar Mike Klein2018-05-10
| | | | | | | | | | | | This reverts commit eab50eb9c6117c2a9d0e5648f89cebbb4dbd9d30 and this tiny bit of e61b969a07ba3ebe9e47e61381ad16c5d2c549a2: https://skia-review.googlesource.com/c/skia/+/127122/3/tests/ICCTest.cpp Change-Id: I4306e5118a4e5eb88c05078186a28bd443fd76f7 Reviewed-on: https://skia-review.googlesource.com/127305 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add SkColorSpace::toProfileGravatar Brian Osman2018-05-10
| | | | | | | | | | | | | | Now that A2B parsing is at least as strict as skcms_Parse, this can never fail, so switch to void. Also use the new programmatic profile helpers, which also ensures the data and profile space fields are set correctly. Bug: skia: Change-Id: Ifc4d89a919ca178c484839bdf88dae8a162c3e4f Reviewed-on: https://skia-review.googlesource.com/127336 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Add GrContextThreadSafeProxy and remove most friends of GrContextThreadSafeProxyGravatar Brian Salomon2018-05-10
| | | | | | | | | | | A step towards removing GrCaps from GrContext.h Also adds operator== to GrContextThreadSafeProxy. Change-Id: Ic0bae12299dfb0ac8817d9f1c56a1219d6df97d9 Reviewed-on: https://skia-review.googlesource.com/127329 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* non-linear blending first stepsGravatar Mike Klein2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | Code: - Add a non-linear blending bit and makeNonlinearBlending() to SkColorSpace - remove enough F16=linear checks to make it possible to create surfaces and encode pngs with nonlinear F16 Testing: - add "esrgb" software config to DM, run it - add "srgbnl" software config, run it - deemphasize importance of "srgb" config on bots - update unit tests to reflect relaxed F16 constraints - add a new unit test file with _really_ basic tests, and a new unit test that's not working yet Bug: skia:7942 Change-Id: I8ac042bdf9f3d791765393b68fd9256375184d83 Reviewed-on: https://skia-review.googlesource.com/127325 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Add driver bug workarounds to GrCaps"Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 328490c6a1625ce51d0e81688e0c85c79c400d86. Reason for revert: Breaking compiles inside chrome Original change's description: > Add driver bug workarounds to GrCaps > > This moves GrDriverBugWorkarounds to include so that it can be included > by GrCaps. This also makes GrContextOptions a nearly empty class in > the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build > in GrDriverBugWorkarounds.cpp. > > Bug: chromium: 829614 > Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d > Reviewed-on: https://skia-review.googlesource.com/126581 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> TBR=bsalomon@google.com,enne@chromium.org Change-Id: I3b35bf65a7b78d2fe16d7c2bcd0e4b3f9bb7fdff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127303 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Driver bug workaround: disable_blend_equation_advanced"Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f31fece6581a46b40403fc78c83c7eebe50816ba. Reason for revert: need to revert to revert original change breaking chrome compile Original change's description: > Driver bug workaround: disable_blend_equation_advanced > > Bug: chromium: 829614 > Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 > Reviewed-on: https://skia-review.googlesource.com/126748 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> TBR=bsalomon@google.com,enne@chromium.org Change-Id: Ic870fbbad615d13569254c355ef6b8281332d60d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127301 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Driver bug workaround: disable_discard_framebuffer"Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8aa0dca395d49b136ab59f6e96c4446342c9ebd2. Reason for revert: need to revert to revert original change breaking chrome compile Original change's description: > Driver bug workaround: disable_discard_framebuffer > > Bug: chromium: 829614 > Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 > Reviewed-on: https://skia-review.googlesource.com/126749 > Commit-Queue: Adrienne Walker <enne@chromium.org> > Commit-Queue: Brian Salomon <bsalomon@google.com> > Auto-Submit: Adrienne Walker <enne@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,enne@chromium.org Change-Id: I563808025a8f77807478c0f0d42c3009c3b57ea5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127302 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Driver bug workaround: disable_discard_framebufferGravatar Adrienne Walker2018-05-10
| | | | | | | | | | Bug: chromium: 829614 Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 Reviewed-on: https://skia-review.googlesource.com/126749 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Driver bug workaround: disable_blend_equation_advancedGravatar Adrienne Walker2018-05-10
| | | | | | | | Bug: chromium: 829614 Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 Reviewed-on: https://skia-review.googlesource.com/126748 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* use 64bit math in TArray reallocGravatar Mike Reed2018-05-10
| | | | | | | | Bug: oss-fuzz:8217 Change-Id: Idecd1867e7047744477c7dfbb6c9bc5654a36ade Reviewed-on: https://skia-review.googlesource.com/127324 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add driver bug workarounds to GrCapsGravatar Adrienne Walker2018-05-10
| | | | | | | | | | | | | This moves GrDriverBugWorkarounds to include so that it can be included by GrCaps. This also makes GrContextOptions a nearly empty class in the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build in GrDriverBugWorkarounds.cpp. Bug: chromium: 829614 Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d Reviewed-on: https://skia-review.googlesource.com/126581 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org>
* Remove GrBackendObject and all related functions from Skia.Gravatar Greg Daniel2018-05-10
| | | | | | | | Bug: skia: Change-Id: I59434b7477c0bc26fd982bd81eb97ab94bbba073 Reviewed-on: https://skia-review.googlesource.com/125822 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove SkPaint::Flags::kDevKernFlag.Gravatar Ben Wagner2018-05-09
| | | | | | | | | It isn't used any more. Change-Id: I79fbbac13bb2595da0ae0cea7e42bca8fcccd8e8 Reviewed-on: https://skia-review.googlesource.com/127127 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
* SkColorSpace::Make(const skcms_ICCProfile&)Gravatar Mike Klein2018-05-09
| | | | | | | | Change-Id: Ib12208d6c148f143fdd0b54538d852b97616a72d Reviewed-on: https://skia-review.googlesource.com/127122 Commit-Queue: Mike Klein <mtklein@chromium.org> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* strip down SkICC.cppGravatar Mike Klein2018-05-09
| | | | | | | | | | | | | | | | Most of SkICC{.h,.cpp} is unused and gone. I've renamed the part that's left to SkWriteICCProfile() and tweaked its API just a little, leaving SkICC:WriteToICC() a wrapper around it. Most of the tests in ICCTest.cpp are moot and deleted, but a few looked somewhat valuable so I've kept them with a little modification. Change-Id: Ia1bb4c772af679885e17dac53d213c315ad0828c Reviewed-on: https://skia-review.googlesource.com/127022 Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Revert "SkAdvancedTypefaceMetrics: factor out GlyphToUnicode""Gravatar Hal Canary2018-05-09
| | | | | | | | | This reverts commit 97c1108607584b6050a6880d6ce22846e4913a92. Change-Id: Ic3c6addc64ced39766bbee3e10b4d88faf61ba2f Reviewed-on: https://skia-review.googlesource.com/127021 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add fPreferExternalImagesOverES3 to GrContextOptionsGravatar Brian Osman2018-05-09
| | | | | | | | | | | | | This forces us to use the ES2 shading language when we have an ES3 context, but the driver claims to only support GL_OES_EGL_image_external (and not the _essl3 variant). Many of these devices will work correctly if we blindly enable both extensions, but there are some that won't. Bug: skia: Change-Id: Id632003a1905ea61b46166befd30905a57cead69 Reviewed-on: https://skia-review.googlesource.com/126681 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>