aboutsummaryrefslogtreecommitdiffhomepage
path: root/gyp/common_conditions.gypi
Commit message (Collapse)AuthorAge
...
* Detect MIPS DSP and DSPR2 programattically.Gravatar mtklein2015-08-05
| | | | | | | | | | | | | | | | | | | | | | | | | Procedure: $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -dM -E - < /dev/null | sort > vanilla.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdsp -dM -E - < /dev/null | sort > dsp.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdspr2 -dM -E - < /dev/null | sort > dspr2.mips $ diff vanilla.mips dsp.mips 239a240,241 > #define __mips_dsp 1 > #define __mips_dsp_rev 1 $ diff vanilla.mips dspr2.mips 239a240,242 > #define __mips_dsp 1 > #define __mips_dsp_rev 2 > #define __mips_dspr2 1 So, defined(__mips_dsp) -> SK_MIPS_HAS_DSP, defined(__mips_dspr2) -> SK_MIPS_HAS_DSPR2. BUG=skia: Review URL: https://codereview.chromium.org/1274873002
* Remove IGNORE_ROT_AA_RECT_OPT flagGravatar robertphillips2015-08-04
| | | | | | It looks like the positive version was added (SHADER_AA_FILL_RECT) but the negative version wasn't removed. Review URL: https://codereview.chromium.org/1271903003
* Remove skia_arch_width, fold into skia_arch_type.Gravatar Brian Salomon2015-07-27
| | | | | | | | | DOCS_PREVIEW= https://skia.org/?cl=1228553010 BUG=skia:4042 R=borenet@google.com, mtklein@google.com Review URL: https://codereview.chromium.org/1228553010
* Add skia_use_android_framework_defines GYP_DEFINEGravatar borenet2015-07-22
| | | | | | BUG=skia:4082 Review URL: https://codereview.chromium.org/1243383002
* Compile with VS2015.Gravatar bungeman2015-07-21
| | | | | | | | | | | | | | | | Visual Studio 2015 has additional warnings around noexcept and disabling exceptions, which can be worked around with the (undocumented) _HAS_EXCEPTIONS macro. Visual Studio 2013 and 2015 have roundf in math.h, so use it to avoid extra work and casts. We avoid using cmath, as it undefs isfinite on gcc, but Visual Studio 2015 no longer provides overloads of copysign from math.h (which is actually correct). As a result, use copysignf (which is available in math.h in 2013 and 2015) directly. Review URL: https://codereview.chromium.org/1244173005
* Add a GYP flag to define SKNX_NO_SIMD when set.Gravatar mtklein2015-07-14
| | | | | | | | Will use this with a new -SKNX_NO_SIMD bot. BUG=skia: Review URL: https://codereview.chromium.org/1227163016
* Add scripts for running LLVM coverageGravatar borenet2015-07-06
| | | | | | BUG=skia:2430 Review URL: https://codereview.chromium.org/1213063009
* Default iOS builds to our code signing identity.Gravatar mtklein2015-04-16
| | | | | | | | | It's super tedious to keep setting it every time I rerun ./gyp_skia. Doesn't look like it'll bother the bots. BUG=skia: Review URL: https://codereview.chromium.org/1053493005
* Remove all code related to NaClGravatar borenet2015-04-02
| | | | | | | BUG=skia:3600 DOCS_PREVIEW= https://skia.org/?cl=1036283002 Review URL: https://codereview.chromium.org/1036283002
* Streamline Thumb config.Gravatar mtklein2015-04-02
| | | | | | | | Enable Thumb2 iff ARM v7. (We don't turn it on today for ARM <v7, and ARM v8 doesn't support it.) BUG=skia: Review URL: https://codereview.chromium.org/1054993002
* Use a wrapper for SkDebugf in SkCodec.Gravatar scroggo2015-03-26
| | | | | | | | | | | It can be silenced or not with one flag. Always print when building for the android framework. Also remove the meaningless define of override to override. BUG=skia:3257 Review URL: https://codereview.chromium.org/1032093004
* Add a go-fast button to Skia GYP configs.Gravatar mtklein2015-03-26
| | | | | | | | | | | | | | | | | | | | | | ./gyp_skia -Dskia_fast=1 will - always optimize for the current machine as much as possible - drop the frame pointer - optimize floating point arithmetic ignoring IEEE compliance This allows things like 3-argument VEX prefix SSE instructions and NEON autovectorization, and can give some seriously helpful clues about how to rearrange floating point math for speed. I've been having trouble with LTO linking, so I'll leave that out for now. I don't think we should set up bots with this mode. -ffast-math means I'm forced to run DM with --match ~Blend ~Path ~Rect ~Math ~Scalar ~Matrix ~Point before it passes, which is a disconcerting chunk of tests to disable (including all of PathOps). BUG=skia: Review URL: https://codereview.chromium.org/1036533003
* C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}Gravatar mtklein2015-03-25
| | | | | | | | | NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
* Add copyright headers to remaining gyp files.Gravatar scroggo2015-03-25
| | | | | | | | Prevents some PRESUBMIT errors. TBR=mtklein@google.com Review URL: https://codereview.chromium.org/1035523003
* Remove SkLONGLONG.Gravatar bungeman2015-03-17
| | | | | | | | | All users now define SkLONGLONG. This fixes a long outstanding TODO now that int64_t is required. BUG=skia:179 Review URL: https://codereview.chromium.org/1000933003
* Clean up SkDynamicAnnotations.Gravatar mtklein2015-03-12
| | | | | | | | | | | | | | | | Unprotected reads -> relaxed reads. Unprotected write -> relaxed write. The only unprotected write we had was in SkTraceEvent, which it looks like we nabbed from Chrome at some point and changed only to silence TSAN. Chrome's version uses AtomicWord / NoBarrier_Load / NoBarrier_Store, which boils down to the same as here, intptr_t / relaxed load / relaxed store. This leaves one place where we're lying a bit to TSAN, in include/core/SkLazyPtr.h where we're doing a data-dependent consume load. We're telling TSAN it's consume, but telling any other compiler to compile it as relaxed, given how they all upgrade consume to acquire. This eliminates a barrier for us on ARM. How do you guys deal with this? Just use a consume memory order, take the hit, and hope compilers get smarter one day? BUG=chromium:465721 No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/996763002
* miniz support in SkFlate / PDFGravatar mtklein2015-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | - Adds miniz.c v115_r4 (latest release) to third_party. - Merges SkDeflateWStream into SkFlate so including "miniz.c" links without duplicating symbols. The only interesting code change I've made is to remove the line fImpl->fZStream.data_type = Z_BINARY; from SkDeflateWStream::SkDeflateWStream(). miniz doesn't have Z_BINARY defined, and as far as I can tell, both zlib and miniz ignore data_type. We should be able to swap skflate.gyp's dependency between zlib.gyp:zlib and zlib.gyp:miniz at will (except of course on Windows) if we're interested in zlib itself. I've left android framework on its own zlib. I think this all means we can stop defining SK_NO_FLATE on Windows. I'll leave the possible cleanup of SK_NO_FLATE itself for another time. Might be we always want to keep this dependency optional. CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-ShuttleA-HD7770-x86-Debug-Trybot BUG=skia: Review URL: https://codereview.chromium.org/957323003
* SK_NO_FLATEGravatar mtklein2015-02-17
| | | | | | | | | | | Also remove skia_zlib_static. We're not using it. We don't even have zlib in DEPS. No public API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/936583002
* Stop adding mssse3 & m32/m64 for Android framework.Gravatar scroggo2015-02-12
| | | | | | BUG=skia:3423 Review URL: https://codereview.chromium.org/920703005
* Don't use m32 cflag for x86_64.Gravatar scroggo2015-02-12
| | | | | | | | | | | | | | | | | When checking the skia_arch_type for "x86", instead of doing an == compare, check if "x86" in skia_arch_type, so it will cover both x86 and x86_64. Except when we specifically want x86. Set skia_arch_width based on "64" in skia_arch_type. No need to specify in scripts. In gyp_to_android.py, create a separate var_dict for x86_64. BUG=skia:3419 Review URL: https://codereview.chromium.org/916113002
* Only define SK_CRASH_HANDLER in crash_handler.Gravatar scroggo2015-02-10
| | | | | | | | | The macro is only used in CrashHandler.* Removes SK_CRASH_HANDLER from Android's SkUserConfig, where it is not needed. Review URL: https://codereview.chromium.org/915663002
* Build in C++11 mode on Unix-like bots.Gravatar mtklein2015-02-05
| | | | | | | | | | | | | | | | Mac and Windows bots are already building in C++11 mode. This turns on the rest, mostly to see what work remains. This will probably break a few bots. It'd be nice if we could let those all come in as red before reverting this so I can see the full list to fix. BUG=skia: Committed: https://skia.googlesource.com/skia/+/779e49602a9c8f4d2799504822e01bcafbcaa534 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu13.10-GCC4.8-NaCl-Release-Trybot,Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot Review URL: https://codereview.chromium.org/868233008
* Revert of Build in C++11 mode on Unix-like bots. (patchset #4 id:60001 of ↵Gravatar mtklein2015-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/868233008/) Reason for revert: Perf-Ubuntu12, and Test-Ubuntu12, Build-Nacl all too old. Android and Chrome OS builders look ok. Android testers look ok. Chrome OS testers haven't run yet. Original issue's description: > Build in C++11 mode on Unix-like bots. > > Mac and Windows bots are already building in C++11 mode. > This turns on the rest, mostly to see what work remains. > > This will probably break a few bots. It'd be nice if we could let those > all come in as red before reverting this so I can see the full list to fix. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/779e49602a9c8f4d2799504822e01bcafbcaa534 TBR=stephana@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/879803003
* Build in C++11 mode on Unix-like bots.Gravatar mtklein2015-02-04
| | | | | | | | | | | | Mac and Windows bots are already building in C++11 mode. This turns on the rest, mostly to see what work remains. This will probably break a few bots. It'd be nice if we could let those all come in as red before reverting this so I can see the full list to fix. BUG=skia: Review URL: https://codereview.chromium.org/868233008
* Build in C++11 mode on Macs.Gravatar mtklein2015-02-03
| | | | | | | | | Build trybots are not triggering. NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/894773002
* Define SK_OVERRIDE when building for Android framework.Gravatar scroggo2015-01-30
| | | | Review URL: https://codereview.chromium.org/868243003
* Setup Android framework builds to use the appropriate shared lib defines.Gravatar djsollen2015-01-27
| | | | Review URL: https://codereview.chromium.org/864043005
* Update compiler warning flagsGravatar mtklein2015-01-23
| | | | | | | | | | | | - add -Wsign-compare, which has been catching useful issues for Kimmo; - add -Winit-self and -Wpointer-arith to Mac builds so everyone's using the same flags; - try try removing -Wno-uninitialized. This was only for the old 10.6 compiler that we have warnings set as non-errors now. BUG=skia: Review URL: https://codereview.chromium.org/872793002
* Don't require -DSK_USE_POSIX_THREADS.Gravatar mtklein2015-01-21
| | | | | | | | | | | | | To compile SkCondVar, we already require either pthreads or Windows. This simplifies that code to not need SK_USE_POSIX_THREADS to be explicitly defined. We'll just look to see if we're targeting Windows, and if not, assume pthreads. Both before and after this CL, that code will fail to compile if we're not on Windows and don't have pthreads. BUG=skia: Review URL: https://codereview.chromium.org/869443003
* Look at DYNAMIC_ANNOTATIONS_ENABLED now.Gravatar mtklein2014-12-15
| | | | | | | | | Defining SK_DYNAMIC_ANNOTATIONS_ENABLED as 1 whenever DYNAMIC_ANNOTATIONS_ENABLED was 1 seems to be working fine for Chrome. Should be we can just use DYNAMIC_ANNOTATIONS_ENABLED. BUG=skia: Review URL: https://codereview.chromium.org/810513002
* Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of ↵Gravatar mtklein2014-11-21
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/702893003/) Reason for revert: Not clean yet. Original issue's description: > Add -ftrapv to debug builds. > > This adds instrumentation to check that signed integers never under- or > overflow, which is undefined behavior. > > BUG=skia:3096 > > Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3096 Review URL: https://codereview.chromium.org/751713002
* Add -ftrapv to debug builds.Gravatar mtklein2014-11-21
| | | | | | | | | This adds instrumentation to check that signed integers never under- or overflow, which is undefined behavior. BUG=skia:3096 Review URL: https://codereview.chromium.org/702893003
* Small changes to get things building and running on Linux/ARM.Gravatar mtklein2014-11-21
| | | | | | | | | | | | ninja -C out/Debug works, and I tested out/Debug/dm --nogpu (no X yet). The only problems encountered were: - Like CrOS, I also needed to use the default float ABI (presumably hard). - The strings in GrBinHashKeyTest weren't necessarily 4-byte aligned. BUG=skia: Review URL: https://codereview.chromium.org/746043002
* Remove /arch:SSE2 from Win 64 Release buildsGravatar bsalomon2014-11-19
| | | | Review URL: https://codereview.chromium.org/740733002
* Don't use /ZI on 64 bit windowsGravatar bsalomon2014-11-13
| | | | Review URL: https://codereview.chromium.org/728633002
* Reenable deprecation warnings on Android framework.Gravatar scroggo2014-11-11
| | | | | | | | | | | | | Most recently introduced here: https://codereview.chromium.org/304333002 It appears these are not currently needed (I just disabled it and successfully built). Since we appear to be out of the transitional period, I propose we remove them so we can know if we deprecate something Android uses (and fix the call site). Review URL: https://codereview.chromium.org/696063006
* Get gpudft support working in dm, gm, nanobench and bench_picturesGravatar jvanverth2014-11-07
| | | | | | | | | | | | Adds a new config to test distance field text. Clean up some flags and #defines to read "distance field text", not "distance field fonts" to be consistent with Chromium NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b Review URL: https://codereview.chromium.org/699453005
* Revert of Get gpudft support working in dm, gm, nanobench and bench_pictures ↵Gravatar jvanverth2014-11-06
| | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/699453005/) Reason for revert: Not compiling in ANGLE build Original issue's description: > Get gpudft support working in dm, gm, nanobench and bench_pictures > > Adds a new config to test distance field text. > Clean up some flags and #defines to read "distance field text", > not "distance field fonts" to be consistent with Chromium > > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b TBR=bsalomon@google.com,mtklein@google.com,reed@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/707723005
* Get gpudft support working in dm, gm, nanobench and bench_picturesGravatar jvanverth2014-11-06
| | | | | | | | | | Adds a new config to test distance field text. Clean up some flags and #defines to read "distance field text", not "distance field fonts" to be consistent with Chromium NOTREECHECKS=true Review URL: https://codereview.chromium.org/699453005
* Revert of Start to vectorize SkTileGrid. (patchset #48 id:1670001 of ↵Gravatar mtklein2014-10-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/634543004/) Reason for revert: breaks chrome GPU debug bots Original issue's description: > Start to vectorize SkTileGrid. > > This adds Sk4x.h to help. > > BUG=skia:3041 > > Committed: https://skia.googlesource.com/skia/+/90c7992bfc6330f070f7704d63372a0ec8410170 > > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot > > Committed: https://skia.googlesource.com/skia/+/958e9628d5f9a81aeafa78572cb4afc4b19a455a TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3041 Review URL: https://codereview.chromium.org/637863005
* Start to vectorize SkTileGrid.Gravatar mtklein2014-10-20
| | | | | | | | | | | | This adds Sk4x.h to help. BUG=skia: Committed: https://skia.googlesource.com/skia/+/90c7992bfc6330f070f7704d63372a0ec8410170 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot Review URL: https://codereview.chromium.org/634543004
* Revert of Start to vectorize SkTileGrid. (patchset #45 id:1430002 of ↵Gravatar mtklein2014-10-16
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/634543004/) Reason for revert: Many GCC bots missing __builtin_shuffle, e.g. Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot. Original issue's description: > Start to vectorize SkTileGrid. > > This adds Sk4x.h to help. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/90c7992bfc6330f070f7704d63372a0ec8410170 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/663663002
* Start to vectorize SkTileGrid.Gravatar mtklein2014-10-16
| | | | | | | | This adds Sk4x.h to help. BUG=skia: Review URL: https://codereview.chromium.org/634543004
* Revert of No threadsafe statics. (patchset #1 id:1 of ↵Gravatar mtklein2014-10-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/654663002/) Reason for revert: Want to think about how to do this only to skialib and not to tools (gms, tests, etc.) Original issue's description: > No threadsafe statics. > > Chrome disables these for speed and code size, so we need > to disable them to make sure our code is safe when used > this way. > > int foo() { > static int32_t atomic_thing; > return sk_atomic_inc(&atomic_thing); > } > > is not safe in Chrome. Making the static global is: > > static int32_t atomic_thing; > int foo() { > return sk_atomic_inc(&atomic_thing); > } > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/cad5d3e264535c919b80e1e2a85407307961f221 TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/649343003
* No threadsafe statics.Gravatar mtklein2014-10-13
| | | | | | | | | | | | | | | | | | | | | | Chrome disables these for speed and code size, so we need to disable them to make sure our code is safe when used this way. int foo() { static int32_t atomic_thing; return sk_atomic_inc(&atomic_thing); } is not safe in Chrome. Making the static global is: static int32_t atomic_thing; int foo() { return sk_atomic_inc(&atomic_thing); } BUG=skia: Review URL: https://codereview.chromium.org/654663002
* Allow GCC to build Skia on Mac.Gravatar mtklein2014-10-13
| | | | | | | | | | | | | GCC doesn't understand -fasm-blocks or -mpascal-strings, but we don't care about them. While looking around in Gyp, I noticed a better way to disable warnings about offsetof so that it doesn't tell us "disabling this warning makes no sense in C" for every C source file we compile. BUG=skia: Review URL: https://codereview.chromium.org/650553002
* Add -Wno-invalid-offsetof to Mac and iOS builds too.Gravatar mtklein2014-10-07
| | | | | | | | | | | | We use this on Linux already, but for whatever reason wasn't a problem on iOS until using it in SkPaint. Mac 10.7 and 10.8 are showing this warning too, but seems -Werror is not enabled. CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Release-iOS-Trybot BUG=skia: Review URL: https://codereview.chromium.org/637593002
* Clean up SK_PICTURE_USE_SK_RECORD and SK_PICTURE_OPTIMIZE_SK_RECORD.Gravatar mtklein2014-09-30
| | | | | | | | | | | | | | | | | This folds the code through as if they were defined, which is the explicit state in both our build and Chrome's. This leaves the EXPERIMENTAL_ and DEPRECATED_ hooks in to be cleaned up or privatized later. CQ_EXTRA_TRYBOTS=tryserver.skia:Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT-Trybot BUG=skia: R=reed@google.com, robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/616033002
* Add flag to call SkRecordOptimize on new pictures.Gravatar mtklein2014-09-15
| | | | | | | | | | | As usual it's enabled by default in the Skia tree. Will flip in Chrome after this rolls. BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/573773002
* Revert of Add a test that uses C++11 features as a compiler canary. ↵Gravatar mtklein2014-09-12
| | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/568913002/) Reason for revert: nope, nacl and ubuntu local bots (at least) broken Original issue's description: > Add a test that uses C++11 features as a compiler canary. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/86e01df8d1d8848044c3fcc31c1a2008b70fe08c R=bungeman@google.com, mtklein@chromium.org TBR=bungeman@google.com, mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/565213008