aboutsummaryrefslogtreecommitdiffhomepage
path: root/gyp/common_conditions.gypi
Commit message (Collapse)AuthorAge
* Added warning for variable-length arrays to GYP, since they are unsupprted ↵Gravatar dvonbeck2016-06-15
| | | | | | | | | under Win targets BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068863002 Review-Url: https://codereview.chromium.org/2068863002
* Define LEAN_AND_MEAN and NOMINMAX for all windows buildsGravatar egdaniel2016-06-10
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055223002 Review-Url: https://codereview.chromium.org/2055223002
* Use SK_TEST_QCMS to mark qcms test codeGravatar msarett2016-06-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2031053005 Review-Url: https://codereview.chromium.org/2031053005
* MIPS32r2: Fix Chromium runtime crashGravatar milko.leporis2016-06-05
| | | | | | | | | | | | | | | | | | Crash is caused by ldxc1 instruction, which traps when double values are not aligned on 8-byte boundaries. Problem was tracked to SkChunkAlloc which produces pointers aligned on 4-byte boundaries leading to misalignment. This change makes sure that SkChunkAlloc will produce pointers that are aligned to 8 bytes. Appropriate tests are added to tests/MemsetTest.cpp TEST=Build Chromium with Clang and run on MIPS32r2 platform TEST=./out/Debug/dm --match Memset BUG=130022 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849183004 Review-Url: https://codereview.chromium.org/1849183004
* [GN] Add support for disabling opts via SK_BUILD_NO_OPTS define.Gravatar sdefresne2016-06-01
| | | | | | | | | | | | | | | | | | | | | When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS. It will be used by Chromium when building skia for iOS with gyp but not gn. Define SK_BUILD_NO_OPTS along-side SK_BUILD_FOR_IOS for all files that look like build configuration (Xcode projects, gyp configuration files, public.bzl) in order to avoid introducing breakage on those builds. BUG=607933 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002423002 Review-Url: https://codereview.chromium.org/2002423002
* Compile SkForceLinking on CMakeGravatar msarett2016-05-06
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956573002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/1956573002
* Remove NEON runtime detection support.Gravatar mtklein2016-05-05
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952953004 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/1952953004
* Delete ChromeOS codeGravatar borenet2016-04-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926163002 Review-Url: https://codereview.chromium.org/1926163002
* Make clang the default Android compiler.Gravatar djsollen2016-04-25
| | | | | | | BUG=skia:5215 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919873003 Review URL: https://codereview.chromium.org/1919873003
* We meant these to be YES... sigh.Gravatar mtklein2016-03-28
| | | | | | | | | This will dramatically improve link times with XCode 7.3. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835303003 Review URL: https://codereview.chromium.org/1835303003
* Update android_make to support both --gcc and --clang options.Gravatar djsollen2016-03-07
| | | | | | | | | | This CL also fixes all the errors that resulted from compiling with clang and ccache. BUG=skia:4948 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774503004 Review URL: https://codereview.chromium.org/1774503004
* link with -rdynamic on LinuxGravatar mtklein2016-03-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets our tools get symbols when they backtrace themselves. Here's an example improved stack trace. Notice there are symbols for some Skia methods now. Stack trace: out/Release/dm() [0x5ec19b] out/Release/dm() [0x5ec209] /lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9] /lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8] out/Release/dm() [0xcd19f9] out/Release/dm() [0x8ca959] out/Release/dm(_ZN11XfermodesGM16onOnceBeforeDrawEv+0x70) [0x8cb640] out/Release/dm(_ZN6skiagm2GM4drawEP8SkCanvas+0x1c) [0x5fc81c] out/Release/dm(_ZNK2DM5GMSrc4drawEP8SkCanvas+0x73) [0x5f3563] out/Release/dm(_ZNK2DM10RasterSink4drawERKNS_3SrcEP8SkBitmapP9SkWStreamP8SkString+0xcc) [0x5f9eac] out/Release/dm(_ZN4Task3RunERKS_+0xd5) [0x5f1685] out/Release/dm() [0xa4d320] out/Release/dm() [0xcb66ba] /lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d] Today the same crash looks more like this. Stack trace: out/Release/dm() [0x5ec19b] out/Release/dm() [0x5ec209] /lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9] /lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8] out/Release/dm() [0xcd19f9] out/Release/dm() [0x8ca959] out/Release/dm() [0x8cb640] out/Release/dm() [0x5fc81c] out/Release/dm() [0x5f3563] out/Release/dm() [0x5f9eac] out/Release/dm() [0x5f1685] out/Release/dm() [0xa4d320] out/Release/dm() [0xcb66ba] /lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d] BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774593002 Review URL: https://codereview.chromium.org/1774593002
* Only modify abort behavior to avoid debugger dialog on windows for bot builds.Gravatar bsalomon2016-03-02
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1752973003 Review URL: https://codereview.chromium.org/1752973003
* GrAuditTrail can now be enabled/disabled at runtimeGravatar ethannicholas2016-02-18
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1712753002 TBR=bsalomon@google.com Doesn't actually change the public API Review URL: https://codereview.chromium.org/1712753002
* Add batch information to jsonGravatar joshualitt2016-02-17
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705093002 Review URL: https://codereview.chromium.org/1705093002
* SkTArray to move when moving.Gravatar bungeman2016-02-09
| | | | | | | | | | | | This updates SkTArray to move elements when possible, instead of always copying them. TBR=reed Agreed moving is good. This should also become private. Committed: https://skia.googlesource.com/skia/+/3c69348e725131150e4ab962dec1b3ff1148a6bd Review URL: https://codereview.chromium.org/1672063002
* try -O1 to speed up msan botGravatar mtklein2016-02-07
| | | | | | | | | | | | | | | We want it to be a debug build, but it probably doesn't need to be completely unoptimized. dm: 27m -> 7m nanobench: 140m -> 33m BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678693002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot Review URL: https://codereview.chromium.org/1678693002
* flags and hacks to get MSAN bot goingGravatar mtklein2016-02-06
| | | | | | | | | | | | | | | | | | | | | This disables a few tests in DM: - one BlurLargeImage GM maybe is really broken - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from source, so MSAN can't see into it. This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to SkCodec, and skips .wbmps, .pngs, and .bmps. We're only seeing issues in colortables for .png and .bmp. I think I can probably back out disabling Codec and the RAW image decodes... they should all be covered by the libjpeg stifles. BUG=skia:4550,skia:4900 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1673663002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot TBR=msarett@google.com Review URL: https://codereview.chromium.org/1673663002
* Revert "Factor out xcode c/cpp settings into variables to apply to cmake ↵Gravatar bungeman2016-02-03
| | | | | | | | | builds." This reverts commit 32235eac4b5c625e639757b8247f6e64ce4dc4c8. This change should no longer be necessary now that gyp has been updated. Review URL: https://codereview.chromium.org/1664923002
* Update SK_IMAGE_VERSION to test RAWGravatar scroggo2016-02-02
| | | | | | | | | | | | | | | | | | | | | Bump SK_IMAGE_VERSION to test the images in v2 in GoogleStorage, which includes the images from v1 plus test images for SkRawCodec. Only define skia_decodes_raw on platforms that support it, rather than defining it always and checking additional conditions to determine whether to support raw. Further, define it and SK_CODEC_DECODES_RAW for all targets, so we can use the compile flag in other targets. In DM, exclude the raw extensions if SK_CODEC_DECODES_RAW is not defined. Blacklist raw extensions on NexusPlayer, which was running out of memory when running them. BUG=skia:4829 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612113002 Review URL: https://codereview.chromium.org/1612113002
* Revert of Treat bad values passed to --images as a fatal error (patchset #17 ↵Gravatar scroggo2016-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:320001 of https://codereview.chromium.org/1611323004/ ) Reason for revert: Speculative to fix windows bots Original issue's description: > Treat bad values passed to --images as a fatal error > > If an option is passed to --images that is either a non-existent path or > a folder with no images matching the supported types, assume this is > an error and exit, so they can supply a valid path instead. > > Share code between DM and nanobench in SkCommonFlags. > > nanobench now behaves more like DM - it will check a directory for > images that match the supported extensions. > > Only consider image paths ending in RAW suffixes as images if > SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure > to decode errors on platforms that cannot decode it. > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 > > Committed: https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93 TBR=mtklein@google.com,borenet@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1653543002
* Treat bad values passed to --images as a fatal errorGravatar scroggo2016-01-28
| | | | | | | | | | | | | | | | | | | If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. Only consider image paths ending in RAW suffixes as images if SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure to decode errors on platforms that cannot decode it. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
* Factor out xcode c/cpp settings into variables to apply to cmake builds.Gravatar bsalomon2016-01-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619243003 Review URL: https://codereview.chromium.org/1619243003
* Make skia_sanitizer work on Macs too.Gravatar mtklein2015-12-09
| | | | | | | | | This is of course limited by what the compiler suppports. -fsanitize=address seems to work OK. BUG=skia: Review URL: https://codereview.chromium.org/1512853005
* Add RTTI to all sanitizers.Gravatar herb2015-12-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1510843003
* Disable sanitizers with a blacklist.Gravatar mtklein2015-12-08
| | | | | | | | | | | | We think this might be more flexible. It allows, e.g, function-level blacklisting, and here an easy one-stop-shop blacklist for all of third_party/externals. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot NOTREECHECKS=true Review URL: https://codereview.chromium.org/1509733003
* Add sk_careful_memcpy to catch undefined behavior in memcpy.Gravatar mtklein2015-12-08
| | | | | | | | | | | | | | | | | | It's undefined behavior to pass null as src or dst to memcpy, even if len is 0. This currently triggers -fsanitize=attribute-nonnull warnings, but also can lead to very unexpected code generation with GCC. sk_careful_memcpy() checks len first before calling memcpy(), which prevents that weird undefined situation. This allows me to mark all sanitizers as no-recover, i.e. make-the-bots-red fatal. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot BUG=skia:4641 NOTREECHECKS=true Review URL: https://codereview.chromium.org/1510683002
* When was SkPDiff last used?Gravatar mtklein2015-12-07
| | | | | | BUG=skia:1451,skia:1463,skia:1798,skia:1859,skia:2710,skia:2711,skia:2712,skia:2713 Review URL: https://codereview.chromium.org/1502173003
* Create a define for nanobench builds to dump statsGravatar joshualitt2015-12-02
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1499453002
* update iOS build flagsGravatar mtklein2015-11-16
| | | | | | | | | | This makes it match OS X build more closely. The most important change is that CLANG_CXX_LIBRARY sets -stdlib=libc++ for both the compiler and the linker. BUG=skia: Review URL: https://codereview.chromium.org/1451913002
* turn on libc++ for iOSGravatar mtklein2015-11-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1442103002
* Target Mac bots at 10.7+libc++ to approximate Chrome's 10.6+libc++.Gravatar mtklein2015-11-12
| | | | | | | | | | | | | | This is necessary if we want to start using C++11 library features. Chrome's got their own custom libc++-for-10.6. This is a somewhat lazy approximation of that. Chrome should still guard us from using 10.7-specific features until 10.6-10.8 all go away. BUG=skia: Review URL: https://codereview.chromium.org/1437173002
* Wire up SDL on macGravatar joshualitt2015-11-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1428633003
* Comments Style: s/skbug.com/bug.skia.org/Gravatar halcanary2015-11-07
| | | | | | DOCS_PREVIEW= https://skia.org/?cl=1432503003 Review URL: https://codereview.chromium.org/1432503003
* skia: Add ANGLE support on MacGravatar hendrikw2015-10-28
| | | | | | | I want to be able to compare ANGLE vs CommandBuffer for dm and nanobench on Mac, so enabling ANGLE on mac. Review URL: https://codereview.chromium.org/1395783003
* skia: Fix command buffer support on the macGravatar hendrikw2015-10-27
| | | | | | | | | | | | | | | | | | The extension on the mac is .dylib, updated the name. EGL.h isn't available on mac (unless we include skia_angle.h). I've got a somewhat bad hack of defining the types that I need to get this running. GetProcedureAddress was somehow successfully grabbing gl functions from another lib. Removed this call, I copied it from ANGLE impl, but it isn't required. lib load path works differently, fixed in GYP BUG=skia:2992 Review URL: https://codereview.chromium.org/1403153002
* Clean up iOS build filesGravatar jvanverth2015-10-15
| | | | Review URL: https://codereview.chromium.org/1409663002
* Skia: Add Command Buffer support to Linux/MacGravatar hendrikw2015-10-01
| | | | | | | Code added to load libcommand_buffer_gles2.so on linux or mac. Review URL: https://codereview.chromium.org/1346423002
* skia: roll ANGLE and remove compile flagsGravatar hendrikw2015-09-29
| | | | | | | Recent angle change allows us to remove some of the ANGLE specific compile flags Review URL: https://codereview.chromium.org/1376803003
* skia: Add support for ANGLE on linuxGravatar hendrikw2015-09-23
| | | | | | | This will allow the ANGLE guys to test the ANGLE gl backend with nanobench and DM Review URL: https://codereview.chromium.org/1343193005
* unplumb sknx_no_simdGravatar mtklein2015-09-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1355833002
* Mimic Chrome better in our GYPs.Gravatar mtklein2015-09-09
| | | | | | | | | | To match Chrome, make sure we've disabled thread-safe statics, RTTI, and exceptions. Linux needed -fno-threadsafe-statics, Mac needed all three. Nothing important triggered this CL. I just got confused when I saw exception handling (calls to delete, stack unwinding) in some generated code on my laptop. BUG=skia: Review URL: https://codereview.chromium.org/1323533003
* Remove SK_OFFSETOF from SkTypes, clean up offsetof usage.Gravatar bungeman2015-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The motivation for this was to remove SK_OFFSETOF from SkTypes, but this CL is mostly about cleaning up our use of offsetof generally. SK_OFFSETOF is removed to SkTypes and added to the two places it is actually used (for the non standard behavior of finding the offset of fields in types which are not standard layout). Older versions of gcc required POD for offsetof to be used without warning. Newer versions require the more relaxed standard layout. Now that we no longer build on older versions of gcc, remove the old warning suppressions. PODMatrix is renamed to AggregateMatrix. SkMatrix is already POD (trivial and standard layout). The PODMatrix name implies that the POD-ness is needed for the offsetof, but it is actually the aggregate attribute which is needed for compile time constant initialization. This makes it more obvious that this can be revisited after we can rely on constexpr constructors. This also adds skstd::declval since this allows removal of existing awkward code which casts a constant to a pointer to find the size of a field. TBR=reed@google.com No API change, only removes unused macro. Review URL: https://codereview.chromium.org/1309523003
* A bit of misc cleanup.Gravatar mtklein2015-08-14
| | | | | | | | | | | - Update comments about skia_shared_lib - Remove dead code (system_preferences) - Remove non-building code (techtalk1) - Turn gm/annotated_text back on. BUG=skia: Review URL: https://codereview.chromium.org/1286133004
* Detect MIPS DSP and DSPR2 programattically.Gravatar mtklein2015-08-05
| | | | | | | | | | | | | | | | | | | | | | | | | Procedure: $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -dM -E - < /dev/null | sort > vanilla.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdsp -dM -E - < /dev/null | sort > dsp.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdspr2 -dM -E - < /dev/null | sort > dspr2.mips $ diff vanilla.mips dsp.mips 239a240,241 > #define __mips_dsp 1 > #define __mips_dsp_rev 1 $ diff vanilla.mips dspr2.mips 239a240,242 > #define __mips_dsp 1 > #define __mips_dsp_rev 2 > #define __mips_dspr2 1 So, defined(__mips_dsp) -> SK_MIPS_HAS_DSP, defined(__mips_dspr2) -> SK_MIPS_HAS_DSPR2. BUG=skia: Review URL: https://codereview.chromium.org/1274873002
* Remove IGNORE_ROT_AA_RECT_OPT flagGravatar robertphillips2015-08-04
| | | | | | It looks like the positive version was added (SHADER_AA_FILL_RECT) but the negative version wasn't removed. Review URL: https://codereview.chromium.org/1271903003
* Remove skia_arch_width, fold into skia_arch_type.Gravatar Brian Salomon2015-07-27
| | | | | | | | | DOCS_PREVIEW= https://skia.org/?cl=1228553010 BUG=skia:4042 R=borenet@google.com, mtklein@google.com Review URL: https://codereview.chromium.org/1228553010
* Add skia_use_android_framework_defines GYP_DEFINEGravatar borenet2015-07-22
| | | | | | BUG=skia:4082 Review URL: https://codereview.chromium.org/1243383002
* Compile with VS2015.Gravatar bungeman2015-07-21
| | | | | | | | | | | | | | | | Visual Studio 2015 has additional warnings around noexcept and disabling exceptions, which can be worked around with the (undocumented) _HAS_EXCEPTIONS macro. Visual Studio 2013 and 2015 have roundf in math.h, so use it to avoid extra work and casts. We avoid using cmath, as it undefs isfinite on gcc, but Visual Studio 2015 no longer provides overloads of copysign from math.h (which is actually correct). As a result, use copysignf (which is available in math.h in 2013 and 2015) directly. Review URL: https://codereview.chromium.org/1244173005
* Add a GYP flag to define SKNX_NO_SIMD when set.Gravatar mtklein2015-07-14
| | | | | | | | Will use this with a new -SKNX_NO_SIMD bot. BUG=skia: Review URL: https://codereview.chromium.org/1227163016
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-26 02:16:37 +0000