| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
| |
This keeps them visible on the bots.
E.g. https://luci-milo.appspot.com/swarming/task/30b9147a09f2ac10/steps/ninja/0/stdout
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254733008
Review-Url: https://codereview.chromium.org/2254733008
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253373002
Review-Url: https://codereview.chromium.org/2253373002
|
|
|
|
|
|
|
|
|
| |
Then we can use it to remind ourselves that SSE and AVX are x86-only.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247413003
Review-Url: https://codereview.chromium.org/2247413003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding flags to the end of cc or cxx is pretty useful, but these always end up
on the command line before the GN generated flags, thus setting defaults that
GN will override.
For full flexibility we want to be able to add flags after the flags GN has
added, so that custom flags can override _it_.
I've updated the Fast bots with an example here: if we said cc="clang -O3 ...",
that '-O3' would be overriden later by the default Release-mode '-Os'. By
putting it in extra_cflags, we get the last word: our '-O3' overrides the
default '-Os'.
Another good use case is a hypothetical Actually-Shippable-Release mode. Our
Release mode bundles in tons of debug symbols via '-g'. libskia.a is about 10x
larger than it needs to be when built that way, but it helps us debug the bot
failures immensely. To build a libskia.{a,so} that you'd really ship, you can
now set extra_cflags="-g0" to override '-g'. You could set '-march' flags there
too, '-fomit-frame-pointer', etc.
There are lots of flags that won't matter where they end up in the command line.
To keep everything simple I've put them in extra_cflags with the rest. This means
the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241263003
Review-Url: https://codereview.chromium.org/2241263003
|
|
|
|
|
|
|
|
|
| |
As usual, might as well roll, and this new behavior is a small convenience.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231833002
Review-Url: https://codereview.chromium.org/2231833002
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209533004
No public API changes.
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/2209533004
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200833010
Review-Url: https://codereview.chromium.org/2200833010
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exec_script runs every time gn does, which is explicitly on every one of our
bot runs. That should be enough to obviate the .git/logs/HEAD hack.
Easiest way to do this was to swap around find.py's argument order to allow
multiple search directories. This is the root of all the .gyp changes.
This moves the blacklist into BUILD.gn, which I think is nice.
It expands it a little as we're now searching recursively, into include/gpu/vk
which we can't include safely without the Vulkan SDK.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205903004
Review-Url: https://codereview.chromium.org/2205903004
|
|
|
|
|
|
|
|
|
| |
This keeps things like VIM .swp files out of skia.h.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202643002
Review-Url: https://codereview.chromium.org/2202643002
|
|
|
|
|
|
|
|
|
|
|
| |
This also puts the .a in the top-level of the ouptut directory, just
like we do for .so files. It's less required than for .sos, but it
does make it easier to find the .a.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197633002
Review-Url: https://codereview.chromium.org/2197633002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should help make the bot logs a little easier to read. (On the console
this wasn't much of a big deal, as Ninja auto-abbreviates when printing to an
interactive console.)
As usual, Ninja will print the full command when a task fails.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188263002
Review-Url: https://codereview.chromium.org/2188263002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These flags hide symbols that are not marked with SK_API when linked into a
shared library. There's nominally no effect on static linking, but I'm
pretty sure the Mac linker takes some advantage of this too to run faster.
This makes component-build DM no longer link: it uses many non SK_API APIs.
Fiddle in contrast is just fine with our public APIs, so no need to restrict that.
It'll be fun finding out which of our other tools go which ways.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180383003
Review-Url: https://codereview.chromium.org/2180383003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make fiddle build on Mac (skipping GL).
- Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
- Re-arrange third_party a bit so that our targets are Fuchsia/Chrome compatible.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
NOTREECHECKS=true
This doesn't affect Chrome/Blink, so landing through the closed tree.
Review-Url: https://codereview.chromium.org/2184133002
|
|
|
|
|
|
|
|
|
| |
Mostly stolen from Joe.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188493002
Review-Url: https://codereview.chromium.org/2188493002
|
|
This sketches out what a world without Chrome's GN configs would look like.
Instead of DEPSing in build/, we now host our own gypi_to_gn.py.
The symlink from skia/ to . lets us run gclient hooks when the .gclient file is in the directory above skia/ or inside skia/. That means we don't need gn.py anymore.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167163002
Review-Url: https://codereview.chromium.org/2167163002
|