aboutsummaryrefslogtreecommitdiffhomepage
path: root/gm
Commit message (Collapse)AuthorAge
* Do not define SK_SUPPORT_DEEPCOPYTO_CONFIG in Skia.Gravatar commit-bot@chromium.org2014-02-24
| | | | | | | | | | | | Clean up our callers who depend on the deprecated function. R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/178003003 git-svn-id: http://skia.googlecode.com/svn/trunk@13566 2bbb7eff-a529-9590-31e7-b0007b416f81
* add new copyTo version to SkBitmap, which takes SkColorTypeGravatar commit-bot@chromium.org2014-02-23
| | | | | | | | | | | BUG=skia: R=scroggo@google.com, halcanary@google.com, bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/171723007 git-svn-id: http://skia.googlecode.com/svn/trunk@13553 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add effect-based clipping for circular "tab" style rrects.Gravatar commit-bot@chromium.org2014-02-21
| | | | | | | | | | | BUG=skia:2181 R=jvanverth@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/175423002 git-svn-id: http://skia.googlecode.com/svn/trunk@13548 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factory methods for heap-allocated SkColorFilter objects.Gravatar commit-bot@chromium.org2014-02-21
| | | | | | | | | | | | | | | | | | This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkColorFilter and its subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep constructor of publicly visible classes public behind a flag. BUG=skia:2187 R=scroggo@google.com, mtklein@google.com, reed@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/175293002 git-svn-id: http://skia.googlecode.com/svn/trunk@13539 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factory methods for heap-allocated SkMaskFilter objects.Gravatar commit-bot@chromium.org2014-02-21
| | | | | | | | | | | | | | | | | | This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkMaskFilter and its subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep constructor of publicly visible classes public behind a flag. BUG=skia:2187 R=scroggo@google.com, mtklein@google.com, reed@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/173633003 git-svn-id: http://skia.googlecode.com/svn/trunk@13527 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-21
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13525 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SkCanvas::drawDRRectGravatar commit-bot@chromium.org2014-02-21
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com, robertphillips@google.com, humper@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/174243003 git-svn-id: http://skia.googlecode.com/svn/trunk@13524 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factory methods for heap-allocated SkPathEffect and SkXfermode objects.Gravatar commit-bot@chromium.org2014-02-20
| | | | | | | | | | | | | | | | | | | | | | | This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkPathEffect, SkXfermode and their subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep the constructors of the following classes public to not break Chrome/Blink: SkXfermode SkCornerPathEffect SkDashPathEffect BUG=skia:2187 R=scroggo@google.com, reed@google.com, mtklein@google.com, bungeman@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/166583002 git-svn-id: http://skia.googlecode.com/svn/trunk@13519 2bbb7eff-a529-9590-31e7-b0007b416f81
* Offer single-param version of deepCopyTo -- much easier to migrate to colortypesGravatar commit-bot@chromium.org2014-02-20
| | | | | | | | | | | BUG=skia: R=reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/167683006 git-svn-id: http://skia.googlecode.com/svn/trunk@13516 2bbb7eff-a529-9590-31e7-b0007b416f81
* Re-enable imageresizetiled, but skip it in tilegrid and rtree.Gravatar senorblanco@chromium.org2014-02-20
| | | | | | | | | | | | | | | | | | | This change makes kSkipTiled_Flag also skip --tileGrid and --rtree. All GMs which were passing kSkipTiled_Flag before were also passing kSkipPicture_Flag, which also skips tilegrid and rtree, so this should have no effect on them, but provides a smaller hammer for GMs which still want to test picture playback, but not tiling. The exception is magnifier, which was passing only kSkipTiled_Flag, but magnifier is an odd beast and not web-exposed, so I'm not worried about reducing its coverage slightly. R=scroggo@google.com BUG=skia: Review URL: https://codereview.chromium.org/165723009 git-svn-id: http://skia.googlecode.com/svn/trunk@13514 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix CTM application in SkResizeImagefilter; implement bounds traversals.Gravatar senorblanco@chromium.org2014-02-19
| | | | | | | | | | | | | | | | | SkResizeImageFilter resizes all the pixels from its input (subject to the input's crop rect), but the offset to be applied was incorrect. It should take the CTM into account, so that the origin of the resize is the world space origin, unaffected by whatever clipping is applied. New GM imageresizetiled exercises the behaviour under impl-side-painting-like conditions, and existing GMs now have resize cases added. R=reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/168283006 git-svn-id: http://skia.googlecode.com/svn/trunk@13506 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: extract common unittest code, and rename tests/ -> testdata/Gravatar commit-bot@chromium.org2014-02-19
| | | | | | | | | | | NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/170803005 git-svn-id: http://skia.googlecode.com/svn/trunk@13499 2bbb7eff-a529-9590-31e7-b0007b416f81
* Analytic rrect clip for cicular corners, radius >= 0.5Gravatar commit-bot@chromium.org2014-02-19
| | | | | | | | | | | BUG=skia:2181 R=robertphillips@google.com, jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/171413004 git-svn-id: http://skia.googlecode.com/svn/trunk@13498 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: fail fast if skpdiff binary is not availableGravatar commit-bot@chromium.org2014-02-18
| | | | | | | | | | | NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/169943002 git-svn-id: http://skia.googlecode.com/svn/trunk@13484 2bbb7eff-a529-9590-31e7-b0007b416f81
* replace SkBitmap::Config with SkColorType in gmsGravatar commit-bot@chromium.org2014-02-17
| | | | | | | | | | | | | add helper installMaskPixels() to SkBitmap BUG=skia: R=halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/169913003 git-svn-id: http://skia.googlecode.com/svn/trunk@13482 2bbb7eff-a529-9590-31e7-b0007b416f81
* Store SkRRects in SkClipStackGravatar commit-bot@chromium.org2014-02-16
| | | | | | | | | | | BUG=skia:2181 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/163683002 git-svn-id: http://skia.googlecode.com/svn/trunk@13465 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix valgrind suppressions (again)Gravatar robertphillips@google.com2014-02-14
| | | | | | | | https://codereview.chromium.org/166193003/ git-svn-id: http://skia.googlecode.com/svn/trunk@13449 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-14
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13447 2bbb7eff-a529-9590-31e7-b0007b416f81
* Gyp flag to disable inlining.Gravatar commit-bot@chromium.org2014-02-13
| | | | | | | | | | | | | | | | | To turn off all inlining, rebuild after running the command $ GYP_DEFINES=skia_disable_inlining=1 ./gyp_skia Provides an initial value in one GM to avoid an uninitialized variable warning. BUG=skia:2126 R=scroggo@google.com, mtklein@google.com, tomhudson@google.com Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/163363004 git-svn-id: http://skia.googlecode.com/svn/trunk@13437 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: create ImagePairSet-- holds a number of ImagePairs to examineGravatar commit-bot@chromium.org2014-02-13
| | | | | | | | | | | | | | See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context BUG=skia:1919 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/139343018 git-svn-id: http://skia.googlecode.com/svn/trunk@13434 2bbb7eff-a529-9590-31e7-b0007b416f81
* add peekPixels to SkCanvas and SkSurfaceGravatar commit-bot@chromium.org2014-02-13
| | | | | | | | | | | | | | fix reference to SkBaseDevice, which was only a problem in no-gpu build This reverts commit 4fa44a6bf73891b21917fb90d02beef9143bffa3. R=reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/163603003 git-svn-id: http://skia.googlecode.com/svn/trunk@13432 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of add peekPixels to SkCanvas and SkSurface ↵Gravatar commit-bot@chromium.org2014-02-13
| | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/161733002/) Reason for revert: compile issues with gm/xfermodes3 Original issue's description: > add peekPixels to SkCanvas and SkSurface > > clone of https://codereview.chromium.org/159723006/ > > Committed: https://code.google.com/p/skia/source/detail?r=13427 R=jvanverth@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/163823002 git-svn-id: http://skia.googlecode.com/svn/trunk@13428 2bbb7eff-a529-9590-31e7-b0007b416f81
* add peekPixels to SkCanvas and SkSurfaceGravatar mike@reedtribe.org2014-02-13
| | | | | | | | clone of https://codereview.chromium.org/159723006/ Review URL: https://codereview.chromium.org/161733002 git-svn-id: http://skia.googlecode.com/svn/trunk@13427 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add the perceptual difference metric to the rebaseline serverGravatar commit-bot@chromium.org2014-02-11
| | | | | | | | | | | | | | | | | | | * Finds the location of the skpdiff binary. * Calculates the perceptual difference percentage using the skpdiff binary (treats -1 as 0% perceptual similarity). * Replaces the weightedDiffMeasure in view.html with perceptualDifferent. BUG=skia:2019 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13398 R=epoger@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/147453003 git-svn-id: http://skia.googlecode.com/svn/trunk@13410 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix valgrind suppressionsGravatar robertphillips@google.com2014-02-11
| | | | | | | | https://codereview.chromium.org/158493004/ git-svn-id: http://skia.googlecode.com/svn/trunk@13403 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Add the perceptual difference metric to the rebaseline server ↵Gravatar commit-bot@chromium.org2014-02-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/147453003/) Reason for revert: Caused failure in RunGmSelfTests: http://108.170.219.160:10117/builders/Housekeeper-PerCommit/builds/154/steps/RunGmSelfTests/logs/stdio Filed: https://code.google.com/p/skia/issues/detail?id=2160 Original issue's description: > Add the perceptual difference metric to the rebaseline server > > * Finds the location of the skpdiff binary. > * Calculates the perceptual difference percentage using the skpdiff binary. > * Replaces the weightedDiffMeasure in view.html with perceptualDifferent. > > BUG=skia:2019 > NOTRY=true > > Committed: http://code.google.com/p/skia/source/detail?r=13398 R=epoger@google.com TBR=epoger@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2019 Author: rmistry@google.com Review URL: https://codereview.chromium.org/131453017 git-svn-id: http://skia.googlecode.com/svn/trunk@13399 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add the perceptual difference metric to the rebaseline serverGravatar commit-bot@chromium.org2014-02-11
| | | | | | | | | | | | | | | | * Finds the location of the skpdiff binary. * Calculates the perceptual difference percentage using the skpdiff binary. * Replaces the weightedDiffMeasure in view.html with perceptualDifferent. BUG=skia:2019 NOTRY=true R=epoger@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/147453003 git-svn-id: http://skia.googlecode.com/svn/trunk@13398 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: add ImagePair class, a step towards new intermediate JSON ↵Gravatar commit-bot@chromium.org2014-02-10
| | | | | | | | | | | | | | | | schema See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context BUG=skia:1919 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/157593006 git-svn-id: http://skia.googlecode.com/svn/trunk@13385 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-09
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13376 2bbb7eff-a529-9590-31e7-b0007b416f81
* Specialize GrConvexPolyEffect for AA rects, use for AA clip rects.Gravatar commit-bot@chromium.org2014-02-08
| | | | | | | | | | | BUG=skia:2051 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/140093004 git-svn-id: http://skia.googlecode.com/svn/trunk@13375 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make GMs aware of what tool they're being run in.Gravatar commit-bot@chromium.org2014-02-07
| | | | | | | | | | | | | Add a saveLayer set of draws to convex_poly_clip and fix GPU bug where polygon clips don't account for the translation between clip and device space. BUG=skia:2051 R=robertphillips@google.com, reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/148283017 git-svn-id: http://skia.googlecode.com/svn/trunk@13371 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: properly handle unexpected GETsGravatar commit-bot@chromium.org2014-02-07
| | | | | | | | | | | | BUG=skia:2147 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/157773002 git-svn-id: http://skia.googlecode.com/svn/trunk@13366 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Revert "Serialization of SkPictureImageFilter" ↵Gravatar commit-bot@chromium.org2014-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/153583007/) Reason for revert: New SKPs with version20 are in Google Storage due to http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22 Original issue's description: > Revert "Serialization of SkPictureImageFilter" > > This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. > > Revert "Sanitizing source files in Housekeeper-Nightly" > > This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. > > TBR=robertphillips@google.com,sugoi@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13356 R=robertphillips@google.com, sugoi@google.com, fmalita@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, fmalita@google.com, robertphillips@google.com, sugoi@google.com NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/143163005 git-svn-id: http://skia.googlecode.com/svn/trunk@13357 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Serialization of SkPictureImageFilter"Gravatar fmalita@google.com2014-02-07
| | | | | | | | | | | | | | This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. Revert "Sanitizing source files in Housekeeper-Nightly" This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. TBR=robertphillips@google.com,sugoi@google.com Review URL: https://codereview.chromium.org/153583007 git-svn-id: http://skia.googlecode.com/svn/trunk@13356 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-07
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13355 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: add "show only"/"show all" buttons to some columnsGravatar commit-bot@chromium.org2014-02-06
| | | | | | | | | | | | BUG=skia:2143 NOTRY=True R=bsalomon@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/156773003 git-svn-id: http://skia.googlecode.com/svn/trunk@13349 2bbb7eff-a529-9590-31e7-b0007b416f81
* add inital gm for colorfiltersGravatar reed@google.com2014-02-06
| | | | | | | | | BUG=skia: R=djsollen@google.com Review URL: https://codereview.chromium.org/140393005 git-svn-id: http://skia.googlecode.com/svn/trunk@13346 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: get "image size" working againGravatar commit-bot@chromium.org2014-02-06
| | | | | | | | | | | | BUG=skia:2134 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/155973003 git-svn-id: http://skia.googlecode.com/svn/trunk@13343 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix memory leak in imagefiltersclipped GM (found by valgrind).Gravatar senorblanco@chromium.org2014-02-06
| | | | | | | | TBR=robertphillips Review URL: https://codereview.chromium.org/146193004 git-svn-id: http://skia.googlecode.com/svn/trunk@13334 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make SkImageFilter methods const.Gravatar commit-bot@chromium.org2014-02-05
| | | | | | | | | | | | | | SkImageFilter had some non-const methods that could all be made const. This is a first step towards making SkImageFilter immutable. BUG=skia:2097 R=mtklein@google.com, reed@google.com, robertphillips@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/148883011 git-svn-id: http://skia.googlecode.com/svn/trunk@13330 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: add bgcolor slider for pixelDiff columnGravatar commit-bot@chromium.org2014-02-05
| | | | | | | | | | | | BUG=skia:1904 NOTRY=True R=robertphillips@google.com, rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/143273003 git-svn-id: http://skia.googlecode.com/svn/trunk@13325 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm self-test: stop checking stdout and stderrGravatar commit-bot@chromium.org2014-02-05
| | | | | | | | | | | | BUG=skia:1568 NOTRY=True R=bsalomon@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/156023002 git-svn-id: http://skia.googlecode.com/svn/trunk@13324 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement correct clipping for image filters.Gravatar senorblanco@chromium.org2014-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | Image filters in Skia currently clip the size of the the offscreen bitmap used for filtering to the device clip bounds. This means that any pixel-moving filter (e.g., blur) has edge artifacts at the clip boundaries. This is problematic for tiling, where a single SkPicture is played back with a clip set to the tile boundaries. By implementing the onFilterBounds() traversal, and using it in saveLayer() when a filter is present, we can clip the layer to the expanded clip rect. Note that this requires that the traversal be performed in reverse as compared to computeFastBounds(). (It's also done in device space, unlike computeFastBounds()). New test imagefiltersclipped tests pixel-moving filters when clipped by various clip rects. New test imageblurtiled tests tiled (compositor-style) rendering of blurred text. There should be no artifacts at the tile boundaries. BUG=337831 R=reed@google.com Review URL: https://codereview.chromium.org/23011012 git-svn-id: http://skia.googlecode.com/svn/trunk@13323 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurfaceGravatar reed@google.com2014-02-05
| | | | | | | | | BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/154163002 git-svn-id: http://skia.googlecode.com/svn/trunk@13319 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-05
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13316 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add magnifier to rebaseline server.Gravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | | NOTRY=true BUG=skia:1917 R=epoger@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/149473005 git-svn-id: http://skia.googlecode.com/svn/trunk@13315 2bbb7eff-a529-9590-31e7-b0007b416f81
* convert gm tool to use surfaces instead of devicesGravatar reed@google.com2014-02-04
| | | | | | | | | BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/148783003 git-svn-id: http://skia.googlecode.com/svn/trunk@13301 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add rect clip to convex_poly_clip GMGravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | BUG=skia:2051 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/147793007 git-svn-id: http://skia.googlecode.com/svn/trunk@13300 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow GMs to be used as benchmarks. Make convex_poly_clip opt in.Gravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/151843002 git-svn-id: http://skia.googlecode.com/svn/trunk@13279 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add GM with convex polygon clipsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia:2051 R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/136563004 git-svn-id: http://skia.googlecode.com/svn/trunk@13262 2bbb7eff-a529-9590-31e7-b0007b416f81