| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MULTILINE, ^, and $ work based on the platform, but the files being
parsed are from other platforms. As a result, the current code for
extracting the actual_results.json version will not find it in
logfiles produced on Windows when run on Mac.
The code for extracting the exact actual_results.json file to use
from a logfile is itself something of a hack, as this information
should be provided ina more structured manner. This proposed
method of finding the exact file is no worse than the old one, and
in cases like above, better.
Review URL: https://codereview.chromium.org/789253002
|
|
|
|
|
|
|
|
| |
Currently server.py --rietveld-issue will crash if there are any
unstarted trybots on the latest patch. Instead of crashing, warn
that the bot hasn't started yet.
Review URL: https://codereview.chromium.org/758793003
|
|
|
|
| |
Commit d09ade4b44edc11 was missing a needed edit.
|
|
|
|
|
|
|
| |
This adds support to rebaseline_server to fetch actual results from
tryjobs run on rietveld issues.
Review URL: https://codereview.chromium.org/688353003
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is going to serve as the starting point for the new front-end once the backend is rewritten.
BUG=skia:
NOTRY=true
R=jcgregorio@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/538613002
|
|
|
|
|
|
|
|
|
|
|
| |
fix the failed test in housekeeping.
BUG=skia:2902
R=mtklein@google.com, rmistry@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/546753003
|
|
|
|
|
|
|
|
|
|
|
| |
server.
BUG=skia:2230
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/479613002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
comparison failures
Without this change, SKP tests *appeared* to fail because the actuals reported
their checksumValues as integers, while the expectations recorded their
checksumValues as strings.
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/489023003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, the first time you compare against these expectations, you get
failures.
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/491063002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/489183002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow developers to maintain SKP baselines without ever running their
own rebaseline_server instance!
For now, the developer must manually apply the resulting patchset to his local
Skia checkout to actually modify expectations; in the near future, we hope to
make the UI upload the patchset to Rietveld on the user's behalf.
BUG=skia:1918
NOTRY=true
R=stephana@google.com, rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/487853004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
old/new
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/484763004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories, not lists
Before this CL, we supported multiple setADirs/setBDirs for some operations but
not others... now we consistently support a single pair of directories.
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/480293002
|
|
|
|
|
|
|
|
|
|
|
|
| |
SKPs.
BUG=skia:2833
NOTRY=true
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/480153002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
need to keep frontend code for URL generation in sync with the backend.
BUG=skia:
NOTREECHECKS=true
NOTRY=true
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/471033003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actuals
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/473973002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for rebaselining using the shared rebaseline_server instance:
by telling the client which git revision was used to fetch expectations, we
allow the client to pass that back along with new baselines (so the server
knows which revision to patch).
This is also handy in that it allows the server to tell the client more about the
different result sets (which files they were generated from).
BUG=skia:1918
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/474813002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patchset 3 from https://codereview.chromium.org/467843002
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/475623002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GET_prefetch_results
patchset 1 from issue 467843002
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/465143004
|
|
|
|
|
|
|
|
|
|
|
|
| |
still need to fix some broken tests).
BUG=skia:
NOTRY=true
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/472703002
|
|
|
|
|
|
|
|
|
|
|
| |
directory to the directory that is served by the rebaseline_server.
BUG=skia:2815, skia:2818
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/457203003
|
|
|
|
|
|
|
|
|
|
| |
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/463213002
|
|
|
|
|
|
|
|
|
|
|
| |
Without this, it's hard to tell whether the server is stuck (or why it's taking so long).
NOTRY=true
R=stephana@google.com, rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/454953002
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/451053004
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=skia:1907
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/449843002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(the list is long and crowds out the results themselves; better to use
a text filter to select the sourceSkpFiles of interest)
R=stephana@google.com
TBR=stephana
NOTREECHECKS=true
NOTRY=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/451853002
|
|
|
|
|
|
|
|
|
|
|
| |
R=rmistry@google.com
TBR=rmistry
NOTREECHECKS=true
NOTRY=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/445753005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JSONKEY_ACTUALRESULTS
See https://goto.google.com/CorrectnessTestingBigIssues for full context
BUG=skia:1942
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/453433004
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as you scroll
NOTRY=true
BUG=skia:1912
R=stephana@google.com, epoger@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/446933002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
without awaiting results
This will allow the buildbots to warn the production rebaseline_server: "I just
generated some new results; here's a comparison that a human might ask for
soon. Download whatever images and generate whatever diffs you would need to
provide those results."
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/443013002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
within the Skia repo
This is a step towards providing SKP comparisons against expectations, not just
other actual results... we still need to allow the user to select
JSONKEY_EXPECTEDRESULTS vs JSONKEY_ACTUALRESULTS within the summary
files found.
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/442203002
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates a new live-view.html page, served by the rebaseline_server, that will display diffs between two sets of rendered SKP images.
BUG=skia:1942
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/424263005
|
|
|
|
|
|
|
|
|
|
| |
general cleanup, which will also help with http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"')
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/397103003
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2618
R=borenet@google.com, cmp@chromium.org
Author: epoger@google.com
Review URL: https://codereview.chromium.org/392353003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(not just within the rebaseline_server subdirectory)
Generally useful, but needed asap for my work on http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"')
BUG=skia:677
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/398043002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2682
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/385783002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than rebuilding the ImageDiffDB from scratch every time we update expected/actual results, keep the same ImageDiffDB instance around and add image pairs to it.
This makes updating results within a long-running server.py *much* faster, and tests out an idea I'm ruminating in https://goto.google.com/LongRunningImageDiffDBServer : we could run an ImageDiffDB server that developers could connect to from their locally running rebaseline_server instances, for much faster launch times.
BUG=skia:2414
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/379563005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes the rebaseline_server client more generic, allowing the server to tweak display properties by writing directives into the JSON file.
Adds two new fields to the rebaseline_server JSON file (and thus increments VALUE__HEADER__SCHEMA_VERSION):
1. KEY__ROOT__EXTRACOLUMNORDER: order in which the client should display columns
2. KEY__EXTRACOLUMNHEADERS__USE_FREEFORM_FILTER: whether a column should be filtered using a freeform text field or checkboxes
BUG=skia:2230
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/376623002
|
|
|
|
|
|
|
|
|
|
|
| |
This is a step towards making rebaseline_server more flexible, and useful for displaying output of the cluster telemetry server as well as actuals-on-configA-vs-actuals-on-configB.
BUG=skia:2230
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/369133004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modification to https://codereview.chromium.org/368933002/ ('rebaseline_server: add urlSchemaVersion parameter')
Means we don't need https://codereview.chromium.org/367173002/ ('add urlSchemaVersion to rebaseline_server link on buildbot console page')
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/364253003
|
|
|
|
|
|
|
|
|
|
|
|
| |
In https://codereview.chromium.org/369473005 ('rebaseline_server: handle category filtering more generically'), I am changing the meaning of some URL parameters. If a user pastes an old URL into an updated rebaseline_server instance, they may get unexpected results. Adding a urlSchemaVersion parameter allows us to automatically convert the URL, or at least warn the user.
BUG=skia:2230
NOTRY=True
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/368933002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2414
R=djsollen@google.com, borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/325413003
|
|
|
|
|
|
|
|
|
|
|
| |
--clone, and SkPicture::clone(), are no longer.
CQ_EXTRA_TRYBOTS=tryserver.skia:Housekeeper-PerCommit-Trybot
BUG=skia:
R=rmistry@google.com
Review URL: https://codereview.chromium.org/343813006
|
|
|
|
|
|
|
|
|
|
|
|
| |
(replaced by perceptual diff)
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/334533003
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/329933002
|
|
|
|
|
|
|
|
|
|
|
| |
builders/configs) into a single row
BUG=skia:2534
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/326013002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of SVN"
relands https://codereview.chromium.org/310093003 with modifications.
BUG=skia:2641
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/313343003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of SVN"
This reverts commit f4666045f378dee22ce40108e90bf5195634ebfc.
BUG=skia:2641
NOTREECHECKS=True
NOTRY=True
R=jcgregorio@google.com
TBR=jcgregorio
Author: epoger@google.com
Review URL: https://codereview.chromium.org/317783004
|
|
|
|
|
|
|
|
|
| |
BUG=skia:553
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/310093003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
skia-autogen
uses google-api-python-client instead of gsutil binary to interact with Google Storage
BUG=skia:553
R=rmistry@google.com, bensong@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/309653005
|