aboutsummaryrefslogtreecommitdiffhomepage
path: root/gm/path_stroke_with_zero_length.cpp
Commit message (Collapse)AuthorAge
* Revert "Reland "Revert "Update GPU DM/nanobench configs for color testing"""Gravatar Brian Osman2018-06-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d5161b9a62b6912105e7a49d06e5126bf4fa1f75. Reason for revert: This should be okay again. Original change's description: > Reland "Revert "Update GPU DM/nanobench configs for color testing"" > > This reverts commit c0fb3c8b9fea2f60062819e92a1fa7f0a1966fba. > > Reason for revert: Had to revert dependent CL. > Original change's description: > > Revert "Revert "Update GPU DM/nanobench configs for color testing"" > > > > This reverts commit 2a284de7a51c198096a6f34ec1cbfe9118db554c. > > > > Re-landing without esrgb configs. Going to enable those separately, > > as they require some blacklisting. > > > > Bug: skia: > > Change-Id: I2315849d4f5c45c2e5512f84f9f867d02ff6fe30 > > Reviewed-on: https://skia-review.googlesource.com/136589 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Commit-Queue: Brian Osman <brianosman@google.com> > > TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com > > Change-Id: I942d4235c17100fd933bf9cbfe923e3ae80657b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/137721 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I280dac49eb74d6c1cbf7c2f52a3f6a68fa2510ae Reviewed-on: https://skia-review.googlesource.com/138301 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "Revert "Update GPU DM/nanobench configs for color testing""Gravatar Brian Osman2018-06-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c0fb3c8b9fea2f60062819e92a1fa7f0a1966fba. Reason for revert: Had to revert dependent CL. Original change's description: > Revert "Revert "Update GPU DM/nanobench configs for color testing"" > > This reverts commit 2a284de7a51c198096a6f34ec1cbfe9118db554c. > > Re-landing without esrgb configs. Going to enable those separately, > as they require some blacklisting. > > Bug: skia: > Change-Id: I2315849d4f5c45c2e5512f84f9f867d02ff6fe30 > Reviewed-on: https://skia-review.googlesource.com/136589 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com Change-Id: I942d4235c17100fd933bf9cbfe923e3ae80657b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/137721 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Revert "Update GPU DM/nanobench configs for color testing""Gravatar Brian Osman2018-06-26
| | | | | | | | | | | | | This reverts commit 2a284de7a51c198096a6f34ec1cbfe9118db554c. Re-landing without esrgb configs. Going to enable those separately, as they require some blacklisting. Bug: skia: Change-Id: I2315849d4f5c45c2e5512f84f9f867d02ff6fe30 Reviewed-on: https://skia-review.googlesource.com/136589 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Update GPU DM/nanobench configs for color testing"Gravatar Brian Osman2018-06-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5e11777a06d591c1e6ab0523e9c7f4739e164609. Reason for revert: Bots with no F16 support failing (as expected). Original change's description: > Update GPU DM/nanobench configs for color testing > > - Rename '*srgbnl' to '*srgb'. > - Add '*narrow' and '*enarrow' for testing a gamut narrower than sRGB. > - Stopped blacklisting glessrgb. It no longer uses sRGB pixel configs, > so should work fine on all GPUs. > - Also runs 'esrgb' (F16 sRGB) everywhere. This is likely to fail on > some devices that have poor (or no) F16 support. > > Change-Id: I941d0758adb3b0c895c7a8a85ff0ae4aa5bff6e7 > Reviewed-on: https://skia-review.googlesource.com/136171 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com Change-Id: I091269b93bc9e76c9d42f701d2018610b9c33a89 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/136300 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Update GPU DM/nanobench configs for color testingGravatar Brian Osman2018-06-20
| | | | | | | | | | | | | | | - Rename '*srgbnl' to '*srgb'. - Add '*narrow' and '*enarrow' for testing a gamut narrower than sRGB. - Stopped blacklisting glessrgb. It no longer uses sRGB pixel configs, so should work fine on all GPUs. - Also runs 'esrgb' (F16 sRGB) everywhere. This is likely to fail on some devices that have poor (or no) F16 support. Change-Id: I941d0758adb3b0c895c7a8a85ff0ae4aa5bff6e7 Reviewed-on: https://skia-review.googlesource.com/136171 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* New zero length path GMGravatar Brian Osman2017-07-13
| | | | | | | | | | | | | | | | | | | | | | I replaced the previous once, because I think this covers everything it was testing, and lots more. It renders many combinations of parameters, and automatically detects if the results are correct or not. Each test is color coded, and the overall image is tinted with gold's red/green to make triaging easy. Adds four new top-level GMs (single and double contour, with and without AA). Each one tests several more params: - Cap type - Stroke width - Path structure (M vs ML vs MZ vs MLZ) - Different verbs (L vs Q vs C vs A) Bug: skia:6781 Change-Id: Ie81b4417101fea0b439cb094a65257dc06b6b5c0 Reviewed-on: https://skia-review.googlesource.com/21480 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Adjust path_stroke_with_zero_length to draw on pixel centersGravatar Brian Osman2017-06-27
| | | | | | | | Bug: skia: Change-Id: I1183574de4e3a429fe00c5a6a0f71745f1f6f5b4 Reviewed-on: https://skia-review.googlesource.com/20969 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* deprecate odd variants of SkCanvas::readPixelsGravatar Mike Reed2017-04-17
| | | | | | | | | Bug: skia:6513 Change-Id: I51179a85f0912d3f899c368c30a943d346dd1d05 Reviewed-on: https://skia-review.googlesource.com/13589 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
* allow clip calls w/o op param, remove unnecessary kReplace opsGravatar reed2016-09-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357333002 Review-Url: https://codereview.chromium.org/2357333002
* abstract name of clipping ops, to transtion to a more restricted setGravatar reed2016-09-20
| | | | | | | | | | | SkRegion::Op --> SkCanvas::ClipOp (alias) --> SkClipOp pre-CL needed in chrome : https://codereview.chromium.org/2355583002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355483002 Review-Url: https://codereview.chromium.org/2355483002
* path_stroke_with_zero_length: turn off drawFat() by default.Gravatar mtklein2016-04-06
| | | | | | | | | | | | The replay modes cannot readback, and so cannot draw the fat parts, which means we've had to exempt them from checking that they draw identically. I don't mind if we leave it alone, but I thought I'd check to see your opinion. BUG=skia:4095 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862113004 Review URL: https://codereview.chromium.org/1862113004
* Style bikeshed - remove extraneous whitespaceGravatar halcanary2016-03-29
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002 Review URL: https://codereview.chromium.org/1842753002
* initialize offscreen in StrokeZeroGMGravatar mtklein2015-12-28
| | | | | | | | | | | Valgrind's complaining that we're drawing uninitialized source pixels from that offscreen via drawBitmap(): https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/736/steps/dm/logs/stdio BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1546363002 Review URL: https://codereview.chromium.org/1546363002
* This brings hairlines into agreement with thick strokes.Gravatar caryclark2015-12-16
| | | | | | | | | | Add more testing and a pixel magnification to GM. R=reed@google.com, fmalita@chromium.org BUG=skia:4599 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1527083002 Review URL: https://codereview.chromium.org/1527083002
* SkPDF: when drawing stroked path, draw using SVG rules for zero-length segmentsGravatar halcanary2015-10-06
The "zeroPath" and emptystroke GMs capture this issue. This CL changes the following PDF GMs: emptystroke dashing4 lineclosepath dashing3 zeroPath linepath complexclip3_complex complexclip3_simple roundrects degeneratesegments filltypes strokerect pathfill inverse_paths desk_chalkboard.skp After this change, all PDF GMs look better (closer to 8888). The dashing4, emptystroke, and zeroPath GMs still need a lot of work to make them look right. BUG=538726 Review URL: https://codereview.chromium.org/1374383004