aboutsummaryrefslogtreecommitdiffhomepage
path: root/gm/gm_expectations.h
Commit message (Collapse)AuthorAge
* Delete dead code. SkBitmapHasher has not been used since gm.Gravatar mtklein2016-02-16
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704783002 Review URL: https://codereview.chromium.org/1704783002
* Style Change: NULL->nullptrGravatar halcanary2015-08-27
| | | | | | DOCS_PREVIEW= https://skia.org/?cl=1316233002 Review URL: https://codereview.chromium.org/1316233002
* remove SkInstCntGravatar mtklein2015-06-26
| | | | | | | | | | | | | | It's been outclassed by Valgrind and leak sanitizer, and it seems to be causing problems for external folks building Skia. I'm not sure why our own builds seem unaffected. Latest thread: https://groups.google.com/forum/#!topic/skia-discuss/oj9FsQwwSF0 BUG=skia: Review URL: https://codereview.chromium.org/1217573002
* C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}Gravatar mtklein2015-03-25
| | | | | | | | | NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
* In Android framework, make tools depend on jsoncppGravatar scroggo2014-06-18
| | | | | | | | | | | | | | | | | | Always build the tools with JSON, but either build our own or use the system's. Rename skia_build_json_writer to skia_use_system_jsoncpp, since we now always build with JSON. Remove SK_BUILD_JSON_WRITER, which was only there so we could build without JSON it in the framework. BUG=skia:2448 R=djsollen@google.com, reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/303913002
* replace config() with colorType()Gravatar commit-bot@chromium.org2014-05-29
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/303543009 git-svn-id: http://skia.googlecode.com/svn/trunk@14959 2bbb7eff-a529-9590-31e7-b0007b416f81
* Generate gm/Android.mk, minus JSON.Gravatar commit-bot@chromium.org2014-05-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running gyp_to_android.py, generate the makefile for gm. For now, remove json functionality and do not depend on json. This allows us to build and run until solving skbug.com/2448. gm/gm_expectations.cpp: gm/gm_expectations.h: gm/gmmain.cpp: Remove all json functionality when SK_BUILD_JSON_WRITER is not defined. This flag is not defined when SK_BUILD_FOR_ANDROID is defined. gyp/gm.gyp: Depend on skia and cutils. platform_tools/android/bin/gyp_to_android.py: Generate gm/Android.mk. platform_tools/android/gyp_gen/makefile_writer.py: Build gm/Android.mk when building external/skia. Depends on https://codereview.chromium.org/282053002/ BUG=skia:2447 BUG=skia:2448 R=epoger@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/281303003 git-svn-id: http://skia.googlecode.com/svn/trunk@14767 2bbb7eff-a529-9590-31e7-b0007b416f81
* reland "extract some common code from PictureRenderer"Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | re-lands https://codereview.chromium.org/273703006/ NOTRY=True R=bungeman@google.com, djsollen@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/278633002 git-svn-id: http://skia.googlecode.com/svn/trunk@14662 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of extract some common code from PictureRenderer ↵Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/273703006/) Reason for revert: breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue. Original issue's description: > extract some common code from PictureRenderer > > Committed: http://code.google.com/p/skia/source/detail?r=14638 R=borenet@google.com, epoger@google.com TBR=borenet@google.com, epoger@google.com NOTREECHECKS=true NOTRY=true Author: djsollen@google.com Review URL: https://codereview.chromium.org/274463004 git-svn-id: http://skia.googlecode.com/svn/trunk@14649 2bbb7eff-a529-9590-31e7-b0007b416f81
* extract some common code from PictureRendererGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/273703006 git-svn-id: http://skia.googlecode.com/svn/trunk@14638 2bbb7eff-a529-9590-31e7-b0007b416f81
* replace gm_fprintf() calls with SkDebugf()Gravatar commit-bot@chromium.org2014-02-27
| | | | | | | | | | | BUG=skia:1221 R=bsalomon@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/181933002 git-svn-id: http://skia.googlecode.com/svn/trunk@13613 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add JSON output option to bench.Gravatar commit-bot@chromium.org2013-12-03
| | | | | | | | | | | | | | | | | | | | A new command-line flag --outResultsFile takes the filename to write the JSON into. The human readable output is the same as before with one exception. Previously DEBUG would be printed if in debug mode, or nothing would be printed if in release mode. Now this is reported as a named option: build=DEBUG or build=RELEASE R=djsollen@google.com, bsalomon@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/83863002 git-svn-id: http://skia.googlecode.com/svn/trunk@12465 2bbb7eff-a529-9590-31e7-b0007b416f81
* More work to integrate skimage with rebaseline tools.Gravatar scroggo@google.com2013-10-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tools/skimage_main.cpp: Add the ability to write the results to checksum based filenames, much like GM uses. This will allow using the skpdiff server to rebaseline images. Write the keys in the JSON file as <original image>_<pref config>.png, so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with '-' in the original file name, to avoid confusing the pattern matcher. The '_' to '-' replacement also happens on the output filename. Read the keys in a similar manner. In make_outname, no longer remove a suffix. This fixes a bug where subset decoding writes multiple subsets to the same file. tools/rebaseline.py: Since the filenames written to json files now match gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based on configs/tests when rebaselining skimage. test json files: Update to match the new format of output. gm/gm_expectations: Add a constructor that takes a BitmapAndDigest as input. tools/tests/skimage_self_test.py: Test that reading the expectations file just created by skimage with the same file actually compares to the original file (rather than just succeeding because expectations were missing). Change the expectations files to match the new format. Will require a buildbot change to use the new flag: https://codereview.chromium.org/27389002/ BUG=1466 R=epoger@google.com Review URL: https://codereview.chromium.org/26297004 git-svn-id: http://skia.googlecode.com/svn/trunk@11902 2bbb7eff-a529-9590-31e7-b0007b416f81
* Spin off incidental changes from DM CL (22839016).Gravatar commit-bot@chromium.org2013-10-14
| | | | | | | | | | | BUG= R=epoger@google.com, bsalomon@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/27023004 git-svn-id: http://skia.googlecode.com/svn/trunk@11752 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm: add --ignoreTests flagGravatar epoger@google.com2013-09-19
| | | | | | | | | BUG=skia:1600 R=scroggo@google.com Review URL: https://codereview.chromium.org/23526065 git-svn-id: http://skia.googlecode.com/svn/trunk@11374 2bbb7eff-a529-9590-31e7-b0007b416f81
* The two leaks are:Gravatar commit-bot@chromium.org2013-07-11
| | | | | | | | | | | | | | | missing unrefs in megalooper GM missing reset capability in oval renderer This CL also expands the instance counting system to some recently adding classes (e.g., SkFontStyleSet) R=bsalomon@google.com, jvanverth@google.com Author: robertphillips@google.com Review URL: https://chromiumcodereview.appspot.com/18461007 git-svn-id: http://skia.googlecode.com/svn/trunk@10030 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reland r9682, using new SkString::appendU64()Gravatar epoger@google.com2013-06-19
| | | | | | Review URL: https://codereview.chromium.org/17157005 git-svn-id: http://skia.googlecode.com/svn/trunk@9687 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r9682, which broke on some compilersGravatar epoger@google.com2013-06-19
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@9684 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: add --writeChecksumBasedFilenames option Gravatar epoger@google.com2013-06-19
| | | | | | | | | | | as needed for Step 2 of https://goto.google.com/ChecksumTransitionDetail : make GenerateGMs upload actual images to Google Storage instead of skia-autogen R=scroggo@google.com Review URL: https://codereview.chromium.org/17365002 git-svn-id: http://skia.googlecode.com/svn/trunk@9682 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reland 'Add path utils, plus a test for it.'Gravatar scroggo@google.com2013-05-28
| | | | | | | | | | | | | | | Build SkPathJoin and SkBasename on windows also. Previous CL did not build on Windows because the two functions were accidentally placed inside an ifdef that did not include windows. Move the functions to the top of the file, and add a comment by the endif for clarity. Previously reviewed at https://codereview.chromium.org/15747004/ Review URL: https://codereview.chromium.org/15740024 git-svn-id: http://skia.googlecode.com/svn/trunk@9295 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Add path utils, plus a test for it."Gravatar scroggo@google.com2013-05-24
| | | | | | | | | | This reverts commit d172374b46cae0bd5d7c024b9848f5bdafcc6a16. This CL broke on Windows. Review URL: https://codereview.chromium.org/15986004 git-svn-id: http://skia.googlecode.com/svn/trunk@9278 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add path utils, plus a test for it.Gravatar scroggo@google.com2013-05-24
| | | | | | | | | | | | | | | | | | | | | | | | SkOSFile: Added class SkOSPath with functions for modifying strings representing path names. OSPathTest.cpp: Test of the new utilities. factory.cpp: Use SkPathJoin. gmmain and gm_expectations: Use SkOSPath::SkPathJoin instead of a local version. skimage_main.cpp: Use the new location of SkPathJoin and SkBasename. R=epoger@google.com Review URL: https://codereview.chromium.org/15747004 git-svn-id: http://skia.googlecode.com/svn/trunk@9277 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") ↵Gravatar epoger@google.com2013-05-24
| | | | | | | | | | and value (12345) R=scroggo@google.com Review URL: https://codereview.chromium.org/15883004 git-svn-id: http://skia.googlecode.com/svn/trunk@9271 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: make behavior of make_filename() more late-bindingGravatar epoger@google.com2013-05-21
| | | | | | | | | | | This will be needed to add the option of writing out files with checksum-based filenames. R=scroggo@google.com Review URL: https://codereview.chromium.org/15415003 git-svn-id: http://skia.googlecode.com/svn/trunk@9215 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: include filename extension (.png) of each output file in JSON summaryGravatar epoger@google.com2013-05-14
| | | | | | | | | | | | Doing this so that, once we *do* start writing PDF checksums into the JSON summary, we'll be able to distinguish those from the PNG checksums. Otherwise, we could have naming collisions. R=scroggo@google.com Review URL: https://codereview.chromium.org/14890017 git-svn-id: http://skia.googlecode.com/svn/trunk@9119 2bbb7eff-a529-9590-31e7-b0007b416f81
* Write/compare against expectations in skimage tool.Gravatar scroggo@google.com2013-05-08
| | | | | | | | | | | | | | | | | | | | | skimage: Add two new modes: one to write expectations to a json file, and another to compare results against expectations. Use SkPATH_SEPARATOR instead of '/'. gm_expectations: Split into a static library so it can be used by skimage. Make functions non static and move function definitions into source file. Capitalize static member functions to follow the coding style guidelines. BUG=https://code.google.com/p/skia/issues/detail?id=1241 R=epoger@google.com Review URL: https://codereview.chromium.org/14670021 git-svn-id: http://skia.googlecode.com/svn/trunk@9069 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: now that we use MD5 instead of CityHash, the JSON should say soGravatar epoger@google.com2013-05-07
| | | | | | | | | | (this should have been part of https://code.google.com/p/skia/source/detail?r=8992 ) R=bungeman@google.com Review URL: https://codereview.chromium.org/14758003 git-svn-id: http://skia.googlecode.com/svn/trunk@9038 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: specify that currently used checksums are CityHashes of SkBitmapsGravatar epoger@google.com2013-04-26
| | | | | | | | | (distinct from other hash algorithms we may switch to, or hashes of files such as PDFs that cannot be read into an SkBitmap) Review URL: https://codereview.chromium.org/14284018 git-svn-id: http://skia.googlecode.com/svn/trunk@8877 2bbb7eff-a529-9590-31e7-b0007b416f81
* rename SkBitmapChecksummer as SkBitmapHasher, and prepare for it to possibly useGravatar epoger@google.com2013-04-12
| | | | | | | some algorithm other than CityHash Review URL: https://codereview.chromium.org/14170010 git-svn-id: http://skia.googlecode.com/svn/trunk@8639 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: remove enableMissingWarning in favor of verbose flag, and trim output in ↵Gravatar epoger@google.com2013-04-10
| | | | | | | | nonverbose mode Review URL: https://codereview.chromium.org/14080003 git-svn-id: http://skia.googlecode.com/svn/trunk@8600 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm: write all messages to stdout/stderr with "GM:" preamble to distinguish ↵Gravatar epoger@google.com2013-03-13
| | | | | | | | from various debug messages coming from elsewhere Review URL: https://codereview.chromium.org/12691009 git-svn-id: http://skia.googlecode.com/svn/trunk@8126 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm: Add ability to compare against checksums (as opposed to image files)Gravatar epoger@google.com2013-02-13
| | | | | | Review URL: https://codereview.appspot.com/7306071 git-svn-id: http://skia.googlecode.com/svn/trunk@7724 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm: report max-pixel-error if comparing against PNG files (not checksums)Gravatar epoger@google.com2013-02-01
| | | | | | Review URL: https://codereview.appspot.com/7241064 git-svn-id: http://skia.googlecode.com/svn/trunk@7526 2bbb7eff-a529-9590-31e7-b0007b416f81
* re-land r7258 with fixes and testsGravatar epoger@google.com2013-01-19
| | | | | | | | BUG=http://code.google.com/p/skia/issues/detail?id=1079 TBR=reed Review URL: https://codereview.appspot.com/7132060 git-svn-id: http://skia.googlecode.com/svn/trunk@7291 2bbb7eff-a529-9590-31e7-b0007b416f81
* Roll out r7258Gravatar epoger@google.com2013-01-18
| | | | | | | | BUG=http://code.google.com/p/skia/issues/detail?id=1079 TBR=robertphillips Review URL: https://codereview.appspot.com/7138065 git-svn-id: http://skia.googlecode.com/svn/trunk@7289 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reapply r7198 with Mac/Windows fixesGravatar epoger@google.com2013-01-17
| | | | | | | BUG=https://code.google.com/p/skia/issues/detail?id=1067 Review URL: https://codereview.appspot.com/7138056 git-svn-id: http://skia.googlecode.com/svn/trunk@7258 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert r7198 until I can fix ↵Gravatar epoger@google.com2013-01-15
| | | | | | | | https://code.google.com/p/skia/issues/detail?id=1067 Review URL: https://codereview.appspot.com/7124043 git-svn-id: http://skia.googlecode.com/svn/trunk@7203 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm: use new Expectations struct instead of comparison bitmapsGravatar epoger@google.com2013-01-15
Review URL: https://codereview.appspot.com/7088044 git-svn-id: http://skia.googlecode.com/svn/trunk@7198 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-29 12:42:55 +0000