aboutsummaryrefslogtreecommitdiffhomepage
path: root/gm/circulararcs.cpp
Commit message (Collapse)AuthorAge
* Replace a lot of 'static const' with 'constexpr' or 'const'.Gravatar mtklein2016-09-01
| | | | | | | | | | | | | | | | | | | | | | | 'static const' means, there must be at most one of these, and initialize it at compile time if possible or runtime if necessary. This leads to unexpected code execution, and TSAN* will complain about races on the guard variables. Generally 'constexpr' or 'const' are better choices. Neither can cause races: they're either intialized at compile time (constexpr) or intialized each time independently (const). This CL prefers constexpr where possible, and uses const where not. It even prefers constexpr over const where they don't make a difference... I want to have lots of examples of constexpr for people to see and mimic. The scoped-to-class static has nothing to do with any of this, and is not changed. * Not yet on the bots, which use an older TSAN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005 Review-Url: https://codereview.chromium.org/2300623005
* avoid generating degenerate conic from arcGravatar caryclark2016-08-26
| | | | | | | | R=bsalomon@google.com BUG=skia:5672 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281953002 Review-Url: https://codereview.chromium.org/2281953002
* Respecify SkCanvas::drawArc, consolidate conversion to SkPath, add GM for ↵Gravatar bsalomon2016-08-25
| | | | | | | | | | oddball drawArcs Allows the arc to wind more than 360 degrees when useCenter is true, specs that nothing draws if the oval is empty or the sweep angle is 0. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281653002 Review-Url: https://codereview.chromium.org/2281653002
* Add cap type variations to circular arcs GMsGravatar bsalomon2016-08-22
| | | | | | | BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2269723002 Review-Url: https://codereview.chromium.org/2269723002
* Add stroke-and-fill circular arc test, test near 180deg arc in all ↵Gravatar bsalomon2016-08-22
| | | | | | | | | circular_arc_tests BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261233002 Review-Url: https://codereview.chromium.org/2261233002
* Adjust angles in circular arcs GMs to test smaller arcsGravatar bsalomon2016-08-22
| | | | | | | BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267713002 Review-Url: https://codereview.chromium.org/2267713002
* Rename circular_arcs_circular_arcs_fill to circular_arcs_fill.Gravatar bsalomon2016-08-19
| | | | | | | | Also fix issue with second paint's alpha getting overwritten. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265643002 Review-Url: https://codereview.chromium.org/2265643002
* Add GMs for testing drawArc.Gravatar bsalomon2016-08-19
This is in preparation for virtualizing this on SkCanvas/SkDevice. Tests the following variations: aa and non-aa stroke/hairline/fill cap types using center point and not BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264593002 Review-Url: https://codereview.chromium.org/2264593002