| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
R=mtklein@google.com
Review URL: https://codereview.chromium.org/1180593005
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1173363011
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I originally thought that there was no harm in reading or skipping
zero lines after we have already reached the end of the image.
However, once we reach the end of the image, onFinish() is
automatically called. Performing a read or a skip after
the call to onFinish() is invalid and will cause onFinish()
to be called a second time (which is also invalid).
Seems like the code requires good behavior and the test is
wrong.
BUG=skia:
Review URL: https://codereview.chromium.org/1179213002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1175993005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This experiment replaces the label used in the aaxfermodes gm with
aliased text generated from paths common to all platforms.
Since there is no way today to generate all dm output from trybots,
this will be checked in to confirm that this strategy provides simpler
output across devices.
This does not introduce a new public interface; instead, dm uses
a extern backdoor to install the SkTypeface::CreateFromName
handler.
Review URL: https://codereview.chromium.org/1163283002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1158263004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1158963002
|
|
|
|
|
|
|
|
|
| |
kScanline_Subset_Mode decodes the image in subsets using a
scanline decoder.
The number of subsets can be specified by changing the constant divisor.
The number of subsets is equal to divisor*divisor.
Review URL: https://codereview.chromium.org/1157153003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1139413003
|
|
|
|
|
|
|
|
| |
Previously it was hard to tell that DrawFn took an SkCanvas* and returned an Error. Now it's clear from the type.
BUG=skia:
Review URL: https://codereview.chromium.org/1125233002
|
|
|
|
|
|
|
|
|
| |
If so, let's do it this way so it works for all source types and doesn't need
to be chosen at compile time.
BUG=skia:
Review URL: https://codereview.chromium.org/1129693003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1117183007
|
|
|
|
|
|
|
|
|
|
| |
Will use this to test the other CL that adds small SkPicture implementations.
Not quite sure why patch_primitive doesn't draw the same in 8888 and sp-8888, but everything else does, so I'm not going to let that hold me back for now.
BUG=skia:
Review URL: https://codereview.chromium.org/1126613005
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1123743007
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1113273006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out/Debug/dm:
( 360/380 MB 2112) 396ms gpu gm xfermodes
out/Release/nanobench:
32/33 MB 1659 2.46µs 2.55µs 2.54µs 2.67µs 2% ▄▄▄▅▅▃▂▁▂█ gpu gradient_conicalZero_clamp_hicolor
out/Debug/nanobench:
42/42 MB desk_css3gradients.skp_1 8888
BUG=skia:
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1115203002
|
|
|
|
|
|
|
|
| |
as we do with getPixels().
BUG=skia:3722
Review URL: https://codereview.chromium.org/1061713007
|
|
|
|
|
|
|
|
|
|
| |
E.g. out/Debug/dm --shards 4 --shard 1
This shards all inputs, GMs, SKPs, tests, etc.
BUG=skia:
Review URL: https://codereview.chromium.org/1109813002
|
|
|
|
|
|
|
|
|
|
|
| |
This requires we remove NVPR from the default set of configs, as we only find
out at runtime that it's not available. All the other defaults will either be
compiled in and supported, or not compiled in and non-fatally skipped as
unknown configs.
BUG=skia:
Review URL: https://codereview.chromium.org/1100773003
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables basic decoding for jpegs
Includes rewinding
565, YUV, and Jpeg encoding are not yet implemented
BUG=skia:3257
Review URL: https://codereview.chromium.org/1076923002
|
|
|
|
|
|
|
|
|
|
|
| |
Motivation: I want to switch back to single-page output by default for
direct comparison to raster backends in Gold.
I can still test the multi-page option via a command-line switch.
BUG=skia:3721
Review URL: https://codereview.chromium.org/1063873004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1072933004
|
|
|
|
|
|
|
|
| |
Disabling scanline decoding to kIndex8 until it can be implemented.
BUG=skia:3715
Review URL: https://codereview.chromium.org/1082923002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We may want to enable swizzles to 565
for images that are encoded in a format
similar to 565, however, we do not want
to take images that decode naturally to
kN32 and then convert them to 565.
***Enable swizzles to kIndex_8. For images
encoded in a color table format, we suggest
that they be decoded to kIndex_8. When we
decode, we only allow conversion to kIndex_8
if it matches the suggested color type (except
wbmp which seems good as is).
***Modify dm to test images that decode to
kIndex_8.
BUG=skia:3257
BUG=skia:3440
Review URL: https://codereview.chromium.org/1055743003
|
|
|
|
|
|
| |
BUG=skia:3676
Review URL: https://codereview.chromium.org/1067053002
|
|
|
|
|
|
|
|
| |
source_options isn't always present.
BUG=skia:
Review URL: https://codereview.chromium.org/1067863002
|
|
|
|
|
|
|
|
|
| |
I'm going to start hacking on SkCanvas a bit to allow a fast reset method,
and I want to have some testing checking me.
BUG=skia:
Review URL: https://codereview.chromium.org/1062043004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1063713002
|
|
|
|
|
|
|
|
|
| |
The file is expected to contain a list of strings. If the hash for
any result is in this file, don't write an image for it.
BUG=skia:3521
Review URL: https://codereview.chromium.org/1059363002
|
|
|
|
|
|
|
|
| |
but helps us not run off the end.
BUG=skia:
Review URL: https://codereview.chromium.org/1059243002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1059513002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1061493002
|
|
|
|
|
|
|
| |
BUG=skia:3600
DOCS_PREVIEW= https://skia.org/?cl=1036283002
Review URL: https://codereview.chromium.org/1036283002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/917943002
|
|
|
|
|
|
|
| |
BUG=skia:3257
BUG=skia:3534
Review URL: https://codereview.chromium.org/1022673011
|
|
|
|
|
|
|
|
| |
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/eed1dae04932483579b02c10f0706127d3f5d984
Review URL: https://codereview.chromium.org/1011403004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1011403004/)
Reason for revert:
Breaks a unit test on mac
Original issue's description:
> BitmapTextBatch and BitmapTextBlob
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/eed1dae04932483579b02c10f0706127d3f5d984
TBR=fmalita@chromium.org,reed@google.com,jvanverth@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@chromium.org,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1050633002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1011403004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Duplicate code from the HWUI backends for DM and nanobench
moves into a single place, saving a hundred lines or more of
cut-and-paste.
There's some indication that this increases the incidence of
SkCanvas "Unable to find device for layer." warnings, but no
clear degradation in test results.
R=djsollen@google.com,mtklein@google.com
BUG=skia:3589
Review URL: https://codereview.chromium.org/1036303002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1006583005
|
|
|
|
|
|
|
|
|
| |
NOPRESUBMIT=true
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002
Review URL: https://codereview.chromium.org/1037793002
|
|
|
|
|
|
| |
BUG=skia:3475
Review URL: https://codereview.chromium.org/999173010
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
@sugoi:
Early out to avoid some segfaults in SkImageDecoder_libjpeg.cpp.
I am just flailing here... things seem to work, but I have no idea why.
This prints out a lot:
libjpeg error 85 <End Of Image> from output_raw_data [0 0]
@halcanary:
I'm skipping on ImageSrc for now. Leon's refactoring that quite a lot.
This causes minor diffs for the GPU backend, given that we're now
going through the YUV path. It also reduced peak RAM usage on
my desktop from 1.26GB to 1.08GB.
BUG=skia:
Review URL: https://codereview.chromium.org/1010983004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1037713003
|
|
|
|
|
|
|
|
| |
BUG=skia:3257
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1011343003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#10 id:280001 of https://codereview.chromium.org/1011343003/)
Reason for revert:
Reverting on suspicion of massive bot failures - possible command line too long?
Original issue's description:
> Enabling ico decoding with use of png and bmp decoders
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97
TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257
Review URL: https://codereview.chromium.org/1022843005
|
|
|
|
|
|
|
|
|
| |
Use (better) paint filter shared with nanobench, instead
of custom implementation.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/1036523002
|
|
|
|
|
|
| |
BUG=skia:3257
Review URL: https://codereview.chromium.org/1011343003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- By default, use new SkGoodHash to hash keys, which is:
* for 4 byte values, use SkChecksum::Mix,
* for SkStrings, use SkChecksum::Murmur3 on the data,
* for other structs, shallow hash the struct with Murmur3.
- Expand SkChecksum::Murmur3 to support non-4-byte-aligned data.
- Add const foreach() methods.
- Have foreach() take a functor, which allows lambdas.
BUG=skia:
Review URL: https://codereview.chromium.org/1021033002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1017293002
|