aboutsummaryrefslogtreecommitdiffhomepage
path: root/BUILD.gn
Commit message (Collapse)AuthorAge
* GN/Win: Vulkan support, convert -Vulkan bots.Gravatar Mike Klein2016-10-14
| | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86_64-Release-Vulkan-Trybot;master.client.skia:Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan-Trybot,Perf-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Release-Vulkan-Trybot,Perf-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3421 Change-Id: I7012719fff66778488589ab9c15fd2fa2a109cd1 Reviewed-on: https://skia-review.googlesource.com/3421 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Move skdiff tool and add to gn build.Gravatar bungeman2016-10-14
| | | | | | | | | I really wanted this today, so I got it working again. Change-Id: I1a37d48d4806198b55c59d1df5ff15a03500195f Reviewed-on: https://skia-review.googlesource.com/3383 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* GN/Win: hook in GPU supportGravatar Mike Klein2016-10-13
| | | | | | | | | | | | Just a simple oversight... this should make Ganesh work. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3382 Change-Id: I90353732a137d004b884cea75f1bd722ede24888 Reviewed-on: https://skia-review.googlesource.com/3382 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN/Win: suppport GDI, convert GDI bots to build with GN.Gravatar Mike Klein2016-10-13
| | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-GDI-Trybot,Build-Win-MSVC-x86-Release-GDI-Trybot;master.client.skia:Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3324 Change-Id: I3ff2f5d16de9fff7ed77fa5127b96bef55bef957 Reviewed-on: https://skia-review.googlesource.com/3324 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* NDK Clang can build hb-icu.cc for mipsel now.Gravatar Mike Klein2016-10-12
| | | | | | | | | | | | | I haven't explicitly confirmed this, but it's likely that today's r12b -> r13 upgrade made this possible. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-mipsel-Debug-GN_Android-Trybot,Build-Ubuntu-Clang-mipsel-Release-GN_Android-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3241 Change-Id: I4d19ad48f387d48e0fa4a9f1637c67eb6e1ba4ae Reviewed-on: https://skia-review.googlesource.com/3241 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN/Win: everything but skiaserve links.Gravatar Mike Klein2016-10-11
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3240 Change-Id: I85c306f89f3a7faa7f50dadf465122844d015604 Reviewed-on: https://skia-review.googlesource.com/3240 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN/Windows: fiddle links and runsGravatar Mike Klein2016-10-11
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3220 Change-Id: Ia8a47d4304a6b8e73b5ef068da9a5ac218ef3f72 Reviewed-on: https://skia-review.googlesource.com/3220 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* More steps toward GN/Windows.Gravatar Mike Klein2016-10-11
| | | | | | | | | | | I think I'm now at the point of needing to just resolve missing symbols. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3201 Change-Id: Ib908bd72c23f2d4bafd17182eedcb2fc85c422e5 Reviewed-on: https://skia-review.googlesource.com/3201 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN: build dump_recordGravatar Mike Klein2016-10-10
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3021 Change-Id: I447ef9a880e5b13103bac76d41e176c7940c8512 Reviewed-on: https://skia-review.googlesource.com/3021 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add fuzz executable to GNGravatar kjlubick2016-10-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389853002 Review-Url: https://codereview.chromium.org/2389853002
* Add gn option to set the location of the Vulkan SDKGravatar Brian Salomon2016-09-30
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2848 Change-Id: I0b60ae03d7b155d4f9a581cab6b551e152b03a86 Reviewed-on: https://skia-review.googlesource.com/2848 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add an SkOpts target for Haswell+ Intel chips.Gravatar Mike Klein2016-09-30
| | | | | | | | | | | | | | | | Haswell brought a whole slew of handy new instructions for us (AVX2, FMA, BMI1+BMI2) and also feature F16C, which came one generation earlier on Ivybridge. We work with integers often enough that we really want to target AVX2 instead of AVX, and this means it's pretty practical to ask for all those other goodies along with it. Chrome's GN files and Google3's BUILD file will need an update, before or after this CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2840 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Change-Id: I826daf77b5104664c5d31ddaabee347e287b87a2 Reviewed-on: https://skia-review.googlesource.com/2840 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Implement 'action' in gn_to_cmake.py.Gravatar Ben Wagner2016-09-30
| | | | | | | | | | | With this change it is possible to build all Skia targets. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2784 Change-Id: I5c53a6ba5746d210e0ae8f7a29b409d40c7b9bff Reviewed-on: https://skia-review.googlesource.com/2784 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Hide monobench target on debug builds.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | Unlike nanobench this tool has no purpose when built in Debug mode. Just don't let it happen. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2718 Change-Id: Iaa7b8c44d46024485d4f5ce3d9c3e33d865b99d7 Reviewed-on: https://skia-review.googlesource.com/2718 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make SkPMColor BGRA on Fuchsia.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2700 Change-Id: I59b8463adcf3d49af524fec379e3b563dcbcbf6b Reviewed-on: https://skia-review.googlesource.com/2700 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* GN: ANGLEGravatar mtklein2016-09-23
| | | | | | | | | | | | | | | | Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gl --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 Review-Url: https://codereview.chromium.org/2361983002
* GN: build skiaserveGravatar mtklein2016-09-22
| | | | | | | | | | | | | | | | | I trimmed the libmicrohttpd sources and defines down to the minimum needed to build and run. This builds and runs on Linux and Android for me. Request.h was missing an include for SkTypes.h, which supplies the default for SK_GPU_SUPPORTED if not otherwise defined. To build on Android, exit() -> _exit(). build.py was unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2367513002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2367513002
* GN: take over CommandBuffer botGravatar mtklein2016-09-21
| | | | | | | | | | As you suspected, I see nothing preventing us from building our side of things unconditionally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2358173002
* Build tools on NoGPU bots.Gravatar mtklein2016-09-21
| | | | | | | | | | | | | | | I was just lazy disabling this before. It turns out to not be difficult. This gets us slightly better testing out of the NoGPU bot, as we now know not only that Skia compiles, but also that DM and nanobench can link (and thus that Skia's got enough compiled in it to be a coherent library). skpbench requires GPU support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356283002 Review-Url: https://codereview.chromium.org/2356283002
* GN: is_skia_standaloneGravatar mtklein2016-09-21
| | | | | | | | | | | | is_skia_standalone will be defined and set to true iff we're using our standalone BUILDCONFIG.gn. Any other build (Fuchsia, Chrome, Pdfium) will have their own BUILDCONFIG.gn, which presumably does not define is_skia_standalone. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357963002 Review-Url: https://codereview.chromium.org/2357963002
* Add define of SK_ENABLE_VK_LAYERS to gn buildGravatar egdaniel2016-09-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357953002 Review-Url: https://codereview.chromium.org/2357953002
* GN: fold :vulkan into :gpu.Gravatar mtklein2016-09-20
| | | | | | | | | | | Obviously, :vulkan can't be used without :gpu, but more subtly, :gpu needs to see SK_VULKAN defined if we're using Vulkan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352923003 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2352923003
* GN: add skia_use_mesa for OSMesa in tools.Gravatar mtklein2016-09-20
| | | | | | | | | | | | I tested by running $ out/dm --src gm --config mesa $ out/nanobench --config mesa --match Xfermode ... but I ran out of patience waiting for nanobench to finish. Probably works. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357703002 Review-Url: https://codereview.chromium.org/2357703002
* GN: add skia_enable_gpu (default true)Gravatar mtklein2016-09-20
| | | | | | | | | | | This lets us replace the NoGPU bot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356853002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2356853002
* skia_enable_android_framework_defines in all code, public and private, ↵Gravatar mtklein2016-09-20
| | | | | | | | | | | | | | | optional and required. The bug fixed here can be demonstrated by $ ninja -C out pdf -v before and after this CL. Before you won't see the Android defines, afterwards you do. Previously the defines applied only privately to Skia, and only to its non-optional components. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356783002 Review-Url: https://codereview.chromium.org/2356783002
* Split SkFontConfigInterface globals and factory.Gravatar bungeman2016-09-19
| | | | | | | | | | Chromium needs to be able to set up their build such that the globals continue existing but the SkFontMgr::Factory can be defined separately. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346333002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/2346333002
* skpbenchGravatar csmartdalton2016-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | skpbench is a benchmarking suite for skps that aims to generate 100% repeatable results. The initial commit consists of three parts: skpbench A minimalist program whose sole purpose is to open an skp file, benchmark it on a single config, and exit. No tiling, looping, or other fanciness is used; it just draws the skp whole into a size- matched render target and syncs the GPU after each draw. Limiting the entire process to a single config/skp pair helps to keep the results repeatable. skpbench.py A wrapper to execute the skpbench binary with various configs and skps. It also monitors the output in order to filter out and re-run results with an unacceptable stddev. In the future this script will lock down and monitor clocks and temperatures. parseskpbench.py A utility for parsing skpbench output into a spreadsheet. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341823002 Review-Url: https://codereview.chromium.org/2341823002
* format GN files, and invert if->config to config->ifGravatar mtklein2016-09-16
| | | | | | | | | | | Both if (...) { config ... } else { config ... } and config { if (...) { ...} else { ... } } work. We just happen to do the if inside the config more often than the other way around. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347953002 Review-Url: https://codereview.chromium.org/2347953002
* Compile the skia library for windows using gn.Gravatar herb2016-09-16
| | | | | | | | TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002 Review-Url: https://codereview.chromium.org/2347443002
* GN: build get_images_from_skps.Gravatar mtklein2016-09-16
| | | | | | | | | | This also splits :common_flags off of :flags. get_images_from_skps wants :flags but not :common_flags. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338173006 Review-Url: https://codereview.chromium.org/2338173006
* GN: add a flag to implement Android_FrameworkDefs bot.Gravatar mtklein2016-09-16
| | | | | | | | | | | This bot builds Skia with a bunch of defines to mimic the Android roll. Apparently it was supposed to be on the CQ... I'll add the GN version to it when it exists. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343103002 Review-Url: https://codereview.chromium.org/2343103002
* GN: enable Vulkan on Android when API >= 24.Gravatar mtklein2016-09-16
| | | | | | | | | | | Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'. If for some reason you wanted to turn it off, you can still override skia_use_vulkan. The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003 Review-Url: https://codereview.chromium.org/2347843003
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot Review-Url: https://codereview.chromium.org/2340463008
* Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of ↵Gravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2340463008/ ) Reason for revert: https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304 Original issue's description: > GN: support 32-bit x86 builds > > Take over Ubuntu -x86- bots. > > Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. > We'll want target_cpu="x86" there too. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 > > Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 TBR=jcgregorio@google.com,borenet@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2338173004
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Review-Url: https://codereview.chromium.org/2340463008
* GN: add is_official_buildGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | ... and use it to control debug symbols and SK_ALLOW_STATIC_GLOBAL_INITIALIZERS. This will most directly have the effect of disabling GLProgramsTest and a bunch of similar failing Vk tests on Android. Hopefully this makes the N7 trybot go green, keeping the N5 trybot green. Just running the N10 for fun. (is_official_build is how Chrome terms this sort of ReleaseForReal build.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340723003 Review-Url: https://codereview.chromium.org/2340723003
* Nanobench SVG supportGravatar fmalita2016-09-14
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339743002 Review-Url: https://codereview.chromium.org/2339743002
* GN: Android Vulkan supportGravatar mtklein2016-09-14
| | | | | | | | | | | | | | | | | | Android's the easiest place to start supporting Vulkan, so it's up first. ndk_api becomes user-specifiable so that the Vulkan bots can kick it up to 24, the first release supporting Vulkan. The defaults remain the same: 18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit. To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then $ ninja -C out dm; and droid out/dm --config vk --src gm Seems to work! Bot scripts to follow. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002 Review-Url: https://codereview.chromium.org/2336343002
* re-add SkDebug_stdio for Fuchsia buildsGravatar mikejurka2016-09-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2331383004 Review-Url: https://codereview.chromium.org/2331383004
* [SVGDom] Initial linear gradient supportGravatar fmalita2016-09-12
| | | | | | | | | | | | | | | Kind of a big change, to connect several new bits into something useful: * ID tracking & lookup * new asPaint() node virtual to support shader (and in the future filter) based paint servers * <defs>, <linearGradient> and <stop> element support * 'href', 'offset', 'stop-color', 'stop-opacity' attribute support * IRI/FuncIRI and rgb(...) parsing BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2327233003 Review-Url: https://codereview.chromium.org/2327233003
* Change shared_sources.gni to use relative pathGravatar mikejurka2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333923003 Review-Url: https://codereview.chromium.org/2333923003
* Alternate approach to turn on freetype in Fuchsia.Gravatar mtklein2016-09-12
| | | | | | | | | | | | | | | | | | | What do you think of this? It's basically what you wrote, factored differently. Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files via the :typeface_freetype target. Then we just pull out the SkFontMgr Fuchsia wants to use into its own little :fontmgr_fuchsia target. No major difference here, except the availability of freetype headers, etc, is a bit more tightly scoped to just those that need them. We (obviously?) don't have Fuchsia builders, so I've got to rely on you for sanity testing this. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002 Review-Url: https://codereview.chromium.org/2333913002
* SkPDF: SkShaper_primitive uses new textblob APIGravatar halcanary2016-09-10
| | | | | | | | | | This will enable me to test the new API in unit tests without depending on HarfBuzz (after https://crrev.com/2322403002 lands). TBR= BUG=skia:5434 Review-Url: https://codereview.chromium.org/2332473003
* GN: port a few missing Android bits from GYP.Gravatar mtklein2016-09-09
| | | | | | | | | | | | | The SK_GAMMA_ defines change text rendering on Android. This is how they're set in GYP for Android... everyone else is default (sRGB). Linking AndroidSkDebugToStdOut.o causes SkDebugf to go to both logcat and stdout on Android. Without it, it only goes to logcat. The file has no effect on non-Android platforms. BUG=skia: Review-Url: https://codereview.chromium.org/2323353002
* GN: fontmgr_customGravatar mtklein2016-09-07
| | | | | | | | | | | | | This makes skia_use_fontconfig=false build on Linux. Instead of using fontconfig it looks in /usr/share/fonts. That alone is a nice feature to have, but it's mostly relevant for MSAN, where we can't link against any uninstrumented system libraries. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318133003 Review-Url: https://codereview.chromium.org/2318133003
* Move Skia GN sources to a separate .gni file.Gravatar brettw2016-09-01
| | | | | | | | | | | | | | This file will be imported by Chrome to access the sources lists. Once Chrome is updated to use this file, changes to the skia .gypi layout can be done entirely within the skia repository as long as the resulting lists produced by the new .gni file have the same name. Marks skia_for_chromium_defines as obsolete and moves the definition into the new .gni file. We can remove the .gypi file when Chrome is updated. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803005 Review-Url: https://codereview.chromium.org/2302803005
* Build LSAN suppressions into the test binaries.Gravatar mtklein2016-09-01
| | | | | | | | | | | | | | | | | This way you don't need to set LSAN_SUPPRESSIONS in your environment... sort of foolproof this way. I _think_ the strdup() business from skia:2916 is actually rooted in libfontconfig, so one suppression should cover both old ones. I'll leave the file empty until I clean up mention of it in bot recipes. BUG=skia:2916 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2295153003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Review-Url: https://codereview.chromium.org/2295153003
* GN: add sources_when_disabled to optionalGravatar mtklein2016-08-31
| | | | | | | | | | | | | Also make sources_when_disabled and public_defines optional arguments. These are the two mechanisms code uses to turn itself off... probably at most one is ever used per optional. Update fiddle to not crash when there's no PDF backend. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292343003 Review-Url: https://codereview.chromium.org/2292343003
* clean up use of register storage classGravatar mtklein2016-08-30
| | | | | | | | | | | | | This fixes this warning-as-error, so we don't have to stifle it any more: error: 'register' storage class specifier is deprecated and incompatible with C++1z [-Werror,-Wdeprecated-register] Tested by building for mipsel via GN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289293002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2289293002
* GN: add skslGravatar mtklein2016-08-30
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2296803002 Review-Url: https://codereview.chromium.org/2296803002
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-27 15:47:48 +0000