aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Fix GPU explicit resource allocation bugGravatar Robert Phillips2018-07-25
| | | | | | | | | | | The explicit resource allocator assumes that it has complete control over the resources it hands out thus, they can have no pre-existing pending IO. Change-Id: I59d8d079d8b8514688c458a54424329b86922cb6 Reviewed-on: https://skia-review.googlesource.com/143300 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* refine NEON checks in raster pipelineGravatar Mike Klein2018-07-25
| | | | | | | | | | | | | | | | | This replaces most defined(__ARM_NEON) with defined(JUMPER_IS_NEON), which is defined(__ARM_NEON) && defined(__clang__). When compiled by Clang like our bots and primary users, this is a noop, but will avoid some of the NEON paths for compilers defining __ARM_NEON that are not Clang. Bug: skia:8178 Change-Id: Ifaea940c95b61d2fefadbd4e752cc477c571eafa Reviewed-on: https://skia-review.googlesource.com/143301 Commit-Queue: Herb Derby <herb@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Go back to cleaning up MIP levels on texture export rather than assuming dirtyGravatar Brian Salomon2018-07-25
| | | | | | | | | | | on texture import. Bug: skia:8155 Change-Id: I23399f442d52c73906829132f798eda260b6d4ae Reviewed-on: https://skia-review.googlesource.com/143291 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Reland "update SkToSRGBColorFilter color management"Gravatar Mike Klein2018-07-25
| | | | | | | | | | | | | | | | | This is a reland of 8b5092671b1d0802e88b5202f67ceb94c9e5d236 Original change's description: > update SkToSRGBColorFilter color management > > Change-Id: Ia4a8bbc9d983bb5cfa02ba62c922efa1fa879d9b > Reviewed-on: https://skia-review.googlesource.com/141054 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Reviewed-by: Brian Osman <brianosman@google.com> Change-Id: Ide55dd34a701a518be11856ecffbacf30954dc64 Reviewed-on: https://skia-review.googlesource.com/143321 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Roll third_party/externals/angle2 096c5296c3b0..2160821e16db (1 commits)Gravatar angle-skia-autoroll2018-07-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/096c5296c3b0..2160821e16db git log 096c5296c3b0..2160821e16db --date=short --no-merges --format='%ad %ae %s' 2018-07-25 jmadill@chromium.org Add gl::TexLevelArray. Created with: gclient setdep -r third_party/externals/angle2@2160821e16db The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=benjaminwagner@google.com Change-Id: Ie106e9f4bb344ab0ee9bf5e3fec5ae9b1ba153e9 Reviewed-on: https://skia-review.googlesource.com/143340 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* temporarily disable t8888 config on *SAN botsGravatar Mike Klein2018-07-25
| | | | | | | | | | | | | | | | This is mainly to debug TSAN issues. I'm not exactly sure why we run this config on ASAN and MSAN bots. This CL will disable them along with TSAN, and depending on how much time that saves on the bots, I might only turn TSAN back on in the end. Change-Id: Id4d92f27a917b4e14b96c25e97e8be70ca2004f5 Reviewed-on: https://skia-review.googlesource.com/143302 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert "Blacklist hanging test."Gravatar Ben Wagner2018-07-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e3e68cf14f6b202540717020e79fb53be4151c38. Reason for revert: The test was hanging due to https://skia-review.googlesource.com/c/skia/+/142102, which has been reverted. Original change's description: > Blacklist hanging test. > > Blacklist gr_mipmap_build_511x512 for nanobench on the Acer Chromebook > R13 Convertible to avoid timeouts for Release build. > > Bug: skia:8187 > No-Try: true > Change-Id: Ic63fb705a6a6cc6576978c96a8dd5206dc59ba0d > Reviewed-on: https://skia-review.googlesource.com/143162 > Commit-Queue: Brian Osman <brianosman@google.com> > Auto-Submit: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> TBR=benjaminwagner@google.com,brianosman@google.com Change-Id: Id5144f1ada6d2059e473a2891816775ea7fe2663 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:8187 Reviewed-on: https://skia-review.googlesource.com/143320 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Roll skia/third_party/skcms dad22fe0e646..4642d9fe69e1 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-07-25
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/dad22fe0e646..4642d9fe69e1 2018-07-25 benjaminwagner@google.com [infra] Adjust job priorities. (skcms) The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=benjaminwagner@google.com Change-Id: I80d5a79fdf660f07afa8966cc4c0f231dffe0b6b Reviewed-on: https://skia-review.googlesource.com/143280 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [infra] Adjust job priorities. (skia)Gravatar Ben Wagner2018-07-25
| | | | | | | | | | | | | | After https://skia-review.googlesource.com/c/buildbot/+/141564, scheduling will work better if most jobs use the default priority. Since task priority is now ignored, remove it everywhere. Bug: skia:8145 Change-Id: Ie49cfbbbda80c6d6419a8f691af6a3c775ae5cda Reviewed-on: https://skia-review.googlesource.com/143163 Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll third_party/externals/angle2 ddd6e8746851..096c5296c3b0 (10 commits)Gravatar angle-skia-autoroll2018-07-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ddd6e8746851..096c5296c3b0 git log ddd6e8746851..096c5296c3b0 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 jmadill@chromium.org Blit11: Refactor for error returning. 2018-07-25 jmadill@chromium.org TextureStorage11: Pass more Context around. 2018-07-25 jmadill@chromium.org TextureStorage11: Don't use gl::ErrorOrResult. 2018-07-25 jmadill@chromium.org D3D11: Don't use ErrorOrResult in TransformFeedback11. 2018-07-25 jmadill@chromium.org D3D: Make computeOffset not use ErrorOrResult. 2018-07-25 jmadill@chromium.org D3D11: Make createStagingTexture return Error. 2018-07-25 jmadill@chromium.org Buffer11: Don't use ErrorOrResult. 2018-07-24 theoking@google.com Vulkan: Check mInFlightCommands doesn't grow too fast 2018-07-24 geofflang@chromium.org EGL: Validate that EGL_GL_TEXTURE_ZOFFSET is used only for 3D sources. 2018-07-24 ynovikov@chromium.org Fix stencil mask check in Framebuffer::partialClearNeedsInit Created with: gclient setdep -r third_party/externals/angle2@096c5296c3b0 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=benjaminwagner@google.com Change-Id: I0cd0c5bffff5585ed74e2d585a0f6c0684c4d225 Reviewed-on: https://skia-review.googlesource.com/143200 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-24
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c201ea2c059e30b35d3b6514cb5febef659c4806 Add basic led module (martiniss@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I08c97872eca7943232a7da371ca428565f274945 Reviewed-on: https://skia-review.googlesource.com/143166 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Blacklist hanging test.Gravatar Ben Wagner2018-07-24
| | | | | | | | | | | | | Blacklist gr_mipmap_build_511x512 for nanobench on the Acer Chromebook R13 Convertible to avoid timeouts for Release build. Bug: skia:8187 No-Try: true Change-Id: Ic63fb705a6a6cc6576978c96a8dd5206dc59ba0d Reviewed-on: https://skia-review.googlesource.com/143162 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Roll third_party/externals/angle2 06235df9ff91..ddd6e8746851 (1 commits)Gravatar angle-skia-autoroll2018-07-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/06235df9ff91..ddd6e8746851 git log 06235df9ff91..ddd6e8746851 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 jmadill@chromium.org Vulkan: Suppress 3 failing blit tests on Pixel 2. Created with: gclient setdep -r third_party/externals/angle2@ddd6e8746851 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=benjaminwagner@google.com Change-Id: I41f559c0df5ebeb83a82a8aa733a1777ec37d83a Reviewed-on: https://skia-review.googlesource.com/143081 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-24
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/6ec6d27f2d1bd3d46eddaf469ee21cacc3e04999 [led] Update to f8fd394bd671f4cf4da8064a1ee074018c275d15. (iannucci@chromium.org) https://crrev.com/ca7d881540e391fc1b5aa44d08c08a67e0b1a797 Reland "Reland "gclient_scm: Use cherry-picking instead of rebasing."" (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic64eeb4ded47104f0432147cec0e59a317d47f59 Reviewed-on: https://skia-review.googlesource.com/143115 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* fixed geometry shaders when canUseFragCoord is falseGravatar Ethan Nicholas2018-07-24
| | | | | | | | Bug: chromium:859705 Change-Id: Ia5c5b15bd5d12bf2d1c3265664bec2c3eaef24d2 Reviewed-on: https://skia-review.googlesource.com/143114 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* handle failing pathop testsGravatar Cary Clark2018-07-24
| | | | | | | | | | | | | | | Some tests isolated from GrShapes_arcs do not fail gracefully, so make sure errors are properly handled. TBR=reed@google.com Bug: skia: Change-Id: Ia8c9903e64ef755ec11c398df3e5d258ca1f5f8b Reviewed-on: https://skia-review.googlesource.com/143112 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org>
* Revert "Reduce arbitrary opList splitting when sorting (take 2)"Gravatar Robert Phillips2018-07-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 20d4e546d8cb34f8944ef00d249416a047c95524. Reason for revert: Android dying on Nexus7 & Nexus Player Original change's description: > Reduce arbitrary opList splitting when sorting (take 2) > > The original CL (https://skia-review.googlesource.com/c/skia/+/141243 (Reduce arbitrary opList splitting when sorting)) was reverted due to Gold image diffs and perf regressions on Android. > > The image diffs should be fixed by: > https://skia-review.googlesource.com/c/skia/+/142163 (Fix explicit allocation bug) > > Change-Id: I4bcc59820daf440de81f48e8970b47a6c8ec2bbb > Reviewed-on: https://skia-review.googlesource.com/142102 > Commit-Queue: Robert Phillips <robertphillips@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,robertphillips@google.com Change-Id: Ice7ed703a17a1e1fef949446538c8da7524dc42e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/143121 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add Metal test bots.Gravatar Greg Daniel2018-07-24
| | | | | | | | | | Currently the test bot is set up with a whitelist that only runs one test. Bug: skia: Change-Id: Ief6a978a527cf581929cafe0f4cd002c35b24235 Reviewed-on: https://skia-review.googlesource.com/143107 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Revert "Revert "removed SkSLLayoutLexer""Gravatar Ethan Nicholas2018-07-24
| | | | | | | | | | This reverts commit 734b2a859784af0b16dbbe07570e6d2f5da34e76. Bug: skia: Change-Id: I1b8f49ab9d2ec1976f82f4feb70a8d0c5015b654 Reviewed-on: https://skia-review.googlesource.com/143109 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Reduce arbitrary opList splitting when sorting (take 2)Gravatar Robert Phillips2018-07-24
| | | | | | | | | | | | The original CL (https://skia-review.googlesource.com/c/skia/+/141243 (Reduce arbitrary opList splitting when sorting)) was reverted due to Gold image diffs and perf regressions on Android. The image diffs should be fixed by: https://skia-review.googlesource.com/c/skia/+/142163 (Fix explicit allocation bug) Change-Id: I4bcc59820daf440de81f48e8970b47a6c8ec2bbb Reviewed-on: https://skia-review.googlesource.com/142102 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Revert "removed SkSLLayoutLexer"Gravatar Ethan Nicholas2018-07-24
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 804f81786148cd3a4385d10ab7a31340fa47b10d. Reason for revert: breaking chrome roll: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940111858576531488/+/steps/compile__with_patch_/0/stdout Original change's description: > removed SkSLLayoutLexer > > Bug: skia: > Change-Id: Iad4c89fbde8bc1f6c3d022af9aec2ec5faa8a4ef > Reviewed-on: https://skia-review.googlesource.com/142583 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> TBR=mtklein@google.com,ethannicholas@google.com Change-Id: Ie07065ac43c5b8356665a7170adbe97ae8fd9f90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/143120 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Clean up bitmap pathGravatar Herb Derby2018-07-24
| | | | | | | Change-Id: If149194fd86f14bea289ad68262ea99cbbc398b6 Reviewed-on: https://skia-review.googlesource.com/142817 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add new vulkan headers to third_party/vulkan.Gravatar Greg Daniel2018-07-24
| | | | | | | | | | | | Currently these headers are not used, but this is just prep for a future change that will make skia build using these headers. The presubmit complains about the formating of these headers so I want to land them separate from the skia code that goes with them. Bug: skia: Change-Id: I97190f4af462a6b5391895ca941b3261a41615b5 Reviewed-on: https://skia-review.googlesource.com/143104 Reviewed-by: Robert Phillips <robertphillips@google.com>
* Some more SkPolyUtils optimizations and clean up.Gravatar Jim Van Verth2018-07-24
| | | | | | | | Bug: skia: Change-Id: I7c03d8fd9557102a95fa3e784ad1d0ca1ee89786 Reviewed-on: https://skia-review.googlesource.com/142328 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* removed SkSLLayoutLexerGravatar Ethan Nicholas2018-07-24
| | | | | | | | Bug: skia: Change-Id: Iad4c89fbde8bc1f6c3d022af9aec2ec5faa8a4ef Reviewed-on: https://skia-review.googlesource.com/142583 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Address fuzzer issueGravatar Robert Phillips2018-07-24
| | | | | | | | | TBR=egdaniel@google.com Bug: 866775 Change-Id: I6d1fa18c4abfad26bf137e491ca2f3ac6b3d7b03 Reviewed-on: https://skia-review.googlesource.com/143101 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* fix bookmaker botGravatar Cary Clark2018-07-24
| | | | | | | | | | | | | | | | | Drawing image subsets too many times causes fiddle to fail where it used to succeed. Reduce the number of draws for now to work around this. TBR=jcgregorio@google.com NOTRY=true Docs-Preview: https://skia.org/?cl=143100 Bug: skia:8180 Change-Id: I2610dc7575ed0e6eec1ee3c88e1f9ccc7b6a716e Reviewed-on: https://skia-review.googlesource.com/143100 Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Roll third_party/externals/angle2 522095f7d7fe..06235df9ff91 (1 commits)Gravatar angle-skia-autoroll2018-07-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/522095f7d7fe..06235df9ff91 git log 522095f7d7fe..06235df9ff91 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 oetuaho@nvidia.com Make HLSL shaders use only one main function Created with: gclient setdep -r third_party/externals/angle2@06235df9ff91 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=benjaminwagner@google.com Change-Id: I0ab3b5cfa110f113a746448b2a1a674c01f1d0cb Reviewed-on: https://skia-review.googlesource.com/143080 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 94c91a95358b..522095f7d7fe (6 commits)Gravatar angle-skia-autoroll2018-07-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/94c91a95358b..522095f7d7fe git log 94c91a95358b..522095f7d7fe --date=short --no-merges --format='%ad %ae %s' 2018-07-23 jmadill@chromium.org Rename "color" functions to "pixel" functions. 2018-07-23 jmadill@chromium.org Vulkan: Support inverted blit for depth/stencil. 2018-07-23 ynovikov@chromium.org Don't generate error for compressed texture formats in glFramebufferTexture2D 2018-07-23 jmadill@chromium.org Make PackPixels take an angle::Format. 2018-07-23 geofflang@chromium.org Pass Context to EGLImage creation and Display to EGLImage initialization. 2018-07-23 lfy@google.com GLES1: GL_OES_draw_texture Created with: gclient setdep -r third_party/externals/angle2@522095f7d7fe The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=benjaminwagner@google.com Change-Id: I024bc42ea7a9ac2d065d8bebbc0250849ed116d6 Reviewed-on: https://skia-review.googlesource.com/143000 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* added integration for non-moltenvk use of SkSLC MSL generatorGravatar Timothy Liang2018-07-23
| | | | | | | | Bug: skia: Change-Id: I4aa230fa25fccde0345b84384d9f7b1bb3045a73 Reviewed-on: https://skia-review.googlesource.com/142686 Commit-Queue: Timothy Liang <timliang@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Blacklist failing test for ANGLE IntelIris6100.Gravatar Ben Wagner2018-07-23
| | | | | | | | | | Bug: skia:7376 No-Try: true Change-Id: I0f79e6a1e07103769f3205f069b84e932c96bd64 Reviewed-on: https://skia-review.googlesource.com/142983 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* ccpr: Blacklist Bay Trail and Sandybridge on MesaGravatar Chris Dalton2018-07-23
| | | | | | | | Bug: skia:8162 Change-Id: I16d8b9a93151c9e568b5c27e6ad6c3cf5b717fe1 Reviewed-on: https://skia-review.googlesource.com/142940 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-23
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/9fa97b59b1c0f2ec1bb48f320f4c16e61fdb08e0 fix fetch on aix (jbarboza@ca.ibm.com) https://crrev.com/5ba1e9caeecb40a6ec7cc045e6850dbe65f79446 git cl: Start reporting metrics. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0282594fd2de671fc71feb12e667346c17476f42 Reviewed-on: https://skia-review.googlesource.com/142980 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Add continuous deploy for skottie and debugger.Gravatar Joe Gregorio2018-07-23
| | | | | | | | | Bug: skia: Change-Id: I90ad3445224a529f7b92951be9f43e37b4a063bd Reviewed-on: https://skia-review.googlesource.com/142891 Auto-Submit: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* implemented copy surface as blit for metal gpu backendGravatar Timothy Liang2018-07-23
| | | | | | | | Bug: skia: Change-Id: Ic59fe585c02168a361985f0864242b3c11e9d98e Reviewed-on: https://skia-review.googlesource.com/142684 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* Restrict radial step countGravatar Jim Van Verth2018-07-23
| | | | | | | | | | Bug: skia:8164 Change-Id: I180f3c097b76f89ce57b780eaf28fb3db2759831 Reviewed-on: https://skia-review.googlesource.com/142895 Commit-Queue: Jim Van Verth <jvanverth@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Jim Van Verth <jvanverth@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* fixed a bug with SPIR-V ternariesGravatar Ethan Nicholas2018-07-23
| | | | | | | | | | | | | | When both the true and false values are constants, we use OpSelect to choose between them instead of branching. However, it turns out that this fails when the values are vectors, because then OpSelect does componentwise selection and expects the input condition to be a vector as well. Bug: skia: Change-Id: Ia30aadc590ac1d1760c7df933595c2c867c472cd Reviewed-on: https://skia-review.googlesource.com/142885 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Reland "Reland "Add some optimizations to PolyUtils""Gravatar Jim Van Verth2018-07-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 946c37057f2618af7eda34fd6d2dd8625a9e9b61 Original change's description: > Reland "Add some optimizations to PolyUtils" > > This is a reland of 8bb0db3d07450880d346d808018708416c928657 > > Original change's description: > > Add some optimizations to PolyUtils > > > > * Switch inset/offset code to use a linked list rather than an array > > * Use std::set to store active edge list for IsSimplePolygon rather than array > > * Pre-alloc the priority queue for IsSimplePolygon > > * When adding radial curves, expand the array all at once rather than pushing > > one at a time. > > > > Bug: skia: > > Change-Id: I692f8c29c500c41ec1d1be39d924d8a752676bf4 > > Reviewed-on: https://skia-review.googlesource.com/140787 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Jim Van Verth <jvanverth@google.com> > > Bug: skia: > Change-Id: I3f5d42cfb941deab2b28bed020b37ce199e91d3d > Reviewed-on: https://skia-review.googlesource.com/142200 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> Bug: skia: Change-Id: I598d4be9108d009d0f885cfa72bf9197fc286b3a Reviewed-on: https://skia-review.googlesource.com/142920 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Roll third_party/externals/angle2 ba365939b90c..94c91a95358b (1 commits)Gravatar angle-skia-autoroll2018-07-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ba365939b90c..94c91a95358b git log ba365939b90c..94c91a95358b --date=short --no-merges --format='%ad %ae %s' 2018-07-23 oetuaho@nvidia.com Don't allow multiview clear during timer query Created with: gclient setdep -r third_party/externals/angle2@94c91a95358b The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=benjaminwagner@google.com Change-Id: I4accea95135ce7d38d8b5b62e56a69469c323567 Reviewed-on: https://skia-review.googlesource.com/142900 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* SkPDF: only draw text with SkglyphRunsGravatar Hal Canary2018-07-23
| | | | | | | Change-Id: I24e79c73a9c65a5d6a974bf52b0d0aee21be07db Reviewed-on: https://skia-review.googlesource.com/142695 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-23
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/356c288a106fc5724223fd807d8afd7ea4b448c2 [my_activity] Fix Filtering of Gerrit Reviews (jdoerrie@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia8dfbdbaa7a4582fbc42b751f4579ed0ff362d0a Reviewed-on: https://skia-review.googlesource.com/142883 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Update SKP versionGravatar skia-recreate-skps2018-07-22
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I953a03beccc45fc9ecac9c50fbd8900984c2f874 Reviewed-on: https://skia-review.googlesource.com/142864 Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
* Convert bitmap to use runs instead of blobsGravatar Herb Derby2018-07-21
| | | | | | | | | | | | Adding the flag SK_SUPPORT_LEGACY_TEXT_BLOB to allow progress without rebaselining many times. Flag landed with chrome cl 1144232. Change-Id: I78ea100085be7db442b703d465533ceb9b124652 Reviewed-on: https://skia-review.googlesource.com/142580 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Roll third_party/externals/angle2 d754eb5620ed..ba365939b90c (1 commits)Gravatar angle-skia-autoroll2018-07-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/d754eb5620ed..ba365939b90c git log d754eb5620ed..ba365939b90c --date=short --no-merges --format='%ad %ae %s' 2018-07-20 jmadill@chromium.org Rename angle::Format::ID to angle::FormatID. Created with: gclient setdep -r third_party/externals/angle2@ba365939b90c The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=bungeman@google.com Change-Id: Ie9c0331bbd3955fb081017da404632bb0e7b49f2 Reviewed-on: https://skia-review.googlesource.com/142709 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Blacklist failing SkRemoteGlyph tests on Vulkan NexusPlayer.Gravatar Greg Daniel2018-07-20
| | | | | | | | | Bug: skia:8166 Change-Id: I4b3553795f90e79520136354c7503d10daf68cc2 Reviewed-on: https://skia-review.googlesource.com/142813 Auto-Submit: Greg Daniel <egdaniel@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-20
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/60b9b6fb9147c8cd512c886bf3969ea114358a56 git_hyper_blame_test: Fix pylint issue. (ehmaldonado@chromium.org) https://crrev.com/7e3c67f2c3322f146e8e81fabb8d85dde1d04a3c presubmit_support: Fix parallel execution of presubmit tests. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I77eb3eb8c200d80716e35bf833314aa3172f25ad Reviewed-on: https://skia-review.googlesource.com/142811 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Vertex color xform benchGravatar Brian Osman2018-07-20
| | | | | | | | | | | | | | Measures two different strategies for dealing with color space transform of per-op colors. Assuming we already use vertex colors, is it better to transform them on the CPU, and use float4 color attributes, or transform them on the GPU, and use ubyte4 color attributes? So far, looks like ubyte4 w/GPU transform wins. Change-Id: If49d75303f669fe7f78af8771af906fa0e872577 Reviewed-on: https://skia-review.googlesource.com/142801 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-20
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077 pylint: reland upgrade to 1.5.6 (vapier@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1b50b702e3b700fb1116314335a6e9fe02b2a8a7 Reviewed-on: https://skia-review.googlesource.com/142808 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Re-add assert for mip maps.Gravatar Greg Daniel2018-07-20
| | | | | | | | Bug: skia: Change-Id: Iec418be2a02b046aa528df4b019be6e98bcdf320 Reviewed-on: https://skia-review.googlesource.com/142802 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-20
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d gclient: Report project url if it's a known project. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5798d4e16c01eb0a37f672655e0ee09a29d7b2ef Reviewed-on: https://skia-review.googlesource.com/142803 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-18 21:10:00 +0000