aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Update webpages_playback documentationGravatar kkinnunen2014-12-03
| | | | | | | Update the documentation on how to run webpages_playback. It was out of date. Review URL: https://codereview.chromium.org/778633002
* Remove Google Storage scheme prefix correctly from gs base name in ↵Gravatar kkinnunen2014-12-03
| | | | | | | | | | | | webpages_playback In python, str.lstrip([chars]) means "lstrip any of the chars from str", not "remove prefix". Thus "gs://skia".lstrip("gs://") yields "kia". Replace with custom function stripping the prefix from lstrip()ed gs base name. Review URL: https://codereview.chromium.org/780493002
* Make render_pdfs not crash webpages_playback scriptGravatar kkinnunen2014-12-03
| | | | | | | | | | | The render_pdfs nowadays seems to input the skps from the dir passed as '-r' parameter. The app will not output anything, but it will not crash the webpages_playback script either. Affects only runs that have --skia_tools=<dir> argument. Review URL: https://codereview.chromium.org/776873004
* Update SKP versionGravatar skia.buildbots2014-12-02
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/773113004
* Revert of rebaseline after clear change -- pdf was not treating clear as ↵Gravatar reed2014-12-02
| | | | | | | | | | | | | | | | | | | | | | | SRC_MODE (patchset #1 id:1 of https://codereview.chromium.org/759303004/) Reason for revert: reverted clear() change Original issue's description: > rebaseline after clear change -- pdf was not treating clear as SRC_MODE > > BUG=skia: > NOTRY=True > TBR= > > Committed: https://skia.googlesource.com/skia/+/2fb352abebc342a322d4a66c054bbff8bd565767 TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/774073002
* Revert "Change clear() to respect the clip"Gravatar reed2014-12-02
| | | | | | | | | This reverts commit 3729469d6a12266037b697c2192768545e097ab0. BUG=skia: TBR= Review URL: https://codereview.chromium.org/778563002
* Revert of implement device::clear until we can remove callers in chrome ↵Gravatar reed2014-12-02
| | | | | | | | | | | | | | | | | | | | | | skia/ext (patchset #1 id:1 of https://codereview.chromium.org/773903002/) Reason for revert: failing win unittests Original issue's description: > implement device::clear until we can remove callers in chrome skia/ext > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/252fccfb546efe83fb1d2c7a0b3c18a96ff46ea4 TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/774063002
* Add SSSE3 acceleration for S32_D16_filter_DXDYGravatar qiankun.miao2014-12-02
| | | | | | | | | | | With this CL, related nanobench can be improved for 565 config. bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x BUG=skia: Review URL: https://codereview.chromium.org/773753002
* Add matrix operations to C canvas APIGravatar abarth2014-12-02
| | | | | | | R=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/769123002
* work in progressGravatar halcanary2014-12-02
| | | | Review URL: https://codereview.chromium.org/769423002
* check matrix does not have rotation or perspective transformationGravatar derekf2014-12-02
| | | | | | | | | | | When checking whether we need apply AA to a rect for non-msaa target, simply checking that the mapped rect is integer is not enough. We need to check whether the transformation matrix has transformations other than simple translation. Original-Author: Henry Song <henrysong@samsung.com> Review URL: https://codereview.chromium.org/772953002
* Flail a little against LLVM crash.Gravatar mtklein2014-12-02
| | | | | | | | | | Cannot reproduce this in my local Chromium checkout (using their Clang, just like the bots). BUG=skia: TBR=reed@google.com Review URL: https://codereview.chromium.org/764433003
* implement device::clear until we can remove callers in chrome skia/extGravatar reed2014-12-02
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/773903002
* baseline colorwheelnativeGravatar halcanary2014-12-02
| | | | | | | TBR=scroggo@google.com NOTRY=true Review URL: https://codereview.chromium.org/777443002
* Remove SK_SUPPORT_DEPRECATED_SCALARROUND.Gravatar scroggo2014-12-02
| | | | | | Our clients no longer require it. Review URL: https://codereview.chromium.org/772933002
* rebaseline after clear change -- pdf was not treating clear as SRC_MODEGravatar reed2014-12-02
| | | | | | | | BUG=skia: NOTRY=True TBR= Review URL: https://codereview.chromium.org/759303004
* Adding a PictureResolution option to SkPictureImageFilterGravatar Justin Novosad2014-12-02
| | | | | | | | | | | This change adds an option to SkPictureImageFilter to make it rasterize SkPicture in a resolution that matches the local coordinate space (equivalent to the record-time device space). BUG=skia:3176 R=reed@google.com, senorblanco@chromium.org Review URL: https://codereview.chromium.org/753073010
* use drawRect when drawing a bitmap with anti-aliasing on a non-msaa targetGravatar derekf2014-12-02
| | | | | | | | | | | | If the dest isn't pixel aligned, or if a non 90 degree rotation is present, we need to use drawRect() for drawing anti-aliased bitmaps on non-msaa targets or the edges won't be anti-aliased as intended. Note: If the bitmap size is bigger than max texture size we fall back to drawBitmapCommon. Original-Author: Henry Song <henrysong@samsung.com> Review URL: https://codereview.chromium.org/649313003
* use portable fontsGravatar halcanary2014-12-02
| | | | Review URL: https://codereview.chromium.org/769343002
* Change clear() to respect the clipGravatar reed2014-12-02
| | | | | | | | patch from issue 769703002 at patchset 1 (http://crrev.com/769703002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/772533004
* Make SkColorTable explicitly thread-safe.Gravatar mtklein2014-12-02
| | | | | | | | | Mostly this means using SkLazyPtr for the 16-bit cache. We can remove the copy constructor now and just ref it instead. BUG=skia: Review URL: https://codereview.chromium.org/769323002
* move some copy surface stuff to GrFlushToGpuDrawTargetGravatar bsalomon2014-12-02
| | | | Review URL: https://codereview.chromium.org/770813002
* colorwheelnative gm, to test that colors look right under all conditions.Gravatar halcanary2014-12-02
| | | | | | | | Motivation: colorwheel on pdf-native (MacOS coregraphics) reverses Blue and Red. I want to see if this has anything to do with image decoding. BUG=skia:3184 Review URL: https://codereview.chromium.org/774713003
* SkColorTable locking serves no purpose anymore.Gravatar mtklein2014-12-02
| | | | | | | | | The only thing the unlock methods were doing was assert their balance. This removes the unlock methods and renames the lock methods "read". BUG=skia: Review URL: https://codereview.chromium.org/719213008
* Remove commentGravatar robertphillips2014-12-02
| | | | Review URL: https://codereview.chromium.org/770323002
* skia: Prevent GL_RED from being used with MESAGravatar hendrikw2014-12-02
| | | | | | | | | MESA unfortunately doesn't support GL_RED or GL_RG when used with frame buffers. Don't allow fTextureRedSupport to be set when using MESA. BUG=skia:3181 Review URL: https://codereview.chromium.org/769073003
* updated expectations from d476a176b774Gravatar halcanary2014-12-02
| | | | | | | | BUG=skia:3180 TBR=reed@google.com NOTRY=true Review URL: https://codereview.chromium.org/773833002
* Remove PDF JPEG shortcut, since it fails on grayscale JPEGs.Gravatar halcanary2014-12-02
| | | | | | BUG=436079 Review URL: https://codereview.chromium.org/767343002
* Remove support for OSX 10.5.Gravatar bungeman2014-12-01
| | | | | | | No user supports OSX 10.5 at this point, so remove the last support for building there. Review URL: https://codereview.chromium.org/768133005
* Remove SkASSERT_CONTINUE.Gravatar bungeman2014-12-01
| | | | | | This macro is no longer used. Review URL: https://codereview.chromium.org/770923002
* Add scale and skew to C canvas APIGravatar abarth2014-12-01
| | | | | | | R=reed@chromium.org BUG=skia: Review URL: https://codereview.chromium.org/762493005
* Clean up FreeType library ref counting.Gravatar bungeman2014-12-01
| | | | | | | | | The existing reference counting and code for LCD is difficult to understand. This cleans it up a bit in preperation for the typefaces holding the references and faces themselves which will clean this up quite a bit more. Review URL: https://codereview.chromium.org/742483004
* add gm to test rounding between clips and drawBitmapRectGravatar reed2014-12-01
| | | | | | BUG=skia:3179 Review URL: https://codereview.chromium.org/766333002
* SkDrawLooper: No need for virtual bounds computation methods.Gravatar mtklein2014-12-01
| | | | | | | | | | | No subclass overrides either method. This is just warmup. Perf is neutral. The real meat of the time spent is inside canComputeFastBounds / computeFastBounds, not getting to them. BUG=skia: Review URL: https://codereview.chromium.org/772573003
* Add function to return an unpremuled version of a GrColorGravatar egdaniel2014-12-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/773553002
* multipage_pdf_profiler, gmtoskpGravatar halcanary2014-12-01
| | | | Review URL: https://codereview.chromium.org/769083003
* Pre-cache local matrix type in shader constructor.Gravatar mtklein2014-12-01
| | | | | | | | TSAN points out we race when choosing our blitter without this. BUG=437511 Review URL: https://codereview.chromium.org/773563002
* Remove SK_SUPPORT_LEGACY_DEEPFLATTENING.Gravatar mtklein2014-12-01
| | | | | | | | | | | | This was needed for pictures before v33, and we're now requiring v35+. Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc BUG=skia: Committed: https://skia.googlesource.com/skia/+/52c293547b973f7fb5de3c83f5062b07d759ab88 Review URL: https://codereview.chromium.org/769953002
* Add additional clean up code in MPD pathGravatar robertphillips2014-12-01
| | | | | | This addresses an edge case where a picture only has one layer which is atlasable but doesn't make it into the atlas. In this case asserts can fire since there is no atlased layer to clean up the tracking picture object. Review URL: https://codereview.chromium.org/764393002
* Remove orphaned SkImageDecoder::Target.Gravatar scroggo2014-12-01
| | | | | | | This was used by an experimental method on SkImageDecoder, which no longer exists. Review URL: https://codereview.chromium.org/760923003
* Force SkMatrix type while recording too.Gravatar mtklein2014-12-01
| | | | | | | | | | | | | | | | | | | | | This switches to a new way of doing this, enforcing the caching with the type recorded rather than having to do it in SkRecorder. Should be more foolproof. Updated SkPath and SkBitmap's equivalents too. ImmutableBitmap was close, but using inheritance now makes the rest of the code less weird. BUG=437511 I'm not sure whether or not this will _fix_ the SkMatrix aspect of that bug. There may be other SkMatrices that we're racing on. It does cover the obvious ones, though, and removing the SkTRacy<> wrapper will allow TSAN to show us any other races. It turned out to be easier to turn missing optional matrices into I early rather than late. I figure this should be harmless. Recording and playback perf both look neutral. Review URL: https://codereview.chromium.org/773433003
* Revert of Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. (patchset #1 id:1 of ↵Gravatar mtklein2014-12-01
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/769953002/) Reason for revert: Breaks canary builds. Will reland after the Chromium change lands. Original issue's description: > Remove SK_SUPPORT_LEGACY_DEEPFLATTENING. > > This was needed for pictures before v33, and we're now requiring v35+. > > Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/52c293547b973f7fb5de3c83f5062b07d759ab88 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/768183002
* Remove SK_SUPPORT_LEGACY_DEEPFLATTENING.Gravatar mtklein2014-12-01
| | | | | | | | | | This was needed for pictures before v33, and we're now requiring v35+. Will follow up with the same for skia/ext/pixel_ref_utils_unittest.cc BUG=skia: Review URL: https://codereview.chromium.org/769953002
* Use variable length key (rather than accumulated matrix) as save layer ↵Gravatar robertphillips2014-12-01
| | | | | | | | | | hoisting key Adding the rendering canvas' CTM to the layer hoisting key (i.e., Add support for hoisting layers in pictures drawn with a matrix - https://codereview.chromium.org/748853002/) has increased the cache miss rate due to accumulated floating point error. This CL fixes part of the issue by using the chain of operation indices leading to each saveLayer as the key. The canvas' CTM must still form part of the key but should be less subject to accumulated error. BUG=skia:2315 Review URL: https://codereview.chromium.org/753253002
* Ignore SkGlyphCache gamma for nvpr textGravatar cdalton2014-12-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/740343006
* Add color emoji fallback for nvpr textGravatar cdalton2014-12-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/759613005
* Add a base class for GrIODB that handles geometry dataGravatar bsalomon2014-12-01
| | | | Review URL: https://codereview.chromium.org/773433002
* Force path bounds in recording.Gravatar mtklein2014-12-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The use of SKTRacy isn't safe in SkPathRef. There are logical dependencies between the racy fields. Doesn't seem to affect recording performance: $ c --match skp --config nonrendering tabl_techmeme.skp 81.1us -> 86us 1.06x desk_mapsvg.skp 1.23ms -> 1.26ms 1.02x desk_yahooanswers.skp 114us -> 117us 1.02x tabl_sahadan.skp 70.9us -> 72us 1.02x desk_fontwipe.skp 31.6us -> 32us 1.01x tabl_cuteoverload.skp 414us -> 419us 1.01x desk_mobilenews.skp 503us -> 508us 1.01x desk_tigersvg.skp 150us -> 152us 1.01x desk_samoasvg.skp 608us -> 610us 1x tabl_digg.skp 636us -> 638us 1x tabl_pravda.skp 155us -> 156us 1x desk_jsfiddlehumperclip.skp 33.9us -> 33.9us 1x tabl_culturalsolutions.skp 295us -> 295us 1x desk_youtube.skp 447us -> 448us 1x desk_gws.skp 144us -> 144us 1x tabl_frantzen.skp 42us -> 42us 1x tabl_gspro.skp 50.1us -> 50us 1x tabl_googlecalendar.skp 165us -> 165us 1x desk_twitter.skp 359us -> 358us 1x desk_wordpress.skp 588us -> 583us 0.99x desk_jsfiddlebigcar.skp 32.8us -> 32.5us 0.99x desk_booking.skp 838us -> 827us 0.99x tabl_androidpolice.skp 1.42ms -> 1.4ms 0.99x desk_blogger.skp 378us -> 372us 0.98x desk_wowwiki.skp 1.11ms -> 1.09ms 0.98x tabl_cnet.skp 115us -> 112us 0.97x desk_silkfinance.skp 57.7us -> 55.9us 0.97x tabl_cnn.skp 136us -> 131us 0.97x desk_sfgate.skp 396us -> 377us 0.95x tabl_deviantart.skp 107us -> 102us 0.95x tabl_mozilla.skp 1.4ms -> 1.32ms 0.94x BUG=437511 Review URL: https://codereview.chromium.org/762313002
* Bump min picture version.Gravatar mtklein2014-12-01
| | | | | | | | | | | | | Chrome Stable is M39, which produces picture format v35: https://chromium.googlesource.com/skia/+/chrome/m39/include/core/SkPicture.h We don't need any code to deal with pictures older than v35. (When M40 goes stable, we can step up to v37, the current latest version.) BUG=skia: Review URL: https://codereview.chromium.org/770703002
* Add extra safety check to the EGL context setup.Gravatar joakim.landberg2014-12-01
| | | | | | | | | | | Adds a check to make sure eglChooseConfig actually found a valid config. Besides checking for EGL errors, we also have to handle the case when no matching configs are found, i.e when num_config is 0. BUG=skia: Review URL: https://codereview.chromium.org/762113003