aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* port encode_bitmap_for_png() to SkRasterPipelineGravatar Mike Klein2017-06-12
| | | | | | | | | | | | | | | | | This logically shouldn't change anything, but it does a bit: - no diffs in 565 - sRGB and 8888 show minor diffs, only when unpremul is non-trivial - f16 shows minor diffs all over, and major ones in shallow gradients I think the shallow gradient diffs make sense. F16's high-precision is being quantized down to a much narrower range (something like 10-40 values), so where the lines are drawn between sRGB bits will come down to all sorts of things, especially rounding. Change-Id: I156b7c613b73d6d6089221e61d0c529798ac1f9f Reviewed-on: https://skia-review.googlesource.com/19449 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkPDF: consolodate glyph runs on BUILD_FOR_WINGravatar Hal Canary2017-06-12
| | | | | | | Change-Id: I455ebe0bec52752ccbcaa5dc5891cbeb529cb8c0 Reviewed-on: https://skia-review.googlesource.com/16871 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* added SPIR-V RelaxedPrecisionGravatar Ethan Nicholas2017-06-12
| | | | | | | | Bug: skia:5524 Change-Id: I716b6bb8da95acb72ba71d083eb8b40cafbc6af8 Reviewed-on: https://skia-review.googlesource.com/19266 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* fixed issue with SkSL dead code eliminationGravatar Ethan Nicholas2017-06-12
| | | | | | | | Bug: skia:6747 Change-Id: I8566f0f6822a452167079cca004730ec0db318a8 Reviewed-on: https://skia-review.googlesource.com/19275 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* only SkHalfToFloat_finite_ftz(uint64_t hs) is calledGravatar Mike Klein2017-06-12
| | | | | | | | | This just cleans up an unused half->float entry point. Change-Id: I7b869d3fd049d807453745c3cca4eab1162848d8 Reviewed-on: https://skia-review.googlesource.com/19451 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/433d34c700138f8aa509f14e9a5c1b19e63e5ede Update vpython version. (dnj@chromium.org) https://crrev.com/a07816ddce78fcbf5f865a582b7895902f9bb9a2 [infra_paths] Don't export "cleanup" for remote. (dnj@chromium.org) https://crrev.com/2c376aa21bef061e6529c1459eb161ce31140d7c git cl: Fix incorrect notify parameter when setting TBR. (tandrii@chromium.org) https://crrev.com/bacbdb9a559c58d0fe462422c913710fd2f38677 git-cl-patch: fix --is-ancestor flag (agable@chromium.org) https://crrev.com/354e1d23e0bd8309540a6d9db7742f1bd9109ecf git cl: improve warning. (tandrii@chromium.org) https://crrev.com/75e7872acfdd29a4939b08db8e5751f68eb69fc9 Convert notify parameter inside gerrit_util (agable@chromium.org) https://crrev.com/480b86701206e7a28c67343fc0e2cebc02278a7b [cipd] bump client version (iannucci@chromium.org) https://crrev.com/3a4a725026d23e8ae1cb926e963e6df722f456d5 [recipes] add .gitattributes for proper recipe bundling (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I34555359244ca1b2d901556b298bccc5d7447d5b Reviewed-on: https://skia-review.googlesource.com/19443 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Init fDevKLMMatrix in GrGLCubicEffect (possible valgrind fix)Gravatar Robert Phillips2017-06-12
| | | | | | | | | TBR=bsalomon@google.com Change-Id: I97357291d6d4098caecc9ac37348c9b9436ce11b Reviewed-on: https://skia-review.googlesource.com/19442 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll recipe dependencies (nontrivial).Gravatar recipe-roller2017-06-12
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/59a74ed5585087e85ff4b7fa2ac18ef3648d05b0 Add cleanup dir, use with bot_update. (dnj@chromium.org) Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9021158a90cb8ba0c939a45c2d480271506da65b Reviewed-on: https://skia-review.googlesource.com/19099 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Update SKP versionGravatar UpdateSKPs2017-06-11
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Id63ab69479d27e3e42179f29275d159de5c7fbbc Reviewed-on: https://skia-review.googlesource.com/19420 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* remove unneeded methodsGravatar Mike Reed2017-06-10
| | | | | | | | Bug: skia: Change-Id: I7256abb1a56abf961e66c399e868a8eb2478c02b Reviewed-on: https://skia-review.googlesource.com/19396 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove unneeded SK_APIGravatar Mike Reed2017-06-10
| | | | | | | | Bug: skia: Change-Id: I4400d1925ed9bb3daef8b3c17fe0f188925732cd Reviewed-on: https://skia-review.googlesource.com/19397 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkXfermode no longer needs to e a flattenableGravatar Mike Reed2017-06-10
| | | | | | | | | | SkArithmeticMode is unreachable, so delete it Bug: skia: Change-Id: Ibe4c48fcf756280569c4b302da8d96bd4e21b717 Reviewed-on: https://skia-review.googlesource.com/19394 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* attempt to fix compiler errorGravatar Mike Reed2017-06-10
| | | | | | | | | | | | | | | | | | | ../../third_party/skia/src/core/SkBlendMode.cpp: In function 'SkPM4f SkBlendMode_Apply(SkBlendMode, SkPM4f, SkPM4f)': ../../third_party/skia/src/core/SkBlendMode.cpp:133:1: error: unrecognizable insn: } ^ (insn 48 47 49 7 (set (reg:V4SF 112 [ D.89567 ]) (unspec:V4SF [ (mem/c:V4SF (reg/f:SI 104 virtual-incoming-args) [0 MEM[(const __builtin_neon_sf[4] *)&src]+0 S16 A32]) ] UNSPEC_VLD1)) /b/c/b/android/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/include/arm_neon.h:8693 -1 (nil)) ../../third_party/skia/src/core/SkBlendMode.cpp:133:1: internal compiler error: in extract_insn, at recog.c:2202 Bug: skia: Change-Id: I85e98e858d00b8b505c6676e9a9dc762f0ccb25c Reviewed-on: https://skia-review.googlesource.com/19392 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove unused arithmetic codeGravatar Mike Reed2017-06-09
| | | | | | | | Bug: skia: Change-Id: I51d382ba8ddb75dff97dd8d773f7a4f3f10663da Reviewed-on: https://skia-review.googlesource.com/19406 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* CanOverflow -> ClampIfNeededGravatar Mike Klein2017-06-09
| | | | | | | | | Centralize the clamping in ClampIfNeeded, and switch it to clamp_1. Change-Id: I056ac029d3ddc81e3f0f194f2b9c9924cad4caae Reviewed-on: https://skia-review.googlesource.com/19401 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Fix GrGradientEffect::isValid()Gravatar Brian Salomon2017-06-09
| | | | | | | | | | This was relying on TextureSampler::proxy() which crashes if the proxy is not valid. Bug: skia: Change-Id: I8452f5cea3a71b5ced15259aede52a44ab152cf2 Reviewed-on: https://skia-review.googlesource.com/19403 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* replace 4f procs with pipeline (only called in 2 places by ganesh)Gravatar Mike Reed2017-06-09
| | | | | | | | | | | enables lots of code to delete CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Bug: skia: Change-Id: I13631ead68a9232bd8c13c5ef54727f44def26ca Reviewed-on: https://skia-review.googlesource.com/19278 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Disable F16-nullptr sources"Gravatar Matt Sarett2017-06-09
| | | | | | | | | | Manual revert: failing ui rendering cts tests Bug: b/62482405 Change-Id: I652ec8dce482d303437835a27c50a22248afd955 Reviewed-on: https://skia-review.googlesource.com/19360 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Fix loopIndex in chopCubicAtLoopIntersectionGravatar Chris Dalton2017-06-09
| | | | | | | | | | | A recent change broke the case where the entire bezier is inside the loop segment. Bug: skia:4410 Change-Id: Ib534d459eaa4461d6760e894a8826e3019584ee8 Reviewed-on: https://skia-review.googlesource.com/19333 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add another gm to Win Intel Vulkan blacklistGravatar Greg Daniel2017-06-09
| | | | | | | | | Bug: skia:6398 Change-Id: I3e4006ce1fbe1644c6d99467c5b9e785161dcc3d Reviewed-on: https://skia-review.googlesource.com/19277 Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Broken link in Tree Sheriffs DocumentationGravatar Allan MacKinnon2017-06-09
| | | | | | | | | | No-Try: true Docs-Preview: https://skia.org/?cl=19326 Bug: skia: Change-Id: I215d02470d14f076af68bfdc88046a0123429fb7 Reviewed-on: https://skia-review.googlesource.com/19326 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Allan MacKinnon <allanmac@google.com>
* Retract GrTexture.h a bitGravatar Robert Phillips2017-06-09
| | | | | | | | | This began as cleaning up SkSpecialImage.h & spiraled out of control from there. Change-Id: I9a570ecd2a7af9ee724ebfebe4e9185748f38bbc Reviewed-on: https://skia-review.googlesource.com/19290 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* SkShader::asACompose is android-onlyGravatar Mike Reed2017-06-09
| | | | | | | | Bug: skia: Change-Id: Ib99a7ee4984544f342699fa6b20797c55be7d5a0 Reviewed-on: https://skia-review.googlesource.com/19268 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* GrTessellator: fix logging; fix test comment.Gravatar Stephen White2017-06-09
| | | | | | | Change-Id: Iaded9025a1518d8c69dbe366deb1035e0bd4295b Reviewed-on: https://skia-review.googlesource.com/19289 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Add comments support for PNG encoderGravatar Yuqian Li2017-06-09
| | | | | | | | | Bug: skia:6689 Change-Id: I6ccac8890f44724ccd6e20c8f4ea80bc99f9fa58 Reviewed-on: https://skia-review.googlesource.com/19080 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Remove blacklisted native_image_to_raster_surface testsGravatar Brian Osman2017-06-09
| | | | | | | | Bug: skia:6457 skia:6401 Change-Id: I18e45617765aa55c3a2837bb735cefc3d93fad22 Reviewed-on: https://skia-review.googlesource.com/19273 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add tonal color support for shadows.Gravatar Jim Van Verth2017-06-09
| | | | | | | | Bug: skia: Change-Id: Ib9bd9083da1d8a9fa90ae7c710386e6903541fd5 Reviewed-on: https://skia-review.googlesource.com/18148 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Improve cubic KLM accuracyGravatar Chris Dalton2017-06-09
| | | | | | | | | | | | | | | | | | | | | | Moves cubic root finding logic out of GrPathUtils and PathOpsCubicIntersectionTest, and unifies it in SkGeometry. "Normalizes" the homogeneous parameter values of the roots, rather than the cubic inflection function. Does this normalization by twiddling the exponents instead of division (which causes a loss of precision). Abandons the built-in derivatives in GrCubicEffect. These don't have high enough precision on many mobile gpus. Instead we pass the KLM matrix to the vertex shader via uniform, where we can use it to set up new linear functionals from which the fragment shader can calculate the gradient of the implicit function. Bug: skia:4410 Change-Id: Ibd64e999520adc8cdef7803a492d3699995aef5a Reviewed-on: https://skia-review.googlesource.com/19017 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Extend composeshader to support a lerp parameterGravatar Mike Reed2017-06-09
| | | | | | | | Bug: skia: Change-Id: I3bbb2cb8d0a84fca0309654498548ebc94d8938f Reviewed-on: https://skia-review.googlesource.com/18460 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Add clamp before drawing F16->8888 in DMSrcSink ColorCodecSrcGravatar Matt Sarett2017-06-09
| | | | | | | | | | | Verified that this fixes the wrongness of a few of the colorImage diffs in Gold. Bug: skia:6738 Change-Id: Icf0b7573ccb87268b480d7cc0a6cfe6fa8ae73f7 Reviewed-on: https://skia-review.googlesource.com/19271 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Remove debug checks for unsupported ICC profilesGravatar Matt Sarett2017-06-09
| | | | | | | | | | | | This was never fully integrated with our automated image testing. I feel it has limited usefulness in terms of catching bugs. Bug: skia: Change-Id: Iecd0a4e9b664ab0b351debde45ada864379de7ec Reviewed-on: https://skia-review.googlesource.com/19267 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Add new Kaby Lake bot Win IntelIris640.Gravatar Ben Wagner2017-06-09
| | | | | | | | | Bug: skia:6743 No-Try: true Change-Id: Ib670ce861ccf6568acfe0d0b27fcc112a51989bc Reviewed-on: https://skia-review.googlesource.com/19092 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Make gradient effect creation fail if texture LUT creation failsGravatar Brian Salomon2017-06-09
| | | | | | | | Bug: skia:6198 Change-Id: Ib8fb273564ca54ee9e6e045ac67e191af705a37a Reviewed-on: https://skia-review.googlesource.com/19260 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* remove unused colorfilter virtual asAComposeGravatar Mike Reed2017-06-09
| | | | | | | | Bug: skia: Change-Id: I1e23dbd18f7145dcaaa864f3fd7b34aea2c342a6 Reviewed-on: https://skia-review.googlesource.com/19269 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Handle too many (or too large) paths in GrDefaultPathRenderer"Gravatar Brian Osman2017-06-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit eb86b7094755a5fc1e49d22b4c5323f372344d61. Reason for revert: May be responsible for Command Buffer failure? Original change's description: > Handle too many (or too large) paths in GrDefaultPathRenderer > > PathGeoBuilder constructs the geometry with the same basic > technique as before, but allows interrupting the process > to emit multiple draws. > > Original test case was 2000 non-AA stroked circles, which > created ~66000 vertices. That now renders, as do various > tests with a single large path (as well as filled paths). > > TODO: I think that this could be extracted and re-used for > MSAA path renderer without too much work? I need to read > that code more carefully to make sure it lines up. > > Re-land of: https://skia-review.googlesource.com/18360 > > Bug: skia:6695 > Change-Id: Ibdedeb0ea2570a8847ba42328588bd7203411573 > Reviewed-on: https://skia-review.googlesource.com/18983 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:6695 Change-Id: I2cb010db502c315b3e2f7212818aea5503ecb28c Reviewed-on: https://skia-review.googlesource.com/19270 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Make SkPixmap::getColor support kUnpremul pixelsGravatar Matt Sarett2017-06-09
| | | | | | | | Bug: skia:6319 Change-Id: Id5ad27b4e85516dfdad0c127655e6272bc0a39ac Reviewed-on: https://skia-review.googlesource.com/19089 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* fix f16 -> sRGB in encode_bitmap_for_png()Gravatar Mike Klein2017-06-09
| | | | | | | | | | | | | | | | | The existing logic looks wrong to me: - clamp premul to [0,1] - unpremul, ignoring zero alpha It seems like we should do: - unpremul, avoiding any divide by zero - clamp unpremul to [0,1] Am I misunderstanding this or has this just always been wrong? Change-Id: I9636b9566c746bc05371e1e660f4e59dde16827b Reviewed-on: https://skia-review.googlesource.com/19264 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Handle too many (or too large) paths in GrDefaultPathRendererGravatar Brian Osman2017-06-09
| | | | | | | | | | | | | | | | | | | | | | PathGeoBuilder constructs the geometry with the same basic technique as before, but allows interrupting the process to emit multiple draws. Original test case was 2000 non-AA stroked circles, which created ~66000 vertices. That now renders, as do various tests with a single large path (as well as filled paths). TODO: I think that this could be extracted and re-used for MSAA path renderer without too much work? I need to read that code more carefully to make sure it lines up. Re-land of: https://skia-review.googlesource.com/18360 Bug: skia:6695 Change-Id: Ibdedeb0ea2570a8847ba42328588bd7203411573 Reviewed-on: https://skia-review.googlesource.com/18983 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* remove unneeded includeGravatar Mike Reed2017-06-09
| | | | | | | | Bug: skia: Change-Id: If8c689c008438efed398d018782021195f6d0274 Reviewed-on: https://skia-review.googlesource.com/19261 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* specialize D32 proc for legacy srcGravatar Mike Reed2017-06-09
| | | | | | | | | | lots of dead-code removal Bug: skia: Change-Id: I23ea25eb38855b4776e97fa8ff777d9744baab1d Reviewed-on: https://skia-review.googlesource.com/19147 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Create a new HDC for each ANGLE contextGravatar Robert Phillips2017-06-09
| | | | | | | | Bug: skia:6711 Change-Id: I9c4720a8dbad4c6b18efe73e0e61afbdc19627bc Reviewed-on: https://skia-review.googlesource.com/19090 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/fd238086f1c3caa5bc4c11d3457f81d9a30f3ed7 Use API to set TBR code-review (agable@chromium.org) https://crrev.com/7303dcb9b399b67cc533d32109b2e4f1da8147e2 Use whole --message argument on patchset upload (agable@chromium.org) https://crrev.com/9387b4f0be621a3027848e0624a3ca3a70ee5195 Make gerrit 'git cl patch' use hard reset by default (agable@chromium.org) https://crrev.com/ce325ac84abf7b4200a0b55681fcb527215ba306 Update gsutil pin for download_from_google_storage.py from 4.15 to 4.26 (hinoka@google.com) https://crrev.com/027a5424859847ae849723812b726eca1d850ef9 [infra_paths] remove unused goma_deps_cache. (iannucci@chromium.org) recipe_engine: https://crrev.com/c40412cbc4e1b8ee1e6eba2e88328ca71c6ec1e4 [context] Add path prefix/suffix manipulation. (dnj@chromium.org) https://crrev.com/c916898b8189866a0bf43fe15c800e4fe6d4a19e [context] fix treatment of None in env. (iannucci@chromium.org) https://crrev.com/154ef7e5d8f964ef30b1250dd33751582705f6f2 [path] Add concept of a "cleanup" directory. (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic45a05b05ab3873d35a844c5c4ddf4f2b20f2353 Reviewed-on: https://skia-review.googlesource.com/19097 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Add flush before drawing lines workaround for Adreno 3xxGravatar Brian Salomon2017-06-08
| | | | | | | | Bug: skia:6309 Change-Id: I354c678ca4e833c523a89b3196804fbe1adcf9d1 Reviewed-on: https://skia-review.googlesource.com/19087 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Use nextafter rather than std::nextafter, it's more widely availableGravatar Mostyn Bramley-Moore2017-06-08
| | | | | | | | Bug: skia: Change-Id: Idffe99cde348af83ae4290614c44767fffe36609 Reviewed-on: https://skia-review.googlesource.com/19120 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Disable ReadPixels_Texture & ReadPixels_Gpu on ANGLEGravatar Robert Phillips2017-06-08
| | | | | | | | | | Depends on https://skia-review.googlesource.com/c/19101/ (Store context type (rather than backend type) in ContextInfo) Bug: skia:6742 Change-Id: I321c01838acf93ad28a17d8e97aa1bf594425502 Reviewed-on: https://skia-review.googlesource.com/19077 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Don't reuse failed buffers as scratchGravatar Robert Phillips2017-06-08
| | | | | | | | | This is/was occurring for ANGLE D3D configs Change-Id: I45d4c40143ce4ac4989612c7bfe7aefd178842da Reviewed-on: https://skia-review.googlesource.com/19076 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Store context type (rather than backend type) in ContextInfoGravatar Robert Phillips2017-06-08
| | | | | | | Change-Id: I7dbfb735f1f094fa0a025b84f69e06a3533f2815 Reviewed-on: https://skia-review.googlesource.com/19101 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add support for SkImageGenerator creating external texturesGravatar Stan Iliev2017-06-08
| | | | | | | | | | | Copy the SkImageGenerator texture if tiling is needed and original texture target is GR_GL_TEXTURE_EXTERNAL. Bug: skia: Change-Id: I98f5acc3883e2060b1a35f80633b02b08a706107 Reviewed-on: https://skia-review.googlesource.com/18268 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stan Iliev <stani@google.com>
* GrTessellator: fix intersection above the first vertex.Gravatar Stephen White2017-06-08
| | | | | | | | | | | | | | | | | | | | Handle the case where the an intersection falls not only above both edge endpoints, but above the first vertex in the mesh. This requires passing the mesh into check_for_intersection(), in order to modify the head. We also need to rewind the mesh after insertion, since we need to rewind to the newly-inserted vertex. This also cleans up vertex ID computation a little (for logging), so that vertices before the first vertex or after the last have a reasonable ID. It also cleans up the intersection-on-endpoint special cases by refactoring the calls to split_edge(). BUG=730687 Change-Id: Idea736eca7b7c3c5d8a470b1373a16ad8e649e80 Reviewed-on: https://skia-review.googlesource.com/19069 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Draw time color xform API for AndroidGravatar Matt Sarett2017-06-08
| | | | | | | | | | | | | | | | | Will do a lazy color xform to the dst color space at GPU upload time. I've included the capability to control the gen id of the output image. This will allow us to reuse images in the Ganesh cache. This should only be temporary. When Android is able to cache the actual SkImage object, we won't need to expose this anymore. Bug: b/62347704 Change-Id: I93b950ef680f6bbdd7eb6a2ec6f50195dbb78311 Reviewed-on: https://skia-review.googlesource.com/16440 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>