aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Call standard libjpeg/libjpeg-turbo APIsGravatar msarett2015-09-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1322623004
* Require Sk4f::toBytes() clampsGravatar mtklein2015-09-01
| | | | | | | | BUG=skia:4117 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.android:Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Release-Trybot Review URL: https://codereview.chromium.org/1312053004
* link test to bugGravatar caryclark2015-09-01
| | | | | | | | | | | | | | | | | | | | | | | | crbug.com/526025 includes a minimized SVG test case. Translating that test case into native code (fuzzTNG) did not reproduce the bug. That test case should have not been included with skia issue 1323813003, and is deleted here. Running the minimal test case in a modified version of chrome isolated the bug. The modified version generated the test fuzz763_3 with the edit #define DEBUGGING_PATHOPS_FROM_HOST 1 in src/pathops/SkPathopsOp.cpp line 188. Rename fuzz763_3 to issue_526025 to associate the test with the bug. Note that the bug contains the body of the CL in comment $5. R=reed@google.com Review URL: https://codereview.chromium.org/1315503005
* Make GrTextContext no longer store a GrDrawContextGravatar robertphillips2015-09-01
| | | | | | This, at least, makes GrTextContexts no longer bound to a single GrDrawContext. (Passing in a RenderTarget and praying it matched the DrawContext was always a bit fishy too). Review URL: https://codereview.chromium.org/1320323004
* Image generator-backed SkPictureShaderGravatar fmalita2015-08-31
| | | | | | | | A respin of http://crrev.com/866773002 R=reed@google.com Review URL: https://codereview.chromium.org/1323863002
* Clean up remaining users of SkPMFloatGravatar mtklein2015-08-31
| | | | | | | | | | | | This switches over SkXfermodes_opts.h and SkColorMatrixFilter to use Sk4f, and converts the SkPMFloat benches to Sk4f benches. No pixels should change here, and no code beyond the Sk4f_ benches should change speed. The benches are faster than the old versions. BUG=skia:4117 Review URL: https://codereview.chromium.org/1324743002
* simplify bitmap scaler and cacheGravatar reed2015-08-31
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1320513005
* Move float<->byte conversions into Sk4f.Gravatar mtklein2015-08-31
| | | | | | | | | | | | | | | | | | | This lets us avoid conversions to [0.0, 1.0] space and rounding that aren't necessary for SkColorCubeFilter_opts.h. Dropping rounding on the way back to bytes means we'll see a bunch of off-by-1 diffs. Rough perf effect: SSSE3: 110 -> 93 (~15%) NEON: 465 -> 375 (~20%) This is the beginning of the end for SkPMFloat as an entity distinct from Sk4f. I've kept it for now so I can convert sites one by one and think about how things that really want to keep PM color order will work. BUG=skia:4117 Review URL: https://codereview.chromium.org/1319413003
* Document SkString::resize(int) as destructive.Gravatar bungeman2015-08-31
| | | | | | | | | It is easy to think in some cases that SkString::resize(int) is not destructive, since optimizations mean that most of the time the data is still there after a resize. However, in the general case, the original string's data is lost and the new SkString contains garbage. Review URL: https://codereview.chromium.org/1304833004
* Add empty files to empty targets to appease XCode.Gravatar mtklein2015-08-31
| | | | | | BUG=skia:4117 Review URL: https://codereview.chromium.org/1312703004
* Minor cleanup in GrTessellatingPathRenderer.Gravatar senorblanco2015-08-31
| | | | | | | | | | Vertex counts are always exact, so don't bother handling the case where they're different. Just assert. Rename variables to reflect. BUG=skia: Review URL: https://codereview.chromium.org/1322023002
* Rename flag from "distance field" to "device independent."Gravatar bsalomon2015-08-31
| | | | Review URL: https://codereview.chromium.org/1322433006
* Revert of By default purge resources that haven't been used for 64 flushes ↵Gravatar bsalomon2015-08-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:60001 of https://codereview.chromium.org/1316233003/ ) Reason for revert: Breaking again Original issue's description: > By default purge resources that haven't been used for 64 flushes > > BUG=skia:4258 > > Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104 > > R=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/71d0c33068d41878cc3117f3761f49300f6b3d54 > > Committed: https://skia.googlesource.com/skia/+/bd783cd5b62118277b75933c3cd7b9097129259a TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4258 Review URL: https://codereview.chromium.org/1322753004
* Add a GM for image filters applied to stroked primitives.Gravatar senorblanco2015-08-31
| | | | | | BUG=skia:3194 Review URL: https://codereview.chromium.org/1323573004
* remove duplicate linked list adjustmentGravatar caryclark2015-08-31
| | | | | | | | | | | | | | | | | | | | | The list of intersection points on a curve segment may have entries that can be safely removed when nearby points have nearly the same t value and point value. When a path includes very large curves as well as small ones, as is the case with this fuzzer, additional points may lie between the similar points that do not meet the nearby criteria. After merging the nearby point with its doppelganger, SkOpSegment::moveNearby() unnecessarily set the doppelganger's next pointer to the one following the nearby point. While this usually has no effect, since the merge already updated the linked list, the explicit call removes the additional outlier points from the segment. TBR=reed@google.com BUG=526025 Review URL: https://codereview.chromium.org/1323813003
* Run Appurify bot in release modeGravatar borenet2015-08-31
| | | | | | BUG=skia:4093 Review URL: https://codereview.chromium.org/1306953006
* Suppress embedding fonts when the skp's fonts match the OS fonts.Gravatar caryclark2015-08-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The million SKPs generated require >5T of storage. A good deal of that are copies of system fonts. Chrome built with #DEFINE SK_WHITELIST_SERIALIZED_TYPEFACES will omit the font data if the font matches a precomputed checksum. The captured SKP prepends sk_ to the names of fonts that have their data omitted. The SKP consumer can either add renamed fonts from the recording machine, or add gDeserializeTypefaceDelegate = WhitelistDeserializeTypeface; which strips the sk_ prefix when deserializing typefaces. whitelist_typefaces --check Computes the checksums of fallback fonts and returns 0 if the checksums match the checked-in file SkWhitelistChecksum.cpp. whitelist_typefaces --generate Writes an updated version of SkWhitelistChecksum.cpp. (Added Mike since this modifies a public header) R=bungeman@google.com,rmistry@google.com,reed@google.com Review URL: https://codereview.chromium.org/1317913005
* Use a different download URL for Android toolchainsGravatar borenet2015-08-31
| | | | | | | | The current one isn't working on the Appurify bot BUG=skia:4093 Review URL: https://codereview.chromium.org/1311533006
* By default purge resources that haven't been used for 64 flushesGravatar bsalomon2015-08-31
| | | | | | | | | | | | BUG=skia:4258 Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104 R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/71d0c33068d41878cc3117f3761f49300f6b3d54 Review URL: https://codereview.chromium.org/1316233003
* Provide some detail about valentine passwordGravatar benjaminwagner2015-08-31
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1317683006 Review URL: https://codereview.chromium.org/1317683006
* CMake builds on Ubuntu now too.Gravatar mtklein2015-08-31
| | | | | | | | Punted for now on GL on Linux. Man that's a beast. BUG=skia:4269 Review URL: https://codereview.chromium.org/1315753009
* Scanline decoding for bmpGravatar msarett2015-08-31
| | | | | | | | | | | | | Redesigns SkScanlineDecoder.h to indicate the ordering in which the scanlines are provided Refactors SkSwizzler::Fill() to include the zeroInit check and to actually be correct. BUG=skia:3257 BUG=skia:4198 Review URL: https://codereview.chromium.org/1287423002
* Revert of By default purge resources that haven't been used for 64 flushes ↵Gravatar bsalomon2015-08-31
| | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:40001 of https://codereview.chromium.org/1316233003/ ) Reason for revert: Blocking roll Original issue's description: > By default purge resources that haven't been used for 64 flushes > > BUG=skia:4258 > > Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104 > > R=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/71d0c33068d41878cc3117f3761f49300f6b3d54 TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4258 Review URL: https://codereview.chromium.org/1316263003
* By default purge resources that haven't been used for 64 flushesGravatar Brian Salomon2015-08-30
| | | | | | | | | | BUG=skia:4258 Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104 R=robertphillips@google.com Review URL: https://codereview.chromium.org/1316233003 .
* Update SKP versionGravatar rmistry2015-08-30
| | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS Review URL: https://codereview.chromium.org/1316403003
* Fix leak in test create for perlin noise fpGravatar bsalomon2015-08-29
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1319723005
* Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*Gravatar bsalomon2015-08-28
| | | | | | Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa Review URL: https://codereview.chromium.org/1316513002
* Revert of Change SkShader;asFragmentProcessor signature to no longer take ↵Gravatar rmistry2015-08-28
| | | | | | | | | | | | | | | | | | | | | | | | skpaint\grcolor* (patchset #8 id:140001 of https://codereview.chromium.org/1316513002/ ) Reason for revert: Primary suspect in failing DEPS rolls: * https://codereview.chromium.org/1315753006 * https://codereview.chromium.org/1308323006 * https://codereview.chromium.org/1320903004 Primary suspect because the failing win bots did not fail in https://codereview.chromium.org/1315753005 Original issue's description: > Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* > > Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa TBR=joshualitt@google.com,wangyix@google.com,robertphillips@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1313573005
* Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*Gravatar bsalomon2015-08-28
| | | | Review URL: https://codereview.chromium.org/1316513002
* fix bounds check for ctables (thanks Hal)Gravatar reed2015-08-28
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1319973008
* Change 900k to 910k in another location.Gravatar benjaminwagner2015-08-28
| | | | | | | | BUG=skia:4063 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1317373002 Review URL: https://codereview.chromium.org/1317373002
* Example CMake build for Skia.Gravatar mtklein2015-08-28
| | | | | | | | | This works only on Mac, probably only on 64-bit, and doesn't support SkCodec. BUG=skia:4269 Review URL: https://codereview.chromium.org/1319543003
* Update CT documentation on Skia site.Gravatar benjaminwagner2015-08-28
| | | | | | | | BUG=skia:4063 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1314413002 Review URL: https://codereview.chromium.org/1314413002
* change colortable to use factory for reinflating, check for emptyGravatar reed2015-08-28
| | | | | | BUG=525763 Review URL: https://codereview.chromium.org/1307023004
* Replace SkPin32 with SkTPin and remove.Gravatar bungeman2015-08-28
| | | | | | | SkPin32 is already just forwarding to SkTPin, so convert existing users and remove SkPin32. Review URL: https://codereview.chromium.org/1314583003
* Remove sys/types.h include from SkTypes.h.Gravatar bungeman2015-08-28
| | | | | | | It appears this was added to support SkToOffT, but SkToOffT is no longer used, so it is removed as well. Review URL: https://codereview.chromium.org/1306963004
* Interlaced gifs without the iteratorGravatar msarett2015-08-28
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1315583003
* Clean up SkTLogic.Gravatar bungeman2015-08-28
| | | | | | | | | This change regularizes Skia's type traits so that when <type_traits> can finally be used the transition is easier. Various traits are renamed to match <type_traits> and placed in the skstd namespace. Current users of these traits are updated. Review URL: https://codereview.chromium.org/1317593004
* Convert child FPs from refs to pending executions when parent convertsGravatar bsalomon2015-08-27
| | | | Review URL: https://codereview.chromium.org/1315923004
* Some codec code formatting cleanup.Gravatar bungeman2015-08-27
| | | | | | | | | While looking at users of SkTAddOffset, some unwanted casts were found. These casts are removed and the lines reformatted. However, the formatting of the rest of the file was unhappy, so this is really just a formatting clean-up. Review URL: https://codereview.chromium.org/1301393010
* Revert of By default purge resources that haven't been used for 64 flushes ↵Gravatar rmistry2015-08-27
| | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/1316233003/ ) Reason for revert: Suspect for the failed "webgl_conformance on Intel GPU on Mac" test on 2 DEPS rolls: https://codereview.chromium.org/1320943002/ https://codereview.chromium.org/1315703003/ Example build: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/105501 Original issue's description: > By default purge resources that haven't been used for 64 flushes > > BUG=skia:4258 > > Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104 TBR=robertphillips@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4258 Review URL: https://codereview.chromium.org/1319053002
* Remove overly complicated GR_CREATE_STATIC_PROCESSOR macroGravatar mdempsky2015-08-27
| | | | | | | | | | | | | | | | | | | This macro was responsible for producing code like: static SkAlignedStorage<sizeof(Foo)> g_gFoo_Storage; static Foo* gFoo = new(g_gFoo_Storage.get()) Foo; static SkAutoTDestroy<Foo> gFoo_ad(gFoo); which would allocate static storage for an object of type Foo (g_gFoo_Storage), lazily instantiate the object in that memory (via gFoo's initializer), and then ensure that at global destruction time the object is destroyed (via gFoo_Ad's destructor). However, the exact same effect is achieved by just writing: static Foo gFoo; Review URL: https://codereview.chromium.org/1314763009
* Add a note about (x*y+255)/256.Gravatar mtklein2015-08-27
| | | | | | BUG=skia:4117 Review URL: https://codereview.chromium.org/1312283004
* Add trace event to SkPicture analysis.Gravatar mtklein2015-08-27
| | | | | | | | | | | RE: https://codereview.chromium.org/1319723002/ This should mark out the time spent to support hasText(), willPlayBackBitmaps(), and numSlowPaths() in about:tracing. BUG=skia: Review URL: https://codereview.chromium.org/1317103002
* skia: add ability to load command_buffer_gles2Gravatar hendrikw2015-08-27
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1306823003
* [tracing] Add support for skia caches to dump memory statsGravatar ssid2015-08-27
| | | | | | | | | Dump the memory statistics of resource cache and glyph cache using the SkTraceMemoryDump interface. BUG=chromium:503168 Review URL: https://codereview.chromium.org/1313793004
* By default purge resources that haven't been used for 64 flushesGravatar bsalomon2015-08-27
| | | | | | BUG=skia:4258 Review URL: https://codereview.chromium.org/1316233003
* nullptr isn't an int; this is what we wantGravatar halcanary2015-08-27
| | | | Review URL: https://codereview.chromium.org/1306753006
* Style Change: NULL->nullptrGravatar halcanary2015-08-27
| | | | | | DOCS_PREVIEW= https://skia.org/?cl=1316233002 Review URL: https://codereview.chromium.org/1316233002
* SkColorCubeFilter_opts: start with a statically-initializable zero.Gravatar mtklein2015-08-27
| | | | | | | | | | | | | | | | SkPMFloat(0) and SkPMFloat(0,0,0,0) end up with the same value, but the first goes through math to get there. The second is a lot more transparent to the compiler, and should compile all the way down to just `xorps xmmN,xmmN` or even be optimized away. Didn't measure any additional benefit from hoisting the zero outside the loop and writing `SkPMFloat color = zero;`. Perf win is <2%. BUG=skia: Review URL: https://codereview.chromium.org/1314763007