aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Allow Vulkan to upload to main mip level without uploading to all levels.Gravatar Greg Daniel2017-04-07
| | | | | | | | | | | | It should be allowed for the client to upload original data to a texture via writePixels and then we just regenerate the mipmaps. I think it also resonable to limit this to either writting to all levels or just the top level. Bug: skia: Change-Id: I66943cca54c2a7187a781788653948fb69c17c68 Reviewed-on: https://skia-review.googlesource.com/11798 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* make SkAutoTMalloc self-move safeGravatar Mike Klein2017-04-07
| | | | | | | | | | | | | | | We were just combing through possible changes that might have affected the attached bug, this popped out as pretty obviously unsafe. This doesn't explain the Chrome bug... SkAutoTMalloc and SKAutoSTMalloc are separate types. :( The new test fails and crashes before, passes after. Change-Id: I033f488a7f644b7a70e612c8535fedfac35c76db Reviewed-on: https://skia-review.googlesource.com/11797 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* SkTypeface:: populate_glyph_to_unicode uniformly across platformsGravatar Hal Canary2017-04-07
| | | | | | | Change-Id: I7edce3c38b4dc0261d425c26a443df9a1f25b32e Reviewed-on: https://skia-review.googlesource.com/11786 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* jumper, byte_tables + byte_tables_rgbGravatar Mike Klein2017-04-07
| | | | | | | | | Factors out a function F from_byte(U8) too. Change-Id: Ib739ccbd509ddf25d2bfb7751ba6eaf51b16c12f Reviewed-on: https://skia-review.googlesource.com/11791 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* cacherator upscales colortables to unify cachingGravatar Mike Reed2017-04-07
| | | | | | | | Bug: skia: Change-Id: Ib63f96b83d696743bbe4335c998acd4d2ea8acdb Reviewed-on: https://skia-review.googlesource.com/11787 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkMultiPictureDocument : clean up MultiPictureDocumentReader interfaceGravatar Hal Canary2017-04-07
| | | | | | | | | | Motivation: We may want to make SkMultiPictureDocument.h public in the future. Change-Id: Ie97b88d51a179c2283155d65bcadee32178115ca Reviewed-on: https://skia-review.googlesource.com/11402 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Make GrCopySurfaceOp friendlier to GrSurfaceProxy (take 2)Gravatar Robert Phillips2017-04-07
| | | | | | | | | Reland of: https://skia-review.googlesource.com/c/11325/ (Make GrCopySurfaceOp friendlier to GrSurfaceProxy) Change-Id: Ibe7312cebe7793af5803353a1499fbe7874c558f Reviewed-on: https://skia-review.googlesource.com/11780 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Simplify subset computation in SkGifImageReaderGravatar Leon Scroggins III2017-04-07
| | | | | | | | | | | | If xOffset or yOffset was not zero, these computations would not be evaluated anyway, so no need to add zero for these comparisons. (Split off from CL 9810) Change-Id: I8481eb257d96766696945cef4eafaff4281fb7d9 Reviewed-on: https://skia-review.googlesource.com/11782 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* stop disabling threadsafe staticsGravatar Mike Klein2017-04-07
| | | | | | | | | Chrome's got threadsafe statics, Android too, Flutter too, and heck, we even have them on all our Windows builds. No one responded to my mail about them. Let's stop turning them off on not-Windows! Change-Id: Iadf00336aa73df3f694ac019c9d54a3f2257a3bd Reviewed-on: https://skia-review.googlesource.com/11683 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix missing valgrind.supp in recipe-bundled tasksGravatar Eric Boren2017-04-07
| | | | | | | | Bug: skia:5813 Change-Id: I734c716d953091e84d30ad36c55a6c74727f376c Reviewed-on: https://skia-review.googlesource.com/11781 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add ChromeOS Test/Perf jobs and recipe changesGravatar Kevin Lubick2017-04-07
| | | | | | | | | Minor cleanup of left over Tab3 tests. Bug: skia:6442 Change-Id: I03bb4a034101a2773619abd2be7a300a70f6ac3d Reviewed-on: https://skia-review.googlesource.com/11414 Reviewed-by: Eric Boren <borenet@google.com>
* SkTypeface_win_dw: populate_glyph_to_unicode uses lowest unicharGravatar Hal Canary2017-04-07
| | | | | | | | | BUG=chromium:538133 BUG=chromium:359065 Change-Id: I8208efc63579e0f1ebb77680beae2cd08cdba547 Reviewed-on: https://skia-review.googlesource.com/11681 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* simplify SkRRect serializationGravatar Mike Klein2017-04-07
| | | | | | | | | | | | | | | | I think this happens to fix the particular issue in the attached bug. memcpy() is kind of the swiss army knife as far as strict aliasing is concerned... you're always allowed to use it. The generated code for writeToMemory() is unchanged, and readFromMemory() gets a bit better looking. BUG=skia:5105 Change-Id: Ib5bf96600f1138650c004ced2d696e9a4ba83ca7 Reviewed-on: https://skia-review.googlesource.com/11682 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Try disabling MSAN workarounds in SkJpegCodecGravatar Mike Klein2017-04-07
| | | | | | | | | | | | | | I don't think we've tried this since switching to GN, where we decided to just go with jsimd_none.c on all x86 bots. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN,Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN BUG=skia:4550 Change-Id: Iff4be3b640fb77d1094565a5db4d32778e7f2b4f Reviewed-on: https://skia-review.googlesource.com/11680 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Reland: Use bundled recipes for all test/perf tasksGravatar Eric Boren2017-04-07
| | | | | | | | | | | It won't save as much time for faster machines, but it should still shave a few seconds, and it'll be nice to be consistent. Bug: skia: Change-Id: I0b2aa010579b527c66325cb5b691bfb549b31316 Reviewed-on: https://skia-review.googlesource.com/11418 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* jumper, gather_f16Gravatar Mike Klein2017-04-07
| | | | | | | | | | Here we use 64-bit gather instructions for HSW, which I think we haven't done before. Change-Id: I7b22b3cc0b7a151952518bb9afb90624ebdb4a22 Reviewed-on: https://skia-review.googlesource.com/11602 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* jumper, gather_i8Gravatar Mike Klein2017-04-06
| | | | | | | Change-Id: Iefa8044bac0555c5fff370217a6270b4f3c64300 Reviewed-on: https://skia-review.googlesource.com/11582 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update stencil ops to have a parallel proxyIDGravatar Robert Phillips2017-04-06
| | | | | | | Change-Id: I842c7f2011c8b9d4487cec4349de8b77f326a381 Reviewed-on: https://skia-review.googlesource.com/11360 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* jumper, more gathersGravatar Mike Klein2017-04-06
| | | | | | | | | | This is all the gathers except index 8 and f16, which aren't conceptually hard but I want to land separately. Change-Id: I525f2496e55451041bd6ea07985858fda7b56a40 Reviewed-on: https://skia-review.googlesource.com/11524 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Make GrCopySurfaceOp friendlier to GrSurfaceProxy"Gravatar Robert Phillips2017-04-06
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d7cda9a6f050c30e65b0744b3cfb45cecdc40834. Reason for revert: Tegra3!!!! Original change's description: > Make GrCopySurfaceOp friendlier to GrSurfaceProxy > > Change-Id: Iba8c068bd96ab154d466e485a9db31dd552138de > Reviewed-on: https://skia-review.googlesource.com/11325 > Commit-Queue: Robert Phillips <robertphillips@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Idc31d469d94e6e2772ee5714987b3a05bb902d88 Reviewed-on: https://skia-review.googlesource.com/11580 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Specialize boxBlur(Interp) based on 'transpose' parameterGravatar Hans Wennborg2017-04-06
| | | | | | | | | | | | | | | | | boxBlurInterp showed up hot when running Speedometer. I noticed that BoxBlur calls boxBlurInterp repeatedly, the call does not get inlined, and the function could be simplified a bit if 'transpose' is a compile-time constant. In particular, dst_x_stride or dst_y_stride now become a constant 1, which simplifies the dptr updates. Bug: skia:none Change-Id: I8782e5b133a2195328e13878aca8a749af150b86 Reviewed-on: https://skia-review.googlesource.com/11362 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Manual revert: Add support for writing ICC profiles to webp encoder"Gravatar Matt Sarett2017-04-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4293a1e5f259cf12560d6e794c1a05ad4dbc0b32. Reason for revert: Relanding, libwebp updated in Android master Original change's description: > Manual revert: Add support for writing ICC profiles to webp encoder > > Bug: skia: > Change-Id: I4e70bee8c2ea8dbd5ae1e84aa097f5a7e2e62721 > Reviewed-on: https://skia-review.googlesource.com/11444 > Reviewed-by: Matt Sarett <msarett@google.com> > Reviewed-by: Leon Scroggins <scroggo@google.com> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,scroggo@google.com,reviews@skia.org,jzern@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I73aa9e8183241ada4ec6451567bce3d3d18995cc Reviewed-on: https://skia-review.googlesource.com/11523 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* jumper, gather_8888Gravatar Mike Klein2017-04-06
| | | | | | | Change-Id: I70bd64d114a2460534bcb51d356e13d9bc3b8603 Reviewed-on: https://skia-review.googlesource.com/11491 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make GrCopySurfaceOp friendlier to GrSurfaceProxyGravatar Robert Phillips2017-04-06
| | | | | | | Change-Id: Iba8c068bd96ab154d466e485a9db31dd552138de Reviewed-on: https://skia-review.googlesource.com/11325 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* tweaks to make gather_* easier in SkJumperGravatar Mike Klein2017-04-06
| | | | | | | | | | | | | | This moves all the values that gather_8888, gather_a8, etc. need to the front of SkImageShaderContext, and dereferences the color table. This should be a no-op, but will make these stages easier to write in SkJumper. Change-Id: I0dff97d5113d14e941e7b717cd85f0036764eb88 Reviewed-on: https://skia-review.googlesource.com/11492 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* jumper, turn off a few fancy featuresGravatar Mike Klein2017-04-06
| | | | | | | | | | | | | | | | | | | | | | | This doesn't change any of the generated .S files, but it does cut a few misc. sections from the intermediate .o files. It's nice to get those sections out of the way, and one day we might be able to find ways to cut everything but .text... that'd allow us to switch the supicious section sniffing code from a blacklist (no .const, no .literal, etc.) to a more foolproof whitelist (.text or bust). The remaining sections are only in ELF objects (aarch64.o, vfp4.o): .comment (notes the version of Clang/LLVM that compiled it) .note.GNU-stack (we manually add this back in build_stages.py) and vfp4.o has two more sections that I don't understand yet: .ARM.exidx (I'd have thought -fno-unwind-tables would cut this) .ARM.attributes While doing this, I've tried to make the ARM flags a bit more compact. Change-Id: I30ef6acb2a917ec938c5358c3f970fe04b6d7afa Reviewed-on: https://skia-review.googlesource.com/11485 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* make copyTo_with_allocator android onlyGravatar Mike Reed2017-04-06
| | | | | | | | | Bug: skia:6464 Change-Id: I3d95daae2ae854671e6231e62f200913ce3586d0 Reviewed-on: https://skia-review.googlesource.com/11486 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Commit the patch before bundling recipesGravatar Eric Boren2017-04-06
| | | | | | | | | | | This was part of https://skia-review.googlesource.com/c/11340/ but split out before relanding. Bug: skia:5813 Change-Id: I5cc97a588300a8656989a8d73e1231bdd606ef39 Reviewed-on: https://skia-review.googlesource.com/11483 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Factor out common work in readSurfacePixels and writeSurfacePixelsGravatar Brian Osman2017-04-06
| | | | | | | | | | | | Use more consistent structure between the two functions. BUG=skia:5853 Change-Id: I82465bee30025574d0d6fad9e287b187d75fff8d Reviewed-on: https://skia-review.googlesource.com/10042 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* handle odd-index-count in encode/decodeGravatar Mike Reed2017-04-06
| | | | | | | | Bug: skia: Change-Id: Iffb123001a77049c6581f63bbc69c62f241a87f8 Reviewed-on: https://skia-review.googlesource.com/11405 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* fix 36605271Gravatar Cary Clark2017-04-06
| | | | | | | | | | | | | typo in function header makes it appear that a buffer overflow may occur R=djsollen@google.com Bug: b/36605271 Change-Id: Iab6d08ae71f49c46736dc025791faefdeb74df5e Reviewed-on: https://skia-review.googlesource.com/11454 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "Remove CPU dimension for Win GCE bots"Gravatar Eric Boren2017-04-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 25bf350d1096622e10cb9d244705c91ed309f8e6. Reason for revert: Speculatively reverting to see if this unsticks try jobs. Original change's description: > Remove CPU dimension for Win GCE bots > > This is mainly to collapse the two groups on the capacity stats page. > > Bug: skia: > Change-Id: Icc125f6fa773ebf11909b0606bc7958146da5983 > Reviewed-on: https://skia-review.googlesource.com/11417 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Eric Boren <borenet@google.com> > TBR=borenet@google.com,kjlubick@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I52f01f6a915fa0ac4446bd492b9e455a07841ee9 Reviewed-on: https://skia-review.googlesource.com/11484 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* jumper, add load_f32()Gravatar Mike Klein2017-04-06
| | | | | | | Change-Id: I71d85ffe29bc11678ff1e696fa4a2c93d0b4fcbe Reviewed-on: https://skia-review.googlesource.com/11446 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* jumper, kill off F4Gravatar Mike Klein2017-04-06
| | | | | | | | | | | | | | | | Its alignment (sometimes 4, sometimes 16) has proven to be error-prone. This also means we don't really need LazyCtx::load(). I think I only had it there to make sure we were doing unaligned loads of F4; the better way is to just never declare the data as aligned... The generated code isn't quite as good, but I can live with it. Change-Id: I5d57a580ca12c94ca84a5e8b72a66cf8d0c829eb Reviewed-on: https://skia-review.googlesource.com/11406 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* jumper, only print non-zero countsGravatar Mike Klein2017-04-06
| | | | | | | | | This makes it easier for me to read. Change-Id: I6936c31981a2af6b7d3d7db9e60d36010fefa7ec Reviewed-on: https://skia-review.googlesource.com/11445 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Manual revert: Add support for writing ICC profiles to webp encoderGravatar Matt Sarett2017-04-06
| | | | | | | | | Bug: skia: Change-Id: I4e70bee8c2ea8dbd5ae1e84aa097f5a7e2e62721 Reviewed-on: https://skia-review.googlesource.com/11444 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Add Windows tester to the CQGravatar Eric Boren2017-04-06
| | | | | | | | | | | | This will likely be followed up by an increase in number of Win VMs. Bug: skia:6462 Change-Id: If22d934c43c57d4ad3a20730e91caed0d4848cd4 Reviewed-on: https://skia-review.googlesource.com/11440 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Remove CPU dimension for Win GCE botsGravatar Eric Boren2017-04-06
| | | | | | | | | | This is mainly to collapse the two groups on the capacity stats page. Bug: skia: Change-Id: Icc125f6fa773ebf11909b0606bc7958146da5983 Reviewed-on: https://skia-review.googlesource.com/11417 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Do nondeterministic FP testing on iOSGravatar Brian Osman2017-04-06
| | | | | | | | Bug: skia:6395 Change-Id: Icc2ba15c6152b8e68bbad656c3ebadb12b56d55e Reviewed-on: https://skia-review.googlesource.com/11403 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "SpecialImageTest no longer fails on GalaxyS6."Gravatar Ben Wagner2017-04-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 093cb35807b20c6571874e5f8621bef5e9524b81. Reason for revert: Not sure why, but it's failing again today. Original change's description: > SpecialImageTest no longer fails on GalaxyS6. > > BUG=skia:6338 > NOTRY=true > > Change-Id: Ie7305f654e9f818dc31cb49eba2e7bf4000a36f9 > Reviewed-on: https://skia-review.googlesource.com/11411 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > TBR=benjaminwagner@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6338 Change-Id: I1e07c74d37682df42023e3b52924f9a29da2cccb Reviewed-on: https://skia-review.googlesource.com/11441 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* remove legacy vertices flag and codeGravatar Mike Reed2017-04-06
| | | | | | | | Bug: skia:6366 Change-Id: Ibea5f71c5ff570e4f3ccec7d064893602c3335cf Reviewed-on: https://skia-review.googlesource.com/11359 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove SK_SUPPORT_LEGACY_BITMAP_SETPIXELREF flag and codeGravatar Mike Reed2017-04-06
| | | | | | | | Bug: skia: Change-Id: I234d221d685a6feab891cbca84869177b4a954bb Reviewed-on: https://skia-review.googlesource.com/11404 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Use bundled recipes on all Test/Perf tasks"Gravatar Eric Boren2017-04-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 43b9c6bbf66b0927a99062c68dff9ea8358f82db. Reason for revert: Windows failing Original change's description: > Use bundled recipes on all Test/Perf tasks > > It won't save as much time for faster machines, but it should still > shave a few seconds, and it'll be nice to be consistent. > > Bug: skia:5813 > Change-Id: I5724e7aae83851edff3129265a9ffee5c3f95825 > Reviewed-on: https://skia-review.googlesource.com/11340 > Commit-Queue: Eric Boren <borenet@google.com> > Reviewed-by: Kevin Lubick <kjlubick@google.com> > TBR=borenet@google.com,kjlubick@google.com,reviews@skia.org,iannucci@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I2a9cc1c12079755969879e37da5cae9f93921ddd Reviewed-on: https://skia-review.googlesource.com/11416 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* add guard for obsolete (non-functioning) replayClipsGravatar Mike Reed2017-04-06
| | | | | | | | | | | | replayClips has been disabled (broken) for a while. This CL just attempts to hide the api (will remove once android's callsite is removed) Bug: skia: Change-Id: I35b412addfc0a08ea888a62609888b9b54dce2a6 Reviewed-on: https://skia-review.googlesource.com/11401 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Rm readPixels from GrSurface & move read/writeSurfacePixels to GrContextPriv ↵Gravatar Robert Phillips2017-04-06
| | | | | | | | | | | | | (take 3) This is in service of: https://skia-review.googlesource.com/c/11125/ (Add parallel proxyID to StencilOps & RenderTargetOpList) where I want a better choke point for texture creation to improve discard handling. This is a re-reland of: https://skia-review.googlesource.com/c/11200/ (Rm readPixels from GrSurface & move read/writeSurfacePixels to GrContextPriv) Change-Id: Icfb9dd223418dd460405efd2bfd9d1c356beed1a Reviewed-on: https://skia-review.googlesource.com/11412 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Use bundled recipes on all Test/Perf tasksGravatar Eric Boren2017-04-06
| | | | | | | | | | | It won't save as much time for faster machines, but it should still shave a few seconds, and it'll be nice to be consistent. Bug: skia:5813 Change-Id: I5724e7aae83851edff3129265a9ffee5c3f95825 Reviewed-on: https://skia-review.googlesource.com/11340 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* SpecialImageTest no longer fails on GalaxyS6.Gravatar Ben Wagner2017-04-06
| | | | | | | | | | BUG=skia:6338 NOTRY=true Change-Id: Ie7305f654e9f818dc31cb49eba2e7bf4000a36f9 Reviewed-on: https://skia-review.googlesource.com/11411 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update MotoG4 to NPJ25.93-14.Gravatar Ben Wagner2017-04-06
| | | | | | | | | | NOTRY=true BUG=skia:6453 Change-Id: Ie8c35643c7e038f64f03d95e1f8d58ba748d4a52 Reviewed-on: https://skia-review.googlesource.com/10754 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix the size check for the drawBitmap fast-path in ↵Gravatar lsalzman2017-04-05
| | | | | | | | | | | SkBitmapDevice::drawBitmapRect. It would fail when the source rectangle had a non-zero offset, in which case it would compare the source rectangle with the offset to the extracted bitmap size, which always fails. The only thing that should matter is that the source rectangle and extract bitmap have the same size, since the offset gets added onto the matrix. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2089583002 Review-Url: https://codereview.chromium.org/2089583002 Committed: https://skia.googlesource.com/skia/+/ea9bc0c07b5dae78a9a449d7d7a07fc79262d41a Review-Url: https://codereview.chromium.org/2089583002
* Fix gather_uninteresting_hashes()Gravatar Mike Klein2017-04-05
| | | | | | | | | | | | | | | | | | | It can crash when the file length is an exact multiple of the page size. When the file size is not an exact page size multiple, SkData::MakeFromFileName() (i.e. mmap) happens to fill the rest with \0, giving us a terminating \0 for free. SkStrSplit() uses this to stop. When the file size is an exact page size multiple, there's no guaranteed \0. We might find one on the next page immediately, eventually, or we might just segfault. Whoops. To fix, copy to an SkString which ought to plop in a \0 for us. Change-Id: I51bbfdd85dfbb1c2276249d0255cf1c410ef9999 Reviewed-on: https://skia-review.googlesource.com/11409 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-23 20:12:51 +0000