aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Add SkFloat2Bits and Region stubGravatar Kevin Lubick2018-07-17
| | | | | | | | Bug: skia: Change-Id: I5ab9a4d42e9eec6563499a09e08ed8b183ac91b2 Reviewed-on: https://skia-review.googlesource.com/141426 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* build for gdb on linuxGravatar Cary Clark2018-07-17
| | | | | | | | | | | | | | | | | | build debug on linux for gdb Building with this define enables additional checks for standard library functions when running gdb, and allows printing std::string. R=halcanary@google.com Bug: skia: Change-Id: I7f2dc12336f9239443328f13264be7a6b285c4b5 Reviewed-on: https://skia-review.googlesource.com/140786 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-on: https://skia-review.googlesource.com/141083 Commit-Queue: Cary Clark <caryclark@skia.org>
* fix bookmaker build botGravatar Cary Clark2018-07-17
| | | | | | | | | | | | | | | | | Sync up with deletion of SkTransferFunctionBehavior. TBR=brianosman@google.com NOTRY=true Docs-Preview: https://skia.org/?cl=141828 Bug: skia:6818 Change-Id: Ibcfad17b8e886a4c980e4eb2bbae5a007f4bb36e Reviewed-on: https://skia-review.googlesource.com/141828 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Cary Clark <caryclark@skia.org>
* Restore SkLightingShader and associated classesGravatar Robert Phillips2018-07-17
| | | | | | | | | This reverts https://skia-review.googlesource.com/c/skia/+/31140 (Remove SkLightingShader and associated classes) and updates the classes to ToT Change-Id: I3b1df1704cca8907aa00f081a7e93339b65ad4fa Reviewed-on: https://skia-review.googlesource.com/141545 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Bug fixes and improvements to SKC and HotSort. Vulkan is WIP.Gravatar Allan MacKinnon2018-07-17
| | | | | | | | | Bug: skia: Change-Id: Iffc75a5b4dfcbfa4a6c23d972bb9798c2f550335 Reviewed-on: https://skia-review.googlesource.com/141582 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Allan MacKinnon <allanmac@google.com> Commit-Queue: Allan MacKinnon <allanmac@google.com>
* remove unused untested parts of text blobGravatar Cary Clark2018-07-17
| | | | | | | | | | | | | | | | | SkTextBlob has a number of untested entry points to serialize and deserialize. Privitize ones only used by Skia, and remove ones suspected to be unused and untested. R=fmalita@chromium.org TBR=reed@google.com,bsalomon@google.com Bug: skia:6818 Change-Id: I6a9982a26a883982af3592f3302029a1bcdf5aa3 Reviewed-on: https://skia-review.googlesource.com/141820 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* Roll third_party/externals/angle2 6fb8ba4e8660..d691aeeb956f (1 commits)Gravatar angle-skia-autoroll2018-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/6fb8ba4e8660..d691aeeb956f git log 6fb8ba4e8660..d691aeeb956f --date=short --no-merges --format='%ad %ae %s' 2018-07-17 geofflang@chromium.org Vulkan: Implement GL_CHROMIUM_copy_texture with CPU copies. Created with: gclient setdep -r third_party/externals/angle2@d691aeeb956f The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=bungeman@google.com Change-Id: I55a67173ef6f9fe888928b442774b13c72eeffaa Reviewed-on: https://skia-review.googlesource.com/141920 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* added byte and ubyte types to SKSLGravatar Ruiqi Mao2018-07-17
| | | | | | | | | | | created new GMs for skinning Bug: skia: Change-Id: I15fb2bd02fba8beb6dd2dd3f3716da016ea92192 Reviewed-on: https://skia-review.googlesource.com/140241 Commit-Queue: Ruiqi Mao <ruiqimao@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Remove crash when shader linking fails.Gravatar Brian Salomon2018-07-17
| | | | | | | | | Bug: 861956 Change-Id: If60c1f4112702d8f96cb27a624de167049b34370 Reviewed-on: https://skia-review.googlesource.com/141547 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Remove SkTransferFunctionBehaviorGravatar Brian Osman2018-07-17
| | | | | | | | Bug: skia: Change-Id: Iccbe609b2a8d4c9098ef36aa6530dbc3771e0c11 Reviewed-on: https://skia-review.googlesource.com/141055 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "Remove interpolants are inaccurate workaround for Adreno 3xx."Gravatar Brian Salomon2018-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of a7a278205bb040061cb4ba46839efe18635c7edc Clean reland. Change to Chrome screenshot unit test has stuck. The previous revert of that was the reason this had to be reverted. Original change's description: > Remove interpolants are inaccurate workaround for Adreno 3xx. > > The chrome screenshot unit test that led to adding this workaround has > been adjusted to avoid testing AA edges of rendered rectangles. We're > accepting the inaccuracy in favor of increased performance. > > Chrome change: https://chromium-review.googlesource.com/c/chromium/src/+/1129041 > > Bug: chromium:847984 > Change-Id: I9b714ade2a67e956ebb2773ebe3b8632dc3a50c6 > Reviewed-on: https://skia-review.googlesource.com/140180 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> > Auto-Submit: Brian Salomon <bsalomon@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> Bug: chromium:847984 Change-Id: I2dc1195f07bb27015b0a7a0fa6263d0e60a32a15 Reviewed-on: https://skia-review.googlesource.com/141761 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* polish picture and rrect docsGravatar Cary Clark2018-07-17
| | | | | | | | | | | | TBR=caryclark@google.com Docs-Preview: https://skia.org/?cl=141263 Bug: skia:6818 Change-Id: I33a197892b3dd5788499dda9dd9e95ddab861388 Reviewed-on: https://skia-review.googlesource.com/141263 Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Revert "Reduce arbitrary opList splitting when sorting"Gravatar Robert Phillips2018-07-17
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 94fee93c9b23bd1a32604753da8bef755d6c8a95. Reason for revert: Android (and Chromecast) woes Original change's description: > Reduce arbitrary opList splitting when sorting > > Change-Id: I49a47672600f72dc46f27462a2c344e77a06a659 > Reviewed-on: https://skia-review.googlesource.com/141243 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: Ic4fd4ab17bb15bef35dcbf852e0f8ad99ee45e8f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/141760 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Reduce arbitrary opList splitting when sortingGravatar Robert Phillips2018-07-17
| | | | | | | Change-Id: I49a47672600f72dc46f27462a2c344e77a06a659 Reviewed-on: https://skia-review.googlesource.com/141243 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll third_party/externals/angle2 e076a2327f0d..6fb8ba4e8660 (3 commits)Gravatar angle-skia-autoroll2018-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/e076a2327f0d..6fb8ba4e8660 git log e076a2327f0d..6fb8ba4e8660 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jmadill@chromium.org DisplayD3D: Don't release bound texture in restoreLostDevice. 2018-07-16 jmadill@chromium.org Surface: Use ref count for bindTexImage. 2018-07-16 theoking@google.com Vulkan: Fixed improperly set env variable Created with: gclient setdep -r third_party/externals/angle2@6fb8ba4e8660 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=bungeman@google.com Change-Id: Idbfe211fb9d9a0de331acc5f07753eb2cfd62962 Reviewed-on: https://skia-review.googlesource.com/141702 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Update markdown filesGravatar skia-bookmaker2018-07-17
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I918bfe1968085e6a61bc98e6811c51b22c4920c2 Reviewed-on: https://skia-review.googlesource.com/141721 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-17
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/54edfa4e534d10fe2029685b10dd0a302b5fc82e Update metrics.README.md (ehmaldonado@chromium.org) https://crrev.com/40bacee96a94600ad2179d69a8025469d119960f Revert "gclient_scm: Use cherry-picking instead of rebasing." (jbudorick@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb5bd45acb70ed98db3e396275ad16423be42c83 Reviewed-on: https://skia-review.googlesource.com/141680 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e396449f8434e3faf4151c36b5ad3f2377b80608 Add typechecking to file recipe module (thomasanderson@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I97b6eb73c9337b3bfb0afc2867e087e3a83217b8 Reviewed-on: https://skia-review.googlesource.com/141640 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2 ddd8eaa8dca0..e076a2327f0d (7 commits)Gravatar angle-skia-autoroll2018-07-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ddd8eaa8dca0..e076a2327f0d git log ddd8eaa8dca0..e076a2327f0d --date=short --no-merges --format='%ad %ae %s' 2018-07-16 geofflang@chromium.org Vulkan: Fix ReadPixels checking the wrong FBO for flipping. 2018-07-16 jmadill@chromium.org Vulkan: Store ProgramVk shaders in ShaderInfo. 2018-07-16 jmadill@chromium.org Context: Fix missing "setErrorSet". 2018-07-16 jmadill@chromium.org Vulkan: Implement "default" vertex attributes. 2018-07-16 fjhenigman@chromium.org Vulkan: Convert streamed vertex data as needed. 2018-07-16 jmadill@chromium.org Vulkan: Store program textures cache. 2018-07-16 jmadill@chromium.org Vulkan: Add a create shader helper. Created with: gclient setdep -r third_party/externals/angle2@e076a2327f0d The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=bungeman@google.com Change-Id: Ic926d46b41d7bbc129c9aa6d4cb6d54e417e41c4 Reviewed-on: https://skia-review.googlesource.com/141620 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-16
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/fb734036f4b5ae6d5afc63cbfc41d3a5d1c29a82 [cipd] Update CIPD client to 2.1.0 (b9c4670197 -> 521b9b6477). (vadimsh@chromium.org) https://crrev.com/fb78b368de1bf462197e376616ffdde5fe65f066 gclient_scm: Use cherry-picking instead of rebasing. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I38c17634deff6b0183d906967e4d1999b0377b70 Reviewed-on: https://skia-review.googlesource.com/141567 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Remove SkRefDict.Gravatar Ben Wagner2018-07-16
| | | | | | | | | It is unused. Remove it. Change-Id: If62a93a58d21bfccd6df112e92a709bff4d11c97 Reviewed-on: https://skia-review.googlesource.com/141566 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Stop running gltestpersistentcache in PreAbandonContext modeGravatar Brian Salomon2018-07-16
| | | | | | | | | | | The config fails to initialized in push_sinks because readbacks in test draw don't match (as the GrContext is already in abandoned mode). Change-Id: I73c68ab52df3e83b688ab43fbe74cf4c1ae8c19d Reviewed-on: https://skia-review.googlesource.com/141562 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Remove processText last vestige of drawTextGravatar Herb Derby2018-07-16
| | | | | | | Change-Id: I03a8c094533cdda1e6e3a43d0124889ef6476b0b Reviewed-on: https://skia-review.googlesource.com/141560 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Remove drawText support from SkOverdrawCanvasGravatar Herb Derby2018-07-16
| | | | | | | | | | | This canvas is used by android, and never uses the drawText method. I think this is the last call to processText which will be deleted shortly. Change-Id: I134abff47b0b7fda02297e4b4496e2f0413a3957 Reviewed-on: https://skia-review.googlesource.com/141546 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Blacklist dftext from gltestpersistentcacheGravatar Brian Salomon2018-07-16
| | | | | | | TBR: egdaniel@google.com Change-Id: I730437d106413cdbb738a14b604455880326d514 Reviewed-on: https://skia-review.googlesource.com/141561 Reviewed-by: Brian Salomon <bsalomon@google.com>
* Test GrContextOptions persistent cache on linux/quadrop400 bots.Gravatar Brian Salomon2018-07-16
| | | | | | | Change-Id: I181ed6d294774a9c6886fde8252bfdde99adc572 Reviewed-on: https://skia-review.googlesource.com/140982 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* [skottie] Treat color properties as optional (default black)Gravatar Florin Malita2018-07-16
| | | | | | | | TBR= Change-Id: I51029b5718ec9925c214709ae4e3497dae130d37 Reviewed-on: https://skia-review.googlesource.com/141544 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* GrTessellator: collinear edges during sanitize.Gravatar Stephen White2018-07-16
| | | | | | | | | | | | When three collinear edges occur during the sanitize_contours() pass, their vertices may not yet have been discovered to be coincident. So we must do the vertex comparison by point, rather than by pointer. Bug: 860655 Change-Id: I89dc7526905bb5473206661348fee431371731a0 Reviewed-on: https://skia-review.googlesource.com/141523 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Device interface uses glyph run listGravatar Herb Derby2018-07-16
| | | | | | | | | | | | | Have devices just treat all runs as drawPosText except for SkGPUDevice and SkRemoteGlyphCache. Those two just pass the blob to the old code. This way the change over from blobs to run lists can happen in smaller steps. Change-Id: I3407bffeafe7fbd1c369f6b3c3db8d64b4b6c3b1 Reviewed-on: https://skia-review.googlesource.com/141300 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Re-add Android Vulkan tryjob to CQ.Gravatar Ben Wagner2018-07-16
| | | | | | | | | | | | | | | | | In https://skia-review.googlesource.com/c/skia/+/140344, we removed Nexus5x jobs from the CQ due to insufficient capacity. This CL re-adds the NVIDIA_Shield for testing Vulkan on Android. It seems like we have enough capacity, and most NVIDIA_Shield tasks complete within a few minutes. The other removed job was already covered by Test-Android-Clang-GalaxyS6-GPU-MaliT760-arm64-Release-All-Android. Change-Id: Ib84bb4d8992856634a5f66900b42cbb413aab6be Reviewed-on: https://skia-review.googlesource.com/141540 Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Roll skia/third_party/skcms ae6a7acc22e5..dad22fe0e646 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-07-16
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/ae6a7acc22e5..dad22fe0e646 2018-07-16 borenet@google.com Remove sign_cla entry from cq.cfg The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=bungeman@google.com Change-Id: Iead8a4318772e907629258781fc0e712cc3678fd Reviewed-on: https://skia-review.googlesource.com/141501 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 76c1d14b8e21..ddd8eaa8dca0 (1 commits)Gravatar angle-skia-autoroll2018-07-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/76c1d14b8e21..ddd8eaa8dca0 git log 76c1d14b8e21..ddd8eaa8dca0 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 cwallez@chromium.org Suppress reverse blits tests on Qualcomm/Vulkan Created with: gclient setdep -r third_party/externals/angle2@ddd8eaa8dca0 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=bungeman@google.com Change-Id: Ic467d02db904931f3a1a3ec51173851ecede7e47 Reviewed-on: https://skia-review.googlesource.com/141481 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* In GrContext::readSurfacePixels fail gracefully if temp pixmap allocationGravatar Brian Salomon2018-07-16
| | | | | | | | | | | fails. Bug: chromium:860399 Change-Id: I6793e7fe7e97b7848d40170046dcff4c2fcc48c7 Reviewed-on: https://skia-review.googlesource.com/141101 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com>
* Whitespace cleanup againGravatar Hal Canary2018-07-16
| | | | | | | | Change-Id: I38ab9ff141eb088084a4c0e664f327ceb89fcf70 Reviewed-on: https://skia-review.googlesource.com/140784 Commit-Queue: Hal Canary <halcanary@google.com> Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* plumb through arenaallocGravatar Mike Reed2018-07-16
| | | | | | | | | | | - simplifies the older pattern of storage/size - removes a dynamic allocation in defaultbitmapcontroller Bug: skia: Change-Id: Ibc937d3e0c057e78cc0c8bf7d9ad2d824eb240d9 Reviewed-on: https://skia-review.googlesource.com/141321 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove sign_cla entry from cq.cfgGravatar Eric Boren2018-07-16
| | | | | | | | Bug: chromium:851750 Change-Id: I78acb449aa4ccbe25a38913ca68f701fa2aedcb5 Reviewed-on: https://skia-review.googlesource.com/141462 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* update generated md filesGravatar Cary Clark2018-07-16
| | | | | | | | | | | | | | | | can't really tell what changed here maybe lf style? TBR=jcgregario@google.com No-Try: true Docs-Preview: https://skia.org/?cl=141461 Bug: skia:6818 Change-Id: I8ddce168b07751b6abdc7931e71613afbb74b872 Reviewed-on: https://skia-review.googlesource.com/141461 Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Shuffle jobs off Nexus5x.Gravatar Ben Wagner2018-07-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All Golo devices except 2 are AWOL. We added 6 to the Skolo, but they can't keep up. This CL moves the following jobs off Nexus5x: - All ASAN jobs to Pixel. Most other devices we have can't be rooted, so they can't run ASAN. - Vulkan NoGPUThreads arm64 jobs to NVIDIA_Shield. Of the devices that support Vulkan, this has the most available capacity. - I removed the arm32 Vulkan NoGPUThreads jobs because it seems a bit esoteric. - Also removed arm32 Vulkan Debug Perf because I can't imagine it would ever give us info that arm64 doesn't already provide. (We ignore Perf data from Debug builds.) - Other arm32 Vulkan jobs stayed on Nexus5x because we don't have any other Vulkan-capable devices with spare capacity. - Most arm32 jobs to MotoG4 and de-duplicated. This device has an ARMv8 processor but runs everything in arm32 mode, which is exactly what these jobs are trying to test. We have a bunch of MotoG4s in the Skolo; however, they don't support Vulkan or ASAN. - NoGPUThreads and NativeFonts arm64 jobs to GalaxyS6. There are only 6 in the Skolo, but for some reason these devices are particularly fast. They also don't support Vulkan or ASAN. - Currently GalaxyS6 CPU arm64 jobs fail, possibly due to OOM. I will try to move those jobs in a future CL. Sorted jobs.json. Change-Id: If02584a9c04906f4b9c31b4ba3f1da0289a5b8a9 Reviewed-on: https://skia-review.googlesource.com/141281 Commit-Queue: Joe Gregorio <jcgregorio@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com>
* Update markdown filesGravatar skia-bookmaker2018-07-16
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I03c2a6518b2bf7dd6972744d3184c20f513d23ed Reviewed-on: https://skia-review.googlesource.com/141446 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-16
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/8d3925b164822e2660d3b985402a5681432b0285 Add support to gclient for skipping CIPD deps. (jsca@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4b23b890ed5ec3eaf08a7e3e750eed27f8a270ab Reviewed-on: https://skia-review.googlesource.com/141428 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Update SKP versionGravatar skia-recreate-skps2018-07-15
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I600e9d18b4a1df49ca5287b9023572c0d82d2bcd Reviewed-on: https://skia-review.googlesource.com/141441 Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
* Update markdown filesGravatar skia-bookmaker2018-07-15
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: If98e6671e6f3ea89c33f147d6a5608dc9599441c Reviewed-on: https://skia-review.googlesource.com/141398 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* [skottie] Teach skottie_tool to dump frame SKPsGravatar Florin Malita2018-07-15
| | | | | | | | | | Similar to saving PNG frames, now we can save SKPs. TBR= Change-Id: I5791b564a1d3e70424e45e62034e559e677795f1 Reviewed-on: https://skia-review.googlesource.com/141320 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll third_party/externals/angle2 92e955f2c4ab..76c1d14b8e21 (1 commits)Gravatar angle-skia-autoroll2018-07-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/92e955f2c4ab..76c1d14b8e21 git log 92e955f2c4ab..76c1d14b8e21 --date=short --no-merges --format='%ad %ae %s' 2018-07-14 jmadill@chromium.org D3D11: Lift dEQP-GLES3 uniform_api test expectations. Created with: gclient setdep -r third_party/externals/angle2@76c1d14b8e21 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=robertphillips@google.com Change-Id: I023b89029eee07da4b33745c16fa3dbd326eae42 Reviewed-on: https://skia-review.googlesource.com/141393 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 06ca634eba4a..92e955f2c4ab (1 commits)Gravatar angle-skia-autoroll2018-07-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/06ca634eba4a..92e955f2c4ab git log 06ca634eba4a..92e955f2c4ab --date=short --no-merges --format='%ad %ae %s' 2018-07-14 theoking@google.com Vulkan: Fix premature pointer freeing Created with: gclient setdep -r third_party/externals/angle2@92e955f2c4ab The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=robertphillips@google.com Change-Id: Ida457b60ca05d9fceac2c6e1c97aada894b0318e Reviewed-on: https://skia-review.googlesource.com/141390 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Update markdown filesGravatar skia-bookmaker2018-07-14
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I10df1c7624fe2ace0c3e1336e172990e72bb0c45 Reviewed-on: https://skia-review.googlesource.com/141387 Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-14
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/2f38df65f95e1e65f276f9bd654b8a98109e6c95 gclient: Reset the fetch config also when --force is passed. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iabd6d56f6b1531ee55755fc46f0e642276e13eac Reviewed-on: https://skia-review.googlesource.com/141424 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-07-14
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/579c98612b6ff77608ecb5fdebc40276b371ddd9 Reset the fetch config in the bots before each run. (ehmaldonado@chromium.org) https://crrev.com/455ee3a61e2bce75229ee007f73bd5a7b450284c bot_update: Don't pass reset-fetch-config to gclient (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I957dadffe939b791f4a10767ff8c7ca2791c37fc Reviewed-on: https://skia-review.googlesource.com/141380 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2 0cc291365934..06ca634eba4a (7 commits)Gravatar angle-skia-autoroll2018-07-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0cc291365934..06ca634eba4a git log 0cc291365934..06ca634eba4a --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org Vulkan: Refactor for draw call shader patching. 2018-07-13 fjhenigman@chromium.org Vulkan: prepare for buffer format fallbacks. 2018-07-13 jmadill@chromium.org dEQP: Fix non-GTest error logging. 2018-07-13 lucferron@chromium.org Vulkan: Implement gl_DepthRange support using driver uniform 2018-07-13 lucferron@chromium.org Vulkan: Enable viewport Y flipping 2018-07-13 jmadill@chromium.org Vulkan: Use angle::Result error handling. 2018-07-13 jmadill@chromium.org Add gl::ErrorSet and angle::Result. Created with: gclient setdep -r third_party/externals/angle2@06ca634eba4a The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=robertphillips@google.com Change-Id: Ifc257e5968d12a4bba2896f028e7b34443e8102f Reviewed-on: https://skia-review.googlesource.com/141340 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* make u32 check runtimeGravatar Mike Reed2018-07-13
| | | | | | | | | Bug: 848521 Change-Id: Id3deb30447cc5caa27203b46b6b257e76cd88679 Reviewed-on: https://skia-review.googlesource.com/140986 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>