aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Do color correction of vertex colors in GPU drawVerticesGravatar Brian Osman2017-05-31
| | | | | | | | | | | SkColor vertex colors need to be linearized (from sRGB), and possibly converted from sRGB gamut to destination gamut. Bug: skia:6659 Change-Id: I2b1b1dd0fa5938519693f56a728fed5957f13fd5 Reviewed-on: https://skia-review.googlesource.com/17534 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* slant colorfilter away from filterSpan4fGravatar Mike Reed2017-05-31
| | | | | | | | | | | rename to make it easy to delete any impl that also had onAppendStages... i.e. rename to make it clear that it is just an impl trick for rasterpipeline. Bug: skia: Change-Id: If3c3b2811eff12d399cdf7a77552c01e72c06996 Reviewed-on: https://skia-review.googlesource.com/18234 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Add CIPD asset for ValgrindGravatar Eric Boren2017-05-31
| | | | | | | | | Bug: skia:6668 Change-Id: I324602b1381f701ec780c02b26775c5e9e09cb84 Reviewed-on: https://skia-review.googlesource.com/17834 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* fix incorrect variable not assigned error in skslcGravatar Ethan Nicholas2017-05-31
| | | | | | | | Bug: skia: Change-Id: Id89db8acb0b14024b79b00d98d32f9c10f019537 Reviewed-on: https://skia-review.googlesource.com/18121 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* enable geometry shader support in GrGLShaderStringBuilderGravatar Ethan Nicholas2017-05-31
| | | | | | | | Bug: skia: Change-Id: Ibbd5209eb3aef9543b7195a114e39ee4254a56c3 Reviewed-on: https://skia-review.googlesource.com/18062 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/694773d5924f9b463710a04f678ebed6db1edad5 gclient: enable syntax validation by default (reland #1) (phajdan.jr@chromium.org) https://crrev.com/c7ba0332596d233510030171ba09bbca230572f7 gclient: allow dict syntax in deps, in preparation for conditions (phajdan.jr@chromium.org) https://crrev.com/1101645d533f44d3fe650d1635fa4bbe2b6eb716 gclient: fix assertion crash when a dep is set to None (phajdan.jr@chromium.org) https://crrev.com/05fec0394f8eec6e2a3c53f9c34a079640e8cffe gclient: fix recursedeps tuple/list validation for chromeos (phajdan.jr@chromium.org) https://crrev.com/aad003b6c1e081db8012c1d2f7a76e5c2f83d6ce Support VS 2017 Preview and changed VS directories (brucedawson@chromium.org) https://crrev.com/d42c68114ce54ec300e58c94da46d02e0670ba77 Add git cl split. (fdoray@chromium.org) https://crrev.com/c515a8bc469453091d7d55c906496d78761fb696 bot_update: expose --disable-syntax-validation to recipes (phajdan.jr@chromium.org) recipe_engine: https://crrev.com/84a695b241eb61b3b6d1a0fa9d63ef572d26cdbd [loader] Make recipe engine support examples/ module subdir (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6ddbf154df9d189e9b9e0c9aeb72260fe5a1a00c Reviewed-on: https://skia-review.googlesource.com/18235 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Update clearOp for split-OpList world (take 3)Gravatar Robert Phillips2017-05-31
| | | | | | | | | | | It would reduce a lot of noise if the GrRenderTargetOpList kept a pointer to the GrCaps but, for now, I'm trying to shrink the GrRTOpList, not expand it. Reland of: https://skia-review.googlesource.com/c/17323/ (Update clearOp for split-OpList world) Change-Id: Ia61ce4d6ce245380fc9651928a46c22039fc12cf Reviewed-on: https://skia-review.googlesource.com/18026 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* remove 565 sprite blitter tooGravatar Mike Klein2017-05-31
| | | | | | | | | While we're deleting sprite blitters, here's another good candidate. Change-Id: If10fc677e6bd120413b6ec54ae2e7876c2de7091 Reviewed-on: https://skia-review.googlesource.com/18232 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* allow sprite blitter for equal color spacesGravatar Mike Klein2017-05-31
| | | | | | | Change-Id: Id64aadcc372b856c4ddbf7144b3d67e618efbeb3 Reviewed-on: https://skia-review.googlesource.com/18231 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* add stages to colorfiltershaderGravatar Mike Reed2017-05-31
| | | | | | | | | | | | Interestingly, this public api (makeWithColorFilter) is only used internally by the legacy raster blitters. Perhaps we could remove/hide it? ... and that API is the only way we create one of these shaders. Bug: skia: Change-Id: I9bbd3786160844c963a78663e503e08122183701 Reviewed-on: https://skia-review.googlesource.com/18230 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Expand partial render target write pixels workaround."Gravatar Brian Salomon2017-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0cc507d22566bb7e28e5fe21e4b3fc7b682d86a2. Reason for revert: Causing IntTextureText to fail on bots Original change's description: > Expand partial render target write pixels workaround. > > The workaround is extended in the following ways: > > 1) It now applies to any texture whose base level has *ever* been attached to a FBO. > 2) It applies to Adreno 5xx in addition to Adreno 4xx > 3) It applies in the atlas upload code path. > > This workaround (and a similar one) are narrowed to GLCaps rather than Caps. > > Bug: skia: > Change-Id: Id600e9739bb97bf6766075ea2a987fd2039e53e5 > Reviewed-on: https://skia-review.googlesource.com/18150 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,robertphillips@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Change-Id: I53c8dd7ea7f614da57331470fcc24c6d84aba354 Reviewed-on: https://skia-review.googlesource.com/18229 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* assume sRGB transfer function on untagged imagesGravatar Mike Klein2017-05-31
| | | | | | | | | | | | | | | | This has been a long time coming. There are probably one or two more places we'd want to do this on the CPU side too, but it's a start. Somewhat seriously, this is my proposed fixed for colorburn + xfermodes2. We're not interpreting the red or green images sensibly. BUG=skia:6680 Change-Id: Iea15be08c1907ac1ac46ef358d3d74f1cc35a156 Reviewed-on: https://skia-review.googlesource.com/18221 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove unused spanprocs (leftover from spriteblitter simplification)Gravatar Mike Reed2017-05-31
| | | | | | | | Bug: skia: Change-Id: Iaa8cd1e5700610cddfb2092fcf7b13d12cf117bd Reviewed-on: https://skia-review.googlesource.com/18228 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Get known hashes from GS directlyGravatar Stephan Altmueller2017-05-31
| | | | | | | | Bug: skia: Change-Id: I8698aad706e2c9cc81280107cb08d83e08a9dc25 Reviewed-on: https://skia-review.googlesource.com/18145 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Revert "Revert "Delete SkGaussianEdgeShader""Gravatar Florin Malita2017-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9d14f936cc09de2a37c05c7af2cf60aa31f74722. Reason for revert: Android fix merged. Original change's description: > Revert "Delete SkGaussianEdgeShader" > > This reverts commit 64790a3714467300848971aa153aca8cea91cf7b. > > Reason for revert: pending Android fix merge. > > Original change's description: > > Delete SkGaussianEdgeShader > > > > No longer used. > > > > Change-Id: I65a61696060ca19f528066ea587e140798450e36 > > Reviewed-on: https://skia-review.googlesource.com/18132 > > Reviewed-by: Jim Van Verth <jvanverth@google.com> > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > > > TBR=jvanverth@google.com,fmalita@chromium.org,reed@google.com > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > > Change-Id: I88a428e942c78b1fc8e70501ba7fdda5727b2ab2 > Reviewed-on: https://skia-review.googlesource.com/18156 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=mtklein@google.com,jvanverth@google.com,reviews@skia.org,fmalita@chromium.org,reed@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ia6c97a79a6425a28fab49984691505bf89ac9736 Reviewed-on: https://skia-review.googlesource.com/18227 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Expand partial render target write pixels workaround.Gravatar Brian Salomon2017-05-31
| | | | | | | | | | | | | | | | The workaround is extended in the following ways: 1) It now applies to any texture whose base level has *ever* been attached to a FBO. 2) It applies to Adreno 5xx in addition to Adreno 4xx 3) It applies in the atlas upload code path. This workaround (and a similar one) are narrowed to GLCaps rather than Caps. Bug: skia: Change-Id: Id600e9739bb97bf6766075ea2a987fd2039e53e5 Reviewed-on: https://skia-review.googlesource.com/18150 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fix outset for blurs when using ignoreXform flag on GPUGravatar Greg Daniel2017-05-31
| | | | | | | | Bug: skia: Change-Id: I7d77bfc4e7652a0ab432b1137f918862ac2009cb Reviewed-on: https://skia-review.googlesource.com/18223 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Fiddle can use EGL if available.Gravatar Joe Gregorio2017-05-31
| | | | | | | | | | | | | To test this turn on egl, e.g. --args='skia_use_egl=true', and run by altering the library path to point to the right directory of the EGL driver you want to use, for example: LD_LIBRARY_PATH=/usr/lib/nvidia-367/ ./out/Release/fiddle | ./tools/fiddle/parse-fiddle-output Bug: skia: Change-Id: I2cce80318925fe88f9407646acb67628a8e48810 Reviewed-on: https://skia-review.googlesource.com/18137 Commit-Queue: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* simplify a confusing expression in SkSLSPIRVCodeGeneratorGravatar Ethan Nicholas2017-05-31
| | | | | | | | | Bug: skia: Change-Id: I3ce0c174677cf93903a5fb33287dfe1df3445837 Reviewed-on: https://skia-review.googlesource.com/18141 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Bruce Dawson <brucedawson@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* remove sprite blitters for non-legacy targets, rely on rasterpiplineGravatar Mike Reed2017-05-31
| | | | | | | | | | preliminary step to trying to remove filterSpan4f() from colorfilter Bug: skia: Change-Id: I6aa6cfde506ffac22188e9641a23a8285e80a5b9 Reviewed-on: https://skia-review.googlesource.com/18185 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* [recipes] Try removing the possibly-over-conservative git stepGravatar Eric Boren2017-05-31
| | | | | | | | Bug: skia: Change-Id: Ie6ea54d26eff7a165f32afbb5c8037b6c1921a5d Reviewed-on: https://skia-review.googlesource.com/18138 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* clean up now that min_stride == 1Gravatar Mike Klein2017-05-31
| | | | | | | Change-Id: I1c285e818c3119bc5917dee6d7fbe4c0c62ff6d7 Reviewed-on: https://skia-review.googlesource.com/18153 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* call compile in convert_with_pipeline()Gravatar Mike Klein2017-05-31
| | | | | | | | | | We used to do this a while ago, then I removed compile(). This puts things back how they used to be. Change-Id: I676ec1a06249f2356f426fd2847af093526f54d2 Reviewed-on: https://skia-review.googlesource.com/18079 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Allow GPU blur fast path for circles and rects when using ignore xformGravatar Greg Daniel2017-05-31
| | | | | | | | | | | | | Since the only thing it looks like we alter when using the ignore xform flag is the blur radius, this is already handled by the computeXformedSigma function call. Thus it should be safe to just use the current fps and draws for circle and rect. Bug: chromium:724735 Change-Id: I7a2f52dc965dcd875b8c2802141f30607a966347 Reviewed-on: https://skia-review.googlesource.com/18122 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Delete SkGaussianEdgeShader"Gravatar Florin Malita2017-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 64790a3714467300848971aa153aca8cea91cf7b. Reason for revert: pending Android fix merge. Original change's description: > Delete SkGaussianEdgeShader > > No longer used. > > Change-Id: I65a61696060ca19f528066ea587e140798450e36 > Reviewed-on: https://skia-review.googlesource.com/18132 > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=jvanverth@google.com,fmalita@chromium.org,reed@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I88a428e942c78b1fc8e70501ba7fdda5727b2ab2 Reviewed-on: https://skia-review.googlesource.com/18156 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Speculative fix for SkPerlinNoiseShaderImpl::asFragmentProcessor leakGravatar Florin Malita2017-05-30
| | | | | | | | Change-Id: I9dfa0e825f944d6abf88abfdfd585f2d504ea4f6 Reviewed-on: https://skia-review.googlesource.com/18151 Commit-Queue: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Add aarch64 tail code.Gravatar Herb Derby2017-05-30
| | | | | | | Change-Id: I25f029604a04f5fc6c249a3817b0dd84379071be Reviewed-on: https://skia-review.googlesource.com/18149 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* [Reland] Relocate shaders to own dirGravatar Florin Malita2017-05-30
| | | | | | | | | | | Consolidate all shader impls under src/shaders/. (reland of https://skia-review.googlesource.com/c/17927/) Change-Id: I7918bdc1aafe842ed194412ba95b9ae53a2ec1d7 Reviewed-on: https://skia-review.googlesource.com/18146 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Delete SkGaussianEdgeShaderGravatar Florin Malita2017-05-30
| | | | | | | | | No longer used. Change-Id: I65a61696060ca19f528066ea587e140798450e36 Reviewed-on: https://skia-review.googlesource.com/18132 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* move perlinenoise2 into effectsGravatar Mike Reed2017-05-30
| | | | | | | | Bug: skia: Change-Id: I5c178bdc5901d15c6924b3fb1f29119ab3cc701d Reviewed-on: https://skia-review.googlesource.com/18131 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* simplify sse41::srcover_srgb_srgbGravatar Mike Klein2017-05-30
| | | | | | | | Most importantly, remove the undefined behavior implied by "delta". Change-Id: I8f9740804ec74dd40b049eafd4f0d51b36ce3237 Reviewed-on: https://skia-review.googlesource.com/18140 Reviewed-by: Herb Derby <herb@google.com>
* Add arm tail code.Gravatar Herb Derby2017-05-30
| | | | | | | | | | CQ_INCLUDE_TRYBOTS=skia.primary:Test-Android-Clang-Nexus10-CPU-Exynos5250-arm-Release-Android Change-Id: Ia0e9f32d0324e66c9d4812dbb156a2b858d49a13 Reviewed-on: https://skia-review.googlesource.com/18127 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* remove sse2::srcover_srgb_srgbGravatar Mike Klein2017-05-30
| | | | | | | Change-Id: Icc570d8a8f1df1dea202e1d234433491122b9b67 Reviewed-on: https://skia-review.googlesource.com/18135 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Don't pull private headers in SkOverdrawColorFilter.hGravatar Florin Malita2017-05-30
| | | | | | | Change-Id: I16254709ffaf6c85110964568ec9422a1ffbb970 Reviewed-on: https://skia-review.googlesource.com/18129 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix glDrawRangeElementsGravatar Chris Dalton2017-05-30
| | | | | | | | | | | | | | | | | | Adds explicit min/max index value fields to GrMesh. This eliminates the previous assumption that the index values were within the range [0..vertexCount-1]. In the pattern case we still maintain this assumption. Updates GrMesh to hide its fields and handle its new complexity using a "helper" interface instead. Adds a unit test for GrMesh. Bug: skia: Change-Id: Ia23de72d510f8827cee56072b727fb70a6e46b8d Reviewed-on: https://skia-review.googlesource.com/17964 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Restore SampleApp picture drawingGravatar Florin Malita2017-05-30
| | | | | | | | | (deleted unintentionally in https://skia-review.googlesource.com/c/15185/) Change-Id: I36111db7012ea7f72a5990b61bb4713d9250da34 Reviewed-on: https://skia-review.googlesource.com/18128 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add GM to test the IgnoreTransform flag on blursGravatar Greg Daniel2017-05-30
| | | | | | | | Bug: skia: Change-Id: I2525daa83d78280e4be3b31b66dc4f13971af311 Reviewed-on: https://skia-review.googlesource.com/18066 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* bug fix in convert_with_pipeline()Gravatar Mike Klein2017-05-30
| | | | | | | | | | | | What do you supppose happens if we put an SkColorSpaceTransferFn on the stack, pass its address to SkRasterPipeline, then pop it off the stack? BUG=skia:6671 Change-Id: I17c777d9dc55a67cca6196a01c076a6be8283d3d Reviewed-on: https://skia-review.googlesource.com/18078 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Convert DstTexture to DstProxy (take 2)Gravatar Robert Phillips2017-05-29
| | | | | | | | | | | | | The last GrTexture-based TextureSampler::reset call must be removed before the TextureSamplers can become purely GrTextureProxy-backed Reland of: https://skia-review.googlesource.com/c/16908/ (Convert DstTexture to DstProxy) Split out of: https://skia-review.googlesource.com/c/10484/ (Omnibus: Push instantiation of GrTextures later (post TextureSampler)) Change-Id: I3a497b6a950fad899f23882c0a9552894ef640f8 Reviewed-on: https://skia-review.googlesource.com/17205 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revise system for checking for uninstantiated proxiesGravatar Robert Phillips2017-05-29
| | | | | | | | | | | | | | The new pattern is: we will "instantiate" pipelines at flush time at flush time we will only access the backing GrSurface by peeking If instantiation fails we should never try to access the GrSurfaces Change-Id: I87f7ff41bd0e84d9ca3dbdd61d3361d3d4ceefd6 Reviewed-on: https://skia-review.googlesource.com/17932 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Update SKP versionGravatar UpdateSKPs2017-05-28
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I8285e9dcf65280e5712d140a7d17a0f99a40bca5 Reviewed-on: https://skia-review.googlesource.com/18084 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/2e559c98e6de6730da99e4acf1ec112ec3607dca git-cl: remove unnecessary similarity notice (agable@chromium.org) https://crrev.com/c4c40d1b5a9a142a50e8b0a1afb24fa2ec05f9e8 git-cl: Print Rietveld deprecation warning (agable@chromium.org) https://crrev.com/568e5919442f1dd3a2b160dbe998d1f1489a09c9 gclient validate: allow None in deps_os values (phajdan.jr@chromium.org) https://crrev.com/3e6d7c1cbccdc1b7881cf27581488769a6edc22b gclient: remove support for $matching_files in hooks (phajdan.jr@chromium.org) https://crrev.com/bf72b593a2fac54e0ac7961be2706581ea47f7f9 gclient: remove support for From() (phajdan.jr@chromium.org) https://crrev.com/8db72efd6351a58a6a689c8db9b02aacfa39b8b7 gclient: enable syntax validation by default (phajdan.jr@chromium.org) https://crrev.com/58abadba2af26354f96035ad67b40ab3b97d63b7 Revert "gclient: enable syntax validation by default" (tandrii@chromium.org) https://crrev.com/b4f9d904734930d83bfbadcfc5d165becd6e3181 Revert "gclient: remove support for From()" (tandrii@chromium.org) https://crrev.com/004923399e12dfff8c4853a1331f39dc91f3e248 Revert "gclient: remove support for $matching_files in hooks" (tandrii@chromium.org) https://crrev.com/4f27802b5c6e1abfb6809006763149456496a3db Revert "gclient validate: allow None in deps_os values" (tandrii@chromium.org) https://crrev.com/35b298f0772d6dbec82c4a33c1e0c94aab9285bf gclient: remove support for $matching_files in hooks (reland #1) (phajdan.jr@chromium.org) https://crrev.com/7e9303ba19e4985f50d68ca1e8f938bb2e513cf4 gclient: remove support for From() (reland #1) (phajdan.jr@chromium.org) https://crrev.com/7c7b5592d84ce41c4b46fac6ddc4587f35989390 gclient: add --disable-syntax-validation escape hatch (phajdan.jr@chromium.org) https://crrev.com/b7e533360cc46f05cd35432d9cb64880b89eb176 gclient validate: schema fixes (patch #1) (phajdan.jr@chromium.org) https://crrev.com/56e4ad939b3c06e2915faea0be14d34473bc3602 Add messages in gclient-new-workdir.py (wychen@chromium.org) https://crrev.com/b02daf0bf9737168491585632d9f9dd5d1c7b4a8 git-cl: use private instead of draft (agable@chromium.org) https://crrev.com/56664461ae794acee098f85d8c33b438909952f2 Support btrfs snapshot in gclient-new-workdir.py (wychen@chromium.org) https://crrev.com/1b9a43aab385070fd75263a9e0f4b4312b5f510e Remove special Cygwin PATH manipulation from .bat. (dnj@chromium.org) https://crrev.com/1ba610bfe2489a0c9cc5750dd49841d54dd31148 gclient validate: dump more details about unexpected AST nodes (phajdan.jr@chromium.org) https://crrev.com/5dd7cd6e8fe33118cc9dbbe40412ed3c0f2c7003 [led] add LUCI editor to depot_tools. (iannucci@chromium.org) https://crrev.com/fb4f1b65e6005e5729c72bbdda86eca30ad3eebd [led] Roll led. (iannucci@chromium.org) recipe_engine: https://crrev.com/5da7e1fbc1f0e8b14d0ac6c1dc770ce9ca39d6ac Remove "Recipe Roll Downstream Tester" builder (nodir@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I92a1c7d8c7e30b74d6f09f9a96233c268da53f89 Reviewed-on: https://skia-review.googlesource.com/18073 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Add casts for SkColor constant macros.Gravatar danakj2017-05-26
| | | | | | | | | | | | This ensures the compiler knows they are SkColors and not "int" which can't be implicitly casted when you end up with a reference to it. Bug: skia: 6696 Change-Id: Ieb6a2270d7d01df279d55e0bad7a793a8edd8658 Reviewed-on: https://skia-review.googlesource.com/18081 Commit-Queue: danakj chromium <danakj@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Hide ctors of SkShader, SkImage & SkColorSpaceGravatar Florin Malita2017-05-26
| | | | | | | | | To prevent external clients from subclassing. Change-Id: I60a3833bf64019aea2f537850ca2a1ae38bb8767 Reviewed-on: https://skia-review.googlesource.com/18038 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* no sprite blitters support gamut conversionGravatar Mike Klein2017-05-26
| | | | | | | | | | | This fixes the None/Low bitmap filtering in gamut GM. BUG=skia:6679 Change-Id: Ic6e0efa6a23b537aea69b4beb24f3c8b8c6ca347 Reviewed-on: https://skia-review.googlesource.com/17923 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Add tests for tail handling in SkJumper.Gravatar Herb Derby2017-05-26
| | | | | | | Change-Id: Ib4ecc33dc9552c16b5530359cd3649487e70bbed Reviewed-on: https://skia-review.googlesource.com/18067 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Reduce tree depth on iOS tooGravatar Brian Osman2017-05-26
| | | | | | | | Bug: skia:6627 Change-Id: Ib92b62bf1191170a46e63f61fa9502ca2f9ee771 Reviewed-on: https://skia-review.googlesource.com/18072 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Really work around iOS varying limit in GLPrograms testGravatar Brian Osman2017-05-26
| | | | | | | | | Bug: skia:6627 Change-Id: I80142f5288e1c6f59f6add3a5a71ab90da90d3cc Reviewed-on: https://skia-review.googlesource.com/18069 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* wait for DM status thread to exit on iOSGravatar Mike Klein2017-05-26
| | | | | | | | CQ_INCLUDE_TRYBOTS=skia.primary:Test-iOS-Clang-iPadPro-GPU-GT7800-arm64-Debug,Test-iOS-Clang-iPhone6-GPU-GX6450-arm64-Debug,Test-iOS-Clang-iPhone7-GPU-GT7600-arm64-Debug Change-Id: I0e7491a6aaad08e969ceaabae49cbda718ea4be8 Reviewed-on: https://skia-review.googlesource.com/18065 Reviewed-by: Stephan Altmueller <stephana@google.com>
* Explicitly check edge count >= 2 in non-debug buildGravatar Yuqian Li2017-05-26
| | | | | | | | | | | We also preserve the check in debug mode that the count should never be 1 when the path is convex. Bug: skia:6684 Change-Id: I4d4c9ad9f9d704e94bbe51f10a96f8b3066afaa1 Reviewed-on: https://skia-review.googlesource.com/17983 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Reed <reed@google.com>