aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* add SkRecordOptimize2 and an experimental API for more aggressive optsGravatar reed2015-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1462973002
* Remove unsigned < signed comparison.Gravatar mtklein2015-11-19
| | | | | | | | | This triggers -Wsign-compare on some builds. Not sure why none of those builds have -Werror set. BUG=skia:4561 Review URL: https://codereview.chromium.org/1464543002
* Parametric contour start GMGravatar fmalita2015-11-19
| | | | | | | | | A GM to capture the newly added SkPath API. BUG=chromium:315277 R=caryclark@google.com,reed@google.com Review URL: https://codereview.chromium.org/1457503002
* Fix UB in SkDivBitsGravatar mtklein2015-11-19
| | | | | | | | | | | | | DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no. This turns numer into a uint32_t to make those defined, and adds a few notes. x >= 0 is always true for unsigned x, so we needed a few small logic refactors. BUG=skia:3562 Committed: https://skia.googlesource.com/skia/+/988adddd48322bfa3e3cb0c017cfce71fbbf1123 Review URL: https://codereview.chromium.org/1455163004
* Fix GpuDrawPathTest on ANGLE and enable itGravatar kkinnunen2015-11-19
| | | | | | | | | | | Fix GpuDrawPathTest on ANGLE by avoiding a crash if MSAA surface creation fails. Enable the test. BUG=skia:4581 Review URL: https://codereview.chromium.org/1463493002
* Revert float xfermodes back to Sk4f (from Sk8f).Gravatar mtklein2015-11-19
| | | | | | | | | | | | | | | Generally this was a performance win, even on devices without AVX due to unrolling, but on ARM+NEON it looks like that unrolling hurt a bit. while (...) { blend a pixel } ~~~> while (...) { blend two pixels } if (n % 2) { blend last pixel } BUG=chromium:555278 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1465483002
* Fix BMP RLE bug: attempt 2Gravatar msarett2015-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1457213003
* Modernize SkRecordPattern.hGravatar mtklein2015-11-19
| | | | | | | | | | | | - Fold Or, Or3, Or4 into one flexible Or. - Fold Pattern1...Pattern7 into one flexible Pattern. - Rename Star Greedy Still fighting with a flexible get<N>() method instead of first, second, third, etc. BUG=skia: Review URL: https://codereview.chromium.org/1465443002
* Fix maybe unintialized warning for GrAutoLocaleSetterGravatar kkinnunen2015-11-19
| | | | | | | | | | | In function void test_GLPrograms(skiatest::Reporter*, GrContextFactory*): ../../../src/gpu/GrAutoLocaleSetter.h:47:35: error: als.GrAutoLocaleSetter::fOldLocale may be used uninitialized in this function [-Werror=maybe-uninitialized] From Build-Ubuntu-GCC-x86_64-Release-Trybot Review URL: https://codereview.chromium.org/1456383002
* add --write option to dump_recordGravatar reed2015-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1459823003
* Change prealloc number of child FPs be 1 rather than 2Gravatar Brian Salomon2015-11-19
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1458913003 .
* Preallocate room for 2 child processors in FPsGravatar bsalomon2015-11-19
| | | | Review URL: https://codereview.chromium.org/1456263003
* Shift up bottom path in smallpaths GM.Gravatar jvanverth2015-11-19
| | | | | | This stops it from being cut off in the image. Review URL: https://codereview.chromium.org/1462903002
* Unit test for conic weight GrPath key collisionGravatar fmalita2015-11-19
| | | | | | | BUG=skia:4580 R=robertphillips@google.com,bsalomon@google.com Review URL: https://codereview.chromium.org/1454223002
* Add SkRecord::defrag().Gravatar mtklein2015-11-19
| | | | | | | | | | | | | Called by SkRecordOptimize(), this moves all the NoOps to the end and slices them off. This implementation with std::remove_if() is linear and doesn't malloc. No diffs: https://gold.skia.org/search2?issue=1461663003&unt=true&query=source_type%3Dgm&master=false BUG=skia: Review URL: https://codereview.chromium.org/1461663003
* Move glsl onto EmitArgs struct for emitCodeGravatar egdaniel2015-11-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1453623003
* Fix leak in drawBitmapNineGravatar egdaniel2015-11-19
| | | | | | | | NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/1462893002
* [Reland] Fix NVPR assert for equivalent ovalsGravatar fmalita2015-11-18
| | | | | | | | | | | | | | | | | | | | | | For oval paths, GrPath ignores the point order and only uses the bounds when building its key. This is problematic because 1) point order is important when dashing 2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal to the cached SkPath - which is not the case for ovals with different directions/different point order. With this CL we no longer use the reduced oval key when dashing, and instead fall through to the more general path cases. The assert is adjusted to accommodate "equivalent" ovals (when not dashing). Also re-enabled & updated the GpuDrawPath unit test (disabled in https://codereview.chromium.org/1456463003/, presumably due to the use of uninitialized SkRects). R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com Review URL: https://codereview.chromium.org/1457073002
* Make SkTLList prealloc its first block of nodesGravatar bsalomon2015-11-18
| | | | Review URL: https://codereview.chromium.org/1458703005
* Make block size a template parameter of SkTLListGravatar bsalomon2015-11-18
| | | | Review URL: https://codereview.chromium.org/1457123002
* Revert SkBlitMask_opts.h back to hand-coded NEON.Gravatar mtklein2015-11-18
| | | | | | | | | SkPx has triggered a bunch of small (2-9%) regressions on NEON devices. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1462783002
* Revert of Fix NVPR assert for equivalent ovals (patchset #1 id:1 of ↵Gravatar stephana2015-11-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1457073002/ ) Reason for revert: Causes failures on Android and Win8: ... ( 137/1245MB 9) 73.9ms unit test GpuLayerCachec:\0\build\slave\workdir\build\skia\include\private\skuniqueptr.h:164: failed assertion "get() != pointer()" Caught exception 2147483651 EXCEPTION_BREAKPOINT ... Original issue's description: > Fix NVPR assert for equivalent ovals > > For oval paths, GrPath ignores the point order and only uses the bounds > when building its key. This is problematic because > > 1) point order is important when dashing > 2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal > to the cached SkPath - which is not the case for ovals with different > directions/different point order. > > With this CL we no longer use the reduced oval key when dashing, and > instead fall through to the more general path cases. The assert is > adjusted to accommodate "equivalent" ovals (when not dashing). > > Also re-enabled & updated the GpuDrawPath unit test (disabled in > https://codereview.chromium.org/1456463003/, presumably due to the use > of uninitialized SkRects). > > R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com > > Committed: https://skia.googlesource.com/skia/+/f9b1577d763988ebc043ddabf80674f71571ecff TBR=bsalomon@google.com,cdalton@nvidia.com,robertphillips@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1461913002
* simplify insertion methods for SkTLListGravatar bsalomon2015-11-18
| | | | Review URL: https://codereview.chromium.org/1459663002
* Fix NVPR assert for equivalent ovalsGravatar fmalita2015-11-18
| | | | | | | | | | | | | | | | | | | | | | For oval paths, GrPath ignores the point order and only uses the bounds when building its key. This is problematic because 1) point order is important when dashing 2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal to the cached SkPath - which is not the case for ovals with different directions/different point order. With this CL we no longer use the reduced oval key when dashing, and instead fall through to the more general path cases. The assert is adjusted to accommodate "equivalent" ovals (when not dashing). Also re-enabled & updated the GpuDrawPath unit test (disabled in https://codereview.chromium.org/1456463003/, presumably due to the use of uninitialized SkRects). R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com Review URL: https://codereview.chromium.org/1457073002
* Revert of Fix UB in SkDivBits (patchset #2 id:10002 of ↵Gravatar mtklein2015-11-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1455163004/ ) Reason for revert: Need to reland with #define guards for tiny layout test changes. (Yikes!) Original issue's description: > Fix UB in SkDivBits > > DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no. > This turns numer into a uint32_t to make those defined, and adds a few notes. > > x >= 0 is always true for unsigned x, so we needed a few small logic refactors. > > BUG=skia:3562 > > Committed: https://skia.googlesource.com/skia/+/988adddd48322bfa3e3cb0c017cfce71fbbf1123 TBR=caryclark@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3562 Review URL: https://codereview.chromium.org/1457863002
* In BUILD.public, remove compile-time dependency on GL.Gravatar benjaminwagner2015-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1458603006
* Add small paths GMGravatar jvanverth2015-11-18
| | | | | | Used to testing caching and quality of distance field paths. Review URL: https://codereview.chromium.org/1456823003
* Make has GrBatchAtlas::ID() inlineableGravatar joshualitt2015-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1456113002
* Initial implementation of GPU no filter NinePatchGravatar joshualitt2015-11-18
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1454933002
* Remove Lua from the Google3 build.Gravatar benjaminwagner2015-11-18
| | | | | | | | | | See internal cl/107087297 for details. Rename some variables in BUILD/BUILD.public. BUG=skia: Review URL: https://codereview.chromium.org/1425013008
* Fix GOOGLE3 Android build.Gravatar benjaminwagner2015-11-18
| | | | | | | | | | | DebugWriteToStderr isn't defined for Android. I'm not sure if I just didn't test compiling for Android or if this is due to a change in the base library. BUG=skia: No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1438773003
* Update debugger UI to auto-refresh the directory listingGravatar djsollen2015-11-18
| | | | Review URL: https://codereview.chromium.org/1462633002
* [debugger] Add visualization of center rect for drawBitmapNine callsGravatar robertphillips2015-11-18
| | | | Review URL: https://codereview.chromium.org/1462643002
* Fix has_aligned_samples helper for SkGpuDevice::drawTextureProducerGravatar Brian Salomon2015-11-18
| | | | Review URL: https://codereview.chromium.org/1454183002 .
* Fix BMP RLE bugGravatar msarett2015-11-18
| | | | | | | | decodeRows() should return an int, not an SkCodec::Result BUG=skia: Review URL: https://codereview.chromium.org/1457793003
* Add an example of embedding a Skia Perf graph to the site docs.Gravatar jcgregorio2015-11-18
| | | | | | | | | | | | This specific page: https://skia.org/dev/testing/skiaperf?cl=1462583002 BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1462583002 Review URL: https://codereview.chromium.org/1462583002
* restore dump_recordGravatar mtklein2015-11-18
| | | | | | | | | | And, - 4 space indents - print out time units (microseconds) BUG=skia: Review URL: https://codereview.chromium.org/1458943002
* Convert SkGpuDevice::drawTextureAdjuster to SkGpuDevice::drawTextureProducerGravatar bsalomon2015-11-18
| | | | | | | | Move createFragmentProcessor to GrTextureProducer base class. Make non-tiled sw-bitmap draws go through drawTextureProducer. Review URL: https://codereview.chromium.org/1459433002
* Convert drawText to using the find and place code.Gravatar herb2015-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1448453002
* Fix buffer overrun, bit overrun and add a test.Gravatar herb2015-11-18
| | | | | | BUG=539691 Review URL: https://codereview.chromium.org/1453163002
* Fix UB in SkDivBitsGravatar mtklein2015-11-18
| | | | | | | | | | | DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no. This turns numer into a uint32_t to make those defined, and adds a few notes. x >= 0 is always true for unsigned x, so we needed a few small logic refactors. BUG=skia:3562 Review URL: https://codereview.chromium.org/1455163004
* Clean up dead code: PictureRendererGravatar mtklein2015-11-18
| | | | | | | | Doesn't appear to actually be used by anything. BUG=skia: Review URL: https://codereview.chromium.org/1457753002
* Add ShaderBuilders to EmitArgs and remove gettings from ProgBuilder.Gravatar egdaniel2015-11-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1457543003
* stifle Math test on Mac bot tooGravatar mtklein2015-11-18
| | | | | | BUG=skia:3562 Review URL: https://codereview.chromium.org/1454093002
* Clean up dead code: filter.Gravatar mtklein2015-11-18
| | | | | | | | We haven't used this since at least landing the new SkPicture backend. BUG=skia: Review URL: https://codereview.chromium.org/1459583003
* Update all code site issue tracker links to point to bug.skia.orgGravatar rmistry2015-11-18
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1461613002 Review URL: https://codereview.chromium.org/1461613002
* Clean up dead code: render_pdfs.Gravatar mtklein2015-11-18
| | | | | | | | DM can do this. BUG=skia: Review URL: https://codereview.chromium.org/1461633002
* Revert of Parametric contour start GM (patchset #1 id:1 of ↵Gravatar stephana2015-11-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1457503002/ ) Reason for revert: Breaks unit test across various platforms: ../../../src/gpu/batches/GrStencilAndCoverPathRenderer.cpp:75: failed assertion "path->isEqualTo(skPath, stroke)" Original issue's description: > Parametric contour start GM > > A GM to capture the newly added SkPath API. > > BUG=chromium:315277 > R=caryclark@google.com,reed@google.com > > Committed: https://skia.googlesource.com/skia/+/56847a65648af4d06da9c26c55242949a1bf31ab TBR=caryclark@google.com,reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:315277 Review URL: https://codereview.chromium.org/1456973002
* Update issue tracker in docsGravatar hcm2015-11-18
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1462493002 Review URL: https://codereview.chromium.org/1462493002
* Move SkImage tests from SurfaceTest to ImageTestGravatar kkinnunen2015-11-17
| | | | | | | | | | | The general SkImage features seem to be tested in ImageTest instead of SurfaceTest. Helps in reviewing further reformatting of SurfaceTest. BUG=skia:2992 Review URL: https://codereview.chromium.org/1452123002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 08:09:46 +0000