aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Switch SkDropShaderImageFilter over to new onFilterImage interfaceGravatar robertphillips2016-03-23
| | | | | | | | TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784863003 Review URL: https://codereview.chromium.org/1784863003
* Switch SkLocalMatrixImageFilter over to new onFilterImage interfaceGravatar robertphillips2016-03-23
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1780233002 Review URL: https://codereview.chromium.org/1780233002
* Use Sk4x4f in srcover_srgb_dst_1.Gravatar mtklein2016-03-22
| | | | | | | | | | | | I've also pulled out the common parts shared with sRGB srcover_n, and rearranged to make the similarities a bit more clear. This speeds up about 25%. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829513002 Review URL: https://codereview.chromium.org/1829513002
* Remove SK_SUPPORT_LEGACY_FILTERBOUNDS_RETURN.Gravatar senorblanco2016-03-22
| | | | | | | | | It's now-unused. BUG=skia:5094 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823243002 Review URL: https://codereview.chromium.org/1823243002
* Sk4x4fGravatar mtklein2016-03-22
| | | | | | | | | | | An API for loading and storing 4 Sk4f with transpose. This has SSSE3+ and portable versions. SSE2 and NEON versions to follow. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825663002 Review URL: https://codereview.chromium.org/1825663002
* Use SkColorSpacePrintf instead of SkDebugfGravatar msarett2016-03-22
| | | | | | | | | TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1828503002 Review URL: https://codereview.chromium.org/1828503002
* Fix borrowed GrVkImage::Resource.Gravatar jvanverth2016-03-22
| | | | | | | | | | | | With the current system, if we wrap a given GrVkTextureInfo*, add a command using it to the command buffer, then delete the texture, the command buffer will unref the GrVkImage::Resource when it's done, which will delete the VkImage and VkDeviceMemory. This subclasses GrVkImage::Resource for those cases, and will not delete the data on an unref. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1824123002 Review URL: https://codereview.chromium.org/1824123002
* fix --threads 4, blacklist interlaced1,2,3 on GPUGravatar mtklein2016-03-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1827543002 Review URL: https://codereview.chromium.org/1827543002
* Remove SkPixmap::releaseGravatar robertphillips2016-03-22
| | | | | | | | No longer need this for ImageFilters GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1821303002 Review URL: https://codereview.chromium.org/1821303002
* SkRecord: infer return type for visit() and mutate().Gravatar mtklein2016-03-22
| | | | Review URL: https://codereview.chromium.org/1824983003
* Try throttling x86 desktop bots down with fewer threads.Gravatar mtklein2016-03-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825163002 Review URL: https://codereview.chromium.org/1825163002
* Correctly handle lfWidth in GDI.Gravatar bungeman2016-03-22
| | | | | | | | | | | The LOGFONT::lfWidth field is related to the LOGFONT::lfHeight field, it is not related in any way to the OS/2::usWidthClass (unlike LOGFONT::lfWeight, which mirrors the OS/2::usWeightClass). Be sure to canonicalize this field to 0 (default) and not use it as a style value. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819973003 Review URL: https://codereview.chromium.org/1819973003
* Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of ↵Gravatar reed2016-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.o… (patchset #1 id:1 of https://codereview.chromium.org/1821103004/ ) Reason for revert: guard has now landed in chrome Original issue's description: > Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (patchset #3 id:40001 of https://codereview.chromium.org/1825073002/ ) > > Reason for revert: > CreateModeFilter not compiling > > Original issue's description: > > Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/1822623002/ )" > > > > Fixed legacy withColorFilter to call new(er) make method > > > > This reverts commit 1eb81db650d31f50be67b12d60c4f9e7dd08432f. > > > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825073002 > > > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/4c9776b046dd5e9e46e2d1ce35154855c8fcb381 > > TBR= > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d6889293dd0942f27f9593f679722c956831f2c4 TBR= # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review URL: https://codereview.chromium.org/1827433002
* Fix second memory leak in SkSpecialImageGravatar robertphillips2016-03-22
| | | | | | | | TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825073003 Review URL: https://codereview.chromium.org/1825073003
* Add experimental Swarmbucket botGravatar borenet2016-03-22
| | | | | | | | | | | Docs here: https://chromium.googlesource.com/infra/infra/+/master/appengine/cr-buildbucket/doc/swarming.md NOTRY=true BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820323002 Review URL: https://codereview.chromium.org/1820323002
* Make GrCircleBlurFragmentProcessor::onIsEqual include the positionGravatar abarth2016-03-22
| | | | | | | | Previously we would fail to draw two adjacent blurred circles if they differed only by their position. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1824693003 Review URL: https://codereview.chromium.org/1824693003
* Blacklist RAW images on x86 UbuntuGravatar msarett2016-03-22
| | | | | | | BUG=skia:5115 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822033002 Review URL: https://codereview.chromium.org/1822033002
* Revert of Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 ↵Gravatar reed2016-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.o… (patchset #3 id:40001 of https://codereview.chromium.org/1825073002/ ) Reason for revert: CreateModeFilter not compiling Original issue's description: > Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/1822623002/ )" > > Fixed legacy withColorFilter to call new(er) make method > > This reverts commit 1eb81db650d31f50be67b12d60c4f9e7dd08432f. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825073002 > > TBR= > > Committed: https://skia.googlesource.com/skia/+/4c9776b046dd5e9e46e2d1ce35154855c8fcb381 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1821103004
* Refactor SkBmpCodecGravatar msarett2016-03-22
| | | | | | | | | | | | I started working on indicating the native encoded formats and things got really complicated for bmp. I think starting with this refactor may help a little, and I also think that this is a good change by itself. BUG=skia:4133 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820283002 Review URL: https://codereview.chromium.org/1820283002
* Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of ↵Gravatar reed2016-03-22
| | | | | | | | | | | | | | | https://codereview.chromium.org/1822623002/ )" Fixed legacy withColorFilter to call new(er) make method This reverts commit 1eb81db650d31f50be67b12d60c4f9e7dd08432f. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825073002 TBR= Review URL: https://codereview.chromium.org/1825073002
* Revert of switch colorfilters to sk_sp (patchset #11 id:200001 of ↵Gravatar reed2016-03-22
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1822623002/ ) Reason for revert: need to fix unguarded makeWithFilter Original issue's description: > switch colorfilters to sk_sp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822623002 > > Committed: https://skia.googlesource.com/skia/+/f809d7687a4fb7b88b651b046da2bc0035d6aa09 TBR=fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1820303002
* Revert of Clean up SSSE3 and SSE4 stubs. (patchset #1 id:1 of ↵Gravatar mtklein2016-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1810183003/ ) Reason for revert: I've just had a better idea about how to fix this. Let's revert while I work on it. Original issue's description: > Clean up SSSE3 and SSE4 stubs. > > We added these stubs to work around OpenBSD's old compiler, which had > support for SSE2 but not SSSE3 or SSE4. > > We now already have other unstubbed files that require SSSE3 and SSE4 compiler > support. All the compilers we support have SSSE3 and SSE4 support, and all the > way up to at least AVX2. > > (Requiring C++11 has had some nice ripple effects...) > > > And, <immintrin.h> is already auto-included for these files, so no need for smmintrin or tmmintrin. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810183003 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/2b1b40e11afc41452b4d2f74cdebb1b6e6f7cc96 TBR=djsollen@google.com,mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review URL: https://codereview.chromium.org/1819223003
* switch colorfilters to sk_spGravatar reed2016-03-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822623002 Review URL: https://codereview.chromium.org/1822623002
* Fully implement onResetContext for VulkanGravatar egdaniel2016-03-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819343002 Review URL: https://codereview.chromium.org/1819343002
* Potential fix for SpecialImageTest memory leakGravatar robertphillips2016-03-22
| | | | | | | | | TBR=bsalomon@google.com NOTREECHECKS=true GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825043002 Review URL: https://codereview.chromium.org/1825043002
* nanobench: Stop reporting median_ms, it's no better than min_ms.Gravatar jcgregorio2016-03-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825473002 Review URL: https://codereview.chromium.org/1825473002
* Change signatures of filter bounds methods to return a rect.Gravatar senorblanco2016-03-21
| | | | | | | | | | | Change filterBounds(), onFilterBounds() and onFilterNodeBounds() and computeFastBounds() to return the destination rectangle. There was no code path that could return false, and returning rects by value is ok now. BUG=skia:5094 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823573003 Review URL: https://codereview.chromium.org/1823573003
* SkPDF: SkPDFDevice has ptr to SkPDFDocumentGravatar halcanary2016-03-21
| | | | | | | | | This is necessary for pre-serialization of images. BUG=skia:5087 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1802963002 Review URL: https://codereview.chromium.org/1802963002
* fix release build vulkanGravatar egdaniel2016-03-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819853004 Review URL: https://codereview.chromium.org/1819853004
* SkPDF: SkPDFDocument reorganized so that some objects can be serialized early.Gravatar halcanary2016-03-21
| | | | | | | | | No change in output. BUG=skia:5087 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1802033003 Review URL: https://codereview.chromium.org/1802033003
* Update SkSpecialImage to be able to create tight SkImages and SkSurfacesGravatar robertphillips2016-03-21
| | | | | | | | This calved off of: https://codereview.chromium.org/1810693003/ (Switch SkTileImageFilter over to new onFilterImage interface) since the TileImageFilter needs a tight bitmap/texture/image to perform its draw. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1816223002 Review URL: https://codereview.chromium.org/1816223002
* Disable the WIC encoder for jpegsGravatar msarett2016-03-21
| | | | | | | | | | | | | | | | | My fix from https://codereview.chromium.org/1791583002/ is not sufficient. WIC will only encode JPEGs if we pass in a bitmap in BGR format. For now, let's disable the WIC encoder on JPEGs and fall back on SkImageEncoder_libjpeg. This should fix the scaled-generator gm. https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator&include=false&head=true&unt=true&pos=false&neg=false&limit=100 BUG=skia:3969 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823743002 Review URL: https://codereview.chromium.org/1823743002
* guard rasterizer and drawlooper settersGravatar reed2016-03-21
| | | | | | | | | Need to land https://codereview.chromium.org/1823513002/ first BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1821533002 Review URL: https://codereview.chromium.org/1821533002
* Refactor 4f gradients using trait templatesGravatar fmalita2016-03-21
| | | | | | | | | | | | | | | | Some 4f gradient housekeeping. 1) replace <DstPtrType, ColorProfile> specialization tuples with an enum covering all dest types (L32, S32, F16, F32) 2) group various template helpers into dest trait classes, specialized for each dest type (2a - conflate current dst_swizzle and scale_for_dest ops into one load op) R=reed@google.com,mtklein@google.com,herb@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1816883002 Review URL: https://codereview.chromium.org/1816883002
* SkPDF: Add SkPDFCanvas to intercept some draw callsGravatar halcanary2016-03-21
| | | | | | | Motivation: this simplifies implementation at the device level. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1812063002 Review URL: https://codereview.chromium.org/1812063002
* Minor fixes to avoid NVPR in Vulkan and provide good GrVkGpu teardown.Gravatar jvanverth2016-03-21
| | | | | | | BUG=skia:5097 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1818093002 Review URL: https://codereview.chromium.org/1818093002
* exit computeFilters if filter width is zeroGravatar caryclark2016-03-21
| | | | | | | | | | | | | | The fuzzer associated with this bug triggered an assert when building the resize filter. I can't tell if there is a more fundemental bug here or not. Checking for a zero-sized filter fixes the fuzzer. R=fmalita@chromium.org BUG=595856 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810333002 Review URL: https://codereview.chromium.org/1810333002
* Exclude new file in Google3 build.Gravatar benjaminwagner2016-03-21
| | | | | | The new file was added in https://codereview.chromium.org/1817633002 Review URL: https://codereview.chromium.org/1823703002
* unified PNG encoding between SkDrawCommand and skiaserveGravatar ethannicholas2016-03-21
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1818043003 Review URL: https://codereview.chromium.org/1818043003
* SkPDF: add drop() virtual to release resources early.Gravatar halcanary2016-03-21
| | | | | | | | | | | | | | | | | | | Call drop() after calling emitObject() on top-level objects. In Debug mode, assert that each object is emited exactly once by asserting that emitObject is never called after drop(). Same for addResources(). To make sure that top level objects don't get deleted prematurely, SkPDFObjNumMap takes a reference. Motivation: save RAM. Allow even earlier serialization with later changes. Also: Switch some SkTDArrays to SkTArrays. BUG=skia:5087 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1790023003 Review URL: https://codereview.chromium.org/1790023003
* SkNx refreshGravatar mtklein2016-03-21
| | | | | | | | | | | | | | | | | | | | - rearrange a bit - fewer macros - hooks for all operators - add left and right scalar operator overrides - add +=, &=, <<=, etc. - add SkNx_split() and SkNx_join() - simplify the many rsqrt() and invert() options to just what we actually use This refactoring pointed out that our float <-> int NEON conversions are not specialized, so I've implemented them. It seems nice that this is an error rather than silently falling back to serial code. It's unclear to me if split/join want to be external, static methods, or non-static methods (SkNx_join(), Sk4f::Join(), x.join()). Time will tell? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1812233003 CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot;client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1812233003
* Remove transitional explicit operator bool.Gravatar mtklein2016-03-21
| | | | | | | | | | These should no longer be necessary. Android's STL should now be sane. TBR=reed This just removes code. Review URL: https://codereview.chromium.org/1817153002
* Make the debug interface a GrGLTestInterface subclass.Gravatar bsalomon2016-03-21
| | | | | | | | | | | The debug interface subsumes the GrDebugGL singleton which allows multiple instances. Fixes a few issues that existed before this CL (pack alignment wasn't tracked or respected, and we weren't initializing a texture id to 0 in one GM). Apparently this is not currently run on the bots. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1812323002 Review URL: https://codereview.chromium.org/1812323002
* Swarming: Ensure depot_tools is in PATH when compilingGravatar borenet2016-03-21
| | | | | | | | | | Turns out we were "lucky" for our Linux bots which already have depot_tools in PATH. The Mac bot does have depot_tools, but it's not in PATH. Add it in the script to ensure we can always get to it. NOTRY=true BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823653002 Review URL: https://codereview.chromium.org/1823653002
* Make SkComposeImageFilter::onFilterImage filter the bounds given to the ↵Gravatar jbroman2016-03-21
| | | | | | | | | | | | | | | inner filter. Previously, the bounds requested by the caller would be passed to both the inner and outer filter, but since the outer filter may move pixels, this is not necessarily sufficient to supply the pixels required by the outer filter to fill the bounds. Unit test included. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813373002 Review URL: https://codereview.chromium.org/1813373002
* add SK_SUPPORT_LEGACY_PATHEFFECT_PTR for google3 roll fixGravatar reed2016-03-21
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1817113002 TBR=mtklein NOTRY=True Review URL: https://codereview.chromium.org/1817113002
* Correct comment to refer to SkImageFilter::kReverse_MapDirection.Gravatar jbroman2016-03-21
| | | | | | | | | | kBackward_MapDirection does not exist; might as well have the comment exactly match the valid enumerator. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820883002 Review URL: https://codereview.chromium.org/1820883002
* Parse icc profiles and exif orientation from jpeg markersGravatar msarett2016-03-21
| | | | | | | | | | New resources should be fine to add since they are already checked into chromium. BUG=skia:3834 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813273002 Review URL: https://codereview.chromium.org/1813273002
* Add note about Chromium's use of old libstdc++ to docs.Gravatar bungeman2016-03-21
| | | | | | | | | | Chromium must still build against libstdc++4.6.4, which presents limits on at least type traits and perhaps performance. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1820873002 Review URL: https://codereview.chromium.org/1820873002
* nanobench: Reduce the total number of statistics being captured.Gravatar jcgregorio2016-03-21
| | | | | | | BUG=skia:5092 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819863002 Review URL: https://codereview.chromium.org/1819863002
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-06 15:35:15 +0000